- 07 Nov, 2018 40 commits
-
-
Clemens Arbesser authored
[Autofill Assistant] Changed overlay color to be consistent with the default modal dialog overlay color, which currently is black @ 0.5 opacity. Bug: 806868 Change-Id: I2725d8df984810ac5f39dfc62f0a326614a79bb0 Reviewed-on: https://chromium-review.googlesource.com/c/1317890Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#606076}
-
Artem Titarenko authored
For XCTests there will be more than 2 arguments, therefore we need to take second argument, not the last one. Change-Id: Ie3bcac032d49e5e75812dcf7bd248e550c73a244 Reviewed-on: https://chromium-review.googlesource.com/c/1317856Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Artem Titarenko <artit@chromium.org> Cr-Commit-Position: refs/heads/master@{#606075}
-
Tom Sepez authored
Since PDFs don't contain webassembly. Once this lands, we should consider doing the same thing for the proxy_resolver_v8.cc file as well. Change-Id: If9e33defb4ea4124eefd6555a5331cfe3f0e22b4 Reviewed-on: https://chromium-review.googlesource.com/c/1321050Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606074}
-
Tom Sepez authored
Removes some potential attack surface since wasm isn't expected as part of proxy resolution. Change-Id: I82b6519a3d60a5577796fe0627f5750234032849 Reviewed-on: https://chromium-review.googlesource.com/c/1321578Reviewed-by:
-
Mark Cogan authored
Change-Id: I5e204e091809a1640856aacfc3126cd63a40a75f Reviewed-on: https://chromium-review.googlesource.com/c/1323074 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606072}
-
Jérôme Lebel authored
This patch is related to crrev.com/i/707588 Bug: 900522 Change-Id: Ib0ba6bcebe7fa88b4ebc7e3c52a20eb0fb8e5276 Reviewed-on: https://chromium-review.googlesource.com/c/1310814 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606071}
-
Jacob Dufault authored
Change-Id: I753bd193538544cfec8883b37d87f74d8a44d581 Reviewed-on: https://chromium-review.googlesource.com/c/1300075Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#606070}
-
Clark DuVall authored
This also enables NetworkServiceRestartBrowserTests on Android, since OOP NS is supported now. Bug: 901026 Change-Id: If66c1fcd7d0286fd2bf545dc406e541c69fd77a8 Reviewed-on: https://chromium-review.googlesource.com/c/1313111Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#606069}
-
Mike Reed authored
bug: skia:8527 Change-Id: I44de70acf82680d1a446c1c1a811c34322e047d9 Reviewed-on: https://chromium-review.googlesource.com/c/1320514 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#606068}
-
Mason Freed authored
Previous to this CL, any value could be passed to this function, which caused problems if very large values were used. See https://crbug.com/899482 for an example. Per the discussion there, 100X seems like a reasonable limit. Bug: 899482 Change-Id: I0ed9b68510bf9462c76dcf85e6954df416c0df2f Reviewed-on: https://chromium-review.googlesource.com/c/1320015Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#606067}
-
Robert Sesek authored
This will prevent packages that have been installed but not yet explicitly launched by the user, as well those that have been force- stopped, from being the target of an Intent from the web. Bug: 607966 Change-Id: I17e1168a7ee8a73e1b42175f7bd0b6f2e61aed04 Reviewed-on: https://chromium-review.googlesource.com/c/1316112Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#606066}
-
Ernest Galbrun authored
Before: autofill assistant would trigger automatically. After: Autofill assistant shows the init screen first, and the "ok" button must be clicked for autofill to proceed. The init screen can be deactivated by checking the dont_show_init_screen checkbox. https://screenshot.googleplex.com/8sRtJSAqVjG Binary-Size: Increase is due to adding new images for the background of the onboarding screen. Bug: 806868 Change-Id: I9b2aa8a537698cdc2d36dd5a1b0fa37aa87091b9 Reviewed-on: https://chromium-review.googlesource.com/c/1296501 Commit-Queue: Ernest Galbrun <galbrun@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606065}
-
Jacob Dufault authored
This is not used in views lock screen. The implementation is also complicated and possibly crashy if UnlockOnLoginSuccess is called twice. One side-effect of this cleanup is that views lock screen now dismisses 400ms faster, because it was never calling UnlockOnLoginSuccess and instead relied on the fallback handler. Bug: 902451 Change-Id: I16c02dab2b263ee7fa304490e3df0bc002252a41 Reviewed-on: https://chromium-review.googlesource.com/c/1320794Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#606064}
-
Marc Treib authored
instead of defining a custom MockSyncService that isn't used as a mock. Bug: 859874 Change-Id: If1458426ff77a666a2be0dc08513a87b26ad76b0 Reviewed-on: https://chromium-review.googlesource.com/c/1322710Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606063}
-
Aaron Krajeski authored
This prevents us from recording canvas size multiple times for the same canvas. Also confirmed that we are recording the correct numbers and move `isOffscreen` to an enum. Bug: 902000 Change-Id: Ic6e66ec960ae0166699280303a61b574c9320294 Reviewed-on: https://chromium-review.googlesource.com/c/1319180 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#606062}
-
Sebastien Marchand authored
There's several singletons / global instances in c/b/rc that are leaked at shutdown, this is causing some issues in runs of unit_tests because we end up re-using them between different test runs that should be independent. This is currently preventing some feature to be enabled. This CL add a new ResourceCoordinatorParts class that encapsulate all these objects that should be created only once, an instance of this class is owned by the browser process. Change-Id: Ia64618b6f47052815d861ff6820d994f8a65cc64 Reviewed-on: https://chromium-review.googlesource.com/c/1290775Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#606061}
-
Christopher Grant authored
Previously, Monochrome used its own set of GN targets to package resources, analogous to the ones used for Chrome (some of which are the same used for non-Android platforms). This change moves both variants to use matching sets of template-generated targets. Later, when bundle-specific native libraries are added, this common template can be reused again. BUG=874584 Change-Id: Ia9c34cb0dfa8754207bdee146dbde47f9aca78d3 Reviewed-on: https://chromium-review.googlesource.com/c/1318418 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#606060}
-
Patricia Hongo authored
The existing sign out pref is written just once, which makes sense for Android EDU devices, but not for child accounts. These accounts may become unsupervised, in which case they should be able to sign out. Test: verified that the "Sign out of Chrome" button is hidden while an existing consumer account is supervised, and enabled after the account chooses to leave supervision. Didn't test on an Android EDU device yet. Bug: 894618 Change-Id: I81e4f75857bf7f8346ef4a48caa3e32edae95848 Reviewed-on: https://chromium-review.googlesource.com/c/1306654Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: P H <phongo@chromium.org> Cr-Commit-Position: refs/heads/master@{#606059}
-
Camille Lamy authored
This CL adds a temporary check in that we have a valid FrameNavigationEntry. NavigationControllerImpl: :CreateNavigationRequestFromLoadParams to check Bug: 896028, 877654 Change-Id: Iaaf20e3eeb98e4ce284fa6a18a9a75d7d8016c79 Reviewed-on: https://chromium-review.googlesource.com/c/1322875 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606058}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/398f37a2e0e6..c06a35b90214 git log 398f37a2e0e6..c06a35b90214 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 jbolz@nvidia.com Rename PCH macro to spvtools_pch to avoid conflicts with other projects. Also add pch to test/opt. (#2034) 2018-11-06 stevenperron@google.com Validate the id bound. (#2031) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c06a35b90214 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib0b2f79c6a5520b0bd4bb1498f7fe13b8adc247c Reviewed-on: https://chromium-review.googlesource.com/c/1323231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606057}
-
Ryan Sturm authored
This CL adds a redirect PreviewsState evaluation for all PreviewsStates that are not used in a URLLoader. Specifically, Offline, server LoFi, and DRP HTTP Lite Page are not re-evaluated on a redirect, but all other Preview types are re-evaluated entirely. Bug: 892253 Change-Id: If83642658304650b29d01ac727911a9cc75dcbf1 Reviewed-on: https://chromium-review.googlesource.com/c/1308768Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606056}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ca5cecde5b0..134e0525ddad git log 3ca5cecde5b0..134e0525ddad --date=short --no-merges --format='%ad %ae %s' 2018-11-07 rsavitski@google.com Kokoro CI: add build configuration for ui-clang-debug. Created with: gclient setdep -r src/third_party/perfetto@134e0525ddad The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic307725477cd86c5f8f6f576f5cd8880fae14f79 Reviewed-on: https://chromium-review.googlesource.com/c/1323129Reviewed-by:
-
Stephane Zermatten authored
Starting with https://chromium-review.googlesource.com/c/1319670 starting a script deletes the BatchElementChecker. Before this patch, this caused a crash when autostarting, because - BatchElementChecker calls the try_done callback set by the script_tracker - that callback autostarts a script - autostarting deletes the calling BatchElementChecker The crash happens right after calling try_done, when trying to access this to schedule a delayed task. With this patch, the callback is called after scheduling the delayed task. This way, there's no necessary usage of this after try_done is called. The weak pointer keeps track of dealing with the fact that the delayed task must not run. Bug: 806868 Change-Id: I1b907fcc96aecb66fc0b68fe2ea0f50532542100 Reviewed-on: https://chromium-review.googlesource.com/c/1323072 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#606054}
-
Justin Cohen authored
Change-Id: If0b97a63239476ed2bb9c5ee9fdf87007f29c36c Reviewed-on: https://chromium-review.googlesource.com/c/1322389Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606053}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=ericrk@chromium.org Bug: 901709 Change-Id: Id41759fbb8b2234c24dbaea33fcc3eff2a97b593 Reviewed-on: https://chromium-review.googlesource.com/c/1322254Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606052}
-
Jesse McKenna authored
TaskScheduler: Add UniversalPredecessorSchedulerLock, which allows one subsequent acquisition of any SchedulerLock Bug: 889029 Change-Id: I704dfd3d463c045d919d9d57cd486ad0a8b7cf83 Reviewed-on: https://chromium-review.googlesource.com/c/1320650Reviewed-by:
-
Antonio Gomes authored
This is a follow up of blundell@ request in [0]. It brings no functionality, but eliminates the need of UserCloudPolicyTokenForwarder to directly inherit from IdentityManager::Observer. [0] https://crrev.com/c/1299313/3/chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc#78 For completeness, this CL is a 4/n CL that migrates UserCloudPolicyTokenForwarder to IdentityManager. Previous two CLs were [1], [2] and [3]. [1] https://crrev.com/c/1296873 [2] https://crrev.com/c/1298775 [3] https://crrev.com/c/1299313. It also takes the opportunity to convert the use of OAuth2TokenService::ScopeSet to Identity::ScopeSet (driven-by). BUG=893504,899175 Change-Id: I907520ed211debe3fbd1a4c21b341da4b0a81dd8 Reviewed-on: https://chromium-review.googlesource.com/c/1319770Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#606050}
-
Colin Blundell authored
As suggested by msarda@ on https://chromium-review.googlesource.com/c/chromium/src/+/1317915. TBR=jochen@chromium.org Bug: 901859 Change-Id: I4b317bafa5e4a1a017e1977e2ddd444c61c3cfd3 Reviewed-on: https://chromium-review.googlesource.com/c/1319596 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Matthew Cary authored
Google.com may show a location-usage permission dialog which interferes with page interaction during profiling and may even cause chrome to crash. Wikipedia is more benign, even if it doesn't exercise the javascript and other processing that Google search result page does. Bug: 898979 Change-Id: I8f48f49ac58162bab482615f843651fafcaa9c0f Reviewed-on: https://chromium-review.googlesource.com/c/1317917Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#606048}
-
Justin Cohen authored
WKWebView -takeSnapshotWithConfiguration can return a nil UIImage if there is an error. Change-Id: Ifb1de97f9afed7436b5fae655ac9a35facdc2868 Reviewed-on: https://chromium-review.googlesource.com/c/1316750Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606047}
-
Colin Blundell authored
//components/signin/core/browser contains three different types of code: 1. Code that forms the guts of IdentityManager and will form the guts of the Identity Service implementation (e.g., SigninManager). 2. Code that will be clients of IdentityManager (e.g., SigninTracker). 3. Code that will be used on both sides (e.g., AccountInfo). Currently, the test support for all of these is naturally grouped in the same GN target, since there was never any distinction between them. However, we need to separate this test support in GN now, as the test support for IdentityManager should depend only on 1 and 3 (and their associated test support). This CL performs an initial split, via the following process: - Moved fake_signin_manager.*, fake_profile_oauth2_token_service.*, and fake_gaia_cookie_manager_service.* into a new "test_support_internals" target that the existing target now depends on. - Kept moving in code (and adding dependencies as needed) until "gn check" no longer complained about the "test_support_internals" target including code that wasn't in any dependencies. This CL also modifies //services/identity/public/cpp:test_support to depend only on //components/signin/core/browser:internals_test_support; this change is is the concrete benefit from doing the split. Finally, this CL strips both the test_support_internals and the test_support target down to the dependencies that they actually need; this change necessitated added some missing direct dependencies to other targets. Bug: 901859 Change-Id: I0ac61f69c0c897d97b570c16d06f0e4f5f99d037 Reviewed-on: https://chromium-review.googlesource.com/c/1319669 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Luna Lu authored
Bug: 829921 Change-Id: Ia2c70c62d4a4235b21996bbd185746080e1efa35 Reviewed-on: https://chromium-review.googlesource.com/c/1320010Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#606045}
-
Vadym Doroshenko authored
MSAN started complaining on uninitializing this variable (the first fail https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9484). Probably the immediate culprit is https://chromium-review.googlesource.com/c/1320027, but it's hard to say. Anyway this issue was earlier and it's easier to fix it, by initializing it to null then revert the CL. TBR=dtseng@chromium.org TBR=dmazzoni@chromium.org Change-Id: Ie045adfcf6860b47c8e649432c6b6c6abf2061b4 Reviewed-on: https://chromium-review.googlesource.com/c/1323090Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606044}
-
Mark Cogan authored
The CL removes a method that was functionally a no-op. Change-Id: I721a3f573253df4728dd9cc18ff484c56b52488a Reviewed-on: https://chromium-review.googlesource.com/c/1317860 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/add61bdaac69..aced3af1656c Created with: gclient setdep -r src-internal@aced3af1656c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idf2d018263fe823b73d57e5faf02ef3a76ece6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1323169Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606042}
-
Vadym Doroshenko authored
Sometimes sites change forms after adding them. For example removing/ adding fields. This CL makes NewPasswordFormManager process this situation, by updating |observed_form|, parsing it again and sending new data to the renderer. Bug: 895411, 831123, 895788 Change-Id: I296180c5b30f879a3f9bcc7af7cccb98f5fa8eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1317893 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606041}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=fmalita@chromium.org Bug: 901709 Change-Id: I32a755124e41532ceebc67900047ccb4580de9c2 Reviewed-on: https://chromium-review.googlesource.com/c/1322331Reviewed-by:
-
Jason Chase authored
The ExperimentalProductivityFeatures flag, with a corresponding chrome flag, was intended as an easy way for developers to turn on the Feature Policy bits. The Feature Policy reporting functionality and JS API have separate runtime flags. This CL configures an implied_by relationship, so that reporting and the JS API can be turned on together with other Feature Policy functionality. Bug: 899366 Change-Id: I2ff6ac9ed48902e7d1383ace94828f9e5154a27e Reviewed-on: https://chromium-review.googlesource.com/c/1303038Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#606039}
-
Patrik Höglund authored
The tests are clearly broken on Windows if a webcam is plugged in. They pass on win10 but only because they're disabled there. See bug for example breakages on Windows. Bug: 893494 Change-Id: I8ea43cc4e3ef23082246ff23ec635f2ec5bfbbe2 Reviewed-on: https://chromium-review.googlesource.com/c/1309789Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606038}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67f5c0ceac22..273fa2f3bd0b git log 67f5c0ceac22..273fa2f3bd0b --date=short --no-merges --format='%ad %ae %s' 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@273fa2f3bd0b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I45336359f6589fa969824646b01cd8a29a630009 Reviewed-on: https://chromium-review.googlesource.com/c/1323010Reviewed-by:
-
