- 07 Mar, 2018 40 commits
-
-
Xiangjun Zhang authored
Add a new mirroring component under components/ for the new mirroring service. The browser side codes are moved into the component in this CL. The media/remoting codes and other mirroring service codes will be added in later CLs. Bug: 734672 Change-Id: I0187f40bdfa44bcf7a9645b8bce4130fa6738eb0 Reviewed-on: https://chromium-review.googlesource.com/943822Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541498}
-
Jose Dapena Paz authored
The helper namespace declarations for manifest_keys, manifest_errors are declared both inside anonymous namespace and extensions namespace. This is ambiguous and makes compilation fail. So move all the helper declarations out of the anonymous namespace. Change-Id: I778b81c8094b12842fd47ae982b6cf620d208671 Reviewed-on: https://chromium-review.googlesource.com/944407 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541497}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Ia777a77da739ead813d8f898e194366d20e3601e Reviewed-on: https://chromium-review.googlesource.com/952987Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541496}
-
Luna Lu authored
Bug: 706389 Change-Id: I445e77e3da2782a7a8d6593cb46417fcaef96394 Reviewed-on: https://chromium-review.googlesource.com/952553Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#541495}
-
Theresa authored
BUG=818861,818751 Change-Id: Ie418d245523011f71d185ad4195ebdee3d2e4765 Reviewed-on: https://chromium-review.googlesource.com/951978Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#541494}
-
Misha Efimov authored
- Make Cronet test server serve files from data directory. - Change Android NativeTestServer to use Cronet test server. Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7f19519e9ee588e028976f4aa3411f735e69a4c1 Reviewed-on: https://chromium-review.googlesource.com/941589 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541493}
-
Leonard Grey authored
The setup for this test refers to features::kViewsBrowserWindows which was moved to ui/base in https://chromium-review.googlesource.com/c/chromium/src/+/949362 Change-Id: I69ea6064330a094dd041fbe7b244dfae0f806802 Reviewed-on: https://chromium-review.googlesource.com/952482Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#541492}
-
Charles Harrison authored
Bug: 813197 Change-Id: I2cc1f37e67911bbcfacbb0235c7330b51c5146c1 Reviewed-on: https://chromium-review.googlesource.com/943741Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541491}
-
https://webrtc.googlesource.com/src.git/+log/db4fa4b94442..2e18061033d3 $ git log db4fa4b94..2e1806103 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I46c08e6d4580d5d5f46a7af916cf538aae8836c0 Reviewed-on: https://chromium-review.googlesource.com/953063 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541490}
-
jdoerrie authored
TBR=csharrison Bug: 819592 Change-Id: Iab5688d761675b69b9ecddf83dc55abd37ea875d Reviewed-on: https://chromium-review.googlesource.com/952450Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541489}
-
Zhenyao Mo authored
This is an attempt to address a crash report. If after this CL, we still see the same crashes, then we might want to consider disabling GPU access. BUG=817286 TEST=bots R=geofflang@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I81979673020ec9ad6169642749cac3bb53f8decb Reviewed-on: https://chromium-review.googlesource.com/952275Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#541488}
-
Steven Bennetts authored
Bug: 804686 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I12f8b20ee210f436e1d4858eddb66a6fa112faaf Reviewed-on: https://chromium-review.googlesource.com/952033 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#541487}
-
jdoerrie authored
TBR=perezju Bug: 819552 Change-Id: Ib4fb62e89cd7b1bdeb6de2d4e94621b4fba519c6 Reviewed-on: https://chromium-review.googlesource.com/951734Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541486}
-
Xiaohan Wang authored
This is only used to support pepper CDM, which is being deprecated now. Hence remove all related code. Bug: 772160 Change-Id: Idfd2f97dd09a8be3f9aa90c998ffc18c60987057 Reviewed-on: https://chromium-review.googlesource.com/947922 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541485}
-
Devlin Cronin authored
We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest files under chrome/test/data/extensions/page_actions (which are not usually named manifest.json). This CL only modifies files that update cleanly (i.e., no other test updates necessary). A separate CL will address those. Bug: 816679 Change-Id: I5bbb98be75c9a1912e3221095d8aa4db1ba6f7d2 Reviewed-on: https://chromium-review.googlesource.com/952270Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541484}
-
Qiang Xu authored
Bug: None Test: still compiles Change-Id: I77e8ef85f1f7ad96fb463d1e3c1b2e6d569f4938 Reviewed-on: https://chromium-review.googlesource.com/952869Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#541483}
-
Fredrik Söderquist authored
ClipDisplayItems would use/generate antialiased clips, so it makes sense to carry that bit (literally) forward. Also update the FloatClip display item code-path for consistency. Bug: 814876, 819617 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1433804bd5734857116e613c2342c49d42499ecb Reviewed-on: https://chromium-review.googlesource.com/934450 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#541482}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Iaba5c56454b48cf1f43cb403599d853902cf7b5e Reviewed-on: https://chromium-review.googlesource.com/953045Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541481}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7948fee. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13447 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts igrigorik@chromium.org, yoav@yoav.ws: external/wpt/preload kojii@chromium.org: external/wpt/css/css-text/i18n external/wpt/css/css-text/line-break external/wpt/css/css-writing-modes TBR=robertma No-Export: true Change-Id: Id58023b08fa221002f143927c7070764d8f0c3e9 Reviewed-on: https://chromium-review.googlesource.com/953043 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541480}
-
Emil A Eklund authored
This reverts commit 6e39ad9c. Reason for revert: Introduced test failures on the layout_ng bot. Original change's description: > Add support for mid ligature position on ShapeResult > > Makes XPositionForOffset and CharacterIndexForPosition support > return results inside a ligature glyph (while still not breaking ZWJs) > by using a cursor-based TextBreakIterator inside glyphs. > > This also changes how InlineTextBoxPainter handles selection paint, to > support partial glyph selection. More specifically, for text selection > we now render the selected glyphs twice: once in the normal text style, > clipped out of the selection area and once in the selection style, > clipped in the selection area. > > Bug: 473476 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I121d03b436de88b367047efb8342cd975047a9ea > Reviewed-on: https://chromium-review.googlesource.com/752342 > Commit-Queue: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541474} TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org,fserb@chromium.org Change-Id: If1420a335f12629d97f45d788fdee1a120bc8aaf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 473476 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/952168Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#541479}
-
Peter Kotwicz authored
This CL parses the url_template as a GURL prior to substituting the placeholders. Parsing the url_template a GURL causes '{' and '}' in the url_template path to be escaped, and thus stops the ReplacePlaceholders() algorithm from replacing placeholders in the url_template path. Parsing the url_template as a GURL does not affect how placeholders in the URL query and URL fragment are treated. This change is in line with share target spec https://wicg.github.io/web-share-target/ A follow up CL (part 2) will make the fact that ReplacePlaceholders() only substitutes placeholders in the query and fragment more explicit. URL spec reference: https://url.spec.whatwg.org/#query-state '{' and '}' - are in the path-percent-encode set https://url.spec.whatwg.org/#path-percent-encode-set - are not in the fragment-percent-encode set https://url.spec.whatwg.org/#fragment-percent-encode-set - should not be percent encoded in the URL query https://url.spec.whatwg.org/#query-state BUG=694380 Change-Id: I0e3bcefa6cd9bc3997caf54ad824b6bfc87b9e88 Reviewed-on: https://chromium-review.googlesource.com/923539Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541478}
-
Jinsuk Kim authored
Added a null check agains getToolbarManager() in WebAppActivity.updateTaskDescription to avoid NPE, which is necessary since it can be invoked upon destruction of the activity where the ToolbarManager was already destroyed. Bug: 789725 Change-Id: I4c91c6f6ad05132c57266a307134efba26b07c79 Reviewed-on: https://chromium-review.googlesource.com/952583Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541477}
-
Devlin Cronin authored
We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates miscellaneous manifest files under chrome/test/data/extensions/ that weren't named manifest.json and weren't in a subdirectory to warrant updating them all in a patch. All files updated cleanly. Bug: 816679 Change-Id: I4e7132e528bc8a760ba77f5665ea8e900d936ddf Reviewed-on: https://chromium-review.googlesource.com/952290Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541476}
-
Philip Jägenstedt authored
So that https://github.com/GoogleChromeLabs/webidl-diff finds the shorter links and processes those. Part of https://github.com/w3c/web-platform-tests/issues/7784. Change-Id: I9697f7f1ae0e1960031ca25979295c8b8282f441 Reviewed-on: https://chromium-review.googlesource.com/952668 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#541475}
-
Fernando Serboncini authored
Makes XPositionForOffset and CharacterIndexForPosition support return results inside a ligature glyph (while still not breaking ZWJs) by using a cursor-based TextBreakIterator inside glyphs. This also changes how InlineTextBoxPainter handles selection paint, to support partial glyph selection. More specifically, for text selection we now render the selected glyphs twice: once in the normal text style, clipped out of the selection area and once in the selection style, clipped in the selection area. Bug: 473476 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I121d03b436de88b367047efb8342cd975047a9ea Reviewed-on: https://chromium-review.googlesource.com/752342 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#541474}
-
erikchen authored
The concepts are only well defined on Windows. The only consumers were in chrome/installer [for courgette and Zucchini], which currently only target Windows, so the call sites were updated to directly call the Windows APIs. Bug: 819289 Change-Id: Ic73d9944ed77276f0ca9fabf2bda62a7c34398b9 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/951923 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541473}
-
Jared Saul authored
Bug: 800588 Change-Id: Ib9c9d3e43ac78b938ac330877695e6d115d7b41f Reviewed-on: https://chromium-review.googlesource.com/952627Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#541472}
-
Jochen Eisinger authored
If a navigation was started by an HTMLAnchorElement with a download attribute (<a download>), the navigation will end up being aborted, and turned into a download, so leaving the URL around for the user to edit is not useful. BUG=808966 R=creis@chromium.org,pkasting@chromium.org Change-Id: Idcfa5c952cba7933fdf62e75a67ec4a2e2087695 Reviewed-on: https://chromium-review.googlesource.com/908451Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541471}
-
edchin authored
Bug: 804542 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2025b05f71013c45af56bfcd07e7143ff2a8c036 Reviewed-on: https://chromium-review.googlesource.com/952868 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541470}
-
jdoerrie authored
TBR=creis Bug: 819541 Change-Id: I5b36ae92c2706f71fc80b7f63504c01d2479eb7e Reviewed-on: https://chromium-review.googlesource.com/951687Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541469}
-
jdoerrie authored
TBR=brucedawson Bug: 819641 Change-Id: I5a24cba7a89ef43e0c0ce762680eaf9e2ab6aa0a Reviewed-on: https://chromium-review.googlesource.com/951689Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541468}
-
Justin Cohen authored
Bug: 805638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I690310beb94b0fed2cb228df37e9b60143119fc3 Reviewed-on: https://chromium-review.googlesource.com/952489Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541467}
-
Jared Saul authored
Bug: 789645 Change-Id: I1ec5fe2ab55858e826cac09cec4cbd2c7ca05903 Reviewed-on: https://chromium-review.googlesource.com/950412Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#541466}
-
Lily Houghton authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/836927 and renames most references to "proxy scripts" and to "pac files", including renaming ProxyResolverScriptData to PacFileData. TBR=mmenke@chromium.org,avi@chromium.org,halliwell@chromium.org,stevenjb@chromium.org,sky@chromium.org Bug: 613655 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3b172834c1281be2f554d96f37ebbf69d7291f4b Reviewed-on: https://chromium-review.googlesource.com/909654 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541465}
-
Steven Bennetts authored
Providing correct initial values reduces the noise when the complete set of properties loads. Bug: 808694 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f15e0965491376eb2c8e2403b55192f597a4dbd Reviewed-on: https://chromium-review.googlesource.com/951853Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541464}
-
Justin Cohen authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/941441, as hiding blur will hide the entire toolbar. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b051fc0573e45922d35bb695bfd3cdff289b3e8 Reviewed-on: https://chromium-review.googlesource.com/951748Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541463}
-
Dominik Röttsches authored
Taking on important fixes to hb_set_union/subtract/difference. Bug: 819624 Change-Id: I41088581a41565cbbd99a430425e2ab9be6ee939 Reviewed-on: https://chromium-review.googlesource.com/951736Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#541462}
-
Ian Vollick authored
This feature is not currently supported, though we hope to add support soon. This work is tracked in crbug.com/779126 Bug: 818012 Change-Id: Ib677f7ea62b9f681ba494c27367b286a122dd10f Reviewed-on: https://chromium-review.googlesource.com/944543 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541461}
-
erikchen authored
The method is only well defined on Windows, but its presence in base/ makes it appear to be well defined on other platforms. There were only 2 consumers: A metrics reporting call in remoting/ and a debug log in v8/. This CL updates remoting/ to fetch the metric directly on Windows and leave it empty on other platforms. This CL updates v8 to remove the field from the debug log. Bug: 819289 Change-Id: Id44c2efd345318dce9734566b4696c947b0fd617 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/951745 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541460}
-
Steven Bennetts authored
Bug: 796118 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e239ddd5430350d8a76a33f1dd5ffbaf4d3317f Reviewed-on: https://chromium-review.googlesource.com/952523Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541459}
-