GitLab

Change-Id: I77a57afaa10c8b5e8306c96f375c8f644e876d13
Reviewed-on: https://chromium-review.googlesource.com/1026095Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553227}

Update SandboxedUnpackerTests to manifest v2 and remove the allowance
for manifest v1 extensions.

Repackage all the crx's used in the sandboxed unpacker tests.

Additionally, git doesn't allow empty directories to be added to the
repository, which appears to have caused problems with some of the
unpacked versions of these extensions (where the empty directory is
necessary for the test). Add the missing directories, and put in a
dummy readme file to appease git.

Bug: 816679
Change-Id: I7130bbe89079437b8ee9090ba120039e2dbe9672
Reviewed-on: https://chromium-review.googlesource.com/1024910Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553226}

Unbounded mime-types result in the renderer getting killed because it is
trying to send a too large mojo message. Sensible mimetypes shouldn't be
very large anyway, so arbitrarily capping the mimetype at 64K is a
reasonable work around.

Bug: 835753
Change-Id: Idf91a27976f41b8cc07662a82f33d45a355c14f8
Reviewed-on: https://chromium-review.googlesource.com/1026201
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553225}

This is an invalid value for the property, but had been incorrectly left
in the CSS parser fast-path code as allowed.

Bug: 816534
Change-Id: Ic787508d21b3f385a37e5c4d50989c69d8dd48ac
Reviewed-on: https://chromium-review.googlesource.com/1024775
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553224}

The fallback logic is different for quic and non-quic proxies on
ERR_MSG_TOO_BIG. This CL adds test coverage for this error code.

Bug: 826570
Change-Id: Ied1470a878ddf3c6fabee1fe7170894a4de02f40
Reviewed-on: https://chromium-review.googlesource.com/1026050
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553223}

R=chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia8a8ea56dadcdba09eef12ee7ee9a6ca6459cef8
Reviewed-on: https://chromium-review.googlesource.com/1025224Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553222}

The test is flaky on all platforms.

BUG=294431
TBR=miu@chromium.org
NOTRY=true

Change-Id: Ifc4b0e8fef5b80bf02670f338987b322d388b666
Reviewed-on: https://chromium-review.googlesource.com/1026377Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553221}

ComponentLoaderTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679

Change-Id: Ic35a4f11840ea2194b16f93eb541aa62e8cd7361
Reviewed-on: https://chromium-review.googlesource.com/1025134Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553220}

Bug:835367

Change-Id: I21286271fb01e0737481a725d4d2d8a207a22ab7
Reviewed-on: https://chromium-review.googlesource.com/1017883
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553219}

Update WebAudio interface to include the very recently added
automationRate attribute for an AudioParam.

Also remove idlharness time expectation (suggested by Robert Ma).

And this doesn't actually resolve any of failures in the bug, but
it's a convenient place to update the IDL that should have been
done earlier.

Bug: 836051
Test: webaudio/idlharness.https.html
Change-Id: Icd535ee63f0a5f8772cb3445c762c89154fbda88
Reviewed-on: https://chromium-review.googlesource.com/1026199Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553218}

This reverts commit 48d140d3.

Original reason for revert: New tests have memory leaks:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27171

Original change description:
Use user preferences for TTS speech rate, pitch and volume if not set.

TBR=thakis@chromium.org,dtseng@chromium.org,jochen@chromium.org,thestig@chromium.org

Bug: 823359
Change-Id: I2e8ac4995a1bd84533cc8f7be3bae4a1f5fcaad7
Reviewed-on: https://chromium-review.googlesource.com/1026087Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553217}

This change also converts the minimum necessary amount of C++ code to pass
objects of base::Value by value instead of std::unique_ptr.

This change also modifies the union condition of DataView template to add
a check for is_null and pass a nullptr to Deserialize so that optional
values are handled correctly.

Bug: 646113,799482
Change-Id: I09575f4e593741370b537ede8103a3c3b196dfc7
Reviewed-on: https://chromium-review.googlesource.com/1011206Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553216}

"application/octet-stream" type may be passed by some apps that do
not know about MHTML file types. So when we check if an intent is
to open MHTML file, we allow this type and let the following file
extension check to find out if the file URL is for MHTML file.

Bug: 831767
Change-Id: Ide23ebbfd4a4fd9d47e8a06003ea2cd66338a354
Reviewed-on: https://chromium-review.googlesource.com/1024506
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553215}

This is just an isolated typo. No logic changes.

TBR=ellyjones@chromium.org

Bug: None
Change-Id: Idac88730e63ed07cca46063045495702368945aa
Reviewed-on: https://chromium-review.googlesource.com/1025228Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553214}

TBR=hzl@chromium.org

Bug: 790520
Change-Id: I92f8b2e00a9062e6a271cf3a94231ab82d78a6d4
Reviewed-on: https://chromium-review.googlesource.com/1026135Reviewed-by: Zhiling Huang <hzl@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553213}

Bug: 836235
Change-Id: Ieef527eb62e8d1184e91c77cfd60bc7fcf01bc56
Reviewed-on: https://chromium-review.googlesource.com/1025639Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Andrew Weintraub <asweintraub@google.com>
Cr-Commit-Position: refs/heads/master@{#553212}

Bug: 831939
Change-Id: I2804796894045dc69aa8309aa3ab34e6c80b38d7
Reviewed-on: https://chromium-review.googlesource.com/1010464
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553211}

Surface synchronization code is plumbed through RenderWidget, RenderViewImpl (because it
currently is a RenderWidget) and RenderFrameProxy (and the ChildFrameCompositor interface).

I'd like to take OWNERship of those files in order to expedite work on child allocated
LocalSurfaceIds for navigation (should improve time to contentful paint metric) and
to add Android top-bar synchronization and text selection handle synchronization support.

Change-Id: Ida8816c495ca64e326ee09f4e5d648f8dcac15b1
Reviewed-on: https://chromium-review.googlesource.com/1026212Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553210}

In my previous attemp to disable this here:
https://chromium-review.googlesource.com/c/chromium/src/+/1026155, there
was a typo and causes compile failure. I have a full build with this CL
and it works fine.

TBR=thestig@chromium.org
NOTRY=true

Bug: 836289
Change-Id: I92df34158b417b87adf48e9b8460d10171594a3e
Reviewed-on: https://chromium-review.googlesource.com/1024603
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553209}

This only contains the UI skeleton.

Bug: 835029
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I98f22b71dd3ab0a51e2f13ab96c54a011897a15d
Reviewed-on: https://chromium-review.googlesource.com/1016083
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553208}

Bug: 836238
Change-Id: Ibec5500a6d9348a30009d3d6d97a51c38a8e64ef
Reviewed-on: https://chromium-review.googlesource.com/1026051Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553207}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=vakh@chromium.org

Bug: 825327
Change-Id: Ic8c07068f4f567da6191716241a39fb3a68e6647
Reviewed-on: https://chromium-review.googlesource.com/1024318
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553206}

ChromeLauncherControllerTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: Ibe3aba811e68240bd5338aef9268af83bd611acc
Reviewed-on: https://chromium-review.googlesource.com/1026084Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553205}

Otherwise loads started right after calling abort() won't work.

Also simplify the watching logic in MojoBlobReader, to prevent hitting
DCHECKs in OnResponseBodyStreamReady.

Bug: 835928
Change-Id: I45eec517ccaf5f830101b6a02fce2fdcf696d17b
Reviewed-on: https://chromium-review.googlesource.com/1024315
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553204}

Bug:790520
Change-Id: If94cb97263cd69486ce25a63078739338d46ff5e

TBR=hzl@chromium.org
TBR=jbudorick@chromium.org

Change-Id: If94cb97263cd69486ce25a63078739338d46ff5e
Reviewed-on: https://chromium-review.googlesource.com/1026254
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553203}

Remove debug-build aslr policy-set test.  It's been failing all along,
but this is the first time we've turned on a debug Win bot.

Follow-up work / cleanup expected to follow.  Ref: crbug/834907

BUG=833648
TEST=sbox_integration_tests.exe, ProcessMitigationsTest.CheckWin8AslrPolicySuccess

Change-Id: I5bd538a1be03020b3dd4e355a3ebbd0a066adf7d
Reviewed-on: https://chromium-review.googlesource.com/1020153Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553202}

Otherwise it will trigger a gl_factory.cc assertion.

BUG=831168
TEST=chrome --in-process-gpu
R=oetuaho@nvidia.com

Change-Id: Ib50dd4350619d516d88bb30412d84a0f2644f1d5
Reviewed-on: https://chromium-review.googlesource.com/1024859Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553201}

And wires it up for WindowService on top of Aura. Another option is to
add a function to EnvObserver that is called anytime the mouse
location changes, but it didn't seem worth the extra complexity.

BUG=none
TEST=covered by tests

Change-Id: I83c426935b7c618351f5d5a786b8f9c4fc75fd59
Reviewed-on: https://chromium-review.googlesource.com/1024722
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553200}

Elements are possibly visible only if they ran the opacity computation
step.

BUG=835445
R=mthiesse

Change-Id: Ib45d933c36d509a8d0f224a1d2080fc88de78412
Reviewed-on: https://chromium-review.googlesource.com/1026071Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553199}

Bug: 829697
Change-Id: Id67192084d36f8a730d05c9e0213893c7776ae6f
Reviewed-on: https://chromium-review.googlesource.com/1026194Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553198}

We trigger the Download Home IPH bubble as a callback on the IPH
initialization path.  However if the Activity is destroyed while we're
initializing, we end up accessing destroyed state, which ends up being
null.

This patch puts a guard in place to early-out if we get the
initialization callback and ChromeTabbedActivity is destroyed.

BUG=833747

Change-Id: I1824250f5ffae4c1232b8b04786214a37e1bc10b
Reviewed-on: https://chromium-review.googlesource.com/1022083Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553197}

Removes dynamic lib dependencies from clang, and shouldn't regress
functionality anyone uses.

Bug: none
Change-Id: I4f46af0364a8c6fb90a591c46a50e373e287ae5d
Reviewed-on: https://chromium-review.googlesource.com/1025648Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553196}

This reverts commit be5a2a38.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 553160 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlNWEyYTM4Yjg3N2NkNzk3YzJlNjJjMzcxOTQ2Nzg5Y2RkMTU0YzMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29/123643

Sample Failed Step: compile

Original change's description:
> [cr-buildbucket] Clear 'cores' dimension for ios-* builders.
> 
> ios-* builders may run on a mix of VMs with cores:8 and Mac Mini's with cores:4.
> 
> Bug: 731546
> Change-Id: I056fbb5bd80ca50ef8005aa8bb99643853acd923
> Reviewed-on: https://chromium-review.googlesource.com/1024729
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553160}

Change-Id: I0c984c1aae350b8ab59954d6602b7a689ffa40f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731546
Reviewed-on: https://chromium-review.googlesource.com/1025284
Cr-Commit-Position: refs/heads/master@{#553195}

This CL is similar to https://codereview.chromium.org/2521793002. In order to
run this test on bots, we use base::LaunchUnitTestsSerially as a test runner.

Bug: 828176
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Change-Id: I49f6331f04168b998edf5504a5c9b39c31e78784
Reviewed-on: https://chromium-review.googlesource.com/1023112
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553194}

Introduce BrowserContext::UniqueId() method that returns
a string, uniquely identifying the browser context.

This patch:
- re-pursposes BrowserContext's media_device_id_salt_ into the
  unique_id
- exposes the id as BrowserContext::UniqueId
- moves headless browser contexts to use BrowserContext::UniqueId()

BrowserContext::UniqueId() will be exposed in DevTools protocol to
support browser context management for the automation needs.

BUG=836272

Change-Id: Ic721d5b06aab555d9c3d47043f49ab02506f2b0b
Reviewed-on: https://chromium-review.googlesource.com/1025269Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553193}

Fixed on https://crrev.com/551279

Tbr: yamaguchi-san
Bug: 836254,701922
Change-Id: I428256f41b8ac7c6119bf0e4ff209dbffdd8cb01
Reviewed-on: https://chromium-review.googlesource.com/1025853Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553192}

TBR=thestig@chromium.org
NOTRY=true

Bug: 836300
Change-Id: I7a60fad866a74518b2cd2bbd2921354bac5c22ea
Reviewed-on: https://chromium-review.googlesource.com/1024829Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553191}

https://skia.googlesource.com/skia.git/+log/af88ec371248..f50c283f0b53

$ git log af88ec371..f50c283f0 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 angle-skia-autoroll Roll third_party/externals/angle2/ b3474d9d7..66410530a (1 commit)
2018-04-24 mtklein disable skcms on Android framework builds

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I55723fc5ea35455f30ea04c80fe3222d6730656d
Reviewed-on: https://chromium-review.googlesource.com/1025959Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553190}

BUG=chromium:826527

Change-Id: I710b1712e016cd482c233fb930264128016c88bd
Reviewed-on: https://chromium-review.googlesource.com/1025102Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553189}

When it calls ReadFileToString() and fails, log the name of the file it
is trying to read.

BUG=826408

Change-Id: I546977b985c71cbd631820e7d7950b7f7449faba
Reviewed-on: https://chromium-review.googlesource.com/1024743Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553188}