- 18 Sep, 2020 40 commits
-
-
Ben Pastene authored
include_unwind_tables was removed from this bot a while ago when binary size metrics were spun up for fear that the tables would inflate the binaries. However, we don't actually ship linux-chromeos binaries, so their size metrics aren't very representative. Plus, the lack of the tables makes sheriffing more difficult since test failures won't produce full stack traces. Adding the tables back to the bot should make sheriffing it easier. Bug: None Change-Id: I67e042dfd1640d014fad62b741966ee211bb557f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419002Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808502}
-
Sunny Sachanandani authored
This pixel test relies on using a raw YUV file in the Chromium checkout for the fake video capture device. This doesn't work when the test runs on another device than the test harness like for Android and ChromeOS. TBR=zmo@chromium.org,behdadb@chromium.org Bug: 1129879 Change-Id: Iaf0d410d7a83ea06c9add4696ee4ad7de8794d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419334Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#808501}
-
Paul Moy authored
Expose a new routine through cros_healthd's ServiceConnection. This routine runs memtester on all of the device's available memory (except for 200MB reserved for the OS) to check that the device's memory is working correctly. The routine is modeled after crosh's memory_test. Long-term, crosh's memory_test will be migrated to this new implementation. The migration is blocked on cros_healthd becoming available on all boards, which should be done in a couple of weeks. This is part of an effort to consolidate all existing diagnostic routines into cros_healthd. Bug: chromium:1113897 Change-Id: I3bb25c1f04c1394e541af9c3c9ef66b8ae6ecd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412956Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808500}
-
Daniel McArdle authored
net_backoff_entry_serializer_fuzzer found a test case that causes the second deserialize step in TestDeserialize() to fail. We CHECK that the return value is truthy, but it is nullptr. Prior to this CL, BackoffEntrySerializer::DeserializeFromValue() would return nullptr when the parsed absolute release time was negative. There are two reasons for removing this less-than-zero comparison: (1) It complicates the fuzzer's logic for predicting the return value. (2) The value comes from TimeBase::ToInternalValue(). We should not assume we understand the internal representation of a time value. Bug: 1113344 Change-Id: I1e1e9d5a422d116e2f9682bab42b2acefb5a0fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398902 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#808499}
-
Marc Treib authored
The commandline param --gaia-config allows specifying a json file that overrides various Gaia-related URLs. This CL adds support for overriding the Sync URL via the same file. Bug: 1129493 Change-Id: Ieb1fee4b32f247acb69fde659c2c0c9564bcb130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418334Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808498}
-
Raphael Kubo da Costa authored
Even after r807421 those tests are presenting some occasional flakiness in the form of timeouts and, in a few cases, crashes in other parts of the stack. Clean up the code a little bit to make the code easier to follow and perhaps reduce the chance of timeouts: * send_message_to_frame() does not need to be an async function. * Use t.add_cleanup() to a few tests to make sure any iframe we add is properly removed even if an error occurs. * Remove all calls to the assert_*() functions from both the code path used by initialize_generic_sensor_tests() as well as generic_sensor_mocks.js, so that we no longer need to include testharness.js in the iframe handler page. * Make the onmessage handler in the iframe page also send a reply when errors occur. Bug: 1073865 Change-Id: Id6f682c95212d7ad9662f8aadad31c866752b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418333 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808497}
-
Alexander Cooper authored
It was discovered that the XRSessionModeRequest data was incorrectly labeled; however, the data source for this has (for quite a while), been the same as the XRSessionMode enum. This change converts the enum value to the properly labeled XRSessionMode enum, and removes the enum that is now no longer used (XRSessionModeRequest). Change-Id: I2177243f7d387f846b43b77e1996320677485978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410356 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#808496}
-
Michael Hansen authored
Invalidate send and receive surfaces to make sure we start or stop advertising based on suspend and resume events. This introduces the LockScreenStatusManager to encapsulate Chrome OS-specific observers. Bug: b:166174379 Bug: 1119993 Change-Id: I26f715be5affcbce14711ab9aeeb6c9b005ce23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412477 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#808495}
-
chrome://flagsAdrienne Walker authored
Bug: 582750 Change-Id: I915211564079f2619e04fd10c5164ea30f63b663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415209 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#808494}
-
Ted Meyer authored
for device 0x0166 with the 9.18.13.* drivers (3788 is the last patch number that is crashing) Bug: 1038006 Bug: 1126834 Change-Id: I0ec11b6b9f824f88d29cedea1ef79572fd3d6168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415138 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808493}
-
Carlos IL authored
Change-Id: Ic473c2bdc1e06214c292afcf9c2e25c1d5d93830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417449 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#808492}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac3fc4afea5d..ce9efee28b62 2020-09-18 bpastene@chromium.org cros_test: Clobber stateful when flashing the DUT. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com,bpastene@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com,bpastene@google.com Change-Id: I8a97d41c60ab071a75e04b1f6253b6506e241dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419244Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808491}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Icd698f3ab4cdd8febec55a0b87054da8fb7d7be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419261Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#808490}
-
manukh authored
Previously, there were overloads accepting values of std::string, int, and base::Time. This CL adds 1 more overload accepting values of base: :string16 in order to not require callees to convert with base: :UTF16ToUTF8(). Change-Id: I376faf110770c3db142ddefb55995858a37d8ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417306Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808489}
-
behdad authored
Skip system_health.memory_mobile/browse:news:washingtonpost:2019 to prevent time out on android-go TBR=jonross@chromium.org Bug: 1129885 Change-Id: I8c6a6dd0e17a2256a0acee15d60dc8a9b154bd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418321Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808488}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eed20333dd52..b3859e8d65e6 2020-09-18 tvanderlippe@chromium.org Reland "Remove support for remote modules" 2020-09-18 andoli@chromium.org [ts] Typecheck components/ImagePreview.js with TypeScript 2020-09-18 aerotwist@chromium.org Adds remote base helper 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingSettingsTab.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icb5d63b8951ec5e54dedc1c8fe8e4580fcfd9877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808487}
-
Ben Pastene authored
The current builder_group is proving difficult due to recipe reasons. A whole new builder_group should be easier. Bug: 1129540 Change-Id: Iee101b7f915ec158d3b761408a36e6fc62c4da21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419134Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808486}
-
Piotr Bialecki authored
Add 2 samples leveraging prototype implementation of depth API. Change-Id: I94514a905d694f168983f1afa9a9d4424a385188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417064 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#808485}
-
Sami Kyostila authored
This patch adds support for interned data in typed trace points. This helps to reduce trace size for frequently repeated data. As an example, an interning index for base::Location could be defined as follows: struct InternedLocationIndex : public perfetto::TrackEventInternedDataIndex< InternedLocationIndex, perfetto::protos::pbzero:: InternedData::kSourceLocationsFieldNumber, Location> { static void Add(perfetto::protos::pbzero::InternedData* interned_data, size_t iid, const Location& location) { auto* loc = interned_data->add_source_locations(); loc->set_file_name(location.file_name()); loc->set_function_name(location.function_name()); loc->set_line_number(location.line_number()); } }; A corresponding typed trace point using the index could look like this: TRACE_EVENT("cat", "Name", [](perfetto::EventContext ctx) { auto* log = ctx.event()->set_log_message(); size_t iid = InternedLocationIndex::Get(&ctx, FROM_HERE); log->set_body_iid(iid); } Bug: b/156727531 Change-Id: I5a78784be688071f7373ac1655b1ce74428f7b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410117 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#808484}
-
Mason Freed authored
The synchronous parser previously had a fixed token budget. This CL enables Finch experimentation on the number of tokens for that budget. If no Finch is enabled, the budget stays the same, 500. Bug: 1128608 Change-Id: I5a0d21833a3b254188dce86fc019a494ce3e3dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412827Reviewed-by:
Richard Townsend <richard.townsend@arm.com> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#808483}
-
Lan Wei authored
We do not need WPT test expectation files for WPT tests except the infrastructure tests, so we should remove third_party/blink/web_tests/external/wpt/pointerevents/ pointerlock/pointerevent_pointermove_in_pointerlock.html.ini. Bug: 1086154 Change-Id: Ie964d783cdf4cd5754de7df0e7262cf5fc3e4696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418975 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#808482}
-
Jeffrey Kardatzke authored
This adds support for setting the HDCP Content Type when enabling HDCP for output protection. The two values are Type 0 and Type 1. Type 0 is equivalent to HDCP 1.4, so it shares the same value as the prior protection setting for that to minimize code changes. This will then be plumbed through to the Chrome OS CDM Factory Daemon to enable it to turn on and query output protection. BUG=b:168230642,b:153111783,b:132039686 TEST=Unit tests pass, works with full set of changes on prototype Change-Id: I19f5ab7e0f1d1b57062e0b77e864e55144afce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413087 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#808481}
-
Jeff Yoon authored
* Roll all iOS builders (goma, webrtc, fyi, mac, try) to 12a7209 * Roll all upstream iOS tests to run on 12a7209 Bug: 1128632 Change-Id: Ia18f2391e9aea21c92d867612bc43a140ef96fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411403 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808480}
-
Charlie Hu authored
'font-display' has been migrated from feature policy to document policy in (https://chromium-review.googlesource.com/c/chromium/src/+/2036518). This CL cleans up some misnames after the migration. Change-Id: I2edc1611a8b5f53997ad152661ba18284eac669a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404147Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#808479}
-
Travis Skare authored
Bug: 1093377 Change-Id: I4df1bf7bdfe6efe0cbf09b20b9815e7f9eebfeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364655 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#808478}
-
Lei Zhang authored
Add a new "-u" switch to list_flags.py to search for unused flags. It checks the obvious files that should reference flags. Change-Id: I0f9b050b2adcafd0a612bae93f2e4ef08cdf0e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416851 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808477}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e69a13d838d..c884631f9942 2020-09-18 johnstiles@google.com Migrate Derivatives tests to golden outputs. 2020-09-18 csmartdalton@google.com Lift SkMeasureAngleInsideVectors and SkFindBisector to public SkGeometry API 2020-09-18 brianosman@google.com SkSL: Cleanup interpreter intrinsics, etc. 2020-09-18 csmartdalton@google.com Don't simplify a stroked shape if it isn't closed 2020-09-18 nifong@google.com Add a define causing debugger to use an older clip feature If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I3dbbbd426e10a4e6f1c4368923bf8fa47c8c9e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808476}
-
Shimi Zhang authored
In this CL, we register listener for content editable element including <input> and <textarea> elements. This is used to notify that the browser side that there will be a handler for touchstart event, so it needs to send the event to the renderer. Please refer to the bug for more information about the overall design. Bug: 1126778 Change-Id: I35457d5f1ca02c943b5bf594c06a6a70e2c6e3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401786 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808475}
-
Ankit Kumar 🌪️ authored
Update pdf/ to use gfx::*F instead of pp::Float* - pp::FloatRect to gfx::RectF - pp::FloatSize to gfx::SizeF - pp::FloatPoint to gfx::PointF or gfx::Vector2dF gfx::FloatPoint is replaced by gfx::Vector2dF where we need to store the vector difference between two points. All other instances have been replaced by gfx::PointF. Noteworthy points: - In pp::FloatRect, Union() is a utility method which takes in two rects and returns a rect with the specified operation of input rects. Whereas in gfx::RectF, Union() is a member method which modifies the rect in-place. All usage of Union() which are replaced in the CL modify the rect in-place. Added conversions between gfx::RectF and pp::FloatRect, with tests. Bug: 1101101 Change-Id: I57ca3bddd16da1328cbe462e60be862be3811ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413769Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808474} -
Chromium WPT Sync authored
Using wpt-import in Chromium e50ef635. With Chromium commits locally applied on WPT: b943d006 "[COOP] Access reporting with 2 reporters." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I0f9b8c43988139c0422edee444e9bb2073a00995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419271Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808473}
-
Mark Yacoub authored
The CL fixes the following issues: 1. When looping over pending modeset requests, do not depend on the dynamic vector size. 2. If the display modeset has failed, do not always select the next available mode, check that it's valid first. 3. Retry configuring displays when any of them fail, not just the last one. 4. Use default values for unittest variables. BUG=b/168800852 TEST=should configure multiple displays even after the first mode is rejected. display_unittests Change-Id: I285d02f4b7f653588b53c48655cc05514264242d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417008Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#808472}
-
Eugene Zemtsov authored
Switched from using parses' object pointers to using ids and looking them up when needed. Bug: 1129422 Change-Id: Ib1e618a048406c5d50290a9512ee455f03f1d28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416863Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808471}
-
Nektarios Paisios authored
This is a reland of 6772afd3 Tests failures in PDF tests were caused by out-of-date expectations which are now fixed. Original change's description: > Stops computing an artificial accessible name from inner text on Mac > > When an object on Mac is focusable but has no value or name, we compute its accessible description > from its inner text. > Unfortunately, we were adding a space between the concatenation of each piece of text coming from each child object > which creates a mismatch between the text offsets returned by AXPosition and text markers vs. the actual text contents. > If extra spaces are needed, they should be added by Blink, not by the browser. > This patch removes the code that computes the inner text completely since > no other screen reader announces focusable items unless they have an accessible name, > and it is not proper to add an accessible name if there is none. > > AX-Relnotes: On Mac and same as on all other platforms, navigating by tab now does not announce > the text contained in a large container such as a table row if that container is focusable. > > R=dmazzoni@chromium.org > > Change-Id: Iac5f321113595a2372df03bb119ab1c7a6f1bbf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308649 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794574} Change-Id: I04ff746943b97d76f90849da558aec7dba3022d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356004 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808470}
-
dpapad authored
In the new UI layout, the PDF area can be resized in two ways 1) expanding/collapsing the sidenav 2) resizing the entire window Because of #1, the previous approach of listening for the Window's 'resize' event is no longer sufficient. Therefore a ResizeObserver is used which works for both #1 and #2. Bug: 1121351 Change-Id: I6fd895a55e4630f9562c8d8ea38dc7d4fc6ebb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391335Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808469}
-
Dominic Mazzoni authored
Original: http://crrev.com/c/2404164 Reverted: http://crrev.com/c/2416357 due to issue with death test. Replace the hand-written code to parse each enum from ax_enums with a templatized function that builds a map from string to attribute value on-demand. This saves a little bit of manual effort each time someone updates an enum. Note that these parsing functions are only used by the automation API. Bug: None Change-Id: Ib710f15f2596b04d30ca177b8141b2dc953ed5c1 AX-Relnotes: N/A Tbr: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418850Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808468}
-
Caleb Raitto authored
We can then divy these up amongst the team and rename them without causing excess merge conflicts. Produced by: gen_web_feature_mojom.py: import sys startingValue = int(sys.argv[1]) numEntries = int(sys.argv[2]) for i in range(startingValue, startingValue + numEntries): print(' kIdentifiabilityStudyReserved%d = %d,' % (i, i)) gen_enums_xml.py: import sys startingValue = int(sys.argv[1]) numEntries = int(sys.argv[2]) for i in range(startingValue, startingValue + numEntries): print(' <int value="%d" label="IdentifiabilityStudyReserved%d"/>' % (i, i)) Bug: 973801 Change-Id: Ica729a243defb580e9dcbf18fa1a433938581cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416259 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#808467}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib49002b92910784299238b52019db57343b9ffaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808466}
-
manukh authored
At one point, the document provider expected responses with http status codes of 200 with a specific error code in the response body. This was deprecated in favor of responses with 400 & 499 http status codes. For a while, the provider handled both. Now that the backend exclusively employs the new responses, it's safe to remove the original 200 backoff handling. Change-Id: Ie79fedaa6e0930db3f32aefedd3ccde699f984a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416561Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808465}
-
Lukasz Anforowicz authored
CORS-for-content-scripts has shipped in M85 - afterwards, the UKM and UMA metrics should only be logged for allowlisted extensions. In M87 we have removed the allowlist (r807240) which means that the metrics can't be utilized going forward. Additionally, we would proceed with deprecating the allowlist, even if the metrics would show that some extensions might still be _hypothetically_ affected. For the reasons listed above, this CL removes the UKM and UMA metrics for CORS-for-content-scripts. This corresponds roughly to reverting the following CLs: r739693 (UMA) and r750700 (UKM). Note that Rappor has been added in r746508, but has been already removed in r768003 (and therefore this CL doesn't touch any Rappor-related code or files). Bug: 920638, 1125776 Change-Id: I5b410d9e17a19ae0d3eec8727317ae940bf1896c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396712Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#808464}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/97813ea40eea..5bfca93e1a51 2020-09-18 jmadill@chromium.org Fix roll script for CIPD deps. 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 6ccc0d9ba0ff to c9f4fb2fccda (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Ib28763d86697ba8b8ecc917dc598eea3bddde9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808463}
-