- 10 Dec, 2020 40 commits
-
-
James Cook authored
Per discussions with product and legal, we want to continue to use a single metrics reporting / crash upload consent on Chrome OS, for both the OS and the lacros browser. Notes at go/lacros-crash-consent This CL connects the browser settings toggle for metrics reporting to the canonical OS metrics reporting pref over mojo. See design doc at go/lacros-metrics-consent Bug: 1148604 Test: added to unit_tests and lacros_chrome_browsertests Change-Id: I38b20ba6d92c6e6b46be297a2120a964023cd195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582642Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#835757}
-
Leonid Baraz authored
Rid cloud_policy_client.h of dependences on EncryptedRecord and related stuff. Bug: 1078512 Change-Id: I45345388e738727d1593d49cfb4042a1d80e63c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580560 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#835756}
-
cfredric authored
This CL also makes the existing --use-first-party-set switch enable the First-Party Sets feature. Change-Id: I8ef099d0eb932e5f4f25f20dc7a426f3a29f6538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583003Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#835755}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32f1a8e81217..108b759ef91b 2020-12-10 xiaoxuan.liu@arm.com EGL: Update EGL headers/xml If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ieb8e1b437e529a305135ad281623e9331dbacc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584333Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835754}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I02bd38160961d061606f4ffd25334857c24146cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583204 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Alexander Surkov authored
Bug: 1136957 Change-Id: I7ccfadcac9f584668508234b3869e919afece962 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563923Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#835752}
-
Marijn Kruisselbrink authored
The first file type will be used as default extension in save dialogs. Previously the mac implementation of the save dialog would arbitrarily re-order the passed in file types (by adding them all to a set, and using the resulting order), which makes it impossible for callers to actually enforce what extension should be used in save dialogs. This fixes this behavior by keeping the order of file types as passed in, only using the set to avoid duplication. Bug: 1103133 Change-Id: I08d9d944eee977a1c99c1b1ecd72f6bb2c9afdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582823 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#835751}
-
Mario Sanchez Prada authored
Migrate this legacy IPC message to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, and update callers in the renderer process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: Ice3ac3cd4e7eca5e6e6876e99576fdca6687063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560583 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835750}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c18d56820d2..145deff4ccea 2020-12-10 jacktfranklin@chromium.org Fix new Linkifier clicks not registering If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie82c851e58a1c608403e6ca6729ece503a05c293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584332Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81356f4bf38c..59df85b5457e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I12673c92d94bc0527d706be94062a3a515bfd9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584582Reviewed-by:
-
Jan Wilken Dörrie authored
Following the removal of PasswordStoreX, PasswordstoreDefault is the only remaining production implementation of the PasswordStore interface. To avoid confusion and to be consistent with existing Chromium practice, this change renames PasswordstoreDefault to PasswordStoreImpl. Bug: 950269 Change-Id: I0ce1c73407b587ace9fdc2d2dfed1a53765a2433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584167 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#835747}
-
Yusuke Sato authored
Now that the function is in arc_util.h, it's better to have tests in arc_util_unittest.cc (rather than indirectly test the function in arc_vm_client_adapter_unittest.cc.) Bug: None Test: components_unittests Change-Id: I75ef434ee39f28cdb545342cec535337849382c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582996Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#835746}
-
Shannon Chen authored
This reverts commit cd68a26c. Reason for revert: Focus ring disappears in switch access menu crbug.com/1157261 Original change's description: > Move focus rings and highlight layers under accessibility bubbles. > > Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. > > Bug: 1143814 > Change-Id: I1c4fce614404c6cabd0336eed2ab6fa7ac1d4c48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568547 > Commit-Queue: Joel Riley <joelriley@google.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833155} TBR=dmazzoni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,joelriley@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143814 Change-Id: I08c1552e93763dfbf8e09ff75e23e64033456675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583106Reviewed-by:
-
Hidehiko Abe authored
Currently, startup data is passed from ash-chrome to lacros-chrome via LacroChromeService::Init() Mojo call. This requires Mojo initialization so that the data is available only after that. However, there are some needs that the data would like to be available earlier. In order to support that situation, this CL introduces another approach, where ash-chrome dumps the serialized data into a memory backed file and lacros-chrome inherits its file descriptor. For backward compatibility, both lacros-chrome and ash-chrome supports older protocol, i.e. LacrosChromeService::Init() for now, while it is now deprecated. Thus, any {old,new} {lacros-chrome,ash-chrome} combination should work. It is planned to remove the older protocol support, when newer/older chromes are distributed enough. BUG=1155494 TEST=Ran tryjob. Ran {old,new} {lacros-chrome,ash-chrome} combinations on DUTs to make sure lacros-chrome can be launched successfully via Shelf icon and mojo_connection_lacros_launcher.py script. Change-Id: I09c7004d07cec9a58ccfc7ee24c0e256149e4951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573264 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#835744}
-
Benjamin Beaudry authored
Allow fragmentation for an abspos element that is positioned using the bottom property and has a computed height. This CL is relatively simple as all of the logic to estimate the block size from the content was already there. It only required some tweaking. There are edge cases, like how to handle break-rules, that I'll address in follow-up CLs. Bug: 1156250 Change-Id: Ibca325df2a22fa6cf6ec3b30409183f459d092b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577757 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835743}
-
Monica Basta authored
This CL adds a tooltip that is visible on keyboard focus and hover over the theme colors in the 'cr-customize-themes' component. Bug: 1156184 Change-Id: I61739db8af17e58aa7f37f773d6a5488c5bad60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584009Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#835742}
-
Eugene But authored
This CL leaves old headers to avoid changing the clients in one large CL. Those old headers import new headers and typedef the old names to point to the new names. Bug: 688063 Change-Id: I31c34463d47e31335dd0909fe816707733cf1a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583386 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#835741}
-
Jacques Newman authored
Some IDLs do not generate a dlldata or proxy stub file. In these cases, midl.py should not expect midl to generate these, similar to how .tlb files are handled today. Currently, midl.py will assert as the output comparison will always try to find the dlldata and proxy files. This issue was found in a project downstream, currently there are no such IDLs being build in chromium. Bug: 1157129 Change-Id: Id6069eb7879ce917ab683c7ac00543f36d0dee4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582261Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835740}
-
Joe Downing authored
This CL cleans up some code that was used in the past to select VP9 and H.264 at connection time. AFAIK neither of the mobile clients are set up to select a codec other than VP8. The website uses WebRTC which negotiates the codec using SDPs. While I was working on getting the h.264 codec back in working order, I needed to read through this code to figure out if it was useful. Since it appears that it isn't (and likely never will be) I think we should clean it up. Change-Id: Ibac53315d9a8daa71353551011654b94430982d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568291 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#835739}
-
Keren Zhu authored
Bug: 1156656 Change-Id: I3073084202bdf677a6a6bd910571027c18c2009f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583384Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#835738}
-
Nico Weber authored
Somehow there's absolutely no Objective-C code left in this file after recent simplifications. Might as well rename it. Bug: 1147069 Change-Id: If74e0e20e4abff8518bb94264101939ccda54995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584606 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#835737}
-
Yuri Wiitala authored
See discussion in crbug 1155426 for details. Changes: MediaStreamCaptureIndicator::UIDelegate: Ignore multiple calls to OnStarted(). TabSharingUIViews: Unconditionally execute clean-up tasks in destructor. Bug: 1155426 Change-Id: I392fba38118ce51744ba36b4dec19ebfe39f1fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581028Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835736}
-
Ali Juma authored
This merges FinishGoToIndex(), FinishReload(), and FinishLoadURLWithParams() into their respective callers. These were previously separate methods so that subclasses of NavigationManagerImpl could provide different implementations, but there are no longer any such subclasses. Bug: 738020 Change-Id: I798415144ba48c59f8c892300b23413de9c9ab7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581301Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#835735}
-
yiyix authored
In the initial implementation, if color setting information is missing in getImageData/createImageData, it uses the information of canvas to initialize the image data. In the spec, it says that it should use the default setting of {colorSpace: srgb, storageFormat: uint8} instead. In this cl, I updated the default behavior for the function getImageData and createImageData. Bug:1118182 Change-Id: I4fba4284028c060d5ac7ff80a294d95f8436ef62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567750Reviewed-by:Fernando Serboncini <fserb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#835734}
-
Yue Zhang authored
These tests are flaky on android-pie-x86-rel. TBR: mlamouri@chromium.org Bug: 1157494 Change-Id: I80ae660c7bbe0e073de2e890bd65d86600ce03e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585126Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835733}
-
Daniel Vogelheim authored
Fix-it week: Fix the "sink" name for Function constructors. The original implementation tried to keep it simple and disambiguated between "eval" and "Function" only when the value was available. That wasn't quite sufficient, so now we pass in the value whenever we determine the sink for script values. (This follows the spec, as linked in the issue.) Bug: 1153054 Change-Id: Ie53f9ee30428b6c94140cabf87d7027367b055a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584024 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#835732}
-
Michael Thiessen authored
On L, before this change (using startActivity()), instead of launching the Activity, Android launches the Android Settings page for Chrome... I couldn't figure out why. Also, with or without these added flags, startActivitySync errors out, even though it does actually work. I also have no explanation for this. However, after 50 runs each of the 4 flaky tests I've had zero failures now on my L device with these changes. Bug: 1153712 Change-Id: I95b9f8d3e4f2013b25429c6fd6ee3afbb43c5618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583084 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#835731}
-
Liquan (Max) Gu authored
According to test coverage report[1], the error handling branches of PRService#updateWith(), OnConnectionError(), OnPaymentDetailsNotUpdated() has no test coverage. This CL adds the tests to cover these cases. [1] https://analysis.chromium.org/p/chromium/coverage/file?host=chromium.googlesource.com&project=chromium/src&ref=refs/heads/master&revision=5089ddb0638765b738ce9690ee00be44d2e19a9c&path=//components/payments/content/android/java/src/org/chromium/components/payments/PaymentRequestService.java&platform=android-java#1213 Bug: 1093971 Change-Id: I555d46796f1b570a49fb0861328effbb8226bd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584463 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835730}
-
Mike Jackson authored
Turn's on support for display_override. To test the change use: chrome Example installable apps: https://mwjacksonmsft.github.io/pwa/display-override/index.html (display: fullscreen, display_override == [minimal-ui, standalone]) https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html (display == browser, display_override == [standalone]) Example non-installable apps: https://mwjacksonmsft.github.io/pwa/display-override-browser/index.html (display: fullscreen, display_override == [browser, standalone]) Explainer: https://github.com/WICG/display-override/blob/master/explainer.md Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/MZgYJgS4Lcs/m/NnUxG2_mAAAJ Bug: 1092667 Change-Id: I8e77b8e38e05e683173f0820fad7006725be24b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536210 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#835729}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/29fd62989338..6bcd4aceef10 2020-12-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 7a0daa233d8a to 287f6f12eff6 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Ie86367873b645e9ff5125262e964f94431253093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584330Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9ae34772. With Chromium commits locally applied on WPT: 01ceb784 "Fix a crash PaintWorkletImageProvider::GetPaintRecordResult" 2becd034 "[AspectRatio] Don't stretch grid items if they have an aspect ratio" cc224570 "SXG + reporting: Make WPT tests work with NetworkIsolationKeys." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iba616b36035c24ef6c7eec79197b946c26d353f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584406Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835727}
-
Mark Schillaci authored
This CL updates the AccessibilityNodeInfo object actions on Android. With this CL we partially revert the work done here: crrev.com/c/2341398 We will no longer add the LONG_CLICK action to all nodes in Android, however we will continue to process LONG_CLICK's sent to performAction. AX-Relnotes: Elements may not explicitly announce they are long clickable on Android Change-Id: I115d29b5288df45de7a800523a9c074237b233b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583142Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
-
Maria Kazinova authored
On other platform, when the user manually typed the username into the login form and then selects a suggestion from the password field, the typed username is not rewritten. This CL ensures the same behaviour on iOS. Bug: 1157460 Change-Id: I7fca9e69256c7efb3cdea3133a9a830b9df1af98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584303 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#835725}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Id6bc188e94a56d9d7a3374a2b585b56ef00b7fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582322 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#835724}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9f89587dc4fc..c566c247eb76 2020-12-10 lalitm@google.com Merge "tp: fix async slices not finishing properly" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If60743a38c23dcc0d00bcc00fbf1c5563a8e9bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584348Reviewed-by:
-
Yi Gu authored
Previously we didn't reject the promise when - the prompt is timeout - sms does not reach user - user declines the promot This patch handles the scenarios and rejects the promise with unified error message and uses an indistinguishable timeout schedule that does not reveal user action or sms arrival to protect user's privacy. This patch also rejects the promise upon kBackendNotAvailable because it doesn't reveal any user info. The timer threshold is based on |Blink.Sms.Receive.TimeSuccess|. i.e. it makes sure that most of the SMSes can reach the user before the deadline. Bug: 1138454 Change-Id: I85c4e50778d021c9b580f6a9598fa6e35d6ac63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569946 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#835722}
-
Aleks Totic authored
What happens when table has more columns than cells? Should the extra columns be discarded, or used to table grid? If the columns are not discarded, and table has border spacing, each empty column would make table wider. Spec, and previous implemntations are not clear on what to do. Initial table spec had a concept of effective columns, where multiple columns could be treated as one for purpose of layout. New spec introduces the concept of track merging. https://www.w3.org/TR/css-tables-3/#dimensioning-the-row-column-grid--step2 It is a messy subject. I think cells could merge, but not columns. But then in some implementations (ours), columns could merge too. I investigated this because two wpt tests were failing in TablesNG: external/wpt/css/css-tables/html5-table-formatting-1.html external/wpt/css/css-tables/html5-table-formatting-2.html They also failed in FF/Legacy, but in different ways. The initial code trimmed the excess columns. New code does not trim the columns. This makes html5-table-formatting-2 pass all tests, and makes one extra test in html5-table-formatting-1 pass. The fix exposed a bug in ColumnGeometries sorting, ordering was not monotonic. Fixed that too. Bug: 958381 Change-Id: I9bd267f7e7782df7224f5db4611751ca10ff1aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583157Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#835721}
-
David Roger authored
This CL changes the following: - profile bubbles are automatically focused when shown - they are announced by screenreaders, using the role="dialog" attribute - the line separator is ignored when navigating the bubble (this is consistent with other line separators, e.g. in settings) Fixed: 1156103 Change-Id: Icc33d0bc790fffbb1e618a50235d09e99c69fdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582079 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Jesse Schettler authored
Bug: 1059779 Change-Id: Iee421f4a2719abaec71d837c68f26aae88aa255a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582528Reviewed-by:
-
Chris Lu authored
FullscreenController is tied to the Browser, so when the Browser is destroyed, any reference to FullscreenController is garbage. Thus, SadTabCoordinator needs to call [self stop] to break itself down (and therefore reset its FullscreenDisabler) before the Browser is completely destroyed in case [self stop] is called by its owning class after the fact. Bug: 1154298 Change-Id: Id9ffc055d338972fe360899a14cf596fc7c41a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572692Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#835718}
-
