- 21 Jul, 2017 40 commits
-
-
Nicholas Verne authored
static methods previouly in WebViewImpl.cpp are now available in WebViewBase.cpp. These classes will eventually merge and the schism will be repaired. Usages of base::SingleThreadTaskRunner in WebLocalFrameImpl are replaced by the alias in platform/WebTaskRunner to satisfy our PRESUBMIT. Bug: 712963 Change-Id: I76ba9b1d7f15180b8d2dfeaed8cdc93ff9ac091f Reviewed-on: https://chromium-review.googlesource.com/577429 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488632}
-
Peter E Conn authored
Make the render tests fail if the rendered bitmap does not match the golden. Bug: 641973 Change-Id: I432111296893bafab18dc65bfb62b12a8212d68e Reviewed-on: https://chromium-review.googlesource.com/565399 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#488631}
-
Daniel Bratell authored
A variable wasn't given the right name inside the ATK support when a patch consolidated 3 AX properties into single restrictions property for accessibility objects. R=aleventhal@chromium.org, jochen@chromium.org Change-Id: I0c82e055e39614110cfc4f7a7299d226bd4e6ad2 Reviewed-on: https://chromium-review.googlesource.com/580927Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#488630}
-
Olivier Robin authored
This check was initially added to avoid overscroll actions on the terms page of FRE. But the terms page does not use BVC at all and is presented by the WelcomeToChromeView, so the check is not needed. Bug: 746415 Change-Id: I30c74c0283dc63a88d8233287cf130af70e84ab2 Reviewed-on: https://chromium-review.googlesource.com/580929Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488629}
-
Kent Tamura authored
Change-Id: I4709561d23a03bb4e76219a99520541ad17ec927 Reviewed-on: https://chromium-review.googlesource.com/580177 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#488628}
-
Yoshifumi Inoue authored
Move same conditional expression of while-statement AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function This patch moves same conditional expression of while-statement in |AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries()| into |IsNonEditableContentInsideTheSameLowestEditableAncestor()| to share code and simplify if-statement for improving code health. This patch is similar to the patch[1]. [1] Tree is open (suspected flake, https://crbug.com/743069) Reply More Move same conditional expression AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function Change-Id: I3662b9bcc78add3c465987b370bde82e7b38008f Reviewed-on: https://chromium-review.googlesource.com/580114 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488627}
-
Koji Ishii authored
HarfBuzzShaper calls ShapeResult::InsertRun() for each run RunSegmenter segmented. This patch fixes ShapeResult::InsertRun() to compute ShapeResult::glyph_bounding_box_ when there are more than one run. Before this fix, it computes glyph bounding box of each run from (0,0) then unite all bounding boxes. So if input text is "englishARABIC", RunSegmenter creates 2 runs and each InsertRun computes: Run 1: "english", width 70, bounding box (0,0,70,10) (x,y,w,h) Run 2: "ARABIC", width 80, bounding box (0,0,80,10) then the united result would be (0,0,80,0) while the total width is 150. This patch fixes InsertRun() to compute bounding box from the current point, so that: Run 1: "english", width 70, bounding box (0,0,70,10) Run 2: "ARABIC", width 80, bounding box (70,0,80,10) and the united result would be (0,0,150,0). This patch also removes incorrect fix made to ShapeResult::CopyRange(). This was done to pass tests in a previous CL[1], but turned out that the original glyph bounds is incorrect and the fix was wrong. [1] r487410, https://chromium-review.googlesource.com/c/574508/ BUG=746904, 636993 Change-Id: Iec147e5e9b9853a60489e23355ede730ce918c36 Reviewed-on: https://chromium-review.googlesource.com/577970Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488626}
-
arthursonzogni authored
In content/, this CL replace every renderer-initiated navigations started with TestRenderFrameHost::SimulateNavigationStart() with a navigation using the NavigationSimulator. Bug: 728571 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Change-Id: Ibe7bf13c645d202af1a7bb1dd9aecdc20a50d288 Reviewed-on: https://chromium-review.googlesource.com/574865 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#488625}
-
Jérôme Lebel authored
If the setting view controller is being reloaded while being dismissed, a new SigninPromoViewMediator is created. This new one is not properly released. -[SigninPromoViewMediator signinPromoViewRemoved] has to be called before dealloc. stack trace: -[SettingsCollectionViewController loadModel] ... -[SettingsCollectionViewController didFinishSignin:] ... -[SigninInteractionController cancel] -[SettingsCollectionViewController settingsWillBeDismissed] ... Bug introduced with crrev.com/2883093002 DCHECK introduced with crrev.com/c/567923 Bug: 747121 Change-Id: Ida6847e0942c5145ddc8fbd6c4681bfcc87a8904 Reviewed-on: https://chromium-review.googlesource.com/580408 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488624}
-
Daniel Vogelheim authored
This introduces a separate task queue for 'control' loading tasks. That is, very short task used to coordinate work between different loading tasks. These are scheduled separately as these tasks would typically unblock other, larger tasks. Bug: 557466 Change-Id: Id2de6b73f24e550fe00efa19f4c898866ed0a1cb Reviewed-on: https://chromium-review.googlesource.com/500147Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#488623}
-
Felix Ekblom authored
This CL will reland / revert revert 2 commits and add a non-Mash guard for listening to DeviceDataManager. A TODO has been added about using InputDeviceClient in Mash, but it's not super urgent as the reaction to the event is a NOP in Mash further down the call chain. Revert "Revert of Remove confusing keyboard test & focus on input device" commit 8a2f3aa1 Revert "Revert "Listen to changes to touch input devices"" commit 0cd134a5 Bug: 738885 Change-Id: Ic805ca3966df2969d8444b2c441eac24f75dce62 Reviewed-on: https://chromium-review.googlesource.com/575138 Commit-Queue: Felix Ekblom <felixe@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#488622}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4d02e904b015..89e6562f31f2 $ git log 4d02e904b..89e6562f3 --date=short --no-merges --format='%ad %ae %s' 2017-07-20 drgage Change CFX_Edit::GetSelText() to CFX_Edit::GetSelectedText(). Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I20eb6dc38f461a9a19a59164e8f3b0543c3e972b Reviewed-on: https://chromium-review.googlesource.com/580847 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488621}
-
Yoshifumi Inoue authored
This patch introduces no parameter variant of |FrameSelection::SelectAll()| to avoid default parameter for a preparation of moving declaration of enum class |SetSelectionBy| to another file[1]. [1] http://crrev.com/c/569662: ALL-IN-ONE Introduce SetSelectionData for FrameSelection::SetSelection() Change-Id: I5860c9f2cb72bb052727dc1dbd0546dc561bb3f1 Reviewed-on: https://chromium-review.googlesource.com/580175Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488620}
-
Irmak Kavasoğlu authored
Created the edit button and added it to the pending password bubble for mac platform. Clicking the button does not do anything. Screenshot is added to the bug as comment #19. Bug: 734965 Change-Id: Iaf424fc8a9964543995a6ef321b9a33af596a594 Reviewed-on: https://chromium-review.googlesource.com/570440 Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488619}
-
wutao authored
Using foreground blur make it possible to cache the render surface and provide good performance. Bug: 738185 Test: tested locally. Change-Id: I838c072ecd4deeb9e181e08644d215877616f0ef Reviewed-on: https://chromium-review.googlesource.com/578713 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#488618}
-
Marti Wong authored
In bookmark_home_handset_view_controller and bookmark_home_tablet_ntp_controller, prevent primaryView's content position from mistakenly reset to zero at viewWillLayoutSubviews(). Bug: 608777 Change-Id: Ifa6a4c075866509171180614cd0d5916a30a9466 Reviewed-on: https://chromium-review.googlesource.com/578693 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#488617}
-
Changwan Ryu authored
The previous fixing attempt for multiline insertion (http://crrev.com/2680733002) only worked for two-line text, and this CL allows for incremental insertion of three or more lines of text. Since selection is shifted after insertion, we need to update the selection start offset that will be used in adjusting selection for incremental insertion. BUG=712380 Change-Id: Ibb3212bd78fc7e30232aaa6b780c0c1182b63d1c Reviewed-on: https://chromium-review.googlesource.com/580496 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488616}
-
Ryo Hashimoto authored
Currently, ObjectProxy::CallMethod is implemented by creating ErrorCallback from ResponseCallback. This does not work with OnceCallback because it's not allowed to create two callbacks from one OnceCallback. To solve this, this change introduces CallMethodCallbackInternal to ObjectProxy which takes either Response* or ErrorResponse*, and dispatches the response to the appropriate callback. Also, Gmock does not allow directly mocking functions which take move-only arguments. https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#mocking-methods-that-use-move-only-types To workaround this, add DoCallMethod to MockObjetProxy. BUG=740015 TEST=build Change-Id: I1a98b5fd1d6d70f69674102a3d66bcec0c13214c Reviewed-on: https://chromium-review.googlesource.com/578541 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#488615}
-
tzik authored
This CL makes base::{Thread,Sequence}CheckerDoNothing noncopyable, so that they are consistent to base::{Thread,Sequence}CheckerImpl, and an accidental copy of SequenceChecker causes a compile error even on DCHCEK-disabled build. Change-Id: I3ac37d87302712ab3decf693d056376c0c2abb91 Reviewed-on: https://chromium-review.googlesource.com/578751 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488614}
-
Bugs Nash authored
Rewritten from https://codereview.chromium.org/2897833004, this version does not use the memory optimisation which has since been removed from the code. This patch - Split property specific parsing logic for background components into the case statements in CSSPropertyParser::ParseSingleValue, using the general ConsumeCommaSeparatedList template instead of ConsumeCommaSeparatedBackgroundComponent so that CSSPropertyID no longer needs to be passed. - Delted ConsumeCommaSeparatedBackgroundComponent (now unused). NB - ConsumeBackgroundComponent is still currently used in ConsumeBackgroundShorthand and so cannot be deleted. - Some bool literals are passed in this patch, violating the style guide. These arguments were not introduced in this patch and so will not be fixed in this patch. They will be converted to enums when the APIs are implemented. Bug: 668012 Change-Id: Ie364b810e10f0df3b3053e337d47fd60118cc985 Reviewed-on: https://chromium-review.googlesource.com/575253Reviewed-by:
Renée Wright <rjwright@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#488613}
-
Jeremy Roman authored
The argument is always equal to the |this| pointer. We can just use the latter. Change-Id: Ia14c0858b18c61bc500e3f276e36dc270a8e8232 Reviewed-on: https://chromium-review.googlesource.com/579961Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488612}
-
Yuki Shiino authored
MutationCallback holds a ScriptState and accesses it assynchronously. So, MutationCallback should check the context if it's alive before the uses. Bug: 738299 Change-Id: Ib16b37b2e90e5ba87117d7c6e1218f9df6d69a41 Reviewed-on: https://chromium-review.googlesource.com/574509 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#488611}
-
Kent Tamura authored
Rebaseline calendar-picker-appearance-zoom125.html and calendar-picker-appearance-zoom200.html for Mac10.9. TBR=qyearsley@chromium.org NOTRY=true Bug: 743068 Change-Id: I6b7e9bae599f22c80bdb420d76d2f238408e37af Reviewed-on: https://chromium-review.googlesource.com/579902Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488610}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d60609d3a12f..4d02e904b015 $ git log d60609d3a..4d02e904b --date=short --no-merges --format='%ad %ae %s' 2017-07-20 drgage Change "Sel" abbreviation to "Selection". Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Icc508c39f951b785e5475611f484e38cd8539efd Reviewed-on: https://chromium-review.googlesource.com/580316 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488609}
-
Koji Ishii authored
Following bot results are included. 769 775 781 782 785 788 789 790 791 792 795 796 798 799 155 lines were removed by consecutive passes since 753. TBR=eae@chromium.org NOTRY=true BUG: 591099 Change-Id: Ib343eeaf4540ed94747f68724adedcecc175dac4 Reviewed-on: https://chromium-review.googlesource.com/580732 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488608}
-
Mike Dougherty authored
The manual layout of the toolbar items for ios_web_view_shell is outdated and no longer works with iOS 11. Update the UIButtons to UIBarButtonItems and automatically lay them out with setItems: instead of adding items as subviews to the UIToolbar. Bug: None Change-Id: I800ade863253ac244cb8705a4afec0b09a0a2198 Reviewed-on: https://chromium-review.googlesource.com/578239Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488607}
-
yhanada authored
Test: It builds. No behavioral change. Change-Id: I786bc492ff79fd3220bd1974d72f0e9703a1ccc2 Reviewed-on: https://chromium-review.googlesource.com/580453Reviewed-by:
Keigo Oka <oka@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#488606}
-
Adam Rice authored
Maximum stack space exceeded exceptions within the WritableStream and ReadableStream implementations can lead to slots being undefined that are expected to contain Promises. This in turn leads to CHECK failures. Protect all calls to V8 Promise intrinsics with checks that the expected Promise is present, and throw an exception if it isn't. Also add a test to verify that a CHECK failure does not occur. Bug: 743082 Change-Id: Iaf89aa2a694600d129021e7e902c6bc02401c8b4 Reviewed-on: https://chromium-review.googlesource.com/579628 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488605}
-
Patricia Lor authored
Since a driving factor behind releasing the "Site Details" page as part of MD Settings is to replace default permissions in the Page Info bubble, the list of permissions shown in "Site Details" should include all permissions shown in the Page Info bubble. Add MIDI-SysEx to match it. and check one of the permissions listed there is "MIDI devices". Bug: 656758 Test: With #enable-site-details turned on, navigate to Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic111c09c17aef557990ae4f522151b294ab84842 chrome: //settings/content/siteDetails?site=https%3A%2F%2Fpermission.site Reviewed-on: https://chromium-review.googlesource.com/578758 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#488604}
-
Naina Raisinghani authored
This patch reduces the tree size for slower performance tests ensuring they don't time out. Bug: 747001 Change-Id: I3e87f1b68b3effcd04c8da2e673bd3e05f2374ed Reviewed-on: https://chromium-review.googlesource.com/580011Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#488603}
-
Yoshifumi Inoue authored
This patch introduces enum class |SelectionModifyDirection| as replacement of |SelectionDirection| since it is used as a parameter of |SelectinModifier::Modify()| for improving code readability. Change-Id: Ib249d01106503138811214895c7e8018e48758c5 Reviewed-on: https://chromium-review.googlesource.com/579248 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488602}
-
Jia authored
This reverts commit 51c2bff2. Reason for revert: causing a crash on clusterfuzz (crbug.com/746769) Original change's description: > Implement API for shorthand properties animation and transition. > > This cl is a resubmission of an earlier cl (crrev.com/c/549675), which > was reverted to fix a crash on one specific version of Google Pixel. > The difference between this cl and the previous cl is in the > implementation of CSSPropertyAnimationUtils::ConsumeAnimationShorthand: > - The old version is a templated function that uses function callback > and variable number of args. > - The new version uses a function pointer, which is simpler than a > callback. > > The original crash was not reproducible using the old patch. > But it is probably better to use function pointers instead of > a callback function with variable number of bugs. > > Have run this new patch on a pixel phone and there was not crash. > > Bug: 668012 > Change-Id: I183df5f3a168fffbed253a8b47b177fa72cd06b4 > Reviewed-on: https://chromium-review.googlesource.com/569505 > Commit-Queue: Jia Meng <jiameng@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487372} TBR=alancutter@chromium.org,jiameng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746769 Change-Id: Ie93a301b97d599e593fcc4dac8c3a30ca972fcf3 Reviewed-on: https://chromium-review.googlesource.com/580588Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#488601}
-
Siddhartha authored
The test was broken because enabling tracing no longer enables MemoryDumpManager. Directly use memory tracing api for checking the dump values instead of trace file analyzer. BUG=746124 Change-Id: I950a1e43a63b6424afd67f0c6d30e0c50722fe24 Reviewed-on: https://chromium-review.googlesource.com/580338 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488600}
-
yoshiki iguchi authored
Previously, the buttons are on the dedicate widget to show them above the ARC notification (NativeViewHost). This CL moves them to a view. In addition, this CL adds a hacks for ARC notification which manipulates the hierarycy of layers to show the buttons at top most. Bug: b/62771497 Bug: 717455 Bug: 747217 Change-Id: I876c653e01d4a4237055bd4f763aa55017ba38ef Reviewed-on: https://chromium-review.googlesource.com/579107 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#488599}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e11a4d0d822c..f9e1294920ec $ git log e11a4d0d8..f9e129492 --date=short --no-merges --format='%ad %ae %s' 2017-07-20 benjhayden Add support for story tags to results.html. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I56c720fc77b14091d33eaab04baa4631de385558 Reviewed-on: https://chromium-review.googlesource.com/580310 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488598}
-
Keishi Hattori authored
Adds Blink's instance count data to memory infra Bug: None Change-Id: I6c814846017e0e7906f014c93b4ffbf7adaccb88 Reviewed-on: https://chromium-review.googlesource.com/577471 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488597}
-
Kinuko Yasuda authored
No BUILD.gn for now as it doesn't have actual files yet, but I plan to add that in the next patch. Bug: 740070 Change-Id: I6e45e864f84a27561718a144fe51bd902482ae59 Reviewed-on: https://chromium-review.googlesource.com/566794 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488596}
-
Nicholas Verne authored
I will be on-hook for populating this directory in the short term. Bug: 738768 Change-Id: I01a1ef5456f3dacb4eec645df8d12cf762d7fc52 Reviewed-on: https://chromium-review.googlesource.com/580013Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488595}
-
Bugs Nash authored
This patch - Implemented the parsing logic for the single property APIs for the following properties - offset-distance - offset-rotate - -webkit-box-flex - -webkit-border-image - Removed the legacy parsing logic for these properties from CSSPropertyParser.cpp - updated CSSProperties.json5 so that the generated header files for the property APIs are updated diff for generated files: https://gist.github.com/BugsNash/8844b947b4e7e165b7475684b04da92c/revisions Bug: 668012 Change-Id: I144a82c9ba6727af9387a59a6d57427fd223327b Reviewed-on: https://chromium-review.googlesource.com/578757Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#488594}
-
Hidehiko Abe authored
Now the lifetime problem was fixed. So, the check is no longer needed. BUG=672829 TEST=Ran trybots. Change-Id: I918d2c3bdec6cbc9a0758e18a8ffee856211e19b Reviewed-on: https://chromium-review.googlesource.com/578917 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#488593}
-