- 09 Oct, 2020 40 commits
-
-
Hajime Hoshi authored
This reverts commit 8e4ad533. Reason for revert: crbug.com/1136758 test failures on macOS Original change's description: > Add fieldtrial testing config for ButterForPasswords > > Bug: 991510 > Change-Id: I447e99f11c322478f007557ab268823ed2616042 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455446 > Commit-Queue: Jesse Doherty <jwd@chromium.org> > Auto-Submit: Marc Treib <treib@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815355} TBR=jwd@chromium.org,treib@chromium.org Change-Id: I41a6d02cb9dce80e5bc41e087c53f8b6b5be0335 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462884Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815507}
-
Hajime Hoshi authored
This reverts commit 96c04c00. Reason for revert: crbug.com/1136750 Original change's description: > Enable fetch send ArrayBuffer more than 128 MB > > This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> > so that fetch can send big ArrayBuffer. > > Bug: 919361 > Change-Id: I45c3c560ca787858453c677cc0c7fbc8c1983063 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415810 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815479} TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,yoichio@chromium.org Change-Id: Ie4339d0cf4b709efb961abe569cbe1fa7cb116e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462908Reviewed-by:
-
Antonio Sartori authored
The PolicyContainer will serve as a container for security policies (such as Content-Security-Policy, Referrer Policy, COOP, COEP) that are applied to a document and have similar lifecycles. This is the first of a series of CLs implementing the PolicyContainer. We define a PolicyContainer class in content and attach a PolicyContainer to each RenderFrameHostImpl. Change-Id: Ief6d3b342c3f458aa21b53bee265732e65f3bd1e Bug: 1130587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418316 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815505}
-
Ramin Halavati authored
On Lacros, when a browser is deleted and a new one is created, the pointer to the new browser can be the same as the old one and this could result in flaky failures. Pointer inequality check is restricted to non-lacros and and a check is added for the old and new browser profile paths. Bug: 1130131 Change-Id: Ibf7004b126587f2341623d69c7c25775fb460018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442530 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815504}
-
chrome://media-appDavid authored
Previously we were writing to loadTimeData in ChromeMediaAppUIDelegate::PopulateLoadTimeData but it was not made available via window.loadTimeData. This change adds load_time_data.js to our untrusted context so we can make use of it. Note: "/strings.js" is required to ensure LoadTimeData is non empty. Now loadTimeData looks like ``` { "data_":{ "appLocale":"en-GB", "fontfamily":"Roboto, sans-serif", "fontsize":"75%", "language":"en", "textdirection":"ltr" } } ``` Side note: also fixes html lint (don't close single tags) & sorts DEPS Bug: b/170160681, b/170423915 Change-Id: I4d73037577534ef516641e2acf86c45126d444f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437582 Commit-Queue: David Lei <dlei@google.com> Auto-Submit: David Lei <dlei@google.com> Reviewed-by:Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#815503}
-
Daniel Ng authored
Followup to CL:2454914. Launches the Borealis VM if it has already been installed. Tests: Ran on DUT. Bug: b:166180697 Change-Id: I7512ce16cfc9f2e17320dce7b69732e35dc7fd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463082 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815502}
-
Marko Ivanovich authored
In CanceledBeforeUnloadShouldNotClearRemoteFrameView test, it is possible that after executing line: document.querySelector('iframe').src = 'about:blank'; in main page's renderer process, that this process is stopped by OS scheduler. In such case, by the time we finish executing JavaScript and return to browser process, dialog might already be requested from OOPIF's process. In BackForwardCacheBrowserTest.CanUseCacheWhenPageAlertsInTimeoutLoop there is already existing class that can prevent such race conditions. Here that class is made generaly available and replaced function WaitForAppModalDialog(), to decrease chances of such problems appearing again. AX-Relnotes: n/a. Change-Id: Icf96383da1e021f2c159fccb33f37d63c23c1839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437393 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815501}
-
Wei Lee authored
This reverts commit 77826976. Reason for revert: The failure is not related to the CL. Original change's description: > Revert "[CCA WebUI] Add deploy_swa function in cca.py" > > This reverts commit 2a4aa8b6. > > Reason for revert: Speculative, suspected in breaking cros_browser_sanity_test, see https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10590 > > Original change's description: > > [CCA WebUI] Add deploy_swa function in cca.py > > > > It can help to boost the development when simply changing JS/CSS/HTML > > on CCA (SWA). > > > > Bug: 1127459 > > Test: cca deploy-swa [BOARD] [DEVICE] > > Change-Id: I3f494a8d455b4c5632f91942f95b428b03294af9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456706 > > Reviewed-by: Shik Chen <shik@chromium.org> > > Reviewed-by: Inker Kuo <inker@chromium.org> > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815087} > > TBR=shik@chromium.org,inker@chromium.org,wtlee@chromium.org > > Change-Id: I0ec15027ea4000d30ca7f7851dd8a6c806c37e0a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1127459 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461270 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815108} TBR=shik@chromium.org,olka@chromium.org,inker@chromium.org,wtlee@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1127459 Change-Id: I2745f6e90318f0051e4f03c3800a47d93c648295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463044Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#815500}
-
Hiroshige Hayashizaki authored
Bug: 824647, 1020812 Change-Id: I76a39e2bf114eb080153952a7f9abc80a1696cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454555Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#815499}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2455947 Change-Id: I31507f9c386803dc1a379177cc62472fe674ba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463043 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#815498}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/19899becb76e..793a07e36636 2020-10-08 senorblanco@chromium.org Fix MSVC build of SerialStorage.h. 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 6d6aed546061 to 4311dd05c883 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f600d3aa9f26 to 6d6aed546061 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I3b75ebbd6ee35b10817a01dce21a357647207b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462009Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815497}
-
Andrew Xu authored
Use the interface provided by MenuController to update the selection instead of sending the synthetic key event. Bug: 1134422 Change-Id: I30d2f05a609e6406aaaf6d4f983ac3d18fd8c498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459127 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#815496}
-
Peter Kotwicz authored
This is in preparation for a new tester which tests Monochrome.apk BUG=1115604 Change-Id: I8e817c1d4ae88c5b410aca502172f881c0864975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460714 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#815495}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I271ae6c81a3c16f65ca2e6c0027e5ce832cb5368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463062Reviewed-by:
-
Hajime Hoshi authored
Disable virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html on Linux Bug: 1136726 Change-Id: I5a1abcf0de40eb7a1fe4826d7c2676d701ff1c46 Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463023Reviewed-by:
-
Hayato Ito authored
This is a follow-up CL of https://crrev.com/c/2460366, adding more tests to cover edge cases. Bug: 1082020 Change-Id: Ia41288dfdc2d693d5be17d9b28af0657926baaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461446Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#815492}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8bce4b0b83a5..528ecb920d34 2020-10-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f6c2eab2e64d6d91b0738b6afbd0da9e0c8577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462282Reviewed-by:
-
Sven Zheng authored
Change-Id: If8b4d748977dfbed10a2c78f545936e0b4eba35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439017 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#815490}
-
Rachel Carpenter authored
All entry points were deleted several milestones ago, and the component extension has been uninstalled for anyone who has updated to either of the milestones in the interim. Actual code for the app lives elsewhere, will also be deleted. Bug: b/159863346 Change-Id: I2792ea8d9482b9199b4dc6a394a8f659d176108b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454960 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chrome://flagsAlexey Baskakov authored
Project BMO has been shipped. This flag expired in M88, as predicted. This CL is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2076753 except enums.xml which is still needed. Bug: 1065748 Change-Id: Ia00e95716ee0e1c19b2225f438cdbfb0c2b01c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463042Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#815488}
-
chrome://flags#web-bundlesKunihiko Sakamoto authored
And updates the owners list. Bug: 1073310 Change-Id: I948d0d8e4aed6c825f3e0846b532fe880f8cedae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462757Reviewed-by:
-
Maggie Cai authored
This CL adds the metrics to record the preferred apps entry count that was recorded in the disk. This value should be able to represent the largest entry number before the user session stopped. This CL also fixed a mistake I made for existing preferred apps metrics. When I created "Apps.PreferredApps.UpdateAction" and "Apps.PreferredApps.FileIOAction" metrics, I updated the scope in the histograms.xml file, but forgot to update the scope in the UMA recording function, causing a mismatch of the metrics name. BUG=1134082, 853604 Change-Id: Ic00c7c78cdaba7268182122ead1877433c1fae61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442398Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#815486}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602125584-6713bc5f5f4e479763b7dc4b9c334026b7e04f91.profdata to chrome-win32-master-1602179909-b26649051a7d8d0314e04dcc1e82c76ad349e786.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ide87bada7b5d61904cbf90cdea908bbf9758bab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462365Reviewed-by:
-
Jazz Xu authored
This CL adds pin/unpin metrics when user clicks pin/unpin button. Bug: 1136254 Change-Id: I9bbbac6444cbbf2d74d74abbd8ec7d8b7ec31a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462195 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#815484}
-
Chan Li authored
This is a reland of 6bcf1a99 Original change's description: > Re-enable `chromium.resultdb.result_sink` experiment on chromium fyi builders at 30% > > Bug: 1108016 > Change-Id: I90beaf78f9f4b8508f6229b17b07a44943f442d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462049 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Chan Li <chanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815450} Bug: 1108016 Change-Id: I257a1f13a7cefe4c95e0a93d9ba87b57b19c716f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463102 Auto-Submit: Chan Li <chanli@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815483}
-
Maggie Cai authored
This CL updates browser test to test for all desktop platforms, user can use intent picker to launch PWA. BUG=939205, 990256 Change-Id: Ibba41fc6c2fd22da42f57e56a73869b36d7e9754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440081 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Kent Tamura authored
ValueWithHardLineBreaks() assumes InnerEditor elements don't contain <br>s other than the last child. DCHECK()s check the assumption, and don't need to emit LFs for non-last <br>s. This CL should not change any behavior. Change-Id: Ifed37f35e01fb34c95c31d966066c25a86cdce81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462742 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815481}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a9b91b5..5cbb8488 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ica0ee82346ca94450c1d0393566d3c4a8accf516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815480}
-
Yoichi Osato authored
This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> so that fetch can send big ArrayBuffer. Bug: 919361 Change-Id: I45c3c560ca787858453c677cc0c7fbc8c1983063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415810Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#815479}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f811799235c1..cd8eb564689a 2020-10-08 geofflang@google.com GL: Work around Mac glBindBufferRange issue. 2020-10-08 timvp@google.com Target the "absl" component for component builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1134776 Tbr: timvp@google.com Change-Id: I1b6379572fc53f8f90960ca6b9b424f7adc9f024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461689Reviewed-by:
-
Koji Ishii authored
In LayoutNG, when `box-decoration-break: clone` is set, |NGInlineBoxState| clones the inline box fragments for every line, but it had no effects in line breaking and measuring. This patch implements the logic in |NGLineBreaker| so that the property is taken account for line breaking, line width (and therefore `text-align`), min-max sizing, etc. |NGInlineNode::ComputeMinMaxSizes| started to hit DCHECK with the |NGLineBreaker| change, because it computes `max-content` from `min-content`. When this property clones box decorations to every line, the logic does not work. This patch disables the fast codepath, instead run a separate layout path when this property is effective. This fixed an old crbug.com/612641. This property is used ~0.7%. The regression crbug.com/1006599 got 10 stars. Bug: 1006599, 612641 Change-Id: I6425fb5e7f8dc951d882eb90d1c081abd127468e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454349Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815477}
-
Glen Robertson authored
Change-Id: I147b5bc188428802a6be8ed82347633ae57a8dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462882 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#815476}
-
Hidehiko Abe authored
It turned out current physical key tracking does not work if IME is enabled. It is not only for ARC, but also Lacros (as we start using IME soon), and crostini in the future when IME is fully enabled. Currently, we have workaround for ARC, so Lacros follows the approach for short term. We need a long term fix in the future, though. if there is no composing text. Bug: 1133651 Test: Typed cursor key on Lacros window. It works as expected Change-Id: Ib709ea852ddbec75d4790cf3aabdf353cade089d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452273 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:Jun Mukai <mukai@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#815475}
-
Karandeep Bhatia authored
Remove the IsolatedWorldCSP blink runtime feature and have the isolated world CSP always enforced. The current behavior when the IsolatedWorldCSP feature is disabled, is to just bypass the main world CSP for clients which set the isolated world CSP. For the most part, there shouldn't be any behavior change. Currently there are 3 blink clients which set an isolated world CSP: - Mv2 extensions specify an empty CSP, so there shouldn't be any behavior change for them. The empty CSP should behave the same as the main world CSP being bypassed. - The translate component does set a non-empty CSP. To preserve the same behavior we change it's CSP to an empty one. - Mv3 extensions specify a non-empty CSP and this CSP will now be enforced in isolated worlds, which is what we want. BUG=896041 Change-Id: I9c5bf6cff5dda6f5ee9090a873c9fcbc42eab317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439540 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#815474}
-
Chan Li authored
This reverts commit 6bcf1a99. Reason for revert: experiment not ready Original change's description: > Re-enable `chromium.resultdb.result_sink` experiment on chromium fyi builders at 30% > > Bug: 1108016 > Change-Id: I90beaf78f9f4b8508f6229b17b07a44943f442d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462049 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Chan Li <chanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815450} TBR=chanli@chromium.org,tikuta@chromium.org Change-Id: I5efd5125c5391970ea34316cc27a000570e7b9df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462052Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815473}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I69ddb1e4466164740d3f8649f52f8bc56282839d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461692Reviewed-by:
-
Ken Rockot authored
This CL introduces generated mojom.m.js modules for mojom JS bindings, allowing most JS bindings consumers to import bindings with the convenience and efficiency afforded by JS modules. These modules can be used as-is by Component Extensions, Web Platform Tests, and Blink Web Tests. A follow-up change will introduce a slight variation on these modules to support consumption by WebUI pages. Bug: 1004256 Change-Id: Ic2b4a6bcadf68023d2078bf065befafce3ccb19b Tbr: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451589 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#815471}
-
Josh Simmons authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5df72efed1de..fe6fea125882 $ git log 5df72efed..fe6fea125 --date=short --no-merges --format='%ad %ae %s' 2020-09-28 simmonsjosh seneschal: Add support for mounting smbfs paths into Crostini 2020-09-16 hollingum vm_tools: Make cicerone track VM type 2020-09-16 jiejiang remove copybara initialization artifacts 2020-09-16 jiejiang Copybara Service Migration Initialization. 2020-09-16 jiejiang patchpanel: Add NeighborStateChanged signal 2020-09-18 keiichiw vm_tools: concierge: Allow to specify kernel/rootfs paths for Termina 2020-09-17 ivadasz vm_tools: Add initrd field to the concierge protocol. 2020-09-18 allenwebb system_api: Refactor to support dev-rust/dbus-0.8* Created with: roll-dep src/third_party/cros_system_api Bug: 962924 Test: Manual - Build chrome Test: unit_tests --gtest_filter="*FileManagerPathUtilTest*" Change-Id: I5a0ecf24ae8e73f585ccd99c9311bff38f4cdb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462749 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815470}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/660580a68ad0..8bce4b0b83a5 2020-10-09 vidorteg@microsoft.com Enable ModuleUIStrings as a fallback in i18n If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6bd6ba7db296deef900b3131a5144eb0ee825c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461690Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602104345-4733e14208bb636a7ce6e80f22bf814b0d8103be.profdata to chrome-win64-master-1602179909-18dbc89acedf4f15864b841a6fe7487536bbc059.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7be127850ce3f5f00e6005d57b87bd53cc5d7c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462355Reviewed-by:
-
