- 18 Sep, 2020 40 commits
-
-
Yutaka Hirano authored
On network::QuicTransport it is difficult to satisfy the requirement of ArmingPolicy::AUTOMATIC written in SimpleWatcher: // NOTE: It is important when using AUTOMATIC policy that your // ReadyCallback always attempt to change the state of the handle (e.g. // read available messages on a message pipe.) Otherwise this will // result in a potentially large number of avoidable redundant tasks. Use ArmingPolicy::MANUAL instead. Bug: 1129597 Change-Id: Ic7170458687b3086eb212cce987e6ce676ee4ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416154 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#808262}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/795fa782ca1a..ec598d5b00eb 2020-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0a8a3ea25b36 to 8d4331eeb5ea (13 revisions) 2020-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 70a60d85 to 33c87dad (467 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: angle_deqp_egl_tests --gtest_filter=dEQP.EGL/functional_query_context_get_current_display_rgba8888_window* --use-angle=vulkanTest: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest*/*Test: Test: angle_perftests --gtest_filter=GenerateMipmapBenchmark.Run/vulkan_webglTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/*Test: Test: dEQP-GLES3.functional.fbo.blit.default_framebuffer.*_linear_* Change-Id: I8e7ba3d468efc128ed63b639b3015e5cfc5bbcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808261}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ac3765e663cd..d6498a41ab4e 2020-09-18 hao.x.li@intel.com Query API: Timestamp Query on Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If9a7928acf17257ea83f6c668b796ed4d69e2f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417958Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd0862c6..e6a7fb53 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1283d81408c7c7698c8e516be7e84eb64cbe2ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417854Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808259}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02cb3385f611..3a2a14855653 2020-09-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c768fd8eab63b2dc04ff0cca95c7e6ea30e4075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417957Reviewed-by:
-
Omid Tourzan authored
It will be used to add/change 3 parts of the Files.app UI by SinglePartitionFormat flag: - Directory tree/Gear context menu for Format and Partition device - Format/Partition dialog warning text - Format/Partition dialog confirm button Along with new feature strings, it changes existing format dialog strings (warning text and confirm button). They will be used with the same flag. Bug: 491043 Change-Id: I35ad96e64605e50c4367338898d7e63e1e76ada0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379338Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808257}
-
Clovis PJ authored
Bug: 1113721 Change-Id: I79132bdf3ea1f276994932e8e6a882c60d8ea946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364618Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clovis PJ <clovispj@google.com> Cr-Commit-Position: refs/heads/master@{#808256}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4183.84-1598870250-benchmark-87.0.4247.0-r1 to 87-4247.0-1600077656-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8ba69e6b509437b6dfdb8c6ff9670989295e8cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417965Reviewed-by:
-
Muyao Xu authored
Bug: b/155648481, 1128722 Change-Id: I63c1c64e6ac6e1e5dd74dc33853805c8d57d3893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412973 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#808254}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I4b1c212368b3b5844d0c49b403a2594dc04b5250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418011Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#808253}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4183.84-1598867895-benchmark-87.0.4247.0-r1 to 87-4247.0-1600080536-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I715ce3210cc2097554fc0d291579495bc2398858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417964Reviewed-by:
-
Nektarios Paisios authored
Changes AXPosition::MaxTextOffset so that it fails gracefully when given a non-supported object type The NGOffsetMapping class in Layout NG does not support calculating text offsets in elements of type other than atomic inline level, out-of-flow and text. This patch enforces an even stricter version of this condition in AXPosition::MaxTextOffset, namely that the layout object should be only of type text. This avoids a bad type cast which was causing a security bug in Blink. A followup patch will thoroughly test the remaining object types, namely atomic inline level and out-of-flow, before possibly adding them back. As a second improvement to the resiliency of the code base, this patch updates AXPosition::IsValid. Previously, AXPosition::IsValid() would DCHECK if called at the wrong document lifecycle stage, i.e. when the document is not active. Also, it would DCHECK when the document attached to the AXPosition has a dirty layout tree. The reason for this behavior is that in both of the above cases the user of the AXPosition is clearly doing something wrong, because AXPosition objects should not be created and used at the wrong document lifecycle or when the document layout is not clean. This patch makes IsValid to also return false in the above cases. AX-Relnotes: n/a. TBR=dmazzoni@chromium.org Bug: 1124661 Change-Id: Ic1ab3654ce9c37051bd001802bb81d569792e678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414251Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#808251}
-
Rob Buis authored
This CL makes unknown elements in the MathML namespace have display: math (instead of display: inline). This makes the HTML sanitizer (relying on the layout object's display in several places) behave differently i.e. it does not filter out these elements and their attributes anymore. However, this is ok because these elements are not treated as HTML/SVG. The clipboard test is changed to check that nothing is style/executed. Bug: 6606 Change-Id: I15b1df448c2bdee46c4a36c48a4cfb27d7828ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397949 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#808250}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32de9efebce4..68c424fe4240 2020-09-18 syoussefi@chromium.org Vulkan: Workaround oldSwapchin bug on Android 2020-09-18 jmadill@chromium.org Guard against data race with MemoryProgramCache. 2020-09-18 syoussefi@chromium.org Vulkan: Add perf warning for mid-RP clear 2020-09-18 syoussefi@chromium.org Vulkan: Free up 5 bits in RenderPassDesc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I4d1f510964888b1b4f9e9990326c19e91649a069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417954Reviewed-by:
-
My Nguyen authored
Strings updated according to: http://go/cros-lang-settings-ux-writing Figma: http://go/cros-lang-settings-figma Spell check view: http://screen/6MFsoL4rUAf8Zg7 Customise spell check view: http://screen/AzuM66T9pEtnBWH Bug: 1113439 Change-Id: I617403ef016c0d3dc7e2b10564522d0c6304f263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417428 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808248}
-
Yoshifumi Inoue authored
This patch changes |NGConstraintSpace::ToString()| to use |BfcOffset()| to avoid using invalid union field |bfc_offset_|. Change-Id: Ic79ae585622135c6d1b28dc75597fe0a404d1143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417784 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Maggie Cai authored
activity. Currently when sign in with GlobalProtect on the web, the code try to launch with the activity that stored in the app info. However this causes a bug when try to sign in with GlobalProtect, most likely because the intent filter is not registered under the default activity. Remove the default activity assignment to fix this issue. BUG=1126183 Bug: b/164976626 Change-Id: Ie0a75801d0739a0a2638573bff0a36045c25bd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416433 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#808246}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4183.74-1598869788-benchmark-87.0.4247.0-r1 to 87-4247.0-1600076215-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1b93e5cc731c5772a39a17dcb4710f8b4027121f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417963Reviewed-by:
-
Christopher Cameron authored
The capture process knows nothing about whether or not hardware acceleration is enabled, and cannot therefore be told not to send GpuMemoryBuffers when there is no GpuMemoryBuffer support. Add a path whereby a media::VideoFrame can be created to wrap an IOSurface-backed gfx::GpuMemoryBufferHandle. This will be used when the capture process gives Blink a GpuMemoryBuffer handle, but there no longer exists hardware acceleration support (because of being disabled statically or dynamically). Bug: 1125879 Change-Id: Id87ca3d832e68a3501ed12540d3d265f23cd0362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415575 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#808244}
-
Eric Willigers authored
Tests in https://chromium-review.googlesource.com/c/chromium/src/+/2405034 failed CSS-COLLIDING-TEST-NAME, which would block export. TBR=andruud@chromium.org Bug: 2405034 Change-Id: I515449b1c52d7c1ee974472e77c2265569a9ddb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417785Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#808243}
-
Alan Cutter authored
Previously if an offline_manifest was specified for a default web app the install flow would immediately use it. This CL adds an only_use_offline_manifest config parameter that says whether to attempt a network install first or not. This allows default web apps to prefer networked install to acquire an up to date manifest and only use the offline_manifest if the user runs into network issues. Bug: 1119710 Change-Id: I9ecee5e105e22388a070247762bf450745098acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413607Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808242}
-
Alex Rudenko authored
This CL removes InspectTool::Dispose method that was never implemented by any of the tools. Change-Id: I5c8c3dea03a0b98f6915f31120f66ab8760c3428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417891Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#808241}
-
Kent Tamura authored
This CL makes SliderPosition() in layout_slider_track.cc a method of blink::HTMLInputElement. This change will help to share the code between the legacy layout and LayoutNG. This CL has no behavior changes. Bug: 1040826 Change-Id: I65bb04e8808820a812a4fabb82a7bf24c5f66341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417780 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/882abc4519b6..b0c99c387b38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085603 Tbr: yutak@google.com Change-Id: I3797b7fbeaff8aefcb7696394dc941efe5596c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417769Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808239}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31634288fdf3..795fa782ca1a 2020-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 6419bddd9b0c to d6498a41ab4e (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I1064f2775c0188bb544e734d5ce612739ef3256e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417767Reviewed-by:
-
Alan Cutter authored
This CL turns the DesktopPWAsMigrationUserDisplayModeCleanUp flag on by default for M87. See https://chromium-review.googlesource.com/c/chromium/src/+/2391704 for details on the clean up. Bug: 1127128 Change-Id: I295a5ee95399fdc2e56e1d85c049b612e2fa112c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417469 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#808237}
-
Koji Ishii authored
In order to use it in other classes and for better consistency. This patch has no behavior changes. Change-Id: Ib5b2601a4773706acd900f9fca1d8a1a5f6866aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417737 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808236}
-
Preethi Mohan authored
Restore the order of the tests to be run if order is "none" Bug: 1071924 Change-Id: I282c71ea745a8fc4afc5b2b442eb286e9e215806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391311 Commit-Queue: Preethi Mohan <preethim@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#808235}
-
Hiroki Nakagawa authored
As a preparation for deprecating old webkit-prefiexed prerender events, this CL adds code to count usage of them. Specifically, this CL records the following events. - webkitprerenderstart - webkitprerenderstop - webkitprerenderload - webkitprerenderdomcontentloaded Bug: 839030 Change-Id: I821b9c993d2c8eb7d14e11d8b49d3042e43a0cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417736Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#808234}
-
Kalvin Lee authored
This change modifies method deferral in PpdProvider. The existing behavior is to * try getting a metadata locale immediately at time of construction and to * retry getting the metadata locale on failure in perpetuity (albeit with a backoff) until it succeeds. This change modifies the behavior to instead * wait until a locale-sensitive method of PpdProvider is called to get a metadata locale and * not to retry getting the metadata locale automatically, electing to wait for the next time a locale-sensitive method is called. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdProviderTest.*' Change-Id: I40fd135a8adecbc1dc3216ef370c4623fcb7195f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391772 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#808233}
-
Dominic Farolino authored
R=kinuko@chromium.org Bug: 988956 Change-Id: If1ba13e7c310bb4f99ee1938bd2aad3813614c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414774Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#808232}
-
Gavin Williams authored
Add function to monitor the destinations dialog's destinations printerStatusReason for changes then update to the appropriate PrinterState. Needed since printer statuses are allowed to change after the dialog is opened. Bug: 1123754 Change-Id: I869aaf91543f710398d8125e7b449bd5ca438813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406675Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#808231}
-
Jiewei Qian authored
We had been recording AlreadyInstalled in our install result histograms: install duration and install result code. If the app is already installed (and we don't request to reinstall it), the installation pipeline will immediately return this code, without further processing. Because we call PendingAppManager to install the app every time the user logs in, this result code skews the histogram. It created a false impression that success rate is high, and the install duration is short (on average). This CL makes two changes: - Only report install duration, if we ask to install all apps. So the duration measured is consistent. In other words, we exclude scenarios where apps are already installed, or only the missing apps are installed. - Exclude AlreadyInstalled in install result codes. So it's easier to calculate install success rate. Bug: 1085274,1129275 Change-Id: I7f226343cbf327832e388e069190a9b1a6ac1fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402859 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#808230}
-
Hirokazu Honda authored
The original code touches out of bounds of the source buffer. This CL fixes the issue. Bug: b:155054799 Test: video_decode_accelerator_tests on hatch Change-Id: I03067fe2231a55dd2edb2963525a03f1667d694a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409725Reviewed-by:
Miguel Casas <mcasas@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808229}
-
Yoshisato Yanagisawa authored
Bug: 1129409 Change-Id: I5f1c14ff6f3f15f3fe29d59296171edf67897fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416837 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#808228}
-
Ahmed Mehfooz authored
Bug: 1129698 Change-Id: I9a2fc1128ac069f40ce42e1ae4c597a8ee26c581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417493Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#808227}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8727abed..bd0862c6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9faf0151d4c223c2a3ee1ce79be61390fb30c6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417851Reviewed-by:
-
Kunihiko Sakamoto authored
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/tybtqf-tdB4/m/PSNj5vSEAwAJ Bug: 935267 Change-Id: Ie690e7e814c5157050af520a5f35b492a3d80b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415709Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/11880b30c360..02cb3385f611 2020-09-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I68f4957da1a290e5cf1e89cf5103337fa7c14484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417760Reviewed-by:
-
rbpotter authored
Note: This CL also demonstrates using a 3rd preprocess_grit target to preprocess and copy the downloads mojo file to the desired relative location in the preprocessed folder. This allows it to be included in the bundle generated by rollup. Bug: 1128583 Change-Id: I5a6e9825ba82110f1df4b5193dc21a8ef6178d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414564 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808223}
-
