GitLab

This will make the template logic reusable by other components in PM.

Bug: 1144025
Change-Id: I378d5626b5f1487dc792e6db14668fc6588448f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462376Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823628}

The downstream iOS bots import a gn file from $root_build_dir/args.gn
that contains nested scopes. Support to parse the file has been added
to //build/gn_helpers.py with https://crrev.com/c/2513217.

The next step on the bot is pretty printing the data parsed, which
fails as nested scopes are converted to nested dictionaries. This
CL adds support to pretty print those.

Bug: 1144711
Change-Id: I3130d493c6385f2016d91245e8a5f12e710495cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517679
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823627}

The cl in devtools-frontend: https://crrev.com/c/2514438

Bug: chromium:1143648
Change-Id: Ia56777df183bd9ba3cecbe41285b4c274595d7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513219Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823626}

This patch re-uses the existing SmsVerificationReceiver backend but
replaces its logic to use the new browser code API [1].


Summary of changes:
 - Use the new SmsCodeBrowserClient
 - Connect both timeout/cancel to caller
 - Properly handle cases where browser code may not be available
    1. Need user permission grant          -> ask for permission
    2. User has previously denied to grant -> cancel request
    3. API not available                   -> TODO in follow up
 - Add tests to check for permission logic and new bindings

This patch depends on a new GMS phone auth library which was added as a
dependency in [2].

[1] https://developers.google.com/android/reference/com/google/android/gms/auth/api/phone/SmsCodeBrowserClient
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2485192

Test: content_unittests --gtest_filter=SmsProviderGmsVerificationTest.*
Bug:1141022

Change-Id: I56c59c92e6e368c906ed7151558de72ad3892253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490248Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823625}

The switch no longer exists.

Bug: b:172071699
Change-Id: Ic6bcf63de7acb1847d40fa5d5caab932e2d90ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514761Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823624}

When multiples displays are removed at the same time, commit a disable
modeset of all them together instead of each separately.
This should prevent unplugged MST connectors from being in zombie mode.

BUG=b/172069469, b/169386252
TEST=unplug and replug 2 connectors on MST hub, ScreenManagerTest.CheckMultipleControllersAfterBeingRemoved

Change-Id: If24f9016462b9c69633148202641f7ba6bae9114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512550
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823623}

This fixes a bug on Windows in which switching to a new tab via a
keyboard shortcut did not focus the tab. Instead, the CaptionBubble was
focused by the FocusManager. This caused keyboard shortcuts, such as
Ctrl+W, to not work. This occurred even if the CaptionBubble was not
not visible.

Bug: 1055150, 1123635
Change-Id: I614715f75f1ff36fb336ae13ca3a53178413ca8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482005
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823622}

Reason: flaky on a few bots since around 2020-11-02.

Tbr: eirage@chromium.org
Bug: 1145181
Change-Id: I9d2cf14a4f1ca26127822f3974626e2142a5ae3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517720Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823621}

This title provides the only display of which origin is requesting the
permission in question, so it should be accessibility-focusable to
allow the user to focus it and navigate within it, select it, etc.

Bug: 1099327
Change-Id: I4f8038f2623a79d10ba18cdd809b202110bc55ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515182Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823620}

Currently, for each tree scope, we gather all @keyframes rules into a
hash map. This may cause memory issues when we have web components that
carry @keyframes rules in its style sheet.

This patch makes each tree scope iterate the already stored
ActiveStyleSheetVector instead, so that we can save some memory.

Bug: 1141814
Change-Id: I09a1fda77f10a22376ed83a0ac7bd1f6f9f3cca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493431Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823619}

changes

Get rid of unnecessary accessibility_tree_formatter.h includes:
no sense to make useless things but it also reduce build time
for accessibility_tree_formatter.h changes.

Bug: 1133330
AX-Relnotes: n/a

Change-Id: I1ed327ec35afb7c876d40dfdaa801f278cd3b18f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510374Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#823618}

This ensures that we perform the same validation and canonicalization,
no matter how the First-Party Set was provided.

Change-Id: Ifdd76cb2d29a2a28215051a2b5b2ad6f312f95aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510233Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@google.com>
Auto-Submit: Chris Fredrickson <cfredric@google.com>
Cr-Commit-Position: refs/heads/master@{#823617}

Updates the expires_after attribute for 18 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-02-01.

TBR=chromium-metrics-reviews@google.com

Change-Id: I42e0ae1d77f773120f1f5be2f486941e4074ff2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517883Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#823616}

Launch on ToT was requested based on
go/clank-sro-incognito-metrics

Bug: 894211
Change-Id: Ib333df7ab99104b8ed9325b3bcb433c27c753b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510355Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823615}

This CL also create a new flag about showing Thumbnail for image search
suggestions. Currently, only Android support showing thumbnail for image
Search suggestions.

When enabling clipboard image suggestions by default on Android in
https://crrev.com/c/2485343, we inadvertently made a change on iOS to
retain the image thumbnail even though it's not used on that platform.
This change restores the correct behavior on iOS because the new Feature
is disabled there.

Bug: 1056501
Change-Id: Idaa1f292e4ff98564035d6eabe64a7d9b8df6d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501073
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823614}

Bug: 1140420
Change-Id: Ia2b704e0e2146dfb7e71406126e101c06fbffd5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514800Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823613}

2 tests were disabled recently as they were flaky on builder
"Linux TSan Tests". That's because when the tests finish, there is
still a pending history query, and on the history backend thread there
is a check for the feature kHideFromApi3Transitions (also introduced
recently). If the check occurs after the ScopedFeatureList is
destroyed, then there is a data race and would fail the sanitizer.

This CL moves the |feature_list_| member to the test class before the
|history_service_| member, and initialize it in the test constructor.
This ensures it will only be destroyed only after |history_service_| is
destroyed.

This CL also removes the FlocIdComputedEventLogging feature
initialization in the test, as it's already enabled by default.

Bug: 1143855
Change-Id: I6b7141a0bf9000ac453768828be1d6a35218a079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512846Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823612}

This is a reland of 365f1d94

I am waiting for action sequence to finish and for the event to
execute before terminating the test.

Original change's description:
> WPT to check click/auxclick/contextmenu are pointerevents
>
> Verify that the user agent returns click/auxclick/contextmenu as pointerevents.
>
> Bug: 989958
> Change-Id: I02757ef704b605471614829177cba24a73b6c8db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513801
> Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823332}

Bug: 989958
Change-Id: Icf79feebe63a3f2b94b3837dedfa68a4574927a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515051Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823611}

Increase SurfaceControl transaction ack hang detection timeout from 1sec
to 5sec.

Bug: 1037760
Change-Id: I0402c3c641f814b6388d2b08798d96bacfa4926e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515227
Commit-Queue: vikas soni <vikassoni@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: vikas soni <vikassoni@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823610}

Bug: b/171776026
Change-Id: Iae2f60159b3ee6e1d912aa2a37aad238ffe8597b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517721
Auto-Submit: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Marian Fechete <marianfe@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Cr-Commit-Position: refs/heads/master@{#823609}

This CL adds stats for SAML password sync token API calls. We use the
standard UMA framework and record basic token operations as well as API
errors.

Bug: 1112896
Change-Id: I280c966a257db6600c9a7734b6c74c88a5d4630a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513207Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Maciek Slusarczyk <mslus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823608}

The UseCounter is counted when offsetX/offsetY/layerX/layerY
is requested, and the target element is rendered inline.

Bug: 1054515
Change-Id: Ie584a9070edce2748537edd06b8b8f2f27efe0c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517020Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823607}

Bug: 772945
Change-Id: Idc5e97a2f8161f6e673a75352c4a398b990a7a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515940
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823606}

This reverts commit 341aef47.

Reason for revert: Tree-closing compilation failure. For example, https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/96007?
../../remoting/host/win/etw_trace_consumer.cc(119,11): error: use of undeclared identifier 'thread_checker_'
  DCHECK(!thread_checker_.CalledOnValidThread());
          ^
../../remoting/host/win/etw_trace_consumer.cc(125,11): error: use of undeclared identifier 'thread_checker_'
  DCHECK(!thread_checker_.CalledOnValidThread());

Original change's description:
> [Windows][Host][Logging] Adding EtwTraceConsumer class
>
> This CL adds the class which consumes the ETW events from
> Windows.  The class is fairly straight-forward but there
> is one interesting bit as the call to consumer events
> blocks us from running tasks on that thread.  In order to
> receive events and not block any of the existing threads,
> we create a new AutoThread which we use to listen for and
> handle events on.  When it is time to clean up, we unblock
> the listening thread by stopping the trace session.
>
> Future CLs will add the logic needed to parse the events
> and redirect the output to a new location (likely based on
> registry settings).  I've kept that out of this CL to keep
> its size on the smaller side.
>
> Bug: 1144185
> Change-Id: Ibf494251d0929a1741cb2796f26d69d258d96a64
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515140
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823596}

TBR=jamiewalch@chromium.org,joedow@chromium.org

Change-Id: Id754b4ac043c4ae34196e6df3e2b621b60673591
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1144185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518104Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823605}

Extended the Enterprise.Policies.SourceConflicts and
Enterprise.Policies.IgnoredByPolicyGroup histograms.

Bug: 1084092, 1125834
Change-Id: I113b93ae2c452a63fb77d31e4dfe9b06fda40b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508261
Auto-Submit: Yann Dago <ydago@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823604}

This adds a bool for SameParty to CanonicalCookie and updates ctor
callers (mostly tests).

It enforces the requirement that a canonical CanonicalCookie with
SameParty must be Secure, and must not have SameSite=Strict. Cookies
that violate this are rejected with a newly added
CookieInclusionStatus::ExclusionReason.

SameParty attribute semantics are not yet enforced.

This adds same_party to the cookie attributes logged for cookie store
events in the NetLog.

Bug: 1142606
Change-Id: I06899aa5e24b5037e0609009aec498476a616bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506303Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823603}

When Chromium is started with dynamic more core lib
(--mojo-core-library-path=path_to_lib), the given library
is used for core mojo functionality instead of the mojo core
embedded in the Chromium.

This switch is propagated to child processes (such as gpu process)
in order for them to use the same mojo core library.
Due to sandboxes, the library is loaded early for child processes
and initialized in a separate step.

However, if single process mode is used (--single-process)
the ChildProcess class is instantiated in a thread of browser process.

This results in a library being loaded twice and an adequate DCHECK.

Don't attempt to load the mojo core library if ChildProcess instance
is run embedded in the browser process.

Change-Id: Ic22d612481b62ccc6b1d07fa245b56bde55e42d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517460Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Krzysztof Olczyk <kolczyk@vewd.com>
Cr-Commit-Position: refs/heads/master@{#823602}

This CL fixes an earlier error where we might be pushing nullptr
reference into a vector.

Bug: 1144967, 1127984
Change-Id: Id80dc38b7ba7611661c080fa404e2fa7c69a762a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517601Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Auto-Submit: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823601}

BackgroundTaskSchedulerExternalUma#toUmaEnumValueFromTaskId is used by
child classes but gives a lint warning. Fix the lint warning by
explaining to lint it was supposed to be protected not private.

Change-Id: I1f1cf080cf0750aaea1fdf94b1972b0f70e134b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514963
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823600}

Currently |LayoutNGBlockFlowMixin<Base>::AddOutlineRects|
falls back to legacy when NG block fragmented. This should be
implemented in NG.

This patch replces with |GetPhysicalFragment| without changing
the behavior for now.

Investigation:
https://docs.google.com/document/d/1Yx7iGeHA2bTZory9kpA2NJNd-nMplGlUIEJl7gglqVo/edit?usp=sharing

This patch has no behavior changes.

Bug: 1061423, 1145048
Change-Id: I22d0e6b3f000060c01e3314e835cb693f2fdd87d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514940Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823599}

This avoids re-parsing the ICC profile in the GPU process. The drawback
is that we go back to the behavior that we had (just a few weeks ago)
of ignoring the custom color profile for capture content.

Of note is that specifying AVCaptureColorSpace_sRGB to the capturer
results in the same gamma=1.961 color space (with the sRGB primaries).

Also of note is that the alternative constant of kCGColorSpaceITUR_709
is not used because it has a substantial difference from gamma=1.961
in darker colors.

Bug: 1143477, 959962
Change-Id: Id5d794ba05801cd6d54a79bd3a3f9cc292537eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515235
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#823598}

This to keep in sync with go/ssufd
Main reasons are:
   * v5.4 reading of this file is slow.
   * file forwat has been changed and it is not clear for now how to
     deal with it.

BUG=b/170215628
TEST=Locally on eve-kernelnext

Change-Id: I80e17014a5bdb67d13b3089e8cd09b5c4bc29612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516242
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823597}

This CL adds the class which consumes the ETW events from
Windows.  The class is fairly straight-forward but there
is one interesting bit as the call to consumer events
blocks us from running tasks on that thread.  In order to
receive events and not block any of the existing threads,
we create a new AutoThread which we use to listen for and
handle events on.  When it is time to clean up, we unblock
the listening thread by stopping the trace session.

Future CLs will add the logic needed to parse the events
and redirect the output to a new location (likely based on
registry settings).  I've kept that out of this CL to keep
its size on the smaller side.

Bug: 1144185
Change-Id: Ibf494251d0929a1741cb2796f26d69d258d96a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515140Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823596}

Downstream(s) can define their own additional_lint_targets to be
included in the general "android_lint" target.

Bug: 1078229
Change-Id: I7c2cb50ef644dd700639860feda8ec9b9f793cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512526Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823595}

Change-Id: Ica5f90107d05bca69ecfb44b652ca24d35a3bf81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516699
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823594}

R=eseckler@chromium.org

Change-Id: I7773289dc53065c27f7ac12bb73f299f67d40b24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517581
Commit-Queue: Alexander Timin <altimin@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823593}

Change-Id: If163eb94a69d8b3743658b84009027dbf80f1f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514241
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823592}

Use will follow in a separate CL.

Bug: 1145025
Change-Id: Ib0d302120256c080f73db36d66c29ad60ab4d14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516246
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823591}

The extra_application_definitions is still used by downstream manifests
even if not used upstream.

Change-Id: I610bb6c50df2ed828c503b4567c1bc0bfc3a8f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517624Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823590}

For GCC 8.4.0 is important to get all the first initializer in
designated init-list in case of implicit construction. Correct compile
if use explicit construction.

Error example (GCC 8.4.0):
-c ../../ui/events/platform/x11/x11_event_source.cc -o obj/ui/events/platform/x11/x11/x11_event_source.o
../../ui/events/platform/x11/x11_event_source.cc: In function ‘void ui::{anonymous}::InitializeXkb(x11::Connection*)’:
../../ui/events/platform/x11/x11_event_source.cc:78:4: error: no matching function for call to ‘x11::Xkb::SelectEvents(<brace-enclosed initializer list>)’
   });

Change-Id: I80ea8d5f0a14bb8edc1e89e66eb6d1034bd1fec3
Bug: 819294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516219Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#823589}