- 08 Oct, 2020 40 commits
-
-
Jamie Walch authored
Bug: 1122155 Change-Id: I6653288c9d4d175d8f2e077c67470464f4194829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458807 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#815216}
-
Sébastien Séguin-Gagnon authored
Max value was not set to the right value. Also changed to enum class, which would cause the previous situation to not compile. Change-Id: I0476ae21eaac5c3ef52de5bb70af073548333564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459691Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815215}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dba8d09f..c8e70787 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ba15a1aec65223381a9da2eb8681adb104f34af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461567Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815214}
-
Brian Ho authored
An earlier CL [1] attempted to fix a screen flickering issue with HDR content by expanding the damage rect to the entire frame if the color usage changes (e.g. SDR -> HDR). This fix, however, doesn't work when there is no damage on the frame (besides the color space change) because the expanded damage rect is eventually overwritten via an intersection with the 0-sized damage [2]. When the frame reports no damage, the draw is skipped entirely even though we should really be invalidating everything as per the original CL. This can be reproduced by playing an HDR video on YouTube in a background tab and then mousing over the tab. Chrome will process the HDR video frame in preparation to display the tab preview and the CompositorFrame is marked as "HDR" [4]. After the user mouses off the tab, Chrome will eventually stop processing the HDR video and will send a transitional "empty frame" [5] with an sRGB color space which triggers the problematic 0-damage DrawAndSwap mentioned above. At this point, the user will likely see the screen flicker black because the frame wasn't properly drawn. This CL updates SurfaceAggregator::Aggregate to stop overwriting the full-frame damage if the color space changes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2369441 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/surface_aggregator.cc;l=1758;drc=72b4db84824e257c412ac88a4941d12619a44dd2 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/display.cc;l=726;drc=cf4c5571a11fd0ce94bccbd867c65b75b28350ac [4] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/graphics/video_frame_submitter.cc;l=614;drc=72b4db84824e257c412ac88a4941d12619a44dd2 [5] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/graphics/video_frame_submitter.cc;l=388;drc=72b4db84824e257c412ac88a4941d12619a44dd2 Bug: 1132962 Change-Id: I03214c857d804b0a969e05db2853a0a5e9dadbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453802 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#815213}
-
Oriol Brufau authored
Before r814053, VisiblePosition::Create had a fast path for positions with downstream affinity, always returning the backward canonical position with downstream affinity. But since r814053, that case chooses between the backward canonical position with downstream affinity and the forward canonical position. The code calls InSameLine() in order to decide, but this is slow. So it caused a perf regression in modify-selection.html This patch adds back a fast path for downstream affinity in case the backward and forward canonical positions are equal, which is usual. This fixes the perf regression in modify-selection.html Bug: 1135577 Change-Id: Icb07c25efe8d21c04eb3659292c880af258cf97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453291Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#815212}
-
Corentin Wallez authored
Bug: dawn:445 Change-Id: I60e9a8b240470eeffd62a0da7328a581972800a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443150 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#815211}
-
Fredrik Söderqvist authored
These instances of StylePath/BasicShape/ShadowList are supposed to be immutable, so add const qualifications and drop some then unnecessary const_cast<>s. Change-Id: I1a6ca8ec9c45dac757a45882129f91f745745023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460894Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#815210}
-
Corentin Wallez authored
These tests were written prior to the group agreeing on the exact rules, disable them until they are updated so Dawn's validation can be updated to match the upstream WebGPU spec. Bug: dawn:542 Change-Id: I3c66d46c669a5c9ab61b057d0f049b4a63c073ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461275 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
-
Yifan Luo authored
Bug: 1116418 Change-Id: Id58d7f0478abb73619d5077d9024800bd7b83c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461331Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#815208}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c90bac4197a4..8ce5f5261ab7 2020-10-08 saklein@chromium.org controller/test: Refactor SplitCPV to parse. 2020-10-08 saklein@chromium.org image: Refactor SplitCPV to parse. 2020-10-08 saklein@chromium.org controller/dependency: Refactor SplitCPV usages. 2020-10-08 saklein@chromium.org android: refactor SplitCPV to parse. 2020-10-07 tcwang@google.com afdo: Rename CWP profiles 2020-10-07 saklein@chromium.org controller_util: Add PackageInfo serialization. 2020-10-07 saklein@chromium.org cbuildbot_run: Refactor SplitCPV to parse. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iecf720ba9601adddaf012dd1ec90d0b6bef7fbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815207}
-
Jeffrey Young authored
This is a reland of 581c91ec Original change's description: > ambient: start when two images loaded > > Construct ambient widget when two images are in memory to prevent burn > in. > > BUG=b:167332126 > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: I520ada00429125d35bda9ef66089ca9a9c8d4440 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440306 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814711} Bug: b:167332126 Change-Id: I7fe0cca3ecb15262666eee1067f57bc21b150468 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459399Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#815206}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6b4a4a85dfd7..33a0deb815ce 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 28ae1471bf2c to 66377ce9be54 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I322727c8bb68d7e571c639892cf1270b2f23c95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461957Reviewed-by:
-
Justin Cohen authored
GetNavigationItemImplAtIndex() appears to return a nil |cached_item| sometimes, perhaps due to a mismatch in WKWebView's backForwardList. Returning early when this happens in RestoreItemsState() may break some restore state features, but should not put the user in a broken state. Bug: 1134096 Change-Id: I47a2f1316375860b223fa988e7aca9e4557057d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454291Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815204}
-
Dave Tapuska authored
PointerLock allow/disallow use to be emulated from the renderer side. There was a unique thing that web_tests treated exiting pointer lock as asynchronous where it really is synchronous. ie. The callback DidLosePointerLock was called via a PostTask but under the normal browser flow it is not. This required some adjustments to the tests to bring them in line with the browser implementation. This change is necessary since the WebWidget overrides for pointer lock are going away with RenderWidget removal. BUG=1097816 Change-Id: Icc58ca6de405308bffb50945b5b828691ff9f2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453913Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#815203}
-
Peter Kotwicz authored
This CL fixes the data deps in //chrome/android/monochrome:monochrome_apk_checker BUG=1115604 TBR=agrieve (CL is subset of https://crrev.com/c/2460714) Change-Id: Iaf838095b13b08872ad52c99480bc0f0b34c8a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460756Reviewed-by:Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#815202}
-
Joe Mason authored
These classes will soon return memory usage of workers as well as frames. This matches the name of the mojo interface in third_party/blink/public/mojom/performance_manager/v8_detailed_memory_reporter.mojom. Also renames v8_per_frame_memory_decorator* to v8_detailed_memory*. A followup will split these classes into separate header files since v8_detailed_memory.h is large enough to be unwieldy, and move V8DetailedMemoryDecorator into a private file since it doesn't need to be part of the public interface. Bug: 1080672 Change-Id: I1c17e8bb1d6ee7d77638116495ba6ed8b5e4a4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453894 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815201}
-
Joel Hockey authored
It seems that web_contents may be destroyed during RunArcExternalProtocolDialog (See TODO comment in the code). See crashes in crbug.com/1136237 So rather than bind web_contents directly into OnArcHandled(), we use render_process_host_id and routing_id to look it up at the end as was happening in ShowFallbackEternalProtocolDialog() prior to crrev.com/c/2423067. Bug: 1136237 Change-Id: If0bc1287f9eedbf2b915cd97e049a19f379254ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460067 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#815200}
-
Omar Morsi authored
This CL extracts platform keys service function execution waiters and the scoped softoken key attributes mapping implementation into a separate test util file so as it can be used by key permissions manager later. Bug: 1127284 Change-Id: Iff156918660e6eb2340a27c3f4e3ddd2ab6c6e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456787Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#815199}
-
Peng Huang authored
For some devices, the hardwarerotation doesn't work with SurfaceControl, so disable it for now. Bug: 1136033 Change-Id: Id1ed7971d50ec815fd315fb728315f05e6be9637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461550 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#815198}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8a7ceda7a71f..11ac723021d5 2020-10-08 jacktfranklin@chromium.org Make MutationHelpers node type generic 2020-10-08 bmeurer@chromium.org Fix consistent typing of ScopeChainEntry vs. Scope. 2020-10-08 szuend@chromium.org [ts] Type-check network/RequestHTMLView.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from RequestPreviewView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1042636 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I66a73c1ce5fb4576e226dfe20994ad813c8967f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461404Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1075649 Change-Id: I340b9a7c0b1dc00122c4cf893b64ac83b425e358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459050Reviewed-by:
-
Adam Langley authored
Previously all caBLE (v1 and v2) adverts were a single, 16-byte UUID. It was encrypted with AES and the receiver checked that certain bits were zero to confirm a correct decryption. caBLEv1 has 64 zero bits and v2 ended up with 18. Since the caBLEv2 advert was so tight, this change adds another 4-byte UUID to save some space for later. That 4-byte UUID contains an HMAC authenticator over the encrypted 16-byte UUID, both adding 14 bits of rejection power and freeing up the previous 18 bits for future use. Thus, in caBLEv2, "EIDs" are now the plaintext 16 bytes and "adverts" are the encryption of EIDs which expands them to 20 bytes. Since BLE stacks might add other UUIDs, all combinations of 16- and 4-byte UUIDs are considered as adverts on the receive side. Additionally, 4-byte UUIDs might actually end up as 2-byte UUIDs if they have 16 bits that matches the magic suffix. Thus 2-byte UUIDs are treated as if they were 4-byte ones. BUG=1002262 Change-Id: I6d46136d1a6e09edd1680b459621731c8358327d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453920 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#815195}
-
Henrique Nakashima authored
TabWindowManagerSingleton will be left in the glue layer, but in the modules the dependency should be explicitly passed. Bug: 1112922 Change-Id: I725277f04c039f2fed42836d4d7a4079665b0ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446839 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#815194}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a8bb3df77a94..6dfd855a10fb 2020-10-08 lehoangq@gmail.com Metal: Implement fence sync 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e171d8431cfa to 24184fe81c6f (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I190d352ed48dafca78ba3a2d8788f19c08b464f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461958Reviewed-by:
-
dpapad authored
These were missed at r814094. Bug: 1132403 Change-Id: Id504b4e2b39fd8c232bc992d31ed9f5b75981ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461206Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815192}
-
Morten Stenshorne authored
Compiling with -Wshadow showed that one of the values conflicted with Document::ParsingState Bug: 294205 Change-Id: I4f932767d1962e7615acfefa5af76ba554aabaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461009Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815191}
-
Chris Sharp authored
Change-Id: I62ac26fd680fd94a245c6b34af6edcb87abfebed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461037Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#815190}
-
Ian Kilpatrick authored
As above. This patch disallows parsing <table width="0"> mapping to "width: 0px" internally. This only applies to width (not height) - see: https://wpt.fyi/results/html/rendering/dimension-attributes.html?label=master&label=experimental&aligned&q=dimension-attributes See also: https://drafts.csswg.org/css-tables-3/#mapping Bug: 958381 Change-Id: I42844dc7b77b8597f4a256e7739baaa3df9f249b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458587Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#815189}
-
George Burgess IV authored
This new clang-tidy check fires when the result of a function like `unique_ptr.release()` is unused. Sometimes this is intentional, other times, it's not (e.g., the dev intended to `.reset()`). Bug: 1134714 Change-Id: Ia6a272a8b45bfc3eace44d94f244cbfcedede608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457649Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815188}
-
Gwendal Grignou authored
This reverts commit 42f6f938. Reason for revert: 1- We need to trigger event before reading 2- Reading one byte will make next reading unaligned. 3- The error was due to invalid group setting, fixed since. Original change's description: > Do not use the accelerometer device file when it's failed to read > > On some system / device configuration, the accelerometer device > file exists but can't be read by the browser process. When this > happens, it generates error log repeatedly, which is not great. > > This CL tries to address this issue in a way. On initializing > accelerometer configuration, it tries to read the device file > at that time, and when it fails to read, it just stops the > initialization and reports an error message. This happens once, > and does not generate repeated logs. > > Also, when an error happens, now it can obtain the errno and > print it as a part of the log, so it would be more understandable > why it fails. On my case, it is just permission denied, for some > reasons. > > Bug: 1134527 > Test: manually with nautilus device in the lab > Change-Id: Ib9823631a70fc54d3e3abc35067aff56a7d7ee50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454840 > Reviewed-by: Min Chen <minch@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814780} TBR=jamescook@chromium.org,mukai@chromium.org,minch@chromium.org,chenghaoyang@chromium.org Change-Id: Icd2a780a14bd4e12358053f150a37bd3d7f46f75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134527,1133429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461648Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org> Auto-Submit: Gwendal Grignou <gwendal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815187}
-
Brian Sheedy authored
Fixes an issue recently introduced in crrev.com/c/2446717. Currently, we're hiding all Android pixel test failures because we re-used the should_hide_failure variable for determining if we should add the ignore:1 key to a test's comparison. Hiding a failure is a separate concept from ignoring an image in Gold, so this CL properly splits the two again. Change-Id: I2501ce27fd20528a8d73bd1531947145253cceed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459573 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815186}
-
Ewann authored
-On iPad, the actionSheetCoordinator is now anchored to to the "Close All" button. -The actionSheetCoordinator is also dismissed when tapping on the screen. - The actionSheetCoordinator is now stopped in -stopChildCoordinatorsWithCompletion: Bug: 1133304, 1135511 Change-Id: Id780844b7d42b4194e6f750859552ec9ff8b6793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450279Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08c89d1c03e1c3d2dbb5c561e18c85fba90fb2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461961Reviewed-by:
-
Rushan Suleymanov authored
The test should check that the sharing message will be sent to the server again if there was AUTH_ERROR in the last request. However the SharingMessage data type doesn't always generate data for the next commit requests. This CL disables the test until it gets fixed because it might fail in other CLs. Bug: 1097054 Change-Id: I6d0b952026e1cdab9f6e8ff51f9b4c86724ec1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460736 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#815183}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8389aa11092..eacaa9a164a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com,olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131415 Tbr: tluk@google.com,olka@google.com Change-Id: I6b37a942f7856d4ee8b80e6016d9f05c759a1136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461956Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815182}
-
Corentin Wallez authored
SPVC has been removed from Dawn and that flag is now a noop. Bug: dawn:521 Change-Id: I52d2887b373c22376f9cd0664e4b6740299a9bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461330 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815181}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010080700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/ccPNzyZsy8IYqEUjkXTCupUsZ6yj49ysyBQKh1jDG28C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Id8997478c137f45830be0488c86ae642b93b13f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461405Reviewed-by:
-
Stepan Khapugin authored
Original CL by marq: crrev/2424125 - Adds a cleanup step to EarlGreyTestCase that closes all but one window. - Adds test utilities for closing all (but one) windows, counting windows, and waiting for a specific window count. - Adds a test utility to check for multiple window support. - Adds a simple test of the tools menu "New Window" item. - Updates & reenables the history and bookmarks EG tests to wait for a window count (and to skip the tab-closing step, which wouldn't have closed the window in any case). Bug: 1126893 Change-Id: Id6b3ab02058e0db036045b0653a716fe19271b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450096 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815179}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb07662e436..31b44b3a70ed 2020-10-08 fmayer@google.com Improve docs about runtime signalling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifea0db3c1d6058c50bc71eff79521bc553ddc2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461960Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the correct URL (i.e. the one of the page that created the error) is used instead of the error page file URL. To do this, this CL uses IsLoadingErrorPage with the new error page workflow. It allows to have the URL of the loaded page (not the URL of the error page) and having the navigation marked as being a navigation to an error page. Then the callbacks can act on it. The main difference with the non-JS workflow is the back-forward navigation. Because the URL of the page is the URL of the file page that is displaying the error, we need to mark the navigation as a error page navigation. Then the navigation to the real page starts, and it is a new context so it is no longer an error page navigation. Bug: 991608 Change-Id: I4362d1cc50262ea86db1e211bfaec619f008625e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449391Reviewed-by:
-
