- 02 Aug, 2017 40 commits
-
-
Francois Doray authored
The FILE thread is deprecated. Bug: 689520 Change-Id: I57db0b1e7150f2ec7ee4fbdb538912b1928cd9dc Reviewed-on: https://chromium-review.googlesource.com/595030Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491368}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b7658d8..5c85b29c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ie0526f93764f4b79c280e5e3dc66fa3da3a66630 Reviewed-on: https://chromium-review.googlesource.com/597831Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491367}
-
Tommy Martino authored
Bug: 749815 Change-Id: Ife1a72146c3f75020286fb588f5e78a12e8d747a Reviewed-on: https://chromium-review.googlesource.com/596412Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#491366}
-
Guido Urdaneta authored
This reverts commit 3dd3e056. Reason for revert: Relanding original CL since the revert did not fix the bot. Original change's description: > Revert "Moved parsing logic to property APIs for grouped longhand properties" > > This reverts commit 264ba723. > > Reason for revert: Speculative revert. Suspect of causing tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html to fail reliably on WebKit Mac10.9 bot. > > Sample failed build: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/48635 > > Will reland if it does not fix the problem. > > Original change's description: > > Moved parsing logic to property APIs for grouped longhand properties > > > > This patch: > > - Moved parsing logic to property APIs for the following grouped > > properties: > > border-image-repeat > > border-image-slice > > border-image-outset > > border-image-width > > background-clip > > background-image > > background-origin > > -webkit-transform-origin-x > > -webkit-transform-origin-y > > -webkit-perspective-origin-x > > -webkit-perspective-origin-y > > -webkit-mask-box-image-repeat > > -webkit-mask-box-image-slice > > -webkit-mask-box-image-outset > > -webkit-mask-box-image-width > > -webkit-mask-image > > - Replaced the bool literal argument in BorderImageUtils with a > > new enum class to comply with the style guide > > - Added #includes to PositionUtils that should have been there > > when the file was created. For some reason this only started > > causing build errors in this patch > > > > Bug: 668012 > > Change-Id: I796f0967e4222689c14700b12d7726df7ab35170 > > Reviewed-on: https://chromium-review.googlesource.com/597378 > > Reviewed-by: meade_UTC10 <meade@chromium.org> > > Commit-Queue: Bugs Nash <bugsnash@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#491288} > > TBR=meade@chromium.org,bugsnash@chromium.org > > Change-Id: I1c6e1a29a52dfb99aaa6cb7fa1f064104fecc91e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 668012 > Reviewed-on: https://chromium-review.googlesource.com/597888 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491346} TBR=guidou@chromium.org,meade@chromium.org,bugsnash@chromium.org Change-Id: I719f967cb722285f771fd123042da35996f4d284 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 668012 Reviewed-on: https://chromium-review.googlesource.com/598167Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491365}
-
Stephen Chenney authored
The names are confusing, leading to bugs. Try to make them more obvious. R=pdr@chromium.org BUG=739228 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5fe6b1c4432818279f4758397d07b581a0fbe408 Reviewed-on: https://chromium-review.googlesource.com/596847Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#491364}
-
Michael Lippautz authored
We previously only kept the wrapper alive as long as the scope had timers attached. This requires us to kept explicit hidden references to event listeners to prevent them from being garbage collected. Relying on wrapper tracing requires us to keep the scope alive as long as its context is alive. This is a dependency for https://chromium-review.googlesource.com/c/576472/ Bug: Change-Id: I82c177f6e93a7ed15697e574f4e0e001957dff7a Reviewed-on: https://chromium-review.googlesource.com/584875 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#491363}
-
Bo Liu authored
All generated RegisterNativesImpl functions are no-op already. Remove all manual jni registration code in ui that calls these generated RegisterNativesImpl calls. TBR=garykac@chromium.org,zmo@chromium.org Bug: 749244 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iebbb9d91e5cc78d62b323113c5ccecd59a7311a8 Reviewed-on: https://chromium-review.googlesource.com/592333 Commit-Queue: Bo Liu <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491362}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/21171e50f486..82d97bdbfc0a $ git log 21171e50f..82d97bdbf --date=short --no-merges --format='%ad %ae %s' 2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 44183ccea..b0761934b (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ifd9ed9292d20b18cffd1968504cc7acd5df39fb8 Reviewed-on: https://chromium-review.googlesource.com/597967Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491361}
-
Nicholas Verne authored
Bug: 712963 Change-Id: I9d88fb2153c9de3ff01c5542923a7d4e832ac382 Reviewed-on: https://chromium-review.googlesource.com/597610 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491360}
-
Guido Urdaneta authored
BUG=751543 TBR=pkasting@chromium.org Change-Id: I9e33b2f01f0c71bb7b032d16ec4e16443fadf0b2 Reviewed-on: https://chromium-review.googlesource.com/597853Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491359}
-
gambard authored
In order to have the feature accessible, all the actions using gestures (long press, swipe to dismiss) must have custom accessibility actions. Also adds action sheet to Read Later cells. Bug: 749131 Change-Id: I49171acf34b897035c998b8f0f8186bc6484d878 Reviewed-on: https://chromium-review.googlesource.com/597600Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#491358}
-
Boris Sazonov authored
This CL adds AccountSigninActivity.startFromAddAccountPage. This entry point doesn't show account selection page, starting flow to add account on device instead. Bug: 749075 Change-Id: I58323c117db9d899119b55e5a2667e5aaebd09b1 Reviewed-on: https://chromium-review.googlesource.com/595983 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#491357}
-
Michael Giuffrida authored
The OS_CHROMEOS define implies OS_LINUX. So a preprocessor conditional like: if defined(OS_LINUX) || defined(OS_CHROMEOS) is redundant and should just be: if defined(OS_LINUX). Bug: 290185 (kind of) Change-Id: I382c636d2641ae95b2a00516fbfd3a494640a9fb Reviewed-on: https://chromium-review.googlesource.com/534776Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491356}
-
Guido Urdaneta authored
This test has flaked sometimes on Android bots. BUG=750566 TBR=jming@chromium.org Change-Id: I2b347ba3d055abe8b93a5a2df6a63e32d72f1a24 Reviewed-on: https://chromium-review.googlesource.com/597851Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491355}
-
Greg Daniel authored
Bug: Change-Id: Ia000b6af703abd81e84880ffa7449b11a61c1d89 Reviewed-on: https://chromium-review.googlesource.com/596792Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491354}
-
Takeshi Yoshino authored
First, parse WATCHLISTS. If it parses, scan the lines to check that: - the entries are sorted - WATCHLIST_DEFINITIONS matches WATCHLISTS. The scanner doesn't parse the dictionary literal but extracts names using re assuming that: - the lines providing the name of rules matches a regexp pattern - WATCHLIST_DEFINITIONS comes before WATCHLISTS as it's sufficient for this purpose. Stop grouping blink_.* rules and separating from the others in WATCHLISTS_DEFINTIONS. WATCHLISTS already has them mixed. As a bonus, remove an unused method GetDefaultTryConfigs(). Bug: Change-Id: I92ccc1e4d31b9bdfb97f5cf187ee44191397c895 Reviewed-on: https://chromium-review.googlesource.com/593708 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491353}
-
Michael Giuffrida authored
Add ExtensionsClient::GetUserAgent() for extension related classes to use instead of querying the ChromeContentClient directly. Bug: 446329 Change-Id: I3416a14d359ba50bec22d376410a0674d620b67f Reviewed-on: https://chromium-review.googlesource.com/587403 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491352}
-
Michael Giuffrida authored
Bug: Change-Id: I40041b48ffed49826f2b725ab06a2b7b5964282e Reviewed-on: https://chromium-review.googlesource.com/587353 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491351}
-
Takeshi Yoshino authored
It's been wrong that this method was enclosed by the if with cors_handling_by_resource_fetcher in its condition. CanRequest() is not about CORS but CSP, etc. However, this was not harmful. Since ResourceLoader::WillFollowRedirect() just calls it on each redirect, calling this in DidReceiveResponse() was just redundant. So, remove it. The only concern was that the CanRequest() uses the SecurityOrigin on the ResourceLoaderOptions updated by HandleRedirect() on the last redirect if any, and we remove that effect. But it looks actually unnecessary. Bug: 736308 Change-Id: I8d7b30a1eac6d7f5f6151a0385e7019ab815c86c Reviewed-on: https://chromium-review.googlesource.com/581955 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#491350}
-
Kinuko Yasuda authored
Very rough plan I have in my mind for now (after this patch): * Set-up URLLoader{Factory} in the renderer process for controllees using the EventDispatcher sent by the page (for now the event is sent to BrowserSideServiceWorkerEventDispatcher in the browser process) * Implement BrowserSideServiceWorkerEventDispatcher::DispatchFetchEvent, which could call receiver_version's StartRequest, event_dispatcher's DispatchFetchEvent (to forward the fetch event) and then call FinishRequest. Once the very basic part works we could possibly move BrowserSideServiceWorkerEventDispatcher in the renderer side. (We'll need yet another controlling channel to the browser side in the page side as well) Naming bike-shedding welcome, while I'd like to keep landing things if possible. BUG=715640 patch from issue 2954253003 at patchset 60001 (http://crrev.com/2954253003#ps60001) Change-Id: I5095b22becc98e809f31c95dd32b9970ba886a6e Reviewed-on: https://chromium-review.googlesource.com/547120Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491349}
-
Yutaka Hirano authored
As no one uses it, this CL removes was_ignored_by_handler from ResourceRequestInfoImpl. This CL also unifies ResourceLoader::Cancel and ResourceLoader::CancelAndIgnore. Bug: 748491 Change-Id: Ic8522be4325bf4be54f34384f00fc5c3a4755aa2 Reviewed-on: https://chromium-review.googlesource.com/595291Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#491348}
-
Michael Hablich authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fca6d756..7b7658d8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. NOTRY=true because of strange bot errors. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=machenbach@chromium.org, ulan@chromium.org Change-Id: I94dffc086c933ef1f31276fd8a6d052251f8aa2e Reviewed-on: https://chromium-review.googlesource.com/596973 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491347}
-
Guido Urdaneta authored
This reverts commit 264ba723. Reason for revert: Speculative revert. Suspect of causing tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html to fail reliably on WebKit Mac10.9 bot. Sample failed build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/48635 Will reland if it does not fix the problem. Original change's description: > Moved parsing logic to property APIs for grouped longhand properties > > This patch: > - Moved parsing logic to property APIs for the following grouped > properties: > border-image-repeat > border-image-slice > border-image-outset > border-image-width > background-clip > background-image > background-origin > -webkit-transform-origin-x > -webkit-transform-origin-y > -webkit-perspective-origin-x > -webkit-perspective-origin-y > -webkit-mask-box-image-repeat > -webkit-mask-box-image-slice > -webkit-mask-box-image-outset > -webkit-mask-box-image-width > -webkit-mask-image > - Replaced the bool literal argument in BorderImageUtils with a > new enum class to comply with the style guide > - Added #includes to PositionUtils that should have been there > when the file was created. For some reason this only started > causing build errors in this patch > > Bug: 668012 > Change-Id: I796f0967e4222689c14700b12d7726df7ab35170 > Reviewed-on: https://chromium-review.googlesource.com/597378 > Reviewed-by: meade_UTC10 <meade@chromium.org> > Commit-Queue: Bugs Nash <bugsnash@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491288} TBR=meade@chromium.org,bugsnash@chromium.org Change-Id: I1c6e1a29a52dfb99aaa6cb7fa1f064104fecc91e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 668012 Reviewed-on: https://chromium-review.googlesource.com/597888Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491346}
-
Guido Urdaneta authored
BUG=751492 TBR=twellington@chromium.org Change-Id: Ia823694259de8e88ac1f121fafcf9393b821472b Reviewed-on: https://chromium-review.googlesource.com/597767Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491345}
-
Rune Lillesveen authored
After style sharing code is removed, we no longer need the sibling and uncommon attribute rulesets to reject style sharing. This also means RuleFeatureSet no longer needs to be traced, so some oilpan cruft could be removed. The StyleEngine API UsesSiblingRules() relied on the size of the sibling ruleset, but it was only used as what looked like an optimization for :empty selector updates where :empty is found in non-rightmost compound selectors. However, the presence of :empty itself would add a sibling selector in the previous code, and :empty in non-rightmost compound not followed by an adjacent selector would only have de-generate cases like ":empty span" which could never match anything, or ":not(:empty) span" which would always be true if the whole selector matches. Therefore, it makes sense to just drop the API/check. Bug: 721517 Change-Id: I85100850cb8cec56b17947916d7755ebcf3f15ec Reviewed-on: https://chromium-review.googlesource.com/597689Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#491344}
-
Guido Urdaneta authored
This reverts commit a58af821. Reason for revert: Relanding the original CL since the revert did not fix the error. Original change's description: > Revert "v8binding: Refactors MutationObserver and MutationCallback." > > This reverts commit e4d81dae. > > Reason for revert: Speculative revert. > > Layout test tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html started failing reliably on WebKit Mac10.9 bot following this CL. > It does not look very related, so I will reland it if the failure continues. > > Original change's description: > > v8binding: Refactors MutationObserver and MutationCallback. > > > > Major changes in this CL are: > > - Drops [CustomConstructor] from MutationObserver.idl. > > - Replaces hand-written V8MutationCallback with code-generated > > MutationCallback. Note that the new (code-generated) > > MutationCallback is different from the old (hand-written) > > MutationCallback. > > - Rewrote the old (hand-written) MutationCallback as > > MutationObserver::Delegate. Note that the name > > "MutationCallback" is taken by the new (code-generated) > > MutationCallback. > > > > This CL mostly follows the same way as https://crrev.com/c/581128 . > > > > Bug: > > Change-Id: I3f8b36044499c50baade331e2bfafbbed4271e0d > > Reviewed-on: https://chromium-review.googlesource.com/590832 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#491297} > > TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org > > Change-Id: Ie6aeebac4741cd3a7cac1dacd15c6f709e15ecab > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/597708 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491333} TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org,guidou@chromium.org Change-Id: I4e2fba2f191aeb2caea234af1307b1a9dde144dc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/597887Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491343}
-
Takeshi Yoshino authored
Bug: Change-Id: I972758628679b0be7ec8627aade1d850fe0f5f3a Reviewed-on: https://chromium-review.googlesource.com/597532Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#491342}
-
guidou authored
Reland of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #1 id:1 of https://codereview.chromium.org/2985393002/ ) Reason for revert: BUILD files have been fixed in a separate CL, so this is safe to reland. Original issue's description: > Revert of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #6 id:120001 of https://codereview.chromium.org/2969093002/ ) > > Reason for revert: > Breaking build https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Audio%20Linux/builds/3356 > > Original issue's description: > > Make rendering of MediaStreams reflect changes to its set of tracks. > > > > Before this CL, MediaStreams assigned to a media element required > > reassignment of the stream to the element in order to make changes > > to the set of tracks visible. > > > > This CL fixes this problem by making WebMediaPlayerMS subscribe to > > changes in the set of tracks of a MediaStream, and correspondingly > > update audio and video renderers. > > > > BUG=720258 > > > > Review-Url: https://codereview.chromium.org/2969093002 > > Cr-Commit-Position: refs/heads/master@{#490906} > > Committed: https://chromium.googlesource.com/chromium/src/+/c9612ba8bf66e48a32301e35425dd3384f48a3d8 > > TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,guidou@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=720258 > > Review-Url: https://codereview.chromium.org/2985393002 > Cr-Commit-Position: refs/heads/master@{#490920} > Committed: https://chromium.googlesource.com/chromium/src/+/b35b4c271b7819e3661942ab2c72083673722910 TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=720258 Review-Url: https://codereview.chromium.org/2994473002 Cr-Commit-Position: refs/heads/master@{#491341}
-
Nicolas Dossou-Gbete authored
Related to https://chromium-review.googlesource.com/c/568492/, stores tile data into sections. The tiles are still transmitted from the native side as a flat array, but when we load them we arrange them in a map of tiles. It should keep the current UI functioning just like before. Some of the current assumptions are affected: - We can have more than one tile per URL, but only one per section - We should not wait for all the tiles before we consider the tile load to be complete (some of the tiles will not be displayed at all) Bug: 740905 Change-Id: Ia91c3c7abb5d05a946d0b9baff95b5a05c9e3581 Reviewed-on: https://chromium-review.googlesource.com/571753 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491340}
-
Boris Sazonov authored
This CL adds second BroadcastReceiver to SystemAccountManagerDelegate to listen for GooglePlayServices package updates. These updates can change data returned by getAccountsSync, so observers should be notified. This CL also suppresses deprecation warning for SystemAccountManagerDelegate constructor (LOGIN_ACCOUNTS_CHANGED_ACTION is deprecated). Bug: 698258 Change-Id: I09c00c2527984fda36f606f332e8cf215a74eb4b Reviewed-on: https://chromium-review.googlesource.com/594767Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491339}
-
magjed authored
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:1 of https://codereview.chromium.org/2973253002/ ) Reason for revert: Update test to still use HW version of H264. Original issue's description: > Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:190001 of https://codereview.chromium.org/2548443002/ ) > > Reason for revert: > Reverting this since it's causing multiple perf regression on mac, looks like HW encode/decode might get disabled. > > Original issue's description: > > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:1 of https://codereview.chromium.org/2521923002/ ) > > > > Reason for revert: > > Try again. > > > > Original issue's description: > > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ ) > > > > > > Reason for revert: > > > Causes these tests to fail on chromium.webrtc bots for Win and Mac: > > > WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 > > > WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 > > > https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367 > > > https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661 > > > > > > Original issue's description: > > > > RTCVideoEncoder: Report H264 profile information to WebRTC > > > > > > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs > > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile > > > > information is added to the cricket::VideoCodec so that WebRTC receives > > > > this information. Also, the mapping between media::VideoCodecProfiles > > > > and cricket::VideoCodecs is cached so that we can send the > > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal > > > > with webrtc::VideoCodecType. > > > > > > > > BUG=webrtc:6337 > > > > > > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5 > > > > Cr-Commit-Position: refs/heads/master@{#433508} > > > > > > TBR=emircan@chromium.org,posciak@chromium.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:6337 > > > > > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c > > > Cr-Commit-Position: refs/heads/master@{#433828} > > > > TBR=emircan@chromium.org,posciak@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=688541,735959 > > > > Review-Url: https://codereview.chromium.org/2548443002 > > Cr-Commit-Position: refs/heads/master@{#484874} > > Committed: https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a96527d59ea5e9 > > TBR=emircan@chromium.org,magjed@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=688541,735959 > > Review-Url: https://codereview.chromium.org/2973253002 > Cr-Commit-Position: refs/heads/master@{#484960} > Committed: https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1d7106b55160d TBR=emircan@chromium.org,niklase@chromium.org,phoglund@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=688541,735959 Review-Url: https://codereview.chromium.org/2985263002 Cr-Commit-Position: refs/heads/master@{#491338}
-
Boris Sazonov authored
This CL adds AccountsChangeObserver to AccountSigninView to update it whenever account list changes. Bug: 693611 Change-Id: Ib888d43f2abf879a259b46e6dd781d909020fab3 Reviewed-on: https://chromium-review.googlesource.com/594388Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491337}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/95988f787423..0327c967ed7f $ git log 95988f787..0327c967e --date=short --no-merges --format='%ad %ae %s' 2017-08-02 achuith Use linux binaries on chromeos. Created with: roll-dep src/third_party/catapult BUG=750323 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I501c4bfc339b126254ac10f685238e2adece9462 Reviewed-on: https://chromium-review.googlesource.com/597727 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491336}
-
Michael Giuffrida authored
Have ExtensionsBrowserClient provide the application locale instead of using g_browser_process. Bug: 446329 Change-Id: Ibbab77cf385b2d11c1e6ee093c9118d652324635 Reviewed-on: https://chromium-review.googlesource.com/587420 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491335}
-
Yutaka Hirano authored
Bug: 748491 Change-Id: I302fe1c5dbd95926ab5cd96d3fb7d53463f15d53 Reviewed-on: https://chromium-review.googlesource.com/588039Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#491334}
-
Guido Urdaneta authored
This reverts commit e4d81dae. Reason for revert: Speculative revert. Layout test tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html started failing reliably on WebKit Mac10.9 bot following this CL. It does not look very related, so I will reland it if the failure continues. Original change's description: > v8binding: Refactors MutationObserver and MutationCallback. > > Major changes in this CL are: > - Drops [CustomConstructor] from MutationObserver.idl. > - Replaces hand-written V8MutationCallback with code-generated > MutationCallback. Note that the new (code-generated) > MutationCallback is different from the old (hand-written) > MutationCallback. > - Rewrote the old (hand-written) MutationCallback as > MutationObserver::Delegate. Note that the name > "MutationCallback" is taken by the new (code-generated) > MutationCallback. > > This CL mostly follows the same way as https://crrev.com/c/581128 . > > Bug: > Change-Id: I3f8b36044499c50baade331e2bfafbbed4271e0d > Reviewed-on: https://chromium-review.googlesource.com/590832 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491297} TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org Change-Id: Ie6aeebac4741cd3a7cac1dacd15c6f709e15ecab No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/597708Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491333}
-
Kinuko Yasuda authored
Make ServiceWorkerNetworkProvider's ctors private, adds specific creation methods like: - CreateForSharedWorker - CreateForController Bug: 740070 Change-Id: Ib17d50f2bf49b3895569551f805892b4c3706d38 Reviewed-on: https://chromium-review.googlesource.com/597553Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491332}
-
tzik authored
This CL removes auto-restart of SyncTaskManager. It used to restart a chain of asynchronous task on an unexpected chaing breakage unless the browser is in the shutdown sequence. However, as the shutdown detection is unstable, that causes a restart loop. Bug: 750800 Change-Id: I2ca231b84908f7c015b4cd97ad02a43f423b20e4 Reviewed-on: https://chromium-review.googlesource.com/597552Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#491331}
-
Yoshifumi Inoue authored
This patch changes |SelectionControlle::SelectClosestWordOrLinkFromMouseEvent()| to use |SelectionInFlatTree| instead of |VisibleSelection| since it is redundant, for improving code health. This is follow-up of the patch[1]. [1] http://crrev.com/c/595309: Make ExpandSelectionToRespectUserSelectAll() to take SelectionInFlatTree Bug: 657237 Change-Id: I4fb3c71c27f3b32322311724a99a44f61376b5ec Reviewed-on: https://chromium-review.googlesource.com/597091Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#491330}
-
tzik authored
Change-Id: I7ecaf4c2924ad4f8937f607b9478ab3636d3459b Reviewed-on: https://chromium-review.googlesource.com/597559Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#491329}
-