- 10 Mar, 2020 40 commits
-
-
Sam Bowen authored
" * Add a validator that removes properties that are not the right type. * Add double, time, and timedelta types in the document metadata mojo structure. * Use the new mojo types in document metadata extractor. " This is a reland of https://crrev.com/c/2062907 which was reverted in https://crrev.com/c/2095670. The substantial changes are two-fold: (1) add build dep on base in schema_org_properties. This should fix the try bot issue which was somehow skipped. (2) Rebase on top of https://crrev.com/c/2073337 which was submitted and contains some changes to the mojo structure. Change-Id: I7f47d74e8833f76d4077028eac0dcb43790a1d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097059Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#748945}
-
David Grogan authored
Relative position offsets are still done in legacy, so we need to teach it about FlexNG's implementation of flexbox's definiteness exceptions. Bug: 845235, 1060346 Change-Id: I3dfc1400efdef1d9601ec0d8762f17d8a9ad64dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093273 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#748944}
-
Bettina authored
SoftwareReporter.ExperimentErrors is logged when software_reporter_tool fails. However, the naming of this metric is confusing as it does not relate to an experiment. It should refer to configuration of the manifest. Bug: 1055870 Fixes: 1055870 Change-Id: I57097d2896a8ac1ab4749c86c230cd9d39df8142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090595 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748943}
-
Nate Fischer authored
No change to logic. This adds the following minor UX improvements: * Removes duplicate dividers (one horizontal divider is already built into the default Spinner theme), so we have a 1dp divider between flags. * Add back the top-most divider (above the first flag) at the bottom of the header. This is now anchored beneath the "reset" button, rather than to the top of the first flag. * Increases vertical padding and margin for the Spinner. This makes it a bigger tap-able target. Fixed: 1059480 Test: Manual - verify Spinner has more space and is easier to tap Change-Id: I9e492b43c9a1b2c1bc82dbc45b735b7c62c32e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095923Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748942}
-
Reilly Grant authored
This change enables by default the new WinRT sensors API backend and removes the histograms which were added to measure the impact of this change. They are no longer necessary as the experiment is over. Bug: 1053125, 1019783 Change-Id: I0a1b148f5a1c3de59f132d384020509dc6465f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091220Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#748941}
-
Alex Newcomer authored
This histogram continues to be useful to our team, so bump it by a year. Bug: 1052901 Change-Id: Ib5f079b44e000f6c24f385caf9763f9608e15aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085602Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#748940}
-
Jinsuk Kim authored
This CL removes logic/class that handles following obsolete histograms: Tabs.FirstSwitchedToForegroundCreation*Rank: expires after M77 Tab.BackgroundLoadStatus: expires after M77 Tabs.StateTransfer.Time*: expires after 2017-05-08 Tab.SwitchedToForegroundMRURank: expires after 2014-04-14 Bug: 925242 Change-Id: Ic605626cfe375d1a83938f1e3d1a9cc3b4b26d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094848Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748939}
-
Kai Ninomiya authored
Previously reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036 Change-Id: I4dac360647610047b04024ef8cb6c2a12d8f164e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097297Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#748938}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I39b3c02528195d497e76c80e375838aca18e848e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748937}
-
Rayan Kanso authored
Bug: 1057381 Change-Id: I6e35e6991a96d452c41b9e5eee945948bf630ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093221Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748936}
-
Henrique Ferreiro authored
ui::Cursor is a superset of content::CursorInfo. Delete the latter and replace all of its uses with the former. Bug: 1040499 Change-Id: I559d463551f616743a25bc4687b12c1d92041b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999201 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748935}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 78 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-09-06. Change-Id: Idee8bde9832388acf36da0314ac1ddaf8676dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093534Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#748934}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82e00fd235e4..ccdbaf215f0c git log 82e00fd235e4..ccdbaf215f0c --date=short --first-parent --format='%ad %ae %s' 2020-03-10 treehugger-gerrit@google.com Merge "processor: Support TrackEvent counters in importer" Created with: gclient setdep -r src/third_party/perfetto@ccdbaf215f0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I81b779e74fb6c3deb535052ddc48aa1b6644c1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097150Reviewed-by:
-
Kent Tamura authored
<select multiple> dispatched unnecessary 'change' event if a user changed nothing on a chooser dialog. This CL fixes it. HTMLSelectElement::SelectMultipleOptionsByPopup() used UpdateSelectedState() to update selection state and prepare for 'change' event. However, it didn't work well mainly because SaveLastSelection() doesn't support menulist <select multiple>. This CL fixes this bug by not using UpdateSelectedState(). SelectMultipleOptionsByPopup() updates selection state and dispatches 'change' event by its own logic. * Add SetDelegatesMenuListRenderingForTesting() to LayoutTheme for ease of testing. This CL affect only Android, but the test is workable on all platforms. Bug: 1060039 Change-Id: I7c9c5ee9bb51ec4aa7b2da21329c9a8d4c0778da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096064 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748932}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8be72df60462..16ae92a4ee52 git log 8be72df60462..16ae92a4ee52 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 amaiorano@google.com Subzero: fix Call on bool-returning functions Created with: gclient setdep -r src/third_party/swiftshader@16ae92a4ee52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I888c166120b1be6f291d31360a4af09da2e1c732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097141Reviewed-by:
-
Charlie Hu authored
This CL migrates following features from feature policy to document policy: - unoptimized-lossless-images - unoptimized-lossless-images-strict - unoptimized-lossy-images - oversized-images Following tests are being migrated to document policy: - feature-policy-unoptimized-lossless-images - feature-policy-unoptimized-lossless-images-strict - feature-policy-unoptimized-lossy-images - feature-policy-image-policies-with-border-radius - feature-policy-unoptimized-images-cached-image - unoptimized-lossy-images-reporting - unoptimized-lossy-images-reporting-onload - feature-policy-oversized-images - feature-policy-oversized-images-edge-cases - feature-policy-oversized-images-forced-layout - feature-policy-oversized-images-responsive-image - feature-policy-oversized-images-styles - feature-policy-oversized-images-resize - oversizsed-images-reporting Changed the test content of feature-policy-image-policies-with-border-radius. As legacy-image-formats is removed, The bmp image is not expected to be blocked. Previously ekaramad@ removed allow=”legacy-image-formats” in the test but did not update the expected png file in CL( https://chromium-review.googlesource.com/c/chromium/src/+/1548869). Also removed flaky expectations on test feature-policy-image-policies-with-border-radius. Following web tests are removed: - external/wpt/feature-policy/parameters/ Bug: 993790 Change-Id: I10e5c4a646efcfab1cdc757c012ae35e75a42241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058702 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#748930}
-
Marijn Kruisselbrink authored
Also update runtime_features to turn on the new writable streams API when the Native File System specific feature flag is enabled. Bug: 853326 Change-Id: I2c66a6917a9d1cec6074f08aa1c2ef12170d133b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095409Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748929}
-
behdad authored
BeginMainFrameStartToCommitDuration metric is removed as it is already reported as part of compositor latency metrics (CompositorLatency.SendBeginMainFrameToCommit). Bug: chromium:1050611 Change-Id: I2a5b0b1cacbefe7ced59b7779084c3877467f9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096110 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#748928}
-
Mason Freed authored
These counters were added in [1], and data was gathered. It turns out that about 7% of all visible radio buttons and 11% of all visible checkboxes are "non-square" - their width != height. With the existing code, these are rendered square, using min(width,height). But the point is that if we relaxed this constraint, 7-11% of page loads would change - a huge web compat problem. Now that data gathering is complete, I'm removing these counters. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1967426 Change-Id: I6f2334d04a2dcd62b71ce428cd2d13c16b5e59c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088334 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Brian Cui authored
This CL fixes the changes to TestExpectations to this CL [1] which attempted to disable some tests in order to land changes to Infobar [2]. The first CL wrote in the wrong file paths for the tests in the TestExpectations file; this CL corrects those file paths to actually disable the tests this time. I've done a rebuild of blink_tests locally to verify that these tests "fail" correctly with the changes in [2]. One test (decorations-after-script-formatter.js) was already disabled in Windows for Timeout. This test is now fully disabled by allowing the Failure outcome on all platforms. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2092424 [2] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1981175 Bug: 1056348 Change-Id: I616775c2c3ff42cf334dc7fea000977f8e2dbe74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097296Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748926}
-
Owen Min authored
CloudExtensionRequestEnabled policy is only used when CloudReportingEnabled policy is set to True Bug: 1006899 Change-Id: Iac7b65d043de6bff91d46b7adfc06b2bbbd6d61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095451 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748925}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4072.0-1583751487-benchmark-82.0.4079.0-r1 to 82-4072.0-1583751487-benchmark-82.0.4081.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4c779a931ce80341e6602af3d043f8c936c81043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097326Reviewed-by:
-
Jonathan Ross authored
This test has begun flaking regularly on Windows. Marking as RetryOnFailure so that we can hopefully handle the flakes. This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2096089 Where we marked deqp/functional/gles3/shaderloop_do_while.html as flaky. Seems both related tests are affected. TBR=ynovikov@chromium.org TEST= webgl2_conformance_gl_passthrough_tests deqp/functional/gles3/shaderloop_while.html Bug: 1060024 Change-Id: Ie9b6e1f5b56a5d1e6515baff0f5133e09cc2e45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094740Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748923}
-
Theresa Wellington authored
If we fail to create a TabModel because there are already too many, don't set TabModel on various clients. Rather, #finish() and return immediately. BUG=1059989 Change-Id: I01dca310d50de4f6665ccd23102316bc234ce611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097235Reviewed-by:
-
Mohsen Izadi authored
To be able to include and use it without including the whole cc::InputHandler. This is specially needed for use in cc::EventMetrics to avoid include cycle. While doing this, also changed ScrollInputType to be an enum class. Bug: 1058162 Change-Id: Ifb17c9852e0f2e6e7481e527a40523a1c153b6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092198Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Lily Chen authored
"Endpoint groups" in the ReportingCache were previously identified by an origin and a group name. Since the NetworkIsolationKey must now be added as an additional key, this CL adds the NIK to the ReportingEndpointGroupKey struct. Everywhere where an origin, group tuple was used to identify a particular endpoint group, we now use a ReportingEndpointGroupKey, which contains a NIK, origin, and group name. The "clients", which used to each describe the Reporting configuration for a particular origin, are also now identified by both a NetworkIsolationKey and origin. This CL does not touch the reports stored in the ReportingCache. It also does not yet double-key the header parser, which is the entry point into the cache, so for now the NIK fields are not yet filled in with real NIKs; they are all empty (except in tests). Bug: 993805 Change-Id: I23aa38bd6ab439376d7f6134c3e13b4e1a2c9318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988987 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#748920}
-
Frank Tang authored
Types of files: conversion data, dictionaries, and break rules, etc with the following extension only: *.cnv, *.dict, *.brk, *.icu, *.cfu, *.nrm None of '*.res' files is tracked. Enable UMA to find out which ICU data files were seldom used for future trimming consideration. Still need to set U_ENABLE_TRACING to 1 in third_party/icu/BUILD.gn to turn it on. Bug: 1056846 Change-Id: Ia99a6b318bae6c1ac6aeeb917440b3a691312733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079299 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e6a773d..1003942d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibfaefeec67a02c902dcbfdecea12fbe0b9bf12a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096391Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748918}
-
Ovidio Henriquez authored
This change implements getDevices() which returns a list of WebBluetoothDevice objects that the current site has permission to access. If the kWebBluetoothNewPermissionsBackend flag is enabled, the list of devices will contain all of the permitted devices. If the flag is not enabled, then the list of devices will contain the permitted devices that are currently connected to the system. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit#heading=h.5ugemo7p04z9 Bug: 577953 Change-Id: I9785f24ee46ac634b6a96d6146f54da37d132a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044660 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#748917}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9e5db26faa43..4bdcfb7b6e69 git log 9e5db26faa43..4bdcfb7b6e69 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 bpastene@chromium.org Revert "Fix CrOS minidump pulling on certain devices" Created with: gclient setdep -r src/third_party/catapult@4bdcfb7b6e69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055225,chromium:1059426 Tbr: eseckler@google.com Change-Id: Ie0157d9731b76304a450924f89274e9484bd1c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097042Reviewed-by:
-
Adrienne Walker authored
This patch restricts IndexedDBContextImpl usages to StoragePartitionImpl and indexeddb itself. This is one of the final pieces before the StoragePartitionImpl bit can be removed and IndexedDBControl is used by StoragePartitionImpl instead of IndexedDBContext. Bug: 1015214 Change-Id: Ia96becbba462716e001633cc526afa55dd6af7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092182 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Joshua Bell authored
Noticed as flakes in wpt-firefox-stability-nightly, interfering with landing some other tests. These tests don't use helpers to ensure unique database names and are sensisive to residue left by previous tests, e.g. if the cleanup functions don't run. Make the tests somewhat more robust by ensuring unique names and deleting state left by previous runs. Change-Id: Ie2cb5672f12c0fed0e6ff53900f16e5ba8998262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086452Reviewed-by:
-
nancy authored
AppService doesn't have the extensions information, so the tilte for extensions on shelf is empty when launch extensions. Modify LauncherControllerHelper::GetAppTitle. If the app can't be found from AppService, call extensions to get the title. BUG=1059732 Change-Id: Ib2766671e85c049c17c98f0a524e79f457706979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096416Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748913}
-
Stephen Chenney authored
Adds UMA and UKM for various aspects of asynchronous HTML document parsing (i.e. parsing files): - Chunk counts, indicating how often the parser yields and is unpaused - Parsing time total and min/max across chunks - Tokens parsed, total and min/max across chunks - Yielded time, min and max, indicating how long the parser wait after yielding Metrics are only collected for main frames, with high resolution clocks, for asynchronous parsing policy. Privacy review doc: https://docs.google.com/document/d/1wp_Od8Q2mwJtf-kqEnGdZ2P3SHu1MzdQLwKqhNQQhdU/edit?usp=sharing Bug: 1031723 Change-Id: Id9cc0faf95e15d1dd0a33b963e876674084f3f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088036 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#748912}
-
Eugene But authored
Most crashes with known steps to repro require 4 product data keys to fit all steps. Users will likely do unnecessary steps between required steps, so using 2 extra keys should allow to accommodate for all steps. Bug: 1046223 Change-Id: Ia6b97453822a2ab7e6b80cc11488f9f0f91fc949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089720 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748911}
-
llin@chromium.org authored
This CL also moved click tracking into QuickAnswersClient to reduce code duplication and make all logging handled by QuickAnswersClient. Bug: 1060265 Test: manual test Change-Id: Ia3ae5d0101a8096aa745c7a797be504bc4093025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096927 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Move Site Settings to org.chromium.chrome.browser.site_settings package and update OWNERS. Bug: 1047357 Change-Id: Id0a9cc5189ec2e9a6eb17dac2aed9bc581cb6568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087978Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748909}
-
George Burgess IV authored
We get warnings if floating-point values are multiplied by enums. The warnings go away if we use a `constexpr int` here instead, which should be equivalent given `kTickMultiplier`'s current uses. Bug: 1058218 Change-Id: I5fef7bfc74a9572020e71b62c667d21123135b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096096Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#748908}
-
Alexis Hetu authored
SwiftShader's Vulkan library will soon switch from using LLVM as its backend to Subzero. When using Subzero small off by one errors may happen, so a few off by one comparators were added in both cases where this was happening. Bug: 1060139 Change-Id: Ib3b793f860cb7d76ef8fd1846757e7ae1e483f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097178Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Alexis Hetu <sugoi@google.com> Cr-Commit-Position: refs/heads/master@{#748907}
-
Navid Zolghadr authored
As pointerlock wpt tests are now all fully automated with testdriver APIs there is no need for internal automation whitelisting of pointerlock folder. Change-Id: Id06b0e49a99c95a7c3d1ffe4f8cee44362159d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097118Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748906}
-
