- 11 Jan, 2021 40 commits
-
-
Jeffrey Young authored
AmbientPhotoController and AmbientPhotoCache are only necessary when a user is logged in and ambient mode is enabled. Construct them at that time, and destruct them if ambient mode is disabled. Schedule fetching backup images when AmbientPhotoController is constructed, rather than in OnFirstSessionStarted. BUG=b:176094707 TEST=ash_unittests --gtest_filter="AmbientControllerTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Id87bb16e6d4cc14074dd9bdb352fb5795d0f8915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605744 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842133}
-
Jeroen Dhollander authored
This is a reland of c307ddb3 This was reverted because its parent CL was temporary reverted. Nothing is different in this reland. Original change's description: > Move |AudioInputHost| to |AssistantManagerServiceImpl| > > The main goal is to ensure we can create |AudioInputHost| independently > of |PlatformApiImpl|. > > This CL also makes |AudioInputHost| virtual so it can be faked during > the unittests of |AssistantManagerServiceImpl|. > > Bug: b/171748795 > Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Ic41ff343b28dae801b0c5f4c8c6417267270d8a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610047 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841226} Bug: b/171748795 Change-Id: Id0f9054a9876f07ec9b0c8d3fac5babc018ef1e9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618769Reviewed-by:
-
Domenic Denicola authored
942aca88 performed the minimal updates to the implementation and tests to shift from "origin isolation" to "origin-keyed agent clusters". This is part of the followup work to fully reflect the rename, in this case focused on the web platform tests. The majority of changes are comment and <title> changes, although some assertion messages are also updated. Note that instead of renaming the top-level directory, we move it under html/, since the the specification is now part of the HTML Standard. Bug: 1158853 Change-Id: I008bb0b5f8c1f943849dfa5fd24cfc99a552f4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616819 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#842131}
-
Lukasz Anforowicz authored
Just as GURL::IsAboutBlank, KURL's IsAboutBlankURL and IsAboutSrcdocURL should work even in presence of query strings or ref strings. Accurately identifying about:blank URLs is required for recognizing them in a follow-up CL that might fix how the origin of about:blank URLs is inherited in Blink (e.g. https://crrev.com/c/2603230). Bug: 888079, 585649 Change-Id: Ic9828155a8a2b6072c7cf12f8d1b7a52689a0cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615581 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#842130}
-
Sebastien Lalancette authored
Bug: 1110944 Change-Id: Ie0c4809718959ca06a1eff8bc7d309644d1d98c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617580 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842129}
-
Chris Lu authored
This CL add a third "Delay Action" button above the primary action button. This will be used by the default browser fullscreen promo to experiment with a "Remind Me Later" option. iphone: https://drive.google.com/file/d/1MiEbfPkKUZ2N9CdGUVoHVENYUK9l5lJ9/view?usp=sharing ipad: https://drive.google.com/file/d/1LGd3-uSift0E2poJUPoUcLVgM_XQ_PVt/view?usp=sharing Bug: 1155778 Change-Id: I98f7ef9183dadeb806ff44a632934eece0b211fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575903 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842128}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610365490-7c6abe53577006e61aa7c1c42d7ef337c3924953.profdata to chrome-win64-master-1610376073-2cb1d075a5ed746f73a3a1ee8fa077d597a4f418.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib9589e8f0e25a9db5bfb3e1c9f8c1f8ee483c09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842127}
-
Basia Zimirska authored
The problem is that there are some discrepancies between kAcceptLanguages and kSupportedSpellCheckerLanguages for languages that there are dictionaries for. For example, before this change if a user adds "pt" to their languages in settings we don't offer to spellcheck even though we have dictionaries. Another issue that this CL solves is duplication of the languages in menu due to omitting country variants (see linked bug). Bug: 1074284 Change-Id: I3a308ea1ba17ff912d7aae87e1bd9071bf451225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606663Reviewed-by:
Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Commit-Position: refs/heads/master@{#842126}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1164521 Change-Id: I27df06bf3f4f5c2e1b55f1862eae668c6653e707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620940 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#842125}
-
Jeroen Dhollander authored
A lot of things are configured between the creation of the |AssistantManager| and the call of |AssistantManager::Start()|. Right now this is done through an initialize callback (which circumvents the Mojom API). To get rid of this initialize callback (and configure things properly through Mojom APIs), we need to separate the creation and start of |AssistantManager| in 2 separate mojom calls. This CL also renames all |ServiceController| tests to |AssistantServiceControllerTest| so we can run all assistant tests using the "Assistant*" test filter. Bug: b/176851446 Test: chromeos_unittests --gtest_filter="Assistant*" Change-Id: I37c11439446f52fcc209d0612fd73cf8b0478de0 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617119Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
David Black authored
Addresses the case where: 1. User has 3+ items in Tote 2. User batch removes all items via Files app 3. User adds back in item to Tote Previously at step 3, the Tote tray icon bounds would jump to max size on visibility change before animating back to min item bounds. Change-Id: I8f15b584d0722b2601e69f63160befe83fc644d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621974Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#842123}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/da06e8f6bdb7..ad0be281a41c 2021-01-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e9fe5946..78ea2c1b (841903:842019) 2021-01-11 danilchap@webrtc.org Use rtc::CopyOnWriteBuffer::MutableData through webrtc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1d948828fc234a129b9f7b445381553c223923a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622494Reviewed-by:
-
Wan-Teh Chang authored
The metric name in the example is "GoatType", not "Type". Change-Id: Ic6055c3b6ee095f319395e22108eb9d0e21f052d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618781Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#842121}
-
Gavin Williams authored
Use a timer for setting the scan preview aria label with scan progress updates. Bug: 1059779 Change-Id: I83d59cb8b70e2fba262d52584deb532ebc9adcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617358Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#842120}
-
Clark DuVall authored
This reverts commit a5819cfe. Reason for revert: This was temporary, canaries look stable. Original change's description: > Temporarily disable isolated splits to get canary coverage > > We are planning on running binary experiments for isolated splits > enabled/disabled on M89. I want to make sure there are no problems with > the disabled version before branch cut. I'll revert this CL after a > couple days. > > Bug: 1150162 > Change-Id: I20061a079e897058625506dab810c4584c200fec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618367 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841596} TBR=agrieve@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150162 Change-Id: I9b7dfb6851df6264e0a7cfd8d1c17a266d4cdbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621993Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842119}
-
Josip Sokcevic authored
Change-Id: Ic48fe52969335c74cef4f7df7258eb9cad556e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616523 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#842118}
-
Adam Langley authored
At several points in the past we have wanted a Finch-controllable filter. This change attempts to add a fairly generic one that would have met all the previous needs. Change-Id: Iec25677b9bca532c45844933cf7d5d0d95e00764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612051Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#842117}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fff8e7632e28..bdc7f626dbce 2021-01-11 primiano@google.com Merge "ui: Update NodeJS and Wasm toolchain" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3c1785fb63b576631198b1c9484bbde674b753c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621953Reviewed-by:
-
Tarun Bansal authored
Add skip_in_background to field trial testing config Bug: 1032153 Change-Id: Ie9fe3b94ad1b7fce3233a469a2c56ed383de0349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621888Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842115}
-
Evan Stade authored
Bug: 1158946 Change-Id: I60a2a192977bffabbac9077ff9f3e36d73589bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611228 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842114}
-
Clark DuVall authored
I needed to fix the IsolatedSplitsSynthetic trial to only log for monochrome, and thought it might be useful to have this as well. This will let us filter UMA data by the WebView APK type, and can help us answer the age old question of how many users have standalone WebView on N+. Bug: 1150162 Change-Id: I4cc97632f514b0c54b07e205c33dd1c1d3703071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618625Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842113}
-
Evan Stade authored
To do this, AddToHomescreenParams is moved to //components. TBR=dtrainor@chromium.org Bug: 1164069 Change-Id: Id84add9db5a9e55b9f494e4f0d1cac79036eef52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617202Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#842112}
-
Ulan Degenbaev authored
This adds WebMemoryAggregator::VisitWorker for handling dedicated worker. It is simpler than the frame case because dedicated workers have the same origin as their parent (frame or worker). Additionally, aggregation never starts from a dedicated worker. Bug: 1085129 Change-Id: If319fce5af3933870822f92bd6f360f524e33c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616705 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842111}
-
Mark Schillaci authored
This CL addresses a NullPointerException crash on Android. The AccessibilityTabModelAdapter was throwing an NPE during getItemId due to getId being called on a null Tab. We now check for null and return an invalid tab id rather than crash. Bug: 1164544 AX-Relnotes: N/A Change-Id: I6e19dd834271d3ba255d46d26da8284d3ce93bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618681Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#842110}
-
Yao Xiao authored
Why: This is the expected behavior. We should keep calculating and serving the floc even if sync/swaa/nac is disabled. Those bits should only affect event loggings. How: Create the FlocEventLogger class for the sync/swaa/nac permission checks and the loggings. Removed the checks in the floc_id_provider. Given that the sync service is often ready a few moments after the browser start, but the floc may already have been computed before then, for practical purposes, each logging attempt that fails the initial sync-history check will be given a second chance 10 seconds later. For sync_integration_test: Remove the feature list initialization and a test: With the new change, the 1st FLoC event logging will at least happen 10 seconds after the profile initialization, so we no longer have the previous issue that the FLoC event being logged right after sync setup. The removed test is essentially similar to the floc browsertests (e.g. FlocIdProviderWithCustomizedServicesBrowserTest. FlocIdValue_ImmediateComputeOnStartUp), so we don't need to have another test. Bug: 1160317 Change-Id: Iec357579fb179b2fdc3a327b2089c5a321d109ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597014Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#842109}
-
Jonathan Backer authored
https://bugs.chromium.org/p/chromium/issues/detail?id=1079161#c32 SkiaRenderer GL seems to be tickling a driver bug where the driver sometimes reports 32 texture units and other times 96 texture units after a context lost event. This leads to crashes in GPU process context virtualization code. Try restarting GPU process instead to see if that fixes the problem. Bug: 1079161 Change-Id: Ib6a91323b05978193fb7f6e3b26e7dbd850d0509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621873Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842108}
-
Nancy Wang authored
The parameter id of the function HandleRestoreNotificationClicked is user-after-free on builder "Linux ChromiumOS MSan Tests", because the notification is closed at the beginning of HandleRestoreNotificationClicked, which may cause `id` becomes uninitialized. Move notification_ as the class variable to hold the notitification id in the function HandleRestoreNotificationClicked to resolve the unit tests issue. And enable the disabled unit tests. BUG=1146900 BUG=1164559 Change-Id: Iabf8ad0233944cce071b3c2be1a10ca746ed2a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619409 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842107}
-
Tanmoy Mollik authored
Method OnPrimaryAccountCleared() is deprecated. This cl changes the unified_consent code to use OnPrimaryAccountChanged() instead. Bug: 1158855 Change-Id: I79f04420e957a95972651851b3dd706e7a9eaa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622373Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842106}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ccdfc9bed156..6f4e54f003dd 2021-01-11 brgoddar@microsoft.com Limit Datagrid Screen Reader Alerts to Focused Grids 2021-01-11 jacktfranklin@chromium.org [Dark mode]: generate dark styles for cmdevtools.css 2021-01-11 morlovich@chromium.org Custom UA ch editting: fix key behavior on the folder 2021-01-11 machenbach@chromium.org [build] Remove obsolete gn flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736,chromium:1162902,chromium:1164034,chromium:1164276 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iffc9be97d143af1c169691875a847018cb089016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621885Reviewed-by:
-
Trevor David Black authored
Bug: 172489285 Change-Id: I041c4722f630fa615d7727c2767f08e605032e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616980Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#842104}
-
Ziran Sun authored
This leaves flexibiity for other properties referencing corners in the future. Bug: 1155270 Change-Id: I67c7f90c1c8c67f31903a1e3455fb504db21f2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595033Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#842103}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eddc7d0df5d1..3bf3659d351a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2059458a568705e11c92c782a25e3e50b9bc0b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622273Reviewed-by:
-
Tomasz Wiszkowski authored
This change addresses the scenario where: - the user is on a website with an input field - the input field (not the Omnibox) is focused, raising keyboard, - the user next presses the overflow menu. In this situation, the keyboard should be dismissed. Bug: 1160617 Change-Id: I84716a264b20c2a57dc6c836325a6d94e14163dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613516Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#842101}
-
Abigail Klein authored
This ensures that the AnnounceTextView is purely an announcement and cannot be navigated to by a screen reader. reader. Bug: 1161047, 1055150 Change-Id: I6ca8157261b2f8fc94978121807de008d59166d4 AX-Relnotes: Announcements in Views are not navigable to by a screen Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617220Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#842100}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/183461f40237..f0cb733b1b1c 2021-01-11 johnstiles@google.com Remove redundant constantPropagate in Swizzle. 2021-01-11 robertphillips@google.com Remove DDLTarget tracking from the GrDrawingManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I5efd1b04eb908e2be0703d65f754e834a5fba76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621875Reviewed-by:
-
Sylvain Defresne authored
A single boolean was used to save whether the UI was showing incognito or regular UI, however with multi-window enabled, each window can be displaying a different UI. This global was read on launch to decide whether incognito UI should be displayed or not. If the window in the foreground when the app was terminated was showing incognito UI, but user start the app by opening a window with no incognito tab, the startup code would consider this an inconsistency, delete all incognito state and switch to regular UI. This behaviour is incorrect when multi-window is enabled and can lead to losing the incognito tabs on app startup. To fix this, convert the bool indicating whether the UI was showing incognito or regular tabs to be per-session (i.e. per window). Also in case of inconsistency (which can still happen if user quit the app while showing the incognito tab switcher after having closed the last incognito tab of the current window), do *not* clear the incognito data (it will only be cleared when the app restart after a crash). Bug: 1163505 Change-Id: I8410acf6f8feadb747d01889a2812e91d5391709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611101 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#842098}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I9fb2c28603eeb7b0c64c61154b8ef87e2cc7f25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621693Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842097}
-
Ian Elliott authored
We've seen a number of flaky failures with Windows7 FYI AMD bots lately (i.e. different tests occasionally fail once). This is taking too much Wrangler attention. This CL should quiet down the flakes. Bug: angleproject:5513 Change-Id: Ic5af13c71da76c1f5a9edb7746201559d455df23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619318Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com> Cr-Commit-Position: refs/heads/master@{#842096}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eddc7d0df5d1..3bf3659d351a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5f0cf03d1b55e98e026403e1cbabb7eedaa7da6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621876Reviewed-by:
-
David Roger authored
See discussions: 1) https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAAIzo6kto 2) https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAAHlUIHWE Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/88cd55b4bf04fb8e41c5196e0570d72599088733 Change-Id: I921bf31a5a9978c07f8110b23ab2bb4d8f996564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622313Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#842094}
-
