- 16 Dec, 2016 40 commits
-
-
lukasza authored
Before this CL, when --all switch was used, then |filenames| 1) wouldn't include any header filenames (which should get rewritten) 2) would include generated files (which shouldn't get rewritten) This would lead to incorrect filtering of edits/files that are passed to _ApplyEdits function. The new filtering behavior helps to ensure that we apply edits to header files that are only included from generated files. Doing this requires 1) running the tool on generated files (this is what --all switch accomplishes even before this CL) and 2) ensuring that edits are applied to the right files (this is what this CL does). Examples of headers that are only included from generated files can be found in https://crbug.com/643779#c11 BUG=643779 Review-Url: https://codereview.chromium.org/2583623002 Cr-Commit-Position: refs/heads/master@{#439136}
-
droger authored
BUG=674181 Review-Url: https://codereview.chromium.org/2580753005 Cr-Commit-Position: refs/heads/master@{#439135}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2580793003 Cr-Commit-Position: refs/heads/master@{#439134}
-
csashi authored
""" MasterCard recently updated their logo https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html with these guidelines https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html """ BUG=None New icons are from https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-icons Review-Url: https://codereview.chromium.org/2579623003 Cr-Commit-Position: refs/heads/master@{#439133}
-
sky authored
It was assuming there is always a root window, which isn't the case. GetRootWindow() only returns non-null when attached to a display, so if a window has a parent but isn't yet attached to a display then GetRoot returns null. BUG=674575 TEST=none R=fsamuel@chromium.org Review-Url: https://codereview.chromium.org/2580703005 Cr-Commit-Position: refs/heads/master@{#439132}
-
lizeb authored
This CL adds support for WPR and network throttling (through WPR) for testing the speculative_prefetch_predictor. The modifications are: - Generate a WPR archive in generate_database.py - Use the archive and set up throttling in prefetch_benchmark. Also adds the ability to test several configuration of the predictor in prefetch_benchmark, and make it loop. BUG=655980 Review-Url: https://codereview.chromium.org/2561353002 Cr-Commit-Position: refs/heads/master@{#439131}
-
chongz authored
This is the last sub-patch (3/3) of supporting |EditCommandSource| in |CompositeEditCommand| (https://crrev.com/2574793002). Instead of adding |EditCommandSource| to constructor, this CL: 1. Pass source to |CompositeEditCommand::apply(EditCommandSource)| 2. Pass source to various static methods of |TypingCommand| We don't have to store command source as attribute because we only need it to fire 'beforeinput' in the above locations. This approach also helped avoiding modifying all the |CompositeEditCommand| constructors. This CL shouldn't have any behavior change. To help reviewing, here is a simple doc describing the following plans: https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing BUG=673789 Review-Url: https://codereview.chromium.org/2579253002 Cr-Commit-Position: refs/heads/master@{#439130}
-
kylechar authored
There is no need to hold onto the SkBitmap object as a member variable in MusDemo. It was originally retained so that the pixel buffer didn't need to be reallocated for each frame (a copy of the pixel buffer was made when submitting the frame). However, the pixel buffer is now locked and ownership is shared with the gfx::ImageSkiaRep, requiring a new pixel buffer to be allocated for each frame regardless. Remove |bitmap_| member variable. BUG=none Review-Url: https://codereview.chromium.org/2581163003 Cr-Commit-Position: refs/heads/master@{#439129}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a95071710cf8..7a32fcc6a55e $ git log a95071710..7a32fcc6a --date=short --no-merges --format='%ad %ae %s' 2016-12-16 dtu [pinpoint] Rename change_unittest.py to change_test.py Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2582803002 Cr-Commit-Position: refs/heads/master@{#439128}
-
kylixrd authored
If a displayed modal dialog is partially or entirely off-screen, the user may be unable to interact with it or even be aware of its presence. This change ensures that the dialog is moved to the nearest display so that it is fully visible to the user. BUG=668734 Review-Url: https://codereview.chromium.org/2549543002 Cr-Commit-Position: refs/heads/master@{#439127}
-
tandrii authored
This has been superseeded by just-in-time determination based on state of gnumbd and git-numberer validation. BUG=644915 R=machenbach@chromium.org,sergiyb@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2583903002 Cr-Commit-Position: refs/heads/master@{#439126}
-
rnephew authored
This adds the ability to set --trace-output <dir> and generate a json file that can be opened in the chrome trace viewer that will display timelines of when each test is run on which testing shard. BUG=667470 Review-Url: https://codereview.chromium.org/2583613002 Cr-Commit-Position: refs/heads/master@{#439125}
-
mlippautz authored
BUG=chromium:468240 NOTRY=true Review-Url: https://codereview.chromium.org/2579043002 Cr-Commit-Position: refs/heads/master@{#439124}
-
haraken authored
When the frame is destroyed, ScreenOrientationController needs to stop updating. BUG= Review-Url: https://codereview.chromium.org/2584453005 Cr-Commit-Position: refs/heads/master@{#439123}
-
reed authored
BUG= NOTRY=True Review-Url: https://codereview.chromium.org/2583723003 Cr-Commit-Position: refs/heads/master@{#439122}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/780dad1ab946..99ad164886ba $ git log 780dad1ab..99ad16488 --date=short --no-merges --format='%ad %ae %s' 2016-12-16 bsalomon Rename batch->op and sk_sp in instanced rendering 2016-12-16 bsalomon Rename batch->op and sk_sp for all remaining path renderer classes. 2016-12-15 msarett Fix gray png BRD tests 2016-12-16 msarett Mark CG and WIC images as srgb 2016-12-16 scroggo Revert "Remove all KTX support" 2016-12-16 mtklein Restore fetch-gn instructions. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2586473002 Cr-Commit-Position: refs/heads/master@{#439121}
-
sdefresne authored
BUG=666375 Review-Url: https://codereview.chromium.org/2582033002 Cr-Commit-Position: refs/heads/master@{#439120}
-
jam authored
The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 Review-Url: https://codereview.chromium.org/2581833002 Cr-Commit-Position: refs/heads/master@{#439119}
-
guidou authored
The test flakes on that platform. BUG=674782 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2577123005 Cr-Commit-Position: refs/heads/master@{#439118}
-
guidou authored
BUG=674858 TBR=junov@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2580013002 Cr-Commit-Position: refs/heads/master@{#439117}
-
dtseng authored
Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG=668775 Review-Url: https://codereview.chromium.org/2575233002 Cr-Commit-Position: refs/heads/master@{#439116}
-
rune authored
With active stylesheets being applied asynchronously, we no longer need to avoid the synchronous stylesheet update during link processing. We can just mark the treeScope dirty to trigger the preferred set to be updated as part of updateActiveStyleSheets(). R=meade@chromium.org BUG=567021 Review-Url: https://codereview.chromium.org/2552353003 Cr-Commit-Position: refs/heads/master@{#439115}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/8dca466..5ea8737 $ git log 8dca466..5ea8737 --date=short --no-merges --format=%ad %ae %s 2016-12-16 kthelgason@webrtc.org Fix wrong log message. 2016-12-16 danilchap@webrtc.org Use NtpTime in RTCPSender::RtcpContext instead of pair of uint32_t 2016-12-16 terelius@webrtc.org Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. 2016-12-16 kthelgason@webrtc.org Move ios_helpers to sdk folder 2016-12-16 mflodman@webrtc.org Adding Åsa and Erik as video owners. 2016-12-16 stefan@webrtc.org Don't report packets with id -1 to the transport feedback adapter as they provide no value. 2016-12-16 kthelgason@webrtc.org Initialize packetization mode in VideoToolbox 2016-12-15 tkchin@webrtc.org iOS: Add trendline filter to field trials. 2016-12-15 sergeyu@chromium.org Fix integer overflow in ProbeController. 2016-12-15 terelius@webrtc.org Avoid precision loss in TrendlineEstimator by passing the arrival time as an int64_t instead of a double. 2016-12-15 ossu@webrtc.org Add ossu@ to OWNERS of audio/ and modules/audio_coding/ 2016-12-15 mflodman@webrtc.org Fixing loopback video test by reconfiguring the encoder to correct size. 2016-12-15 philipel@webrtc.org Create VideoReceiver with external VCMTiming object. 2016-12-15 henrika@webrtc.org Improves release of allocated audio resources on Android. 2016-12-15 terelius@webrtc.org Revert of Avoid precision loss in TrendlineEstimator from int64_t -> double conversion (patchset #7 id:120001 of https://codereview.webrtc.org/2577463002/ ) 2016-12-15 terelius@webrtc.org Revert of Avoid precision loss in MedianSlopeEstimator from int64_t -> double conversion (patchset #3 id:40001 of https://codereview.webrtc.org/2578543002/ ) 2016-12-15 terelius@webrtc.org Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. 2016-12-15 nisse@webrtc.org Reland of Delete VideoFrame default constructor, and IsZeroSize method. (patchset #1 id:1 of https://codereview.webrtc.org/2574123002/ ) 2016-12-15 michaelt@webrtc.org Wire-up audio BWE with overhead. 2016-12-15 terelius@webrtc.org Avoid precision loss in TrendlineEstimator by passing the arrival time as an int64_t instead of a double. 2016-12-15 hbos@webrtc.org Rename RTCOutboundRTPStreamStats *_rtt members to *_round_trip_time. 2016-12-15 nisse@webrtc.org Revert of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2581663002/ ) 2016-12-15 hbos@webrtc.org RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs. 2016-12-15 nisse@webrtc.org Reland of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2576673002/ ) 2016-12-15 kjellander@webrtc.org MB: Enable memcheck for the linux_memcheck trybot. 2016-12-15 hbos@webrtc.org RTCOutboundRTPStreamStats.roundTripTime: Only report non-negative values. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2585763002 Cr-Commit-Position: refs/heads/master@{#439114}
-
estade authored
Remove said obsolete resources. BUG=522168 Review-Url: https://codereview.chromium.org/2577913004 Cr-Commit-Position: refs/heads/master@{#439113}
-
skyostil authored
To support the --headless flag, include resources needed by the headless library in Chrome's resources.pak. The size of these resources is about 1.7 KiB. This patch also makes the headless library fall back to loading resources.pak if headless_lib.pak isn't found. The reason is that the former is shipped with Chrome while the latter is used in purely headless builds. BUG=612904 Review-Url: https://codereview.chromium.org/2576413002 Cr-Commit-Position: refs/heads/master@{#439112}
-
lunalu authored
NavigatorLanguage::language() returns defaultLanguage() which either preferredLanguagesOverride()[0] if preferredLanguagesOverride() is not empty or platformLanguage() which will never return null; therefore, the change is safe. Added web platform test for InputEvent BUG=662005 Review-Url: https://codereview.chromium.org/2570203004 Cr-Commit-Position: refs/heads/master@{#439111}
-
dtseng authored
This cl adds an option/preference for a user to trigger automatic read/continuous read on load. Defaults to off. BUG=672938 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2577473003 Cr-Commit-Position: refs/heads/master@{#439110}
-
zqzhang authored
This CL fixes an issue which PLAY_PAUSE is not removed before computing buttons that need to be shown in the notification. As PLAY_PAUSE action is going to be removed shortly, no bug is filed. BUG=None Review-Url: https://codereview.chromium.org/2577063003 Cr-Commit-Position: refs/heads/master@{#439109}
-
estevenson authored
Calls to GMS can be extremely slow after updating GMS, which can result in an ANR error since we currently make calls to GMS on the UI thread. This CL introduces a ProgressDialog that is shown while accounts are fetched in the background, preventing ANR errors while letting the user know that we're still waiting for GMS. BUG=669522 Review-Url: https://codereview.chromium.org/2551063003 Cr-Commit-Position: refs/heads/master@{#439108}
-
jvanverth authored
BUG=673752 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2579053002 Cr-Commit-Position: refs/heads/master@{#439107}
-
tdresser authored
Behind the MainThreadBusyScrollIntervention content feature. Uses the estimated input latency (https://docs.google.com/document/d/1b9slyaB9yho91YTOkAQfpCdULFkZM9LqsipcX3t7He8/) to determine when the main thread is unresponsive. When the main thread is unresponsive, forces events to be non-blocking. To be enabled via Finch. TEST=MainThreadEventQueueTest.ForcedNonBlockingDueToUnresponsiveMainThread, RenderWidgetUnittest.RenderWidgetInputEventUmaMetrics QueueingTimeEstimatorTest.EstimateQueueingTimeDuringSingleLongTaskIncompleteWindow QueueingTimeEstimatorTest.EstimateQueueingTimeDuringSingleLongTaskExceedingWindow BUG=599609 Review-Url: https://codereview.chromium.org/2273703002 Cr-Commit-Position: refs/heads/master@{#439106}
-
Emily Hanley authored
BUG=chromium:674907 R=sullivan@chromium.org Review-Url: https://codereview.chromium.org/2579043003 . Cr-Commit-Position: refs/heads/master@{#439105}
-
estade authored
And move one to the one webui surface it's used for. BUG=522168 TBR=oshima@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2576233005 Cr-Commit-Position: refs/heads/master@{#439104}
-
mathp authored
Revert of Cleanup DataReductionProxy (DRP) Brotli code (patchset #3 id:140001 of https://codereview.chromium.org/2571993002/ ) Reason for revert: Reverting because it's hitting a DCHECK on top of tree (android). It's going to make it hard for people to work. Filed a bug at https://bugs.chromium.org/p/chromium/issues/detail?id=674918 Original issue's description: > Cleanup DataReductionProxy (DRP) Brotli code > > Add thread checkers to request options class. > > Force the generation of the chrome-proxy header, and use it later when > generating the MockWrite for the sockets in tests. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > BUG=634061 > > Committed: https://crrev.com/1d20801e2b126cfec1d66cb78c05082d0f90b3ba > Cr-Commit-Position: refs/heads/master@{#438978} TBR=ryansturm@chromium.org,tbansal@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634061 Review-Url: https://codereview.chromium.org/2577413002 Cr-Commit-Position: refs/heads/master@{#439103}
-
rune authored
Active stylesheet update is now asynchronous and handled from StyleEngine::updateActiveStyleSheets(). R=meade@chromium.org BUG=567021 Review-Url: https://codereview.chromium.org/2557773004 Cr-Commit-Position: refs/heads/master@{#439102}
-
beaufort.francois authored
BUG=674540 Review-Url: https://codereview.chromium.org/2582543002 Cr-Commit-Position: refs/heads/master@{#439101}
-
jinho.bang authored
Write PaymentAppDatabase class and then just move most of logics to access database from PaymentAppManager to the new class. The class is providing APIs to read/write payment app related data(e.g. manifest and associated service worker). It can be shared between payment_app_manager.cc and payment_app_context.cc. The payment_app_manager.cc contains a actual implementation of the PaymentAppManager interface[1] used on the page or worker. Also, the payment_app_context.cc can be used to query all manifests data. in order to update payment request UI in Chrome layer. [1] https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manager BUG=661608 Review-Url: https://codereview.chromium.org/2572183002 Cr-Commit-Position: refs/heads/master@{#439100}
-
guidou authored
The test has been flaking on at least one Mac bot. BUG=674904 TBR=lazyboy@chromium.org Review-Url: https://codereview.chromium.org/2582023002 Cr-Commit-Position: refs/heads/master@{#439099}
-
jdoerrie authored
Similarly as done for Desktop this change adds an information tooltip for PSL matches. This tooltip shows the origin URL when tapped on. BUG=666340 R=bauerb@chromium.org,vasilii@chromium.org CC=vabr@chromium.org,melandory@chromium.org Review-Url: https://codereview.chromium.org/2541693004 Cr-Commit-Position: refs/heads/master@{#439098}
-
rune authored
R=meade@chromium.org BUG=567021 Review-Url: https://codereview.chromium.org/2546343006 Cr-Commit-Position: refs/heads/master@{#439097}
-