- 05 Mar, 2020 40 commits
-
-
Wenyu Fu authored
Seems every RadioButtonWithDescription has the xml attribute of android:background="?attr/selectalbeItemBackground". Adding this attributed into widget constructor for simplicity. Bug: 1048863 Change-Id: Ia335afe12cd5130bdddccf0e083db1b35e28a572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067279 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#747090}
-
Alex Cooper authored
Currently, SessionMetricsHelper tracks both WebXr and VRB state. WebXr state is triggered from VrServiceImpl as the "source of truth" that a VR Session has started, while various vr_shell classes are the source of truth for whether or not the user is in the VR Browser. In order to move the VRService out of chrome/ its dependencies also need to be able to be moved out of chrome. This includes the WebXr metrics portions of SessionMetricsHelper. Given the dwindling usage of the VR Browser, it was decided to remove metrics that were specific to it. This allows for breaking any dependencies on SessionMetricsHelper except to log WebXr metrics. Much of SessionMetricsHelper's complexity stems from the fact that it tracked whether the browser was in VRB, WebXr, or Fullscreen (VRB). However, since we no longer need to differentiate between these modes, and can simply track WebXr, the class was dramatically simplified. RecordImmersiveSessionStart and RecordImmersiveSessionStop become the only methods that actually drive the "state" of the core metrics, with the video metrics aided by their listeners. The class also still listens to navigation events as an extra way to ensure that all sessions are cleaned up appropriately. The following changes were also made: * SessionTracker class split into its own file * Given that the only "SessionMetricsHelperTest" was actually a SessionTracker test, the UT was also renamed. * WebXrSessionTracker split into its own file * SessionTimer was split into its own file * Dependency on explicit WebXrSessionTracker class was abstracted from callers of SessionMetricsHelper * This includes abstracting the logging of initial session data. * Update logging levels that were overly verbose and impede validation. BUG: 1031622,1021314 Change-Id: I2c52189ccec978f378df384d7342524af4680b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076431 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#747089}
-
Eric Willigers authored
The tests in ShelfWebAppBrowserTest use no extensions APIs to create web apps. Note that a number of these tests do not yet pass when the flag DesktopPWAsWithoutExtensions is enabled. TabbedHostedAndBookmarkApps and WindowedHostedAndBookmarkApps have not yet been ported. Bug: 1054116 Change-Id: I3d806138bebdaa672b67fa4c1772daf7992a75f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082425Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#747088}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/628f3e70ee01..f1d78a6c68da git log 628f3e70ee01..f1d78a6c68da --date=short --first-parent --format='%ad %ae %s' 2020-03-05 mtklein@google.com add an ulp of error on the clamp asserts 2020-03-04 mtklein@google.com better SKVM_JIT_STATS output 2020-03-04 mtklein@google.com skip dump checks on machines w/o FMAs 2020-03-04 reed@google.com detect when the localmatrix forces us into a perspective stage 2020-03-04 egdaniel@google.com Move GrGpuResource GrSurface and GrTexture into src. 2020-03-04 mtklein@google.com async llvm compile, take 2 2020-03-04 mtklein@google.com turn off LLVM FMA discovery 2020-03-04 mtklein@google.com do our own fma discovery 2020-03-04 mtklein@google.com get rid of troublesome Op::round Created with: gclient setdep -r src/third_party/skia@f1d78a6c68da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057418 Tbr: herb@google.com Change-Id: I89fb9043914c2f3d7864f1cd57f6844e6f9ecaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088792Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747087}
-
Lukasz Anforowicz authored
Bug: 1057599 Change-Id: I31661c23763cb9861ec883b203a022c9e2d324da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085836Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#747086}
-
Luciano Pacheco authored
For Grid View, add titles "Folders" and "Files" for the respective sections. Add test to check that the title is available. Add translations and their screenshots. Test: browser_tests --gtest_filter="*showGridViewTitles*" Bug: 992822 Change-Id: Ic71d31891e2d8575920fa815b0a9df5e49bc5ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087231 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#747085}
-
Alex Danilo authored
Bug: 1035691 Change-Id: I23db4dc4ad0d98e86bb4887842ed520a884f096e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087494Reviewed-by:
-
Danan S authored
This dialog's purpose is to prompt a parent of a child-type user to enter their credentials to approve an action. This dialog will also allow you to pass in an extension::Extension, whose details (i.e. permissions, title) will be displayed above the credential entry form. This CL is inspired by the functionality of ExtensionInstallPrompt, but simplifies the approach used by that code. Bug: 957832 Change-Id: I3a9395f56505b43cd5c8f8c269b0b19c99ce6379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972417 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747083}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I45628359441887e4843dc01e2f08410a708142d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088802Reviewed-by:
-
Kent Tamura authored
This CL also moves: - ObserveTreeMutation() - UnobserveTreeMutation() - DidMutateSubtree() - popup_updater_ This CL has no behavior changes. Bug: 1052232 Change-Id: I381d18022b5b08e04214a9d2e163e1a33b929f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087491Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#747081}
-
Sinan Sahin authored
This CL implements the color and text transition animations that run when showing or hiding the status indicator. Show: 1- Transition the status bar color. 2- Wait for the browser controls animation in cc to finish. 3- Fade in text. Hide: 1- Transition the status bar and the indicator color. 2- Wait 2 seconds. 3- Fade out text, and transition the status bar and indicator color back to the original status bar color. 4- Let the browser controls hide animation run in cc. Bug: 989148 Change-Id: If19a51e6c5091436d78e34ef50f11ffa0118ee0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067095 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/43d8e93fa7bf..14e5f0b2cb03 git log 43d8e93fa7bf..14e5f0b2cb03 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 ouj@fb.com Update RTC_CHECK and RTC_LOG macros so they work when called from xxxxx::rtc namespaces Created with: gclient setdep -r src/third_party/webrtc@14e5f0b2cb03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7779442dbd498ce63bc992dcbf2ff31889ef034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088469Reviewed-by:
-
Lijin Shen authored
There exists some unknown issue on the measurement of a text view with a compound drawable. Using a linear layout containing an imageview and a textview inside can avoid this issue. Bug: 1053448 Change-Id: Ibdcd220e0eba7218c1d500d870da17d37c7e767c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083729 Commit-Queue: Lijin Shen <lazzzis@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
We already filtered out writable directories from the list of readable directories in the usage indicator bubble, this CL extends that to also apply to files. This way the same file will only show up once in the usage indicator bubble. Bug: 992158 Change-Id: I04c4a45c41701d9291f0fee3edd4cd9797f6ac5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088675Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747077}
-
Joshua Bell authored
The DirectoryReader readEntries() call fails if invoked a second time while there's an outstanding request. But the failure was being reported on the first call's callback, which is non-inuitive. Fix by reordering the duplicate call logic and not relying on the reader's OnError handler. Manual Test: entries-api/filesystemdirectoryreader-manual.html Bug: 1054981 Change-Id: Ieaaea993c48af5d9c1fabe4ec509afe3d22b3477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069017Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#747076}
-
Will Cassella authored
Previously, the way time progression was simulated for FakeWebMediaPlayer in tests was to increment the current time by a whole second every time a call to |FakeWebMediaPlayer::CurrentTime| was made. This is kind of strange, since it relies heavily on the implementation of |HTMLMediaElement| to not call |CurrentTime| more than once per update. Additionally, it led to scenarios where time in FakeWebMediaPlayer would progress more quickly than test time (such as in HTMLMediaElementWithMockSchedulerTest.PeriodicTimeupdateAfterSeek). The new mechanism uses a recurring delayed task to increment time, and also calls |Microtask::PerformCheckpoint| in order to update |HTMLMediaElement::official_playback_position_|. Previously, tests would fail unless they were specifically designed to avoid code paths that rely on that value of |HTMLMediaElement::official_playback_position_| (which ideally shouldn't be necessary). This CL resolves all of the above issues, allowing some tests to be simplified (such as HTMLMediaElementWithMockSchedulerTest.CueEnterExitEventLatency, which is implemented in a pending CL: 2008079). Change-Id: Ia0392a77a013b33a492f9a29402605ceb7f147ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048415 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#747075}
-
Artem Bolgar authored
WebXR is using so called 'opaque' framebuffer, i.e. all attachments are made on GL level and not visible by WebGL. When 'enable(gl.STENICL_TEST)' is called, the on WebGL context checks the WebGLFramebuffer object for presence of the STENCIL attachment and fails (because the opaque framebuffer doesn't have those). I am adding an additional state to WebGLFramebuffer to track if the opaque framebuffer has the stencil buffer or not. Note, I can't check if the actual GL framebuffer object has the corresponding attachment, since the framebuffer might not be bound (yet). The repro case: https://artyom17.github.io/webxr-samples/tests/stencil-cube-sea.html In 2D mode you'll see that the green triangle has a cutout, while in VR mode it doesn't. This is because gl.enable(gl.STENCIL_TEST) is failing. Bug: 1057571 Change-Id: I8b94a60de8c14ac7e435f17e57523ec430f22fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084067Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Artem Bolgar <artyom@fb.com> Cr-Commit-Position: refs/heads/master@{#747074}
-
Simon Que authored
These are no longer necessary now that we have migrated most builders in Chromium to Goma RBE Prod. Bug: 1058219 Change-Id: I8e09feef1fefdce282ec6af37cec62fe77ca85c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086373Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#747073}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/16f581398d7d..43c76d116441 git log 16f581398d7d..43c76d116441 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 bsheedy@chromium.org [Telemetry] Cleanup unsymbolized minidumps Created with: gclient setdep -r src/third_party/catapult@43c76d116441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056235 Tbr: wenbinzhang@google.com Change-Id: I721710c50f06de7cf32331a3216c8bbcec720e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088512Reviewed-by:
-
Hiroki Sato authored
Sometimes Android sends a focus event to non-important node, which makes ChromeVox focus gets lost. This CL changes AXTreeSource to adjust focused node to be on an important node. Bug: b/148356932 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open PlayStore, press install button of an app with in-purchase when touch mode is off. Ensure focus isn't lost. Change-Id: Ic19796d7b0d7abbeb1ff7a0e72ef3770346b1de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086462Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#747071}
-
Zhuoyu Qian authored
This CL update the functions {Notify|On}{Granted|Revoked} of SpecialStoragePolicy to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: Ifd2ba2c513e866ff3b1f5857b95fa67a42a77d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086354Reviewed-by:Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747070}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9459bae14b65..e682bc57e190 git log 9459bae14b65..e682bc57e190 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 cnorthrop@google.com Capture/Replay: Add Sampler Object support to mid-execution capture 2020-03-04 ianelliott@google.com Vulkan: Suppress some flaky tests for Intel Linux driver Created with: gclient setdep -r src/third_party/angle@e682bc57e190 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Idcd207382033f687a3625733208127d20a4469d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088467Reviewed-by:
-
Chris Hall authored
R=aboxhall,dmazzoni Bug: 889370 Change-Id: I1ec73c67ae4780fb33ee3c9899aeeaad0a2d67c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044257 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747068}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ef887c89d5c..986058e2b8a4 Created with: gclient setdep -r src-internal@986058e2b8a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058522 Tbr: jbudorick@google.com Change-Id: Icee85589dcbcc4ae683cec6f788c830ec157ef47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088464Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747067}
-
Wenyu Fu authored
Remove as expired and released to everywhere :) Bug: 945545 Change-Id: I8a4d205049e2846a105151ff4222c8a31f7e6f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067537Reviewed-by:
-
Robert Liao authored
USE_COLOR_PIPELINE is no longer referenced. BUG=1057239 TBR=sky@chromium.org Flag removal. Change-Id: I843d41bee9152dd0bb464e22ffcf5e1bd8f03375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088674 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#747065}
-
sauski authored
During sync setup the toggle which controls chrome sign in should be disabled in an on state, signifying to the user that this control cannot be changed during sync setup. Previously this behaviour was tested manually. This CL extends the existing browser_test to confirm this behaviour. Bug: 1043948 Change-Id: Idd54b3ad0fd83e70b7ba356aa11dae66fdb27e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088372Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#747064}
-
Natasha Lee authored
Dawn should respect the SharedImage texture clear status. Also uses new wrapping API that takes in the ExternalImageDescriptors Bug: chromium:1036080 Change-Id: Ibe5f8f9e837e6fd9d5af19ff8a9d83823420b9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085160 Commit-Queue: Natasha Lee <natlee@microsoft.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#747063}
-
Marijn Kruisselbrink authored
IndexedDB assumes it can non-destructively deserialize a SerializedScriptValue, however our implementation for deserializing native file system handles actually modified the SSV in a way that violated that assumption. This fixes this by cloning the handles in the SSV rather than consuming them. Bug: 1058419 Change-Id: I11ddfef757849941cc26e920eadb9022f7e138a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088218Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747062}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1a83da1f41e9..83bc671bd217 git log 1a83da1f41e9..83bc671bd217 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-03-04 ehmaldonado@google.com git-map-branches: Fix Python 3 errors. 2020-03-04 ehmaldonado@google.com git-cl: Use open instead of file. Created with: gclient setdep -r src/third_party/depot_tools@83bc671bd217 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1058315 Tbr: agable@chromium.org Change-Id: I1c497c9866b4de3428e312ddda5e376c9f0e8752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088463Reviewed-by:
-
Akihiro Ota authored
This change updates the style for tables in the menus to ensure they take up the most width as possible. This implicitly fixes an issue where the 'no items' menu item was smaller than it should have been, which was throwing off the active item highlight. Change-Id: Iba446383302b9af217b070ae695d4701eaae7d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088509 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da29ae6f..d4ed59c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I15aca0551b0ca50a2f40561e12ee285e1e144d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088691Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747059}
-
Yue Zhang authored
http://crrev.com/c/1934832 introduces the flag check for TabGroupsContinuation in isGridTabSwitcherEnabled() which could happen before native is started. This means that we need to cache the TabGroupsContinuation flag as well. This CL fixes this issue and fixes related tests. Bug: 1057586 Change-Id: I4edaca4c202bdd19d2da04a5224d727100673947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085601 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#747058}
-
David Tseng authored
See go/unified-accessibility-component-extensions for additional details. This creates a new suite, AccessibilityExtension*.*, for common tests for accessibility extensions. Test: browser_tests --gtest_filter=AccessibilityExtension*.* Change-Id: I578068985da3793b2bf4ce1c795a4a016b9f4c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076420 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#747057}
-
Peter Kasting authored
A better fix would require rearchitecting that is beyond me at the moment. Bug: none Change-Id: I85ac54cd1cd031035bbe69cc596fc63bf59c5e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071384 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
This reverts commit ae3270a7. Reason for revert: Breaks compile on Android Release (Nexus 5X) Original change's description: > Decompose some Blink public mojom targets > > This picks some low-hanging fruit in the effort to decompose Blink mojom > into smaller targets. > > Bug: 1058621 > Change-Id: Iaf1a8efffa43f64ea7e618555262b929235ca2eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088677 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#747044} TBR=rockot@google.com,haraken@chromium.org Change-Id: Ie248057ff8168c230b347c2eeeb8ba3c8a520d3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088646Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for devices page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I903af5b573f9773edefba354a82b93c826c2de11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067390 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#747054}
-
Yao Xiao authored
It's suspected that there could be another request coming to the completion callback, between the final navigation request and the final assertion. Checking the URL in the completion callback to make sure we are checking the cache status of the navigation request. Bug: 1024033 Change-Id: I200f5c44ba72e6abcff7468f0e037a97cdf4fc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087736Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#747053}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/783d9f6c614f..6ffd816ce45b git log 783d9f6c614f..6ffd816ce45b --date=short --first-parent --format='%ad %ae %s' 2020-03-04 rwkeane@google.com mDNS: MdnsQuierier Refactor Created with: gclient setdep -r src/third_party/openscreen/src@6ffd816ce45b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Idb4106f1b942130ec822e341f4edb689004e15d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088465Reviewed-by:
-
Dale Curtis authored
This reverts commit 2f702ab1. Reason for revert: https://crbug.com/1058627 https://crbug.com/1058583 Original change's description: > Enable H.264 hardware MFT encoder on Windows > > Currently Microsoft H.264 encoder MFT is always used as WebRTC external > encoder without hardware acceleration. This change enables H.264 > hardware MFT encoder on Windows. > > Bug: 982799 > Change-Id: Ia33812508034daa99dd3dc1fb64b83cb1d7c8465 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777521 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Tommi <tommi@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745539} TBR=tommi@chromium.org,dalecurtis@chromium.org,sprang@chromium.org,chunbo.hua@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982799 Change-Id: Iab66c1936f27901889e371901642b72f80eff733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088733Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747051}
-
