- 03 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f55b6a510625..b5f346a1b0b4 git log f55b6a510625..b5f346a1b0b4 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@b5f346a1b0b4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2a1b65d4316c68910792527d9e87e5a73fb8dd9b Reviewed-on: https://chromium-review.googlesource.com/c/1394363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619593}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic4422602a4dab51f54a2d1a87fdcd827cc38d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1394367Reviewed-by:
-
Darwin Huang authored
Bug 369621 originally led to this check being introduced via https://codereview.chromium.org/289573002/patch/40001/50002, but after https://crrev.com/c/1345809, I'm not sure that it's still necessary. This change succeeds when tested against the "minimized test case" provided in crbug.com/369621 's description, but I'm unsure how to make the minimized test case fail, so this doesn't prove that the change would succeed against the fuzzer's test case (which originally filed the bug). As I'm unable to view the relevant fuzzer test case, (see crbug.com/918705), I don't know exactly what may have caused the fuzzer to fail. Therefore, I've added a CHECK for the time being, so that we will be notified in canary if my assumption was incorrect. Bug: 369621 Change-Id: Ie9b47a4b38ba1ed47624de776015728e541d27f7 Reviewed-on: https://chromium-review.googlesource.com/c/1393436Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#619591}
-
Zhongyi Shi authored
Use PendingStreams to buffer incoming streams. Behavior changes protected by QUIC version 99 Allow QuicSession to buffer frames for incoming streams in a PendingStream until the first byte arrives, if ShouldBufferIncomingStream() returns true. Change QuicSpdySession to return true for v99 unidirectional streams. Merge internal change: 226538637 https://chromium-review.googlesource.com/c/chromium/src/+/1394084 Changes how QUIC connection IDs are created. Seventh step towards variable length QUIC connection IDs. This CL has more of the codebase treat QUIC connection IDs as opaque bags of bytes instead of uint64_t's. The change is protected by GFE restart flags quic_variable_length_connection_ids_(client|server). This CL also removes the enabling_blocked_by on quic_restart_flag_quic_connection_ids_network_byte_order. Merge internal change: 226428581 https://chromium-review.googlesource.com/c/chromium/src/+/1394083 In QUIC v99, client closes connection if it tries to create a server initiated bidirectional stream. Merge internal change: 226397697 https://chromium-review.googlesource.com/c/chromium/src/+/1393784 Add QpackHeaderTable::inserted_entry_count(). Turns out this quantity is needed for relative indexing on the encoder stream, not the dropped entry count. See https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.3.2.5. Merge internal change: 226352231 https://chromium-review.googlesource.com/c/chromium/src/+/1393342 Fix ServerSendsVersionNegotiation in http end_to_end_test In tests with the client supporting all versions (from a bucket) and the server supporting all possible versions, the client's choice of version can be one that the server also supports, but not be the head of the list. The current implementation of ServerSendsVersionNegotiation would return true in this case, even though the server won't send version negotiation. (This currently isn't an issue because of which tests are run with TLS enabled and how the buckets are set up, but it will be an issue when there are more version buckets added in the CRYPTO frame CL.) Merge internal change: 226246369 https://chromium-review.googlesource.com/c/chromium/src/+/1393673 Change header type byte in v99 to meet draft 17 https://quicwg.org/base-drafts/draft-ietf-quic-transport.html Merge internal change: 226235106 https://chromium-review.googlesource.com/c/chromium/src/+/1393672 Modify CheckMultiPathResponse to use a client_framer to validate path responses. Merge internal change: 226227650 https://chromium-review.googlesource.com/c/chromium/src/+/1393341 Add two DCHECKs to TestHeadersHandler::ReleaseHeaderList(). Because belts and suspenders. Merge internal change: 226211897 https://chromium-review.googlesource.com/c/chromium/src/+/1393377 Change flag count 'quic_monotonic_epoll_clock' to only increment when time goes backwards. Merge internal change: 226196406 https://chromium-review.googlesource.com/c/chromium/src/+/1393663 Make ReadFileContents take |filename| argument as QuicStringPiece. Merge internal change: 226192259 https://chromium-review.googlesource.com/c/chromium/src/+/1393462 Signal error in QpackProgressiveDecoder if header data prefix is incomplete. Every header block must have a prefix that communicates Largest Reference and Delta Base Index. Make it an error if header block data is terminated without a complete prefix. Merge internal change: 226190644 https://chromium-review.googlesource.com/c/chromium/src/+/1393550 Change behavior of empty QUIC connection IDs. Empty connection IDs (created using either QuicConnectionId() (the default constructor) or EmptyQuicConnectionId()) now have length zero instead of 8. QuicConnectionIdFromUInt64(0) is no longer considered empty. QuicConnectionIdIsEmpty() has been removed. Some test code is changed from EmptyConnectionId() to TestConnectionId() because the code it exercises expects 8-byte connection IDs. Merge internal change: 226099591 https://chromium-review.googlesource.com/c/chromium/src/+/1393549 Adopt QuicConnectionId::ToString(). Switches the parts of the code that need a string representation of a connection ID away from the hop through a uint64_t. Use QuicConnectionId::ToString() to stringify QUIC connection IDs as hex strings instead of decimal strings. Merge internal change: 226060328 https://chromium-review.googlesource.com/c/chromium/src/+/1393525 Change server_address/client_address to self_address/peer_address in ProcessPacketInterface::ProcessPacket and all override methods. Merge internal change: 225995694 https://chromium-review.googlesource.com/c/chromium/src/+/1393446 Fix Quic_Frame.cc output to use correct frame type for APPLICATION_CLOSE frame Quic_frame.cc attempted to output a CONNECTION_CLOSE frame when when the frame was, in fact, an APPLICATION_CLOSE. This CL corrects that. N/A - these frames exist only in version 99 Merge internal change: 225979605 https://chromium-review.googlesource.com/c/chromium/src/+/1393445 Add default virtual destructor for every derived class in QPACK. Merge internal change: 225925387 https://chromium-review.googlesource.com/c/chromium/src/+/1393434 Add stream_id to progressive encoder and decoder. This will be necessary for the encoder to keep track of references to dynamic entries by stream id, and for the decoder so that a Header Acknowledgement instruction (which contains the stream id) can be sent when decoding is complete. Also use the (currently incorrectly defined 32-bit, soon-to-be-64 bit) QuicStreamId type instead of uint64_t for stream IDs. Merge internal change: 225917487 https://chromium-review.googlesource.com/c/chromium/src/+/1393433 Add Header Data Prefix to Qpack{En,De}coder. Encoder does not emit dynamic entries yet, so Largest Reference and Base Index are always zero. Decoder does not decode dynamic entries yet, but at least records Largest Reference and Base Index. Merge internal change: 225908419 https://chromium-review.googlesource.com/c/chromium/src/+/1393334 Add Header Data Prefix instruction and necessary fields. Add support for second varint in QpackInstructoin{En,De}coder. Also rename static bit to S bit, because in the Header Data Prefix it is a Sign. Merge internal change: 225895953 https://chromium-review.googlesource.com/c/chromium/src/+/1392366 Sixth step towards variable length QUIC connection IDs. This CL creates QuicUtils::CreateRandomConnectionId() and adopts it from inside //third_party/quic/. There will be followup CLs to adopt it from our clients, to facilitate our effort of moving them away from QuicConnectionIdFromUInt64(). Merge internal change: 225884942 https://chromium-review.googlesource.com/c/chromium/src/+/1392362 Add QPACK dynamic table.(Prototype code not used in production yet.) Implement dynamic table with synchronous lookup only. The ability to request an entry that has not been added to the table yet and call back with the result later will be added in a future CL. However, as the decoder can request that the encoder never refers to an unacknowledged entry by setting SETTINGS_QPACK_BLOCKED_STREAMS to zero (default value), this functionality will be enough for a compliant (though not maximally efficient) decoder. This CL already uses the nomenclature "dynamic table capacity" and "maximum dynamic table capacity" proposed at https://github.com/quicwg/base-drafts/pull/2115#issuecomment-446796679 which has not been merged into the spec yet. Merge internal change: 225870655 https://chromium-review.googlesource.com/c/chromium/src/+/1392329 Split AppendIetfTypeByte and ProcessIetfTypeByte out from AppendIetfPacketHeader and ProcessIetfPacketHeader. Refactoring only. No functional change expected. Merge internal change: 225827558 https://chromium-review.googlesource.com/c/chromium/src/+/1392359 Change server_address/client_address to self_address/peer_address in buffered packet store. (n/a) Rename only, not protected. Merge internal change: 225817243 https://chromium-review.googlesource.com/c/chromium/src/+/1392177 Change-Id: I073e223e92314ac7fdb69a15098e63ac52855f7c Reviewed-on: https://chromium-review.googlesource.com/c/1394143 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#619590}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48bbc53ea4d0..904bb9185767 git log 48bbc53ea4d0..904bb9185767 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 jmadill@chromium.org Rename constants in blocklayout.h. Created with: gclient setdep -r src/third_party/angle@904bb9185767 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ibde0902fa4e4f6713dda961757707a1cfd8b60d6 Reviewed-on: https://chromium-review.googlesource.com/c/1393923Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e413dae8840a..96345a23dfa9 git log e413dae8840a..96345a23dfa9 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 reed@google.com pass font's explicitly, instead of relying on SkFont::LEGACY_ExtractFromPaint Created with: gclient setdep -r src/third_party/skia@96345a23dfa9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ie129cfb1a5a7e68ef6beb605f0718e9615ffcf43 Reviewed-on: https://chromium-review.googlesource.com/c/1394364Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/479562cc0b31..4b6f54f365ea Created with: gclient setdep -r src-internal@4b6f54f365ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibf2916990cbf6faa6981cd6b29f6acfe849f9b94 Reviewed-on: https://chromium-review.googlesource.com/c/1394227Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a6ba1795b7bc..b7b477b1120e git log a6ba1795b7bc..b7b477b1120e --date=short --no-merges --format='%ad %ae %s' 2019-01-03 eseckler@google.com Merge "service: Flush file descriptor when disabling tracing" Created with: gclient setdep -r src/third_party/perfetto@b7b477b1120e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib10240243f290df678069eb5de1b4099419e00cb Reviewed-on: https://chromium-review.googlesource.com/c/1394204Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed72ba44. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: emircan@chromium.org: external/wpt/screen-capture hbos@chromium.org, hta@chromium.org: external/wpt/webrtc kojii@chromium.org: external/wpt/css/CSS2/text external/wpt/css/css-text/overflow-wrap kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 mstensho@chromium.org: external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I118d3ec3bfdb8a5f0fac318debd582352b747aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1394189Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619585}
-
Stefan Zager authored
Blur filters do not contribute to visual overflow, so hit testing doesn't account for them, even when the kHitTestVisualOverflow flag is used. This change expands the rect used for occlusion hit testing to include the radius of blur filters. BUG=827639 R=chrishtr@chromium.org Change-Id: I01eb61eacbaac2005a84fa181daa8e6f8765d18d Reviewed-on: https://chromium-review.googlesource.com/c/1364152Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#619584}
-
Dan Beam authored
TBR=michaelpg@chromium.org BUG=916782 Change-Id: I22b4d6cefaf75d1e0331eaddb201643d5bb0d67c Reviewed-on: https://chromium-review.googlesource.com/c/1394193Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#619583}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I6ee0054c1dc9ed5018108b21c6f503444284abca Reviewed-on: https://chromium-review.googlesource.com/c/1394424Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#619582}
-
Dominick Ng authored
This CL addresses a bug where bookmark apps (including desktop PWAs) do not have their navigations record to Chrome history. Chrome Packaged apps do not have a |browser| object, so removing the is_app() check will not affect them. BUG=821685 Change-Id: I87356b6c6d3dad5e4cc321966bf385975adac995 Reviewed-on: https://chromium-review.googlesource.com/c/1388045Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#619581}
-
Dan Beam authored
This is so I prescribe a method for folks to fix their code when updating the chromium-dev@ thread about single-line conditionals: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/pQMvLrovE48/OuPV1URmAgAJ TBR=dpapad@chromium.org BUG=916782 Change-Id: If777de735b44157fb79365488088174bdef4ac2d Reviewed-on: https://chromium-review.googlesource.com/c/1394228Reviewed-by:
-
Katie D authored
This fixes the constantly onscreen / somewhat noisy autoclick animation to only show up when the user has stopped moving the mouse as rapidly. The click now occurs where the mouse position was when the animation starts. Bug: 915861 Change-Id: I536850bb8a2d0f2cac6add3cf2f693f68f3fb073 Reviewed-on: https://chromium-review.googlesource.com/c/1380950 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#619579}
-
Tom Anderson authored
BUG=webrtc:10165 R=thakis CC=titovartem Change-Id: I72541d412d0f92d94efaadc3fcdc730f8d641e4b Reviewed-on: https://chromium-review.googlesource.com/c/1393805Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#619578}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/191e64b6c6c2..e413dae8840a git log 191e64b6c6c2..e413dae8840a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 04ea03e4e1e1..904bb9185767 (4 commits) 2019-01-02 egdaniel@google.com Move GrVkSecondaryCBDrawContext header into src to hide it. 2019-01-02 reed@google.com hide drawpostext etc. Created with: gclient setdep -r src/third_party/skia@e413dae8840a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Id6af735f939339dc88883a8ac51fc71488d8ef66 Reviewed-on: https://chromium-review.googlesource.com/c/1394225Reviewed-by:
-
Bin Wu authored
For Quic sessions closed with code QUIC_TOO_MANY_RTOS at client side, record (in UMA) the number of packets it sent/received at the time of close. R=zhongyi@chromium.org Change-Id: If735d0d663c74bedf18d40795bdae25aae1edc92 Reviewed-on: https://chromium-review.googlesource.com/c/1392251 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619576}
-
khmel@chromium.org authored
This allows making default app customization based on user type. For example make Youtube TV as default app on nocturne users only for unmanaged apps. This is implemeted similar to crrev.com/c/851338 that introduced the same concept for crx default apps. TEST=Locally (together with crrev.com/i/755690) + unit tests BUG=902978 Change-Id: I78d5e3da4150d6d0e1f374261113d9cdfb80260a Reviewed-on: https://chromium-review.googlesource.com/c/1391870 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#619575}
-
kylechar authored
CallbackTests still use base::Callback/base::Closure instead of base::RepeatingCallback/base::RepeatingClosure. Update tests to set a good example for what type new code should use. Bug: none Change-Id: I36da5d6bad06df0b05137560c0fe5c3840dafbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1340564Reviewed-by:
-
Paul Miller authored
It's been replaced by NormalizedPermutingEntropyProvider; see commits 7c0efea0 and 43556679. BUG=890413,912368 Change-Id: I962ecdde976f84c0cdadfb6c1a36a3d12246fb0b Reviewed-on: https://chromium-review.googlesource.com/c/1388287Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d110aee1f7a..f55b6a510625 git log 1d110aee1f7a..f55b6a510625 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 dburger@chromium.org Remove constants now unused with removal of GetAnnotatedBuilds 2019-01-03 lamontjones@chromium.org signing: correctly find the vboot_reference signing scripts 2019-01-03 vapier@chromium.org gerrit: todo: filter out Verified-1 2019-01-03 vapier@chromium.org gerrit: todo: switch to native search syntax 2019-01-03 itspeter@google.com runtime_probe: Add user "runtime_probe" to group "cros-ec_access" Created with: gclient setdep -r src/third_party/chromite@f55b6a510625 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iadc6abd61b46e7330e8ac7d35f32e412e12ec703 Reviewed-on: https://chromium-review.googlesource.com/c/1394226Reviewed-by:
-
dstockwell authored
Bug: 902646 Change-Id: I397bc8d7043ce3a911bfdd5139381f4cae7599bf Reviewed-on: https://chromium-review.googlesource.com/c/1393123 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#619571}
-
dstockwell authored
This will allow the ink component to be unloaded and will prevent any of its globals from intefering with the PDF viewer. Covered by existing tests in annotations_feature_enabled.js Bug: 902646 Change-Id: Ie45067d95df2d91441516714b04e6e5f4f3e459d Reviewed-on: https://chromium-review.googlesource.com/c/1392702Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a70cce175222..479562cc0b31 Created with: gclient setdep -r src-internal@479562cc0b31 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6590331a1e22dda7f16f7413766da3bd133d6539 Reviewed-on: https://chromium-review.googlesource.com/c/1394223Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/392ae31831b7..46a3ae6dffc6 git log 392ae31831b7..46a3ae6dffc6 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 cepheus@frii.com Update copyright years. 2019-01-03 cepheus@frii.com Include the new spv.d file when fixing line endings on Windows. Created with: gclient setdep -r src/third_party/spirv-headers/src@46a3ae6dffc6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I467e0560e7edbad2ef8fc1cc2894133d3d788e84 Reviewed-on: https://chromium-review.googlesource.com/c/1394224Reviewed-by:
-
Dan Beam authored
This CL was generated with: $ eslint --fix chrome/browser/resources $ git cl format --js Note: there are some annoying edge cases that mess up formatting. Specifically: if (blah) // trailing comment <do something> is transformed by eslint --fix into: if (blah) // trailing comment { <do something> } and all other types of things start to get funky. TBR=aee@chromium.org Bug: 916782 Change-Id: I03b591da917d5315616bf5e31566733771dc168c Reviewed-on: https://chromium-review.googlesource.com/c/1393944Reviewed-by: -
edchin authored
This CL simply removes unused/dead code from snapshots. Change-Id: I23d7eebea71d1db42057b5b06750d76fc2081bd0 Reviewed-on: https://chromium-review.googlesource.com/c/1392265Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619566}
-
edchin authored
The default snapshot image is a simply a 2x2 white pixel image. This image is unnecessarily passed around and unnecessarily complicates code. This CL removes use of a default snapshot image, and updates the API contract to use nil as the sentinel value for failed retrieval or generation. Bug: 918032 Change-Id: Ie7d8312cad6d05912474c6205c1bbb4ec9d242e0 Reviewed-on: https://chromium-review.googlesource.com/c/1392264Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
edchin authored
Snapshot coalescing is dead code. It is only enabled when the user enters the tab switcher. A lot of code around entering the tab switcher has changed since this coalescing code was first written. It is no longer the case that multiple snapshots are taken during the transition. Additionally, snapshots are now asynchronous and do not block the UI. This CL removes the dead snapshot coalescing code. Bug: 918032 Change-Id: I766e6b8546c785d9ba25e36c329504cdce7208e4 Reviewed-on: https://chromium-review.googlesource.com/c/1392261Reviewed-by:
-
edchin authored
This CL improves snapshots with the following changes: 1) Snapshots are taken earlier when entering the tab switcher. Snapshots are now taken at the earlier TouchDown event rather than the later TouchUpInside event. This is where the tab grid cells are prepared, so the snapshot is needed at this time. 2) Snapshots are now taken when entering the tab switcher while the page is still loading. Metrics show that 30% of tab switcher entries are while the page is still loading. Previously, we disabled snapshotting while the page is still loading so as to prevent stale snapshots. That means 30% of tab switcher transition animations resulted in a blank snapshot. This CL enables snapshotting in these cases. The page will continue to load even while the tab switcher is shown and will successfully update the snapshot in the tab switcher. 3) Snapshots are no longer removed from the cache when a page begins to load. This supports #2 above. However, snapshots are now removed from the cache when snapshot attempts fail. This ensures that a stale snapshot isn't kept around to retrieve. 4) Histogram metrics at tab switcher entry are updated to capture two dimensions: a) whether the page was loading or not at that time, and b) whether the snapshot was successful. 5) Histogram metrics are added to understand whether stale snapshots are successfully updated at page load. Stale snapshots are defined as snapshots of a previous page, when a new page is loading. Bug: 918032 Change-Id: Ibb1cd267ca37cbd066e047742300967c57ce7962 Reviewed-on: https://chromium-review.googlesource.com/c/1391713 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5dee56f39c42..d238bb67a52a git log 5dee56f39c42..d238bb67a52a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 jiawei.shao@intel.com Support using a layer of a texture as a color attachment on OpenGL Created with: gclient setdep -r src/third_party/dawn@d238bb67a52a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2565ffe5f18802812210c0917933f0af7a4dfbde Reviewed-on: https://chromium-review.googlesource.com/c/1393925Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/534e18423b9c..1d110aee1f7a git log 534e18423b9c..1d110aee1f7a --date=short --no-merges --format='%ad %ae %s' 2019-01-02 pprabhu@chromium.org chromeos_config: Stop running HWTests from link-paladin 2019-01-02 jclinton@chromium.org Add Emacs elisp to automate finding compile command Created with: gclient setdep -r src/third_party/chromite@1d110aee1f7a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic18546f18838ed172632ad7db4530ba408708814 Reviewed-on: https://chromium-review.googlesource.com/c/1393924Reviewed-by:
-
Chris Lu authored
Adds class that defines public //ios/web API for FindInPageManager. Bug: 894651 Change-Id: Ie1f750e6ea8953bcbb169bc4c957a6946b217d8f Reviewed-on: https://chromium-review.googlesource.com/c/1387696 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#619560}
-
Lukasz Anforowicz authored
This gives extension authors a way to test whether their extension is ready to be removed from the allowlist. Bug: 846346 Change-Id: Ide112dab32076ac2a554115b7ca815a23385050c Reviewed-on: https://chromium-review.googlesource.com/c/1368783 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619559}
-
Istiaque Ahmed authored
Bug: None Change-Id: I8b5c88b97f0214298264d57212e5aa3b18a31d2d Reviewed-on: https://chromium-review.googlesource.com/c/1387984Reviewed-by:
-
Daniel Ng authored
Modified Crostini registry to store exec data of apps and updated AppSearchProvider to add exec to the searchable words field. Updated the appropriate test files to also test for this new case. Bug: 849936 CQ-DEPEND=CL:1381311 Change-Id: Ice016099aa10a42dabb788c7ae4f05e35b036477 Reviewed-on: https://chromium-review.googlesource.com/c/1382658 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619557}
-
Wez authored
Update the run_all_tests.cc for Blink's heap tests to derive from base::TestSuite and override Initialize/Shutdown to provide the expected environment for the heap tests. Bug: 918724 Change-Id: I3c9bab5e07b828e04473ad61d0dc380f60d34c60 Reviewed-on: https://chromium-review.googlesource.com/c/1393893Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619556}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbd8fc1f9fa4..a70cce175222 Created with: gclient setdep -r src-internal@a70cce175222 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id71543b5f469a205da6aca3dca7010188fc08c60 Reviewed-on: https://chromium-review.googlesource.com/c/1393357Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4618b86e9e4b..392ae31831b7 git log 4618b86e9e4b..392ae31831b7 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 johnkslang@users.noreply.github.com Merge pull request #87 from rtbo/dlang Created with: gclient setdep -r src/third_party/spirv-headers/src@392ae31831b7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia712ff4d3bccbe1bfec57a7c68dce03e7b7ced7e Reviewed-on: https://chromium-review.googlesource.com/c/1393926Reviewed-by:
-
