GitLab

In the current Linux ShowPrinterManagerDialog() implementation, if the
desktop environment is "OTHER" then an error log entry gets generated
and nothing else happens. To improve this, just treat it like GNOME and
try some commands that may launch the printer management UI.

BUG=869845

Change-Id: I92da6fd3edcc9ca51b9f2b494b9762d5935ba9cf
Reviewed-on: https://chromium-review.googlesource.com/1159475Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588934}

When caption bar shows back button, it should be equivalent to clicking
the back button.

Bug: b:113048612
Test: locally build and test
Change-Id: I7b388d784e24d43ffcf863103d7746998e573a4a
Reviewed-on: https://chromium-review.googlesource.com/1205673Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588933}

Found when debugging nested remove() issue for CSS update roots.
Resolves TODO.

TEST=media/
TEST=external/wpt/media*

Bug: 868810
Change-Id: If2d13a9167ed331b562f55ca7e5a5802e7751362
Reviewed-on: https://chromium-review.googlesource.com/1202142Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588932}

Bug: None
Change-Id: Ifa3a39ba86ba899f9c736c779f20d8924dc302ce
Reviewed-on: https://chromium-review.googlesource.com/1207610Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588931}

This regressed in crrev.com/c/1081370 due to a combination of
1. Over-eager refactoring
2. Phantom tests that didn't actually test the functionality.

The regression is reverted here and the test for the feature is
fixed so it actually triggers the behavior.

Bug: 880829
Change-Id: Ic27a0718de685acea00af0b5d88e249b5fb0a6c2
Reviewed-on: https://chromium-review.googlesource.com/1206674Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588930}

Now we will dismiss launcher when longpress and OKG.

Bug: b:113337956
Test: locally build and run
Change-Id: Icd605d30baa1d494b64f90ed2a2a64569195c8f1
Reviewed-on: https://chromium-review.googlesource.com/1205538
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588929}

When media Stop is called, AudioStreamHandler::OnStopped will delete
both audio_stream_handler_ and device_owner_. However, device_owner_ is
posted to a background thread to be deleted. It is possible that
device_owner_ still using audio_stream_handler_ after
audio_stream_handler_ has been deleted.

Bug: b/113707507
Test: manual.
Change-Id: I20a48a5193b78608e58c3a911af77af7ff8d647e
Reviewed-on: https://chromium-review.googlesource.com/1200572Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588928}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a330ed95..1b573e9f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibb551aff8591eb9481604514a9245a4f8dd7005f
Reviewed-on: https://chromium-review.googlesource.com/1207090Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588927}

Previously, when animating the footer view and/or its children, we
modified visibility so as not to receive focus/accessibility events on
hidden views.

Unfortunately, changing the visibility of the footer view has a side
effect of freeing up space for UiElementContainerView. When this
happens, there is a bit of UI jank when the UiElementContainerView
takes that available space when really that space should permanently be
reserved for the footer. This becomes more obvious in a follow up CL in
which we add a shadow above the footer.

Now, we don't modify view visibility. Instead, we update focus behavior
as appropriate before animations start and after they end.

See bug for repro steps.

Bug: b:113871610
Change-Id: Ic8aa509c722ace44675a3ab7c7e0453c0aa4a352
Reviewed-on: https://chromium-review.googlesource.com/1197906
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588926}

This reverts commit 718282e6.

Reason for revert: Added for debugging purposes and no longer needed.

Original change's description:
> Add aliased variables for GPU failure browser crashes.
> 
> This CL saves some state in local variables and aliases them for
> inclusion in crash minidumps. This information will help diagnose GPU
> process failures with OOP-D and the resulting browser crash when we
> can't launch a GPU process.
> 
> Bug: 849639
> Change-Id: Id5a65c428eff83c80208b53081083d4feaf26063
> Reviewed-on: https://chromium-review.googlesource.com/1138178
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575294}

TBR=backer@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 849639
Change-Id: I09f1e28b6ccad89bde6a38139787a3e218d01d62
Reviewed-on: https://chromium-review.googlesource.com/1206697Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588925}

When the user set a custom passphrase, the unified consent toggle
on the settings page is disabled.

Bug: 873731
Change-Id: I0de9a9f933d5832eced65ac2800453ee2394ae67
Reviewed-on: https://chromium-review.googlesource.com/1206371Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588924}

When the sync section expand button is disabled, the opacity of the
section header is reduced to make it look greyed out.

This means that the sync-section header is greyed out in the following
cases:
 - the user is signed out
 - the user is in a synced-paused state

Screenshots:
https://drive.google.com/file/d/1rDwDIqinKa2gl6QGnf2WoRkF2j28JOpH/view?usp=sharing
https://drive.google.com/file/d/1IFqP5M6pSI2bSwrTNphrQBGy1bO1Hce8/view?usp=sharing

Bug: 854273
Change-Id: I29e04b19f56c7c36a2c8e00f12929327b5612742
Reviewed-on: https://chromium-review.googlesource.com/1205836Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588923}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/safe_browsing/chrome_cleaner.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=csharp@chromium.org

Bug: 874080
Change-Id: I131400a7be516f5ea30857e04528550ea5472fae
Reviewed-on: https://chromium-review.googlesource.com/1191230Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588922}

Change-Id: If23a2708a2c93207541322d5c34e1c938d46f1c0
Reviewed-on: https://chromium-review.googlesource.com/1207351Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588921}

This is in preparation for launching on M69+ Stable.

Bug: 794201, 794203, 794204
Change-Id: I800af4d71755911314afc7e6406899189deaaf11
Reviewed-on: https://chromium-review.googlesource.com/1197104
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588920}

Migrate URLPattern::ParseResult to an enum class (rather than just a
plain ol' enum) in order to make statements like this fail to compile:
  EXPECT_TRUE(pattern.Parse(...));
 or
  if (pattern.Parse(...))

Compiler failures are much easier to catch for methods that have semi-
ambiguous return results.

TBR=bradnelson@chromium.org (mechanical change in chrome/browser/nacl_host/nacl_browser_delegate_impl.cc)
Bug: None

Change-Id: I52496ae09d6ae6f683ec6a57767957f6ba8ea796
Reviewed-on: https://chromium-review.googlesource.com/1205999
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588919}

Bug: 879428
Change-Id: If92ac26be1fbf71be3e4a6040b764a09bc460eac
Reviewed-on: https://chromium-review.googlesource.com/1207190Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588918}

This is a reland of 9ee73d67, with DLOG
fixed to avoid an unused-variable error in Release builds.

- Define PlatformSharedMemoryRegion::PlatformHandle to use the typed
  zx::unowned_vmo wrapper, rather than raw zx_handle_t.
- Migrate zx_vmar_* call-sites off of *_old() variants, to use zx::vmar
  methods.

Change-Id: I86edf46edb6640ccb16a99fab284d5fe363ace8c
Reviewed-on: https://chromium-review.googlesource.com/1204726Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588917}

https://chromium.googlesource.com/angle/angle.git/+log/cc0466301999..750e508722a9


git log cc0466301999..750e508722a9 --date=short --no-merges --format='%ad %ae %s'
2018-09-05 jmadill@chromium.org Update style guide.


Created with:
  gclient setdep -r src/third_party/angle@750e508722a9

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I41436c94fcfa9de5f0f0b337874695094e1c9098
Reviewed-on: https://chromium-review.googlesource.com/1207155Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588916}

If an op contians a paint op buffer of size 2, then this code will fail.
All ops are at least size 4, so safely early out when this is not true.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia44fa235f1e8fbae923b0ebf407bc6f0bc0a4cbe
Reviewed-on: https://chromium-review.googlesource.com/1205533Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588915}

In the download backend used by incognito mode in background download
service, OnDownloadCreated is called before receiving the server
response, that the URL chain and the server response headers are not
correctly propagate to clients.

TBR=peter@chromium.org

Bug: 863949
Change-Id: Ic5f4dabe1c312a8c949bfb5edbc4e17e3e1081be
Reviewed-on: https://chromium-review.googlesource.com/1171594
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588914}

Do the same for png_zlib_inflate().

Change-Id: I43357020646585d38075b59fb9d24390654c5587
Reviewed-on: https://chromium-review.googlesource.com/1205672Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588913}

TBR=bnc@chromium.org

Change-Id: I74bdbf6694bdd7f5cec878ec6c4be259fed79421
Reviewed-on: https://chromium-review.googlesource.com/1205100Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588912}

Create basic chrome://management page to contain the template for the
disclosure page, which describes administrator's capabilities in a
managed environment, like policies which report information, local
trust roots or force installed extensions.

Bug: 879146
Change-Id: I621bed79843b2a677ed1df82b90043bc8937e44a
Reviewed-on: https://chromium-review.googlesource.com/1196548
Commit-Queue: Stefan Teodorescu <fane@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588911}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf7940726346..797fd93eccde


git log bf7940726346..797fd93eccde --date=short --no-merges --format='%ad %ae %s'
2018-09-05 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@797fd93eccde

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib74d213cf88913296fe82593df5427d6bfff5096
Reviewed-on: https://chromium-review.googlesource.com/1207070Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588910}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/ui/ash.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=derat@chromium.org

Bug: 874080
Change-Id: I478ab0929c7bba7131b214205041e66bb23de087
Reviewed-on: https://chromium-review.googlesource.com/1191182Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588909}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8be34d04fd8af7c530c7109f0ff378f0c2aeff61
Reviewed-on: https://chromium-review.googlesource.com/1207352
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588908}

In the following case false positive on accounts.google.com happens:

1.Suppose that the user has 2 Gaia credentials (with usernames and passwords
u1/p1 and u2/p2). Let u1 be saved in Password Manager.

2.The user go to accounts.google.com, u1/p1 are autofilled by CPM (a username
field is visible, a password field is invisible).

3.The user is typing u2 in the username field and is clicking next button.

4.At that moment the page removes password form from the DOM and Password
Manager incorrectly thinks that it was successful submission with u2/p1

Video is on bug 764663 (actual_bubble).

This CL fixes this by ignoring for saving accounts.google.com forms without
a visible password field.

Similar issues might be on different sites, this CL fixes only
accounts.google.com, because
1.A general solution is unlikely without more complex changes and server-side
support.
2.accounts.google.com is crucial for Chrome, in particular because it serves
the Chrome sign-in page.


Bug: 758155, 764663, 880876

Change-Id: I57bbe94ea0a6d101c6a5a33cf354b42f0d0353fc
Reviewed-on: https://chromium-review.googlesource.com/1206476
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588907}

Bug: 878574
Change-Id: I8d5b0be24be4db3d117d2b1edcca1c39ab93e2c9
Reviewed-on: https://chromium-review.googlesource.com/1206072Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588906}

This patch updates Duet's IPH to work on the NTP which has no visible
toolbar (which the bubble whould ordinarily anchor to). Instead, the
bubble takes the place of the toolbar and removes the arrow.

Bug: 862611
Change-Id: I523d8d14748ff2668101ec1890e36decd5c07213
Reviewed-on: https://chromium-review.googlesource.com/1207311
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588905}

This is a reland for
https://chromium-review.googlesource.com/c/chromium/src/+/1195662
except for the wizard_controller changes

TBR=xiyuan@chromium.org, xiaohuic@chromium.org

Bug: b/78190629
Test: Manual Test
Change-Id: I9064ae4017a2b848e00522bcbecf8d93e5e99e4a
Reviewed-on: https://chromium-review.googlesource.com/1205208Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588904}

DRM does not support overlay rotation well.
NV12 planes are supported, but they need to be
tiled.  That information is not available currently.

BUG=872901
TEST=browser

Change-Id: Ide9c837dca62a6db9d13e6fedaaf5b256e4bcb79
Reviewed-on: https://chromium-review.googlesource.com/1196019
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588903}

https://chromium.googlesource.com/catapult.git/+log/f056cc5a549e..638bda3a17c0


git log f056cc5a549e..638bda3a17c0 --date=short --no-merges --format='%ad %ae %s'
2018-09-05 anthonyalridge@google.com Create link for relevant metric.
2018-09-05 nastasoiuf@google.com Update the UI: table structure


Created with:
  gclient setdep -r src/third_party/catapult@638bda3a17c0

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866423,chromium:866423
TBR=sullivan@chromium.org

Change-Id: I7b6ece1a6cc01ec30a5e14e11cf55577e14c3550
Reviewed-on: https://chromium-review.googlesource.com/1207153Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588902}

When a script has a function with multiple const declarations for the
same variable, ex:
function hey(){
  const duplicate = 0;
  const duplicate = 1;
}
The script that contains this function will parse correctly, but
when the function `hey` is run a scriptFailedParse event will be
emitted. DevTools only ever expects to get one script parsing
event per scriptId, and this causes flickering of the script in
the Sources panel.

This patch swallows subsequent script parsing events for a script.

Bug: 864296
Change-Id: I55a2e865b665e8fe1283a3dd19e9f152d0982b97
Reviewed-on: https://chromium-review.googlesource.com/1140782
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588901}

ChromeOSOAuth2TokenServiceDelegate should notify SigninErrorController
about auth error updates.

These updates will be provided for Device Account and Secondary
Accounts, both.

Bug: 820046
Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*"
Change-Id: I1e3d218969350a3dc3b11755870b2e281045f2ef
Reviewed-on: https://chromium-review.googlesource.com/1202802
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588900}

The backdrop now moves with the window when swiping up or down to use
home launcher gestures. This also allows non resizable windows to be
swiped up or down now.

Test: manual
Bug: 880605
Change-Id: I020f21fc04f95da55cd2c897841ade0b105d66ed
Reviewed-on: https://chromium-review.googlesource.com/1205593
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588899}

This patch adds a notion of IsParentAlias to paint property tree
nodes.

In this patch, we make the root transform be an "alias for parent".
Also, this adds some tests for various interactions with these nodes,
as well as code in PaintChunksToCcLayer to ensure we don't emit
unnecessary save/concat/restores for these nodes.

We also need to do this for clips and effects, but this patch can
land on its own.

R=trchen@chromium.org, chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibf1a0cd21754dc226f7c19716028eafad63339c9
Reviewed-on: https://chromium-review.googlesource.com/1200382
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588898}

Refactoring code from BrowserView and ViewAXPlatformNodeDelegate
into a static helper.

Change-Id: I247ca4c8a7da4eeb02dfd0cd7886ae82c2bc3280
Reviewed-on: https://chromium-review.googlesource.com/1195898Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588897}

Added injectable TickClock to MockHostResolver to fix some timing
issues I ran into while debugging some of the new cache tests.

Note: HostResolverSource still has an ANY value for now, despite recent
conversations that it's not the clearest name. Still trying to decide
on the best name for that value, so not renamed yet.

Bug: 846423
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I22431d47f76d831bbf67d0f4010c1753093a3f32
Reviewed-on: https://chromium-review.googlesource.com/1195550Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588896}

cr.isWin() does not exist. Also fix formatting for some TODO entries.

Change-Id: Ib64b2eeac0166484e60bf93c5a60159def81afec
Reviewed-on: https://chromium-review.googlesource.com/1204590Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588895}