- 09 Apr, 2020 40 commits
-
-
chromium-autoroll authored
Roll broadwell AFDO profile from 83-4085.6-1585564150-benchmark-83.0.4099.3-r1 to 83-4091.0-1586169176-benchmark-83.0.4103.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I62362c53762d94410eb04663c1f9d664b694d5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757784}
-
Tim van der Lippe authored
The location for CDP-related bugs is https://bugs.chromium.org/p/chromium/issues/list?q=component%3APlatform%3EDevTools%3EPlatform&can=2 Moving these bugs from Platform>DevTools to Platform>DevTools>Platform allows us to separate issues regarding the frontend from issues regarding the protocol. This also allows us to move issues on other repositories (like https://github.com/ChromeDevTools/debugger-protocol-viewer/issues into the Monorail component) Change-Id: I845c2a6ed0eb28925ee7bd15b959b3e75a9a1c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139811Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#757783}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4091.0-1585565910-benchmark-83.0.4099.3-r1 to 83-4099.3-1586165807-benchmark-83.0.4103.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I118f485ba9c54ed213401bef5b375c513c7997e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143952Reviewed-by:
-
arthursonzogni authored
Follow up for: https://chromium-review.googlesource.com/c/chromium/src/+/2134246 The CSP parser implemented by: services/network/public/content_security_policy/ is already tested and fuzzed. Blink reuses it for parsing responses built from a service worker. This patch tests it. The parser is already tested, so we just need to check the conversion from/to blink types is not missing any attributes. Of course, this doesn't prevent future attributes from being missed. An attempt to have something 'future-proof' has been made here: https://chromium-review.googlesource.com/c/chromium/src/+/2126933 but it has been withdrawned. Bug: 1063832 Change-Id: Id4da82e0dc34ce3b7062a74668c8a5c8215893bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139718Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#757781}
-
Mario Sanchez Prada authored
Partially migrate the contents of this test into the WPT-specific directory, including only the checks that can be upstreamed and leaving the parts that are Chromium-specific in the original test. In addition, this CL also adapts the description of the original Chromium-specific test to reflect what it actually does now after having removed some parts. In the newly-added test, we also add the relevant meta information i.e links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I57df80bf8a3c48dd94c70315a07d31715477a28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129537 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#757780}
-
chrome://settingsAlex Ilin authored
Polymer 3 uses JavaScript ES6 modules that don't leak variables to the global context. Signin live tests depended on one of this variables to perform sync-related operations on the settings page. Fixed: 1069089 Change-Id: Ia705f9da4a4c3a356a13bd8c7d6cc5f5d61c3997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142274Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757779}
-
Greg Thompson authored
The multi-install support was deactivated in 2017 but there were still many remnants remaining in the Chromium code base. These remnants have been a source of friction for changes being made in the install and update infrastructure. Some additional house-keeping is included by reviewer request. TBR=rsesek@chromium.org,jxiang@google.com NOTRY=true Bug: 1067489 Change-Id: I132f3146db2f465226d1b793c8fd2f8c4e66d9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143811 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757778}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2fb0b345. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 239eeaa8 "[css-filters] Migrate effect-reference-image.html to WPT" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" e7582c3e "[css-filters] Migrate effect-reference-displacement-negative-scale to WPT" 7bcf733d "[css-filters] Migrate effect-reference-external-stylesheet to WPT" dc790030 "[css-filters] Migrate effect-reference-local-url-with-base to WPT" 2fb0b345 "[css-masking] Migrate clip-path-reference-local-url-with-base to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib64a5f3747eb1e92003032c58cfdd0524ef3d4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757777}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/61e170b3c5f6..d56b69f115e2 git log 61e170b3c5f6..d56b69f115e2 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 cwallez@chromium.org Skip Float16 TextureFormatTests on Swiftshader Created with: gclient setdep -r src/third_party/dawn@d56b69f115e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1823b44f72eb1e0a30d5d6c5647b1bb4583d4c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143567Reviewed-by:
-
Matt Falkenhagen authored
The test is evidently slow. Add long timeout. Bug: 1068289 Change-Id: I8fb1ec3d749bd2ff07153ec9ee178b8d1f8f55b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142874 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757775}
-
Colin Blundell authored
This CL augments WebLayer's external intent launching to use the RedirectHandler implementation that is used by Chrome. This takes another step in bringing WebLayer's external intent launching logic up to par with Chrome's; in particular, see the tests modified in this CL, which highlight areas that had previously been deficient in WebLayer. There is one subtlety in this bringup: RedirectHandlerImpl wants to know the last time that the user interacted with the app as a heuristic to help determine if a navigation was started by the user. In Chrome this is determined by the Activity subclass listening for user interaction. However in WebLayer this information is not available, as WebLayer's Activity is provided by the client and thus opaque. Instead, this CL uses a replacement heuristic wherein we pass a user interaction time to RedirectHandlerImpl that is updated on navigations that are either from user typing or have a user gesture associated with them. To date, we have not seen any differences that would result from the usage of these different heuristics. Bug: 1031465, 1066291 Change-Id: Ia9b2c94433db61eb743bfdd50caa9f99fc699c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130790 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#757774}
-
Hajime Hoshi authored
Thic CL adds PageLoadTracker::OnRestoreFromBackForwardCache, which is triggered when the page is restored from the back-forward cache. Now there are no use cases to call OnRestoreFromBackForwardCache since OnEnterBackForwardCache returns STOP_OBSERVING. This CL is a preparation to treat metrics in CorePageLoadMetricsObserver. Bug: 1014174 Change-Id: If5e2316c922fbad43ed68c32a307ba02a95f6b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132560 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#757773}
-
Alan Cutter authored
This CL fixes the unit_tests warning: The following parameterized test case is not instantiated: UninstantiatedTypeParamaterizedTestSuite<PasswordStoreOriginTest> Bug: 1045846 Change-Id: Iae85d808ae25b83c9473225bcbb671d977573a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143098 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#757772}
-
Dominik Röttsches authored
Update FontMetrics implementation to return Optional<int> for underline offset and thickness metrics to represent unretrievable values. Update underline thickness painting implementation to only perform what the `auto` keyword would do, as UnderlineThickness() was never initialised on the FontMetrics object. Update TextDecorationOffsetBase implementation support auto and from-font modes. Bug: 1067242 Change-Id: Ica8c7bf3ea8812fae9cd8e285f71d3eba1a9c983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134018 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#757771}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4091.0-1585562740-benchmark-83.0.4099.3-r1 to 83-4099.3-1586168020-benchmark-83.0.4103.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I886fb0d20284cd863850c52495b636831d3f17ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143569Reviewed-by:
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c98edc42336f..00e6685b05e8 git log c98edc42336f..00e6685b05e8 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 treehugger-gerrit@google.com Merge "perfetto-ui: Fix rounding of merged slice percents" 2020-04-08 lalitm@google.com Merge "tp: add documentation for trace analysis feature" 2020-04-08 treehugger-gerrit@google.com Merge "base: round two of trying to fix vs2019" 2020-04-08 treehugger-gerrit@google.com Merge "TrackEvent: Fix compatibility issues with Clang 11 on macOS" 2020-04-08 lalitm@google.com Merge "tp: fix inconsistency of base::optional<StringId> column API" 2020-04-08 primiano@google.com service: Emit a marker when all data source started Created with: gclient setdep -r src/third_party/perfetto@00e6685b05e8 Bug: chromium:150960749 Change-Id: Ieaac915d9c4d2c0325abaac326346cdb5e998065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142034 Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757769}
-
Thanh Nguyen authored
Increase the relevance threshold and use simple fuzzy app search instead of weighted ratio to filter unwanted search results. Bug: 1065455 Change-Id: I1c59368eb8dd3a235b2fd723098ac42cffca3aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143096Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757768}
-
Side Yilmaz authored
incognito. This CL is to revert crrev.com/c/2134230 that crash Chrome. The main reason of the crashes are that the called OfflinePageBridge and MostVisitedListBridge return null for incognito profile. Bug: 1068485 Change-Id: I3f3d6aa1d98ce06e16aaa9dbff9af92f6ca3c729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141091Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757767}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/330286ebf4aa..d7bec5552079 git log 330286ebf4aa..d7bec5552079 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8bd3dab11206..2caf7ffda74f (7 commits) Created with: gclient setdep -r src/third_party/skia@d7bec5552079 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ibd1637a18258092fb4af11a2da681d0efb2bf42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143566Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit 309e1e97. Reason for revert: Re-enabled tests fail on KitKat Phone Tester (dbg) https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/21374 Original change's description: > Re-enable NewTabPageTest#testRender_FocusFakeBox > > Enable flaky test to gather failure images. Unable to repro locally, and > insufficient information on bug for speculative fixes yet. > > Bug: 888129 > Change-Id: I438daec8bbb9faa4d098fc83016e96f3db1792d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136272 > Commit-Queue: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757630} TBR=tedchoc@chromium.org,chouinard@chromium.org Change-Id: Idc9f515e744a90ca7faf653da12862d8d78e2ce0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143871Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#757765}
-
Victor Hugo Vianna Silva authored
Remove an outdated TODO in the file. Change-Id: Ia0da37fca5b028128bdee39cf60519b2d8f8f855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137324Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#757764}
-
Noel Gordon authored
Add unittest fixtures (18 in all) to cover the breadcrumbs public API. Note that Polymer3 does not work in files app unittest harness, so the <cr-action-menu> aspects of breadcrumb can only be partly tested here, see [1]. Keyboard Enter and Space, and <cr-action-menu> drop-down menu open/close behavior etc will need integration tests. [1] The <cr-action-menu> fails on a "Polymer is not defined" exception at unittest start-up and its JS code is non-functional as a result. Bug: 1061388 Change-Id: Ie2d03cb16dbcde421131c933c92a3a0e4a1e7f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143024Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#757763}
-
jimmy gong authored
This reverts commit 75e29f77. Reason for revert: Did not fix flaky test Original change's description: > Fix flaky printmanagement browser test > > - The original cause of the flaky is because the page element was not > ready by the time we try to query for elements within it. > - The fix is to attach a promise to the instatiation of the page and > to only continue with the test once the promise is resolved. This > ensures that each step of the test is handled synchronously. > > Bug: 1068860 > Test: browser_tests > Change-Id: I0a30e2971107b44354603adbb0396ddfea3c218d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142951 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757687} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org Change-Id: Iecd238842fc5954e922e77a4c0c677814754216f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143517Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#757762}
-
Austin Tankiang authored
Bug: 1068479 Change-Id: Iaca92655f6633658e56cd4969646e96fc8030b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139060 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#757761}
-
Colin Blundell authored
The APIs via which AuthenticatorNavigationInterceptor instances are obtained from Tabs are currently being refactored. However, those APIs are used downstream. To allow those refactorings to proceed without breaking downstream this CL introduces an AuthenticatorNavigationInterceptorTabHelper wrapper that downstream can use to be isolated from the specific APIs being refactored. I will delete this wrapper once the upstream refactorings have landed and I have converted downstream to use them. Bug: 1031465 Change-Id: I232e785674d155d16b968c8d91889df6c73b7ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142257Reviewed-by:
-
Daniel Hosseinian authored
An earlier change [1] to printing/BUILD.gn that built CUPS IPP files for macOS made it such that some files already built for fuzzing get built twice. That resulted in a macOS fuzzing builder breakage. TBRing this CL as it is a minor change that will fix a high priority bug. [1] crrev.com/754744 TBR=thestig@chromium.org Bug: 1069349 Change-Id: I99343e035c0d1f1599930e5fc3f127a888664fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143514 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#757759}
-
Gauthier Ambard authored
This CL makes sure that the virtual URL of the items are restored when finishing the session restoration. Fixed: 1065433 Change-Id: I9570c73caad9e025ff5425412d83a5b7c4532dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134296Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#757758}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/15398905e2cd..46d2d5e4c4ce git log 15398905e2cd..46d2d5e4c4ce --date=short --first-parent --format='%ad %ae %s' 2020-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6c7769b5..9fa8abd9 (757605:757716) Created with: gclient setdep -r src/third_party/webrtc@46d2d5e4c4ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I72ce395a810b7532ba0165e88e09fbc9362cd5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143558Reviewed-by:
-
Josh Simmons authored
Bug 1067499 requires the addition of individual browser tests to validate the MIME type detected and reported by Quick View for all file extensions known to Files.app. This CL is the first of many and adds MIME type checks for file extensions with existing tests. It also adds a new test that highlights the quirks of the file content sniffing used by the Media Gallery API (the underlying implementation used by Quick View to determine and report MIME type in the right-hand metadata information box). Subsequent CLs will split out MIME type testing from some of the current tests (where it is overloaded in the test of a wider feature) and add new tests for currently untested file extensions. Bug: 1067499 Change-Id: I08fb9926ac3aa734f95cc5cc04afa1c241300cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141563Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I4d8b5d03212fcca5dbe66a39104803c651e892a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141498Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#757755}
-
John Pham authored
This allows screen readers to announce when a tree view node collapses/expands after user action. Change-Id: Ia4e686a88ddc9c73643342453f08d3603b3e151b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136865 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#757754}
-
Dominic Mazzoni authored
This was originally needed so that we wouldn't cast a BrowserAccessibility* into a platform-specific subclass in a unit test that was explicitly constructing the parent class. We got rid of all such unit tests now, so there's no longer a need for IsNative. Bug: None Change-Id: I934f08f22aa497c3894ee60c0c8f13fb046fc98e Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141047Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2319607679d7..2caf7ffda74f git log 2319607679d7..2caf7ffda74f --date=short --first-parent --format='%ad %ae %s' 2020-04-09 xinghua.cao@intel.com Address a TODO for instance uniform block Created with: gclient setdep -r src/third_party/angle@2caf7ffda74f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I7e4722ea58803ceb3b1c1413bf31fa87d9f54fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143556Reviewed-by:
-
Alex Danilo authored
The selection menu button was using 'cr-button', while all of the other menu buttons on the action bar were using 'button' elements. Styling for files-ng was added to our CSS targeting 'button' for some background-color cases. Changes the selection menu button to 'button' element so those styles apply. Fixes 2 integration tests to look for lack of 'display:none' on the selection menu button, i.e. actually test for visibility. Bug: 1067218 Change-Id: I6fc8050128ec42b9e743f8facf405281b9d9c013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143415 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dcf3a9b3dce1..330286ebf4aa git log dcf3a9b3dce1..330286ebf4aa --date=short --first-parent --format='%ad %ae %s' 2020-04-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 65c03361..9fa8abd9 (398 commits) Created with: gclient setdep -r src/third_party/skia@330286ebf4aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I6de8d087012185570fe1f5bee90d9016d5706e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143557Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I0576fddfd300a57f8d92d62306e6d58ba6b7338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141919 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757749}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: If42f93a2184eff9a8f47a193a1c6bc3ebca89452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139656Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#757748}
-
Igor authored
We would like to get in logs a string description of value received from the server rather than the integer value associated with enum. BUG=chromium:1021892 TEST=None Change-Id: Ic1a97924b9b070f35e9e0854dc97380dd115d6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142268Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#757747}
-
Austin Tankiang authored
Bug: None Change-Id: I67d1337c2b72ed23937863bdd33db52de9ac8383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143025Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#757746}
-
Alan Cutter authored
This CL updates ChromeLauncherControllerTest.WebAppPolicy* to be ShelfWebAppBrowserTest.WebAppPolicy* tests and removes the dependency on web apps being Extensions. Bug: 1068919, 1054116 Change-Id: I0a89b926d1ff2184896c03f608879a3265922a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141397Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#757745}
-
