GitLab

git-svn-id: svn://svn.chromium.org/blink/trunk@42637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Darin Adler

Fix a check that was intended to mark a cached call as invalid when the callframe could
not be constructed.  Instead it was just checking that there was a place to put the
exception.  This eventually results in a non-recoverable RegisterFile starvation.


git-svn-id: svn://svn.chromium.org/blink/trunk@42636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-17  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25277
        If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box
        
        Also added code to handle a caret wider than one pixel.
        
        Added fast/inline/25277.html and fast/inline/25277-2.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect): Distribute a caret's width to either side of the offset,
        so that a caret between two characters doesn't hang over one character more than the other.
        If there is no wrapping, the caret can leave its containing block, but not its root line box.

LayoutTests:

2009-04-17  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.
        
        https://bugs.webkit.org/show_bug.cgi?id=25277
        If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box

        * fast/inline/25277-2.html: Added.
        * fast/inline/25277.html: Added.
        * platform/mac/fast/inline/25277-2-expected.checksum: Added.
        * platform/mac/fast/inline/25277-2-expected.png: Added.
        * platform/mac/fast/inline/25277-2-expected.txt: Added.
        * platform/mac/fast/inline/25277-expected.checksum: Added.
        * platform/mac/fast/inline/25277-expected.png: Added.
        * platform/mac/fast/inline/25277-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions
        
        Some refactoring of "inline" event listeners.
        
        Renames:
            dispatchEventForType => dispatchEvent
            setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
            removeInlineEventListenerForType => clearInlineEventListener
            setInlineEventListenerForType => setInlineEventListener
            inlineEventListenerForType => getInlineEventListener

        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::eventParameterName):
        (WebCore::JSLazyEventListener::JSLazyEventListener):
        (WebCore::createInlineEventListener):
        * bindings/js/JSLazyEventListener.h: Added two helper functions for
        creating "inline" event listeners. These replace Document::createEventListener,
        and abstract the creation of JS event listeners for DOM attributes out
        of the DOM. Removed legacy JSProtectedEventListener constructor code for
        adding the event listener's function to a map, since lazy event listeners
        don't have functions at construction time.

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode):
        * dom/Document.h:
        (WebCore::Document::isSVGDocument):
        * dom/Element.cpp:
        (WebCore::Element::setWindowInlineEventListener):
        * dom/Element.h: Updated for renames. Nixed Document::createEventListener,
        mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute
        to Element, for simplicity.

        * dom/InputElement.cpp:
        (WebCore::InputElement::setValueFromRenderer):
        * dom/Node.cpp:
        (WebCore::Node::dispatchFocusEvent):
        (WebCore::Node::dispatchBlurEvent):
        (WebCore::Node::dispatchEvent):
        (WebCore::Node::clearInlineEventListener):
        (WebCore::Node::setInlineEventListener):
        (WebCore::Node::getInlineEventListener):
        (WebCore::Node::onabort):
        (WebCore::Node::setOnabort):
        (WebCore::Node::etc.):
        * dom/Node.h: Updated for renames.
        
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.
        
        Updated these files for renames, and to use the new createInlineEventListener
        helper function:

        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::parseMappedAttribute):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::onChange):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::prepareSubmit):
        (WebCore::HTMLFormElement::reset):
        (WebCore::HTMLFormElement::parseMappedAttribute):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::dispatchLoadEvent):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::onSearch):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadInternal):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::parseMappedAttribute):
        (WebCore::HTMLScriptElement::dispatchLoadEvent):
        (WebCore::HTMLScriptElement::dispatchErrorEvent):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::notifyFinished):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::mouseButtonListener):
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        (WebCore::DOMWindow::eventListeners):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::canMouseDownStartSelect):
        (WebCore::EventHandler::canMouseDragExtendSelect):
        (WebCore::EventHandler::sendScrollEvent):
        * page/Page.cpp:
        (WebCore::networkStateChanged):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::valueChanged):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::selectionChanged):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::parseMappedAttribute):
        * svg/SVGElementInstance.cpp:
        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::dispatchLoadEvent):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::parseMappedAttribute):
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::dispatchErrorEvent):
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::defaultEventHandler):



git-svn-id: svn://svn.chromium.org/blink/trunk@42633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        <rdar://problem/6714488>
        REGRESSION (Safari 3-4): Edit menu commands (cut/copy/paste/select all) do not work on Flash content
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
        Send a keyDown event to the plug-in host.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView sendModifierEventWithKeyCode:character:]):
        Call the plug-in instance proxy.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
        Add this. Subclasses are required to override it.
        
        (-[WebBaseNetscapePluginView cut:]):
        (-[WebBaseNetscapePluginView copy:]):
        (-[WebBaseNetscapePluginView paste:]):
        (-[WebBaseNetscapePluginView selectAll:]):
        Call sendModifierEventWithKeyCode.
        
        * Plugins/WebNetscapePluginEventHandler.h:
        Add syntheticKeyDownWithCommandModifier.
        
        * Plugins/WebNetscapePluginEventHandlerCarbon.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::syntheticKeyDownWithCommandModifier):
        Send the synthetic event.
        
        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
        Send the synthetic event.
        
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendModifierEventWithKeyCode:character:]):
        Call the event handler.



git-svn-id: svn://svn.chromium.org/blink/trunk@42632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
        variables to their own FeatureDefines.xcconfig file.  It also
        extracts a new ENABLE_GEOLOCATION variable so that
        FEATURE_DEFINES only needs to be defined once.

JavaScriptCore:

        * Configurations/FeatureDefines.xcconfig: Added.
        * Configurations/JavaScriptCore.xcconfig: Removed definition of
        ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES.  Added include
        of FeatureDefines.xcconfig.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added
        FeatureDefines.xcconfig file.

WebCore:

        * Configurations/FeatureDefines.xcconfig: Added.
        * Configurations/WebCore.xcconfig: Removed definition of
        ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES.  Added include
        of FeatureDefines.xcconfig.
        * WebCore.xcodeproj/project.pbxproj: Added
        FeatureDefines.xcconfig file.
        * bindings/scripts/CodeGeneratorObjC.pm: When creating a list of
        command-line macro definitions, split on one-or-more spaces
        instead of a single space since the FEATURE_DEFINES macro may
        now contain more than one space between macros if some macros
        aren't defined.

WebKit:

        * WebKit.xcodeproj/project.pbxproj: Added
        FeatureDefines.xcconfig file.

WebKit/mac:

        * Configurations/FeatureDefines.xcconfig: Added.
        * Configurations/WebKit.xcconfig: Removed definition of
        ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES.  Added include
        of FeatureDefines.xcconfig.

WebKitTools:

        * Scripts/build-webkit: Realphabetized code related to enabling
        Geolation features for WebKit.  Also set ENABLE_GEOLOCATION
        variable for xcodebuild.

git-svn-id: svn://svn.chromium.org/blink/trunk@42631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Steve Falkenburg.

        * WebHistory.cpp:
        (WebHistory::data): Return null if there are no history items.



git-svn-id: svn://svn.chromium.org/blink/trunk@42630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Steve Falkenburg

        Fix the link for setting the Platform SDK paths in the Windows instructions.

        * building/build.html:

git-svn-id: svn://svn.chromium.org/blink/trunk@42629 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6786999> Tiger WebKit shouldn't try to POST on back/forward without nagging.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::willLoadFromCache):

LayoutTests:

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6778137> - Disable post-goback-repost-policy.html until the networking layer allows it to be useful.

        * http/tests/navigation/post-goback-repost-policy.html: Removed.
        * http/tests/navigation/post-goback-repost-policy.html-disabled: Copied from http/tests/navigation/post-goback-repost-policy.html.



git-svn-id: svn://svn.chromium.org/blink/trunk@42628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Timothy Hatcher.

        Added sudden termination functions that can be called without involving
        the page or client.

        * GNUmakefile.am: Added SuddenTermination.h.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto. Also added SuddenTermination.mm.

        * platform/SuddenTermination.h: Added.
        * platform/mac/SuddenTermination.mm: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Move more code into RenderSVGModelObject

        needsLayer() already returns false from RenderSVGModelObject
        lineHeight and baselinePosition are from days of RenderPath having RenderBox parents.

        I also added comments to explain how focus rings work (now that I understand)
        I got rid of two more uses of m_absoluteBounds (nearly dead!)

        * rendering/RenderPath.cpp:
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::addFocusRingRects):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::absoluteRects):
        (WebCore::RenderSVGModelObject::absoluteQuads):
        * rendering/RenderSVGModelObject.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - Fix a leak in WebHistoryItem::children() by adopting the created instance of WebHistoryItem.
        - Remove the unnecessary call to QueryInterface() which is not related to the leak.

        Reviewed by Adam Roben.

        * WebHistoryItem.cpp:
        (WebHistoryItem::children):



git-svn-id: svn://svn.chromium.org/blink/trunk@42625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=25238
        Invalidate the hovered scrollbar part when resetting the pressed part,
        since once there is no pressed part we can draw a hovered state.

        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::setHoveredPart):
        (WebCore::Scrollbar::setPressedPart):



git-svn-id: svn://svn.chromium.org/blink/trunk@42624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25223
        REGRESSION: Back button after form submission to the same URL fails to navigate.

        Test: http/tests/navigation/post-goback-same-url.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): Check if the page we are leaving has
        FormData.



git-svn-id: svn://svn.chromium.org/blink/trunk@42623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix to generate all .mo files at the correct
        location.

        * GNUmakefile.am:

git-svn-id: svn://svn.chromium.org/blink/trunk@42621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Fix crashes seen in regression tests with hosted plug-ins.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Check the stream for 0,
        not the stream ID.



git-svn-id: svn://svn.chromium.org/blink/trunk@42620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser.

        Add support for the media element 'played' attribute.
        This involves support of "normalized TimeRanges" as described by
        the spec.

        Test: media/video-played.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Renamed 
        m_currentTimeDuringSeek->m_lastSeekTime. Added m_playing and m_playedTimeRanges.
        (WebCore::HTMLMediaElement::loadInternal): Reset m_playing, m_lastSeekTime, and
        m_playedTimeRanges
        (WebCore::HTMLMediaElement::seek): Set current time to m_playedTimeRanges
        (WebCore::HTMLMediaElement::currentTime): m_currentTimeDuringSeek -> m_lastSeekTime
        (WebCore::HTMLMediaElement::played): Returns m_playedTimeRanges.
        (WebCore::HTMLMediaElement::updatePlayState): Add the new played time ranges when pausing. 
        Set the m_playing flag.
        * html/HTMLMediaElement.h:

        * html/TimeRanges.cpp:
        (TimeRanges::add): Merge range(s) if overlap.
        * html/TimeRanges.h: Add various helpers (below).
        (WebCore::TimeRanges::Range::isPointInRange): Added.
        (WebCore::TimeRanges::Range::isOverlappingRange): Ditto.
        (WebCore::TimeRanges::Range::unionWithOverlappingRange): Ditto.
        (WebCore::TimeRanges::Range::isBeforeRange): Ditto.

2009-04-17  Pierre d'Herbemont <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Add test for media element 'played' attribute.

        * media/video-played-expected.txt: Added.
        * media/video-played.html: Added.
        * media/video-test.js:
        (disableFullTestDetailsPrinting): New, include less information in 'reportExpected' output
        to accomodate tests with values that are expected to change from run to run.
        (reportExpected): Don't log expected and observed values when printFullTestDetails is false.
        (runSilently): New, same as run() but without logging.
        (run): Call runSilently to run command.


git-svn-id: svn://svn.chromium.org/blink/trunk@42619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-17  Darin Adler  <darin@apple.com>

        Reviewed by Antti Koivisto.

        Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
        https://bugs.webkit.org/show_bug.cgi?id=25210

        * WebCore.base.exp: Export the core and kit function overloads that are used
        in WebKit. Also resorted this file.

        * WebCore.xcodeproj/project.pbxproj: Re-added DOMHTMLCanvasElement.h to fix
        a strange problem with the file type.

        * bindings/objc/DOM.mm: Removed the many extraneous includes. Added new includes
        so we can use and implement the new core and kit functions. Import DOMInternal.h
        first so it can do its public/private magic.
        (-[DOMNode _rootObject]): Changed to use early-return style.
        (kitClass): Added. Tells the wrapper generator what kind of node class to create
        to wrap DOM nodes. This has the code that used to be in the _wrapNode method.
        (kit): Added. Takes an EventTarget and makes the appropriate type of wrapper,
        dpending on whether it's a Node or an SVGElementInstance. This replace methods
        that used to be on both of those classes.
        (-[DOMNode boundingBox]): Changed to use early return, and the core function.
        (-[DOMNode lineBoxRects]): Ditto.
        (-[DOMNode renderedImage]): Ditto.
        (-[DOMRange boundingBox]): Ditto.
        (-[DOMRange lineBoxRects]): Ditto.
        (-[DOMElement image]): Ditto.
        (-[DOMElement _font]): Ditto.
        (-[DOMElement _imageTIFFRepresentation]): Ditto.
        (-[DOMElement _getURLAttribute:]): Ditto.
        (-[DOMElement isFocused]): Ditto.
        (kit): Hand-wrote the version of this for NodeFilter, since it's a protocol,
        not a class in the binding.
        (core): Ditto.
        (-[DOMNodeFilter acceptNode:]): Use core.

        * bindings/objc/DOMAbstractView.mm:
        (-[DOMAbstractView document]): Use kit.
        (-[DOMAbstractView _disconnectFrame]): Call removeDOMWrapper, which is no longer
        in the WebCore namespace, since it's headed for WebKit in the future.
        (core): Hand-wrote the version of this for DOMAbstractView.mm, since we store
        a pointer to the Frame, not the DMWindow.
        (kit): Ditto.

        * bindings/objc/DOMCSS.mm:
        (kitClass): Added. Tells the wrapper generator what kind of node class to create
        to wrap CSS objects. This has the code that used to be in the _wrapStyleSheet,
        _wrapCSSRule, and _wrapCSSValue methods.

        * bindings/objc/DOMEvents.mm:
        (kitClass): Added. Tells the wrapper generator what kind of node class to create
        to wrap event objects. This has the code that used to be in the _wrapEvent methods.

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): Use kit and core.
        (-[DOMHTMLDocument createDocumentFragmentWithText:]): Ditto.
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.
        (-[DOMHTMLInputElement _rectOnScreen]): Ditto.
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Ditto.
        (-[DOMHTMLInputElement _selectedRange]): Ditto.
        (-[DOMHTMLInputElement _setAutofilled:]): Ditto.
        (-[DOMHTMLSelectElement _activateItemAtIndex:]): Ditto.
        (-[DOMHTMLInputElement _isEdited]): Ditto.
        (-[DOMHTMLTextAreaElement _isEdited]): Ditto.
        (kitClass): Added. Gives HTMLOptionCollection objects an appropriate wrapper.

        * bindings/objc/DOMInternal.h: Removed most of the imports. There's no reason
        to have this header include all the other internal DOM headers. Removed unneeded
        interfaces, including the redeclaration of _init in DOMObject, since it's already
        inherited from WebScriptObject. Moved all the functions out of the WebCore
        namespace since this code is destined for WebKit, which doesn't use a namespace.
        Added kit and core functions for the two classes that live in this header.

        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]): Use core.

        * bindings/objc/DOMObject.h: Made the _internal field be private instead of
        protected. This also allows the "#define private public" trick to be used to
        make the field accessible inside the bindings code.

        * bindings/objc/DOMObject.mm:
        (-[DOMObject dealloc]): Updated for namespace change.
        (-[DOMObject sheet]): Use core and kit functions.

        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor dealloc]): Updated for namespace change.
        (-[DOMRGBColor red]): Use kit function.
        (-[DOMRGBColor green]): Ditto.
        (-[DOMRGBColor blue]): Ditto.
        (-[DOMRGBColor alpha]): Ditto.
        (core): Added. Replaces the _RGBColor method.
        (kit): Added. Replaces the _wrapRGBColor method.

        * bindings/objc/DOMSVGPathSegInternal.mm:
        (kitClass): Added. Replaces the _wrapSVGPathSeg method.

        * bindings/objc/DOMUtility.mm:
        (JSC::createDOMWrapper): Use kit function.
        (createDOMWrapper): Ditto.

        * bindings/objc/DOMXPath.mm:
        (core): Added. Replaces the _xpathNSResolver method.
        (kit): Added. Replaces the _wrapXPathNSResolver method.

        * bindings/objc/ObjCEventListener.mm:
        (WebCore::ObjCEventListener::find): Changed to use early return.
        (WebCore::ObjCEventListener::handleEvent): Use kit function.

        * bindings/objc/ObjCNodeFilterCondition.mm:
        (WebCore::ObjCNodeFilterCondition::acceptNode): Use kit function.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]):
        Updated for namespace change.

        * bindings/scripts/CodeGeneratorObjC.pm: Changed spelling of "license"
        to U.S. spelling. Removed GetObjCTypeMaker, GetObjCTypeGetterName,
        GetInternalTypeGetterSignature, and GetInternalTypeMakerSignature.
        Changed includes to conform to new scheme. Generate core and kit
        functions instead of methods and calls to those functions. Added a new
        attribute, Polymorphic, to indicate classes that have derived subclasses.
        Removed the old ObjCCustomInternalImpl attribute.

        * css/CSSRule.idl: Use Polymorphic attribute, so core and kit functions
        will be generated, with kit calling kitClass. This requires less hand-
        written code than the old ObjCCustomInternalImpl.
        * css/CSSValue.idl: Ditto.
        * css/StyleSheet.idl: Ditto.
        * dom/Event.idl: Ditto.
        * dom/Node.idl: Ditto.
        * html/HTMLCollection.idl: Ditto.
        * svg/SVGPathSeg.idl: Ditto.

        * editing/TextAffinity.h: Moved kit and core functions out of the
        WebCore namespace since this code is destined for WebKit, which
        doesn't use a namespace

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::declareAndWriteDragImage): Use kit function.

        * platform/mac/DragDataMac.mm:
        (WebCore::DragData::asFragment): Use core function.

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection): Use kit function.

        * svg/SVGElementInstance.idl: Removed now-unneeded ObjCCustomInternalImpl
        function. This can be generated in a standard way now.
        * svg/SVGViewSpec.idl: Ditto.

WebKit/mac:

2009-04-17  Darin Adler  <darin@apple.com>

        Reviewed by Antti Koivisto.

        Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
        https://bugs.webkit.org/show_bug.cgi?id=25210

        * DOM/WebDOMOperations.mm:
        (-[DOMNode markupString]): Use the core function instead of an Objective-C method.
        (-[DOMNode _subresourceURLs]): Ditto.
        (-[DOMDocument _focusableNodes]): Ditto.
        (-[DOMRange webArchive]): Ditto.
        (-[DOMRange markupString]): Ditto.

        * Misc/WebElementDictionary.mm: Added now-needed include since the core and kit
        functions now come from the internal headers from DOM bindings.
        * Misc/WebNSPasteboardExtras.mm: Ditto.
        * Plugins/WebNullPluginView.mm: Ditto.
        * Plugins/WebPluginController.mm: Ditto.
        * WebCoreSupport/WebChromeClient.mm: Ditto.
        * WebCoreSupport/WebInspectorClient.mm: Ditto.
        * WebCoreSupport/WebPasteboardHelper.mm: Ditto.
        * WebView/WebHTMLView.mm: Ditto.

        * WebCoreSupport/WebEditorClient.mm: Made kit function have internal linkage
        since it's only used in this file. Someone had instead added a declaration to
        suppress the warning you would otherwise get. Removed the core function.
        (WebEditorClient::textFieldDidBeginEditing): Added correct type checking.
        Previously the function would check only that something was an HTMLElement,
        but then cast it to HTMLInputElement. Also call kit instead of old wrap method.
        (WebEditorClient::textFieldDidEndEditing): Ditto.
        (WebEditorClient::textDidChangeInTextField): Ditto.
        (WebEditorClient::doTextFieldCommandFromEvent): Ditto.
        (WebEditorClient::textWillBeDeletedInTextField): Ditto.
        (WebEditorClient::textDidChangeInTextArea): Ditto, but for HTMLTextAreaElement.

        * WebView/WebFrame.mm: Removed the core and kit functions here which are no longer
        needed since they're automatically generated now.
        (-[WebFrame _nodesFromList:]): Use kit.
        (-[WebFrame _markupStringFromRange:nodes:]): Use core.
        (-[WebFrame _stringForRange:]): More of the same.
        (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
        (-[WebFrame _firstRectForDOMRange:]): Ditto.
        (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
        (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
        Ditto.
        (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
        (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
        (-[WebFrame _markDOMRange]): Ditto.
        (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
        (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
        (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
        (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
        (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
        (-[WebFrame _characterRangeAtPoint:]): Ditto.
        (-[WebFrame _typingStyle]): Ditto.
        (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
        (-[WebFrame _pauseAnimation:onNode:atTime:]): Ditto.
        (-[WebFrame _pauseTransitionOfProperty:onNode:atTime:]): Ditto.
        (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.

        * WebView/WebFrameInternal.h: Removed the core and kit functions here which are no longer
        needed since they're automatically generated now.

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): Use core.
        (formElementFromDOMElement): Ditto.
        (inputElementFromDOMElement): Ditto.
        * WebView/WebTextIterator.mm:
        (-[WebTextIterator initWithRange:]): Ditto.
        (-[WebTextIterator currentRange]): Ditto.
        (-[WebTextIterator currentNode]): Ditto.
        * WebView/WebView.mm:
        (-[WebView textIteratorForRect:]): Ditto.
        (-[WebView setSelectedDOMRange:affinity:]): Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@42618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=25251
        Crash when frame creation removes it from the parent

        This brings us up-to-date with the expectations of sub-frame
        creation, following what Mac has done. It fixes crashes when
        calling init on the child frame removes it from the page.

        This makes the following test pass instead of crash:

          fast/loader/frame-creation-removal.html

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createFrame):

git-svn-id: svn://svn.chromium.org/blink/trunk@42617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        <rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage

        If the Page is in private browsing mode when a statement is queued up, flag that 
        statement as read-only.

        It would be better to set the read-only flag on the database thread when it actually
        executes, but that would either require making Settings access a lock-protected operation
        or involve a synchronous callback to the WebCore thread, neither of which seem worth it.
        If it becomes an issue in practice, we can revisit this later.

        Test: storage/private-browsing-readonly.html

        * storage/Database.cpp:
        (WebCore::Database::setAuthorizerReadOnly):
        * storage/Database.h:

        * storage/DatabaseAuthorizer.cpp:  For all action types that would alter the database,
          deny when in read-only mode.
        (WebCore::DatabaseAuthorizer::reset):
        (WebCore::DatabaseAuthorizer::createTable):
        (WebCore::DatabaseAuthorizer::dropTable):
        (WebCore::DatabaseAuthorizer::allowAlterTable):
        (WebCore::DatabaseAuthorizer::createIndex):
        (WebCore::DatabaseAuthorizer::dropIndex):
        (WebCore::DatabaseAuthorizer::createTrigger):
        (WebCore::DatabaseAuthorizer::dropTrigger):
        (WebCore::DatabaseAuthorizer::createVTable):
        (WebCore::DatabaseAuthorizer::dropVTable):
        (WebCore::DatabaseAuthorizer::allowDelete):
        (WebCore::DatabaseAuthorizer::allowInsert):
        (WebCore::DatabaseAuthorizer::allowUpdate):
        (WebCore::DatabaseAuthorizer::setReadOnly):
        * storage/DatabaseAuthorizer.h:

        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::create): Add a m_readOnly flag.
        (WebCore::SQLStatement::SQLStatement): Ditto.
        (WebCore::SQLStatement::execute): If m_readOnly is set, tell the authorizer to change
          to read-only mode.
        * storage/SQLStatement.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::executeSQL): Flag the statement as read-only if the Page is
          currently in private browsing mode.

LayoutTests:

2009-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        <rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage

        * storage/private-browsing-readonly-expected.txt: Added.
        * storage/private-browsing-readonly.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.

        WebKit side of <rdar://problem/6449642>.
        
        * Plugins/Hosted/HostedNetscapePluginStream.h:
        (WebKit::HostedNetscapePluginStream::create):
        New function that creates a stream from a frame loader.
        
        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
        Add the constructor that takes a frame loader.
        
        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Pass "fullFrame" to the plug-in host.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCCancelLoadURL):
        Call NetscapePluginInstanceProxy::cancelStreamLoad.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::create):
        Pass "fullFrame" to the constructor.
        
        (WebKit::NetscapePluginInstanceProxy::manualStream):
        New getter for the manual stream.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Take the implicit request into account if we have a full frame plug-in.
        
        (WebKit::NetscapePluginInstanceProxy::setManualStream):
        Setter for the manual stream.
        
        (WebKit::NetscapePluginInstanceProxy::cancelStreamLoad):
        Cancel the manual stream if necessary.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        WebHostedNetscapePluginView now conforms to the WebPluginManualLoader protocol.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView createPlugin]):
        Pass "fullFrame" to instantiatePlugin.
        
        (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
        (-[WebHostedNetscapePluginView pluginView:receivedData:]):
        (-[WebHostedNetscapePluginView pluginView:receivedError:]):
        (-[WebHostedNetscapePluginView pluginViewFinishedLoading:]):
        Call the equivalent manual stream functions.
        
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin):
        Use a macro for getting the plug-in view type.



git-svn-id: svn://svn.chromium.org/blink/trunk@42615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        * WebHistory.cpp:
        (WebHistory::data):



git-svn-id: svn://svn.chromium.org/blink/trunk@42614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
        https://bugs.webkit.org/show_bug.cgi?id=25268

        Lots of minus lines.  Now we're sharing more sane code
        (which will respect -webkit-transforms! and scroll offsets correctly)

        Which means this fixes:
        https://bugs.webkit.org/show_bug.cgi?id=20769 too!

        We're no longer expanding the paint rect "for anti-aliasing", since
        I can't find a case where that's required.  If it is, repaintRectInLocalCoordinates()
        should be fixed to handle those cases instead of here.

        This fixes svg/custom/scroll-hit-test (now that we respect scroll offsets when repainting)
        as well as improves our focus ring drawing seen in svg/custom/focus-ring
        focus rings are now closer to transformed content by a couple pixels (they were needlessly outset by the antialiasing hack)
        Also, it fixes the dumped rects for markers, causing a progression in svg/custom/marker-overflow-clip

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::setPath):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGModelObject::computeRectForRepaint):
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::computeRectForRepaint):
        * rendering/RenderSVGRoot.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - remove tests affected by <rdar://problem/6661401> from the skip list,
          now that it is fixed.

        * platform/mac-snowleopard/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@42612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=25259

When a node becomes visible or hidden, accessibility needs to be told to update.



git-svn-id: svn://svn.chromium.org/blink/trunk@42611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix.

        Fix the build with enabled SVG filters

git-svn-id: svn://svn.chromium.org/blink/trunk@42609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=25242

        Remove QtCore 4.5 dependency from QWebElement test

git-svn-id: svn://svn.chromium.org/blink/trunk@42608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<https://bugs.webkit.org/show_bug.cgi?id=25027>

Contributed by Mihnea Ovidenie
Reviewed by Oliver Hunt

When dealing with negative numbers, parseInt should use ceil instead of floor.


git-svn-id: svn://svn.chromium.org/blink/trunk@42607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        <rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size

        Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit.  Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.

        * create_hash_table:
        * runtime/Lookup.cpp:
        (JSC::HashTable::createTable):
        (JSC::HashTable::deleteTable):
        * runtime/Lookup.h:
        (JSC::HashEntry::initialize):
        (JSC::HashEntry::next):
        (JSC::HashTable::entry):
        * runtime/Structure.cpp:
        (JSC::Structure::getEnumerableNamesFromClassInfoTable):



git-svn-id: svn://svn.chromium.org/blink/trunk@42606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Gavin Barraclough

Basically to ensure we don't accidentally invalidate the cached callframe
we should be using the cached callframe rather than our own exec state.
While the old behaviour was wrong i have been unable to actually create a
test case where anything actually ends up going wrong.


git-svn-id: svn://svn.chromium.org/blink/trunk@42605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25196
        Add a missing V8DOMMap include.

        * bindings/v8/WorkerScriptController.cpp: Included V8DOMMap.h.

git-svn-id: svn://svn.chromium.org/blink/trunk@42604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25260
        Finish V8 custom bindings for InspectorController.

        * bindings/v8/custom/V8InspectorControllerCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL): Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Mark Rowe.

        Fix for heavy leakage of WebURLResponses seen during the stress test 

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::shouldCacheResponse):



git-svn-id: svn://svn.chromium.org/blink/trunk@42602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Switch to wxGraphicsBitmap when using wxGraphicsContext so that we're not doing unnecessary conversions internally when drawing bitmaps.
        
https://bugs.webkit.org/show_bug.cgi?id=25248


git-svn-id: svn://svn.chromium.org/blink/trunk@42601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-16  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        Performing a block style change in an editable root that contains only a br adds a newline
        https://bugs.webkit.org/show_bug.cgi?id=25256

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Fix a bad check for an root
        block that didn't handle a root that contained a placeholder.

LayoutTests:

2009-04-16  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.
        
        Performing a block style change in an editable root that contains only a br adds a newline
        https://bugs.webkit.org/show_bug.cgi?id=25256

        * editing/execCommand/25256-expected.txt: Added.
        * editing/execCommand/25256.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Fix computeContainerBoundingBox to respect viewport translations
        https://bugs.webkit.org/show_bug.cgi?id=25254

        Previously computeContainerBoundingBox was just adding the viewportTranslation.
        Which, although it has a confusing name, only contains the scale and translation
        for the viewBox/preserveAspectRatio adjustment.  It does not contain the
        translation for the x/y offset of the viewport.
        localToParentTransform() does contain this offset, so we use that instead
        of the previous hacky code.

        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::computeContainerBoundingBox):

git-svn-id: svn://svn.chromium.org/blink/trunk@42599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Add a localToParentTransform() method which includes the
        full transform between local and parent local coordinates.
        https://bugs.webkit.org/show_bug.cgi?id=25226

        Moved m_localTransform up into RenderSVGTransformableContainer
        and added a comment to RenderSVGViewportContainer to make it more
        clear that it does not have a localTransform().

        This patch reveals two more failed design decisions:
        1.  Use of RenderBox::absoluteTransform() to mean "absoluteTransform()
            including only my localTransform()" callers are probably using it
            incorrectly anyway and are just masking bugs in the confused code.
        2.  computeContainerBoundingBox does not include viewport translations in
            its computed bounding box, so bounding boxes will be off for parents of
            inner <svg> elements.  I'll fix this an updated the results in a separate change.

        No functional changes, thus no tests.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::localToParentTransform):
        (WebCore::RenderObject::absoluteTransform):
        * rendering/RenderObject.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::viewportTransform):
        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:
        (WebCore::RenderSVGHiddenContainer::absoluteTransform):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::localToParentTransform):
        (WebCore::RenderSVGRoot::absoluteTransform):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGTransformableContainer.cpp:
        (WebCore::RenderSVGTransformableContainer::localToParentTransform):
        (WebCore::RenderSVGTransformableContainer::localTransform):
        * rendering/RenderSVGTransformableContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::localToParentTransform):
        (WebCore::RenderSVGViewportContainer::absoluteTransform):
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::computeContainerBoundingBox):

git-svn-id: svn://svn.chromium.org/blink/trunk@42598 bbb929c8-8fbe-4397-9dbb-9b2b20218538