- 11 Nov, 2020 40 commits
-
-
Nico Weber authored
After the 2nd-to-last clang roll, release component builds make chrome crash on launch due to CFG. Disable CFG for component builds until we roll in a fix. This does not affect shipping chrome, which doesn't use component builds. CFG was already disabled in debug component builds. Bug: 1147194,1147445 Change-Id: Idd2ab6dcc6e89e604d8f0c6f37369f7b389b31c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532875 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#826317}
-
S. Ganesh authored
All the new library/class/interface ids in the BUILD file are now dynamically generated by midl, based off the product name and current version. Bug: 1109612 Change-Id: I3f0806c7266184c78fd61ff25ac511834dc2ed56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530525Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826316}
-
Guillaume Jenkins authored
Enables CBCM by default on Chrome branded build (the --enable-chrome-browser-cloud-management command-line switch is still needed for Chromium builds). Because the logic for checking whether CBCM is enabled or not is now back to being the same on all platforms, this change also removes the IsEnabled delegate method and brings the check back to the core CBCMController class. As a result, the command switch declaration was moved to components so it can be shared between platforms. Bug: 1111435, 1097161 Change-Id: I5f15f06885b4deb3974616667273706931df6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522981 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826315}
-
danakj authored
Convert RenderWidgetHostNSView mojom to use ui::Cursor instead of WebCursor. Then WebCursor is no longer used, which was previously using the SkBitmap param traits.. R=dcheng@chromium.org TBR=inferno@chromium.org Bug: 1144462 Change-Id: I5f06739475e5421ba5f6acdca985bf0e03182744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523334Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826314}
-
Liquan (Max) Gu authored
Context: Currently, "waitForUpdatedPaymentDetails" is used in the payment codebase to mean two things: (1) an action: whether show() should be blocked from showing the payment details until the merchant passes in the payment details with show()'s PaymentDetailsUpdate promise. (2) a state: whether the payment details is now pending for update - once the details is received, the state is reset to false. These two meanings makes it ambiguous for code readers. To clarify it, this CL create mIsShowWaitingForUpdatedPaymentDetails to make it clear when it represents a state (meaning #2). Also, "isShow" makes it easier to read when this variable appears out of the scope of show(), e.g., in PaymentUiService for example. This CL also renames initializeWithUpdatedDetails() as continueShow() to make the control logic explicit. Changes: * Renamed some waitForUpdatedPaymentDetails as isShowWaitingForUpdatedPaymentDetails when it means a state. * Renamed initializeWithUpdatedDetails as continueShow. * Documents about show()'s PaymentDetailsUpdate promise in updateWith(). Bug: 1131059 Change-Id: I6c6b99ce5149c22fc6d7d4327e1eae0dacd10e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529618Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826313}
-
Roman Sorokin authored
Also modify test to verify the behavior. Bug: b/168759134 Change-Id: Ic04de90bb393efba4ad262090305e8232f398a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532075 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826312}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e42693daf419..850ce5aaee72 2020-11-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-11 kimjae@chromium.org portage_util: Compile regex once for efficiency 2020-11-10 bmgordon@chromium.org cros_sdk: Switch use_image off by default 2020-11-10 juahurta@google.com cros_branch: Remove cros_branch 2020-11-10 ahassani@chromium.org dev_server_wrapper.py: Deprecate unused functions 2020-11-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-09 seanabraham@chromium.org constants: update skylab package pin 2020-11-09 engeg@google.com service/payload.py: full images can be signed 2020-11-09 lamontjones@chromium.org api: freshen python bindings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia404b8d63725813a2bc11d3409b16fcfa70c3a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532920Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826311}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011110600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/q6S1Q6V4_M64y2wv8AI6ZmwjOFY46EgVtPz9XcWJVRsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/172266988 Tbr: help-app@grotations.appspotmail.com Change-Id: I69944115874ce5dc239930c58a3c0f7df80ca01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826310}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d4297e6b205..dfff133590c2 2020-11-11 treehugger-gerrit@google.com Merge "test: don't run KernelAddressSymbolization test on user builds" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idabd307466bc11ff023ea23281cce451377fa404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532626Reviewed-by:
-
Fredrik Söderqvist authored
The |needs_boundaries_update_| flag isn't really used for anything since we always update the boundaries/object bounding box regardless. Hence it doesn't add anything that the return value of UpdateBoundingBox() doesn't already convey. In ImageChanged() only check if the image dimensions changed without updating the oBB, but rather leave that to the layout that will be triggered. Bug: 1028061 Change-Id: I418e49952bbd808ceecc44bfa27b7ce07f8d698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532459Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#826308}
-
Steven Bingler authored
Two histograms will be added, one for localhost and one for non-localhost navigations. These will be used to help determine how cookies are used in the wild. These histograms, unlike their "scheme" omnibox counterpart, will collect values on copy/paste. The values collect are a subset of the full TCP port range for performance reason. A number of "interesting" values were chosen + 5 more incremental values for each. Both the desktop and Android builds were tested using chrome://histograms. Bug: 1141135 Change-Id: I70dd3f6833519bbf74300a0807c7326c90117c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518252 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#826307}
-
Leo Lai authored
we are obsoleting `TpmIsBeingOwned()`, which is not really necessary anyway; even if `TpmIsBeingOwned()` returns `true`, triggering the TPM initilaization again is just no-ops at ChromeOS side. BUG=b:172775884 TEST=TBD if untitests needed. Change-Id: If4240a0c8a9a7485d77856e1e5c346c89407c09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532155 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#826306}
-
Guillaume Jenkins authored
Donates the Search In Chrome intent to SiriKit every time a search is performed in the Omnibox. The donation is performed on the IO thread to avoid blocking the UI thread. This also updates the intents definition file to make the Search in Chrome intent available for Siri suggestions, which was previously disabled and prevented intent donation. Bug: 1146116 Change-Id: I6f7beb004a7f38d3a6297c8e7c171675fef2277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521202 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#826305}
-
Dave Tapuska authored
This collapses two implementations into a common one in the base class. BUG=1097816 Change-Id: I31a9edbe6af04450c12521a7a9b68907df8fb18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526172 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3630044b6610..17f22b43ebf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC wjmaclean@google.com,mstensho@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: wjmaclean@google.com,mstensho@google.com Change-Id: I2c1809a7c00f644279a76621ee8d7beea717c679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532914Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I90dab70bbcf3bd89ac7b02cd4dbb05e9c5828970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502669 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The goal of the UI is to notify the user if the recoverability of the account that holds the sync data is not good enough, and the user may run into data loss. To fix this case, the user can press the button in the profile menu. The actual action corresponding to this button is not introduced yet in this patch but instead TODOs have been added, to be addressed in follow-up patches. All logic is behind a feature toggle in lower layers (SyncServiceCrypto) and disabled by default. Change-Id: I86977e710b6109d86f2384b235dbeafaebd762fb Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461326 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#826301}
-
Scott Violet authored
To do otherwise results in accessing random data. BUG=1147430 TEST=none Change-Id: Icedacbaac64cad3fc903e6423c6f9aad8c1e8cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531118 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Chris Sharp authored
Bug: 1146509 Change-Id: I67d27099b546bc913807f516ec807f36bd74f9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523491 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826299}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011110600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/JSl1qileDHkV8PHpvOU7urG6MOGEQqSYE0Nn_cEAVYIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/162791694,b/163087524,b/170172788 Tbr: media-app@grotations.appspotmail.com Change-Id: Ie7b57314959edbb0c6898d741e5db313bd5f3118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532913Reviewed-by:
-
Ana SollanoKim authored
This change addresses a TODO for the resolution of grid gaps that are percent or calculated. The available size used to calculate the gap is based on the column/row definitions, as the grid's width/height are 'auto'. The intrinsic block size does not include the gap when it is percent or calculated. The rest of the failing grid-gutters WPT tests depend on 'auto' inline sizes. A couple of TODOs were added to address the changes that will be needed in order to mark those as passing. Bug: 1045599 Change-Id: Ia226f179eb4b3a0034e3701567dce6458b79736d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503402 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#826297}
-
Brian Salomon authored
There is one remaining but it requires deeper refactoring to convert. Bug: skia:10632 Change-Id: I95b8742c50f1af724940c937ac7f95b572e17463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522979 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#826296}
-
Jan Krcal authored
This CL improves the algorithm of color selection to disallow colors that are taken by other profiles. To this end, logic to generate ProfileThemeColors is consolidated in profile_colors_util.h. The exact same logic is then used to generate ProfileThemeColors from the list of all predefined profile colors. A next CL will improve the logic further: to exclude the first line of predefined profile colors (unless all colors are taken) and to prefer colors on the same line (for sign-in interception). Bug: 1108295 Change-Id: I6ed155dfa4376ea195e1a5a0f51586319d5ad0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529123 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
behdad authored
CompositorLatency.Diagnostic.PresentationTimeDeltaFromDeadline we being recorded to validate the assumption that most presented frames would be reported close to the deadline. As reported values confirm this assumption we do not need to track this values anymore, so this change removes this metric. Bug: 1125656 Change-Id: Ic2ab96609577c91d71d402a114d22f3df14cf86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527622Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#826294}
-
Nicholas Verne authored
DeviceManager isn't necessarily ready to be used straight away. It should be ready after PostBrowserStart returns. Bug: 1129735 Change-Id: I9b65ab48a3b442bf2803a0337354b8fefaab38d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530962Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826293}
-
Ian Kilpatrick authored
... replace with more explicit naming. Length::IsIntrinsic, Length::IsAutoOrIntrinsic were a misnomer. Specifically they returned true for -webkit-fill-available. For many of the callers, returning true for this case was necessary (often triggering a ComputeMinMaxSizes pass). This change renames these Length functions, introducing: - Length::IsContentOrIntrinsic - Length::IsAutoContentOrIntrinsic - Length::IsContentOrIntrinsicOrFillAvailable Change-Id: Ie06f535ccae7c362ecd2e35d7757bf8e87ad2df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523681 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826292}
-
Felipe Andrade authored
Create kerberos_section.h/cc files to implement the new Kerberos section. The UI for this new section will be added later. Also, define new settings routes, URL paths and icon for this new section. Bug: 983041 Change-Id: If29a1cfcf9999eb46b0a3615b720a27aaf4d8e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489906 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 00592994. Reason for revert: Turned android-asan red. crbug.com/1147311 Original change's description: > Read later: Implement more ReadingListModelObserver methods. > > Implements more ReadingListModelObserver methods. When sync happens, we > need to sync the in-memory bookmark tree. > > Bug: 1133504 > Change-Id: I87f7c9ec0f52a73b436d3b44eb8bd3278cda78ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518774 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824094} TBR=dtrainor@chromium.org,twellington@chromium.org,olivierrobin@chromium.org,wylieb@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1133504 Change-Id: Icf7dfee5df7d35fe59f9e806b72c8a69f1d93f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532461 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
danakj authored
R=dcheng@chromium.org NOPRESUBMIT=true TBR= NOTRY=true Change-Id: I93bc6a9360997fae7adeab8c01f56e08fc025dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523543 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
This CL updates the expiry of histograms that are bound to expire soon. It also updates the descriptions since the semantics of the histograms changed in place after commit a5484e63. Bug: 1144816 Change-Id: I0eaf28a4f59c7d5803dcda9acd0f36e6678e8bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527507Reviewed-by:
-
Roman Arora authored
A list component that renders DOM items on demand based on the viewable scroll area and user navigation and scrolling interactions. Provides a performance gain for use cases where users have several dozens of items that should be available while scrolling the list by deferring scripting and rendering costs until necessary to fill the current scroll view. Bug: 1099917 Change-Id: Ib22c0edf5ebc5febe3d8d6d4f7d8ac319e9bd0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503401 Commit-Queue: Roman Arora <romanarora@google.com> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#826287}
-
Evan Stade authored
Bug: 1147291 Change-Id: I04705c3aa57a0fa8cf7069b63b797c8882f7f277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530322Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#826286}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ca89ac1f4b0..8630bb119f96 2020-11-11 sigurds@chromium.org Revert "Add option to git cl st to sort by committer date" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ida955be5937cba773b011835adb22f68425631db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532698Reviewed-by:
-
Mohamed Heikal authored
This is blocking doubledown roll. Change-Id: Icd55bbdb029665ca7342ffba3161efc0d9eacfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532713 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#826284}
-
Toby Huang authored
I was unable to reproduce the flaky failure, which is a DCHECK error in an unrelated file. I suspect the error is due to daylight savings time changes. This CL re-enables the flaky tests. I will reassign the bug to the file owners. Bug: 1144651 Change-Id: I59224e96031dc27bd6839c43ccc3f7b3b6936431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531015 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826283}
-
Nico Weber authored
This is a reland of 5e46febb Original change's description: > mac/ios: Use real response files instead of -filelist. > > Xcode 12 added support for real response files, so let's use them. > Allows making response file contents more like on other systems > (libs, solibs, frameworks, swiftmodules now go in the rsp file too), > and makes it theoretically possible to have object files with spaces > in their name. > > No intentional behavior change. > > Bug: none > Change-Id: I8c2d6ff1abd47261bf7674dc7bf4506814681ad4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527621 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Brett Wilson <brettw@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825480} Bug: none Change-Id: Ib355508d2d45ab3ddf9ece76b6e95106c784fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530350 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826282}
-
Mitsuru Oshima authored
This allows target specific path/data resolution. Bug: None Change-Id: I684e99b09c43838f1b5065a892fa013c9a6be462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524823Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#826281}
-
Andreas Haas authored
Also rename byteLengthAsSizeT to byteLength, lengthAsSizeT to length, and byteOffsetAsSizeT as byteoffset. Bug: chromium:1008840, v8:11074 Change-Id: Ia689bc69be99c334567f1664bf8933c859b01301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521185 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#826280}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/869eb97f6c29..5acf6a857b48 2020-11-11 johnstiles@google.com Code cleanup: replace macros with lambda functions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: Iea3566ceacffe38a1705f0f8bda29d1d49ff346a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532816Reviewed-by:
-
Nicolas Ouellet-Payeur authored
This is needed to enable DestroyProfileOnBrowserClose by default in automated tests (crrev.com/c/2503629). GCMStoreImpl::Backend owns an sql::Database object, which may perform IO when destroyed. Release it on the blocking task runner, so it doesn't cause issues when the DestroyProfileOnBrowserClose flag is on. Bug: 88586 Change-Id: I657ae488c6a55c1608bf45466ea6a3bc0153786f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511250 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#826278}
-
