- 29 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia12ca4e2f2c10018dd44d058ef4d9778cb4eb866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324680Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792702}
-
Victor Hugo Vianna Silva authored
Bug: 1090931 Change-Id: If41e533eefce52db80a40e1ab7fdcfe75ae906e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317873Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#792701}
-
David Maunder authored
To support the work of moving Tab attributes out of Tab to objects which implement the UserData interface so the Tab doesn't become too big and unwieldy Bug: 1109345 Change-Id: Ife994234aa53ae1f12dde47cee0abe91765b3491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318625 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#792700}
-
Sebastien Lalancette authored
Listing gambard and myself as co-owners of this directory. Bug: 1093302 Change-Id: I2e37ebeb2c5ffe4cb649026a443e0707df06f1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323131Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#792699}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d8380b6383dc..eb118ddc8dea 2020-07-29 janscheffler@chromium.org Migrate `front_end/mobile_throttling` to `devtools_entrypoint` 2020-07-29 janscheffler@chromium.org Migrate `front_end/inline_editor` to `devtools_entrypoint` 2020-07-29 janscheffler@chromium.org Migrate `front_end/screencast` to `devtools_entrypoint` 2020-07-29 szuend@chromium.org Add basic Markdown rendering component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099162,chromium:1101738,chromium:1108699 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e75d36ffbb402feeaa2da199c934d2381852b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325983Reviewed-by:
-
Jérôme Lebel authored
Updating Signin.SSOIdentityListRequest metrics. The metrics should record where the identity list come from when being requested. This changes don't change the values already recorded. The goal is to prepare to add a third value later: "SSO identity list returned from stale cache" Related to: + crrev.com/i/3151963 Metrics introduced with: + crrev.com/c/2201720 + crrev.com/i/2995955 Change-Id: Idc3264e2864c2a1ea98cac41f61fef0c69f74399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283744 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#792697}
-
Steven Bingler authored
Create new exclusion reasons to send to DevTools for Issue Pane messages. These new reasons will be added when the correct conditions cause a cookie to be blocked because of Schemeful Same-Site. The messages for these new reasons are in progress. Bug: 1054036 Change-Id: If23d4a01cad160b6c7b0b6b342c8982d172a672c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292686Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#792696}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc8e77f0e521..28e801ad3afb 2020-07-29 swiftshader.regress@gmail.com Regres: Update test lists @ dc8e77f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1dc8ba00f6dc6824ec2cea225a288b846c04bcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325974Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3bb07848..e5f80a2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I949bbb0bb99aa9b26e8c7271e524002e67ed79b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324365Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792694}
-
Alexei Svitkine authored
Bug: None Change-Id: If395ad9984c944efd609f7ea2c9c86ee3f904d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324882Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792693}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/592c94cd987f..ab07b2bef2ac 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 171e04fac342 to c0bf676837e4 (3 revisions) 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3ee5f2f1d331 to 7ab4564696a7 (1 revision) 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 3b36fdc64014 to a4505d37ffe7 (1 revision) 2020-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 12c9d4ac61f2 to dc8e77f0e521 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I4efb1142becbd402a1d35bb4c533111f6cacf5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325908Reviewed-by:
-
David Jean authored
Bug: 1079422 Change-Id: I2dba760395245d3d14a6459c38955907a9bef41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270152 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#792691}
-
Wez authored
Bug: 1053628 Change-Id: I59254c7f29b05642dee3ce30c867bf190bcc18a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315032 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792690}
-
Yutaka Hirano authored
Bug: 109251 Change-Id: I2dd9728b5489f0ead1c0e75d89623845844f97d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325430 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Fargat Sharipov authored
There are some cases when deletable matches can be duplicates in BaseSearchProvider, so after deleting we can still observe Remove Suggest button. This CL adds checking whether there are deletable duplicates with matching contents and type. Bug: 1108674 Change-Id: Ic1a247957a3c8d0dde01134edb6205bd3006e6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315859 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792688}
-
Swapnil authored
We have several installation stages that the force installed extension must go through. We want to add installation stage event to the existing events for the event based reporting for force installed extensions. Bug: 1106423 Change-Id: I0be845a1c30ad399eb62103dd3bc6ec07d783bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302906 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792687}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I71b438c741141bb240587a2eff5f1d696144d857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326011Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c34efe0da102..8c7ecc1c06f4 2020-07-29 reed@google.com Revert "Revert "Never share pixels when we make a subset image"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8f54932ae7aaabff8d63814a7f6ffd3f0de99bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325976Reviewed-by:
-
Sreeja Kamishetty authored
Instead of clearing the user data on renderer crash, this CL clears the data only after starting next navigation when the RenderFrame goes to created state. Bug: 1099237 Change-Id: I3816d5c32ea36b4f651430076a262ae9b71b84bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292492 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792684}
-
Alex Ilin authored
Upcoming updates to the multi-profile experience make the "main" color of the profile more prominent on several surfaces. One of these surfaces is the profile picker window which should have access to colors attributed to unloaded profiles. Currently, the profile theme info is stored in profile preferences which are read from the disk when a profile is loaded. This CL caches required colors in ProfileAttributesStorage. Data from ProfileAttributesStorage can be accessed without having to actually load a profile from disk. The colors are updated every time the profile's theme changes. This is implemented by listening for the chrome::NOTIFICATION_BROWSER_THEME_CHANGED notification in ProfileThemeUpdateService. Bug: 1102384 Change-Id: I4683ded5d7182117dd2a712437f64f1f00ceed72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317796 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792683}
-
Mikel Astiz authored
Instead of manually creating keyed services using deprecated TestingProfile APIs, it's more appropriate to access a keyed service that is not null in tests. Change-Id: I49ecd1425a3bc2f4aa533c52aa3530da568a5bd8 Bug: 789214,1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325919Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792682}
-
Victor Hugo Vianna Silva authored
This CL fixes the linked bug by ensuring the plaintext password property in ShowPasswordBehavior is reset when the element is pointed to another credential, i.e. when "entry" is changed. The result is that removing a credential, or doing a search filter will hide any plaintext passwords being shown. Before what happened was: - Deleting a pwd would update the savedPasswords array in MergePasswordsStoreCopiesBehavior. - The backing array of the iron-list of pwds in PasswordsSection would be updated. - The "entry" properties of the PasswordListItem in the iron-list would be updated *but* the "password" properties wouldn't be updated. Contrary to what one may believe, removing an element from the backing array of an iron-list doesn't actually remove the corresponding element from the DOM. The CL also makes the visibility state of the password in the edit dialog not be synced with the corresponding row in the pwd list anymore. Bug: 1110290 Change-Id: Ibb5d10999b4c966fcf382f5a18e76ce462090188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325731 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792681}
-
Matt Jones authored
This patch replaces the obsolete ScrimView widget with the new scrim component in the autofill assistant. Some of the tests that included waiting for elements to be removed from the test web page have been updated to use criteria helpers, making them a bit less flaky. This patch also includes a change to how the touch delegate is attached to the scrim: it is now only attached if a delegate is set as it would otherwise interfere with the gesture detector. Bug: 1062099 Change-Id: I79547256efa62eef7bc1d86090942a8471a60285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308454 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#792680}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596002257-98af7ef1af792787ca531e13e152ea25d40693fb.profdata to chrome-mac-master-1596023419-4b4a08e94302fde0805a3dccb841fbad1e992234.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibe64428b888271632ed25175549a849faaf7827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325978Reviewed-by:
-
Rainhard Findling authored
* Adds the reboot functionality to the reboot button of the safety check Chrome cleaner child. This allows users to directly reboot their machines from safety check, instead of being forwarded to the Chrome cleaner UI first. Bug: 1087263 Change-Id: Ie10ab48cd6452fb23e737de3d8a01c3be0edff9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299742 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792678}
-
Joel Hockey authored
Bug: 1109941 Change-Id: If9c7cf3656685f0339338a78afee7dbc07e16cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325432 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792677}
-
arthursonzogni authored
Display a console error whenever the COOP header is ignored by chrome due to the origin being untrustworthy. This will help developers understand why their Cross-Origin-Opener-Policy isn't effective. Bug: chromium:1110821,chromium:1059303 Change-Id: I1965391da92154376d0e2a9699a697091389b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325917Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792676}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fbf20a6507ed..d8380b6383dc 2020-07-29 janscheffler@chromium.org Migrate `front_end/settings` to `devtools_entrypoint` 2020-07-29 jacktfranklin@chromium.org Reland "Migrate `front_end/toolbox_bootstrap` to `devtools_entrypoint`" 2020-07-29 szuend@chromium.org [cleanup] Fix imports for 'bindings' and 'common' unit tests 2020-07-29 sigurds@chromium.org Invalidate console viewport once new issue is detected If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1110102 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6ede338d47c76080d123c5b4aedb1cdda3500ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325971Reviewed-by:
-
Roman Sorokin authored
This CL modifies code in a way that GaiaScreenHandler is owned and handled by GaiaScreen. TBR=alemate@chromium.org Bug: 1079199 Change-Id: Idea2f8b9a2974007286e9e8562d1bcee0f2df423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279800 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#792674}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I6aaf3124709d62805436b15471ee16a79f1aaa6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324679Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792673}
-
Sebastien Lalancette authored
Added a new Delete action to History entries' context menus. Selecting that action will delete the focused entry. Regarding the business logic of the action (deleting the entry), this CL reuses the existing delete logic used by entries' accessibility actions. Bug: 1093302 Change-Id: Id1a21fe441ee922d63e10107e9bdbaadadc7be75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308849Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
arthursonzogni authored
There are 3 function to get a DomWindow from an isolate: - LocalDOMWindow* EnteredDOMWindow(v8::Isolate*); - LocalDOMWindow* IncumbentDOMWindow(v8::Isolate*); - LocalDOMWindow* CurrentDOMWindow(v8::Isolate*); The difference is explained by: third_party/blink/renderer/bindings/core/v8/V8BindingDesign.md For same-origin accesses to a window's method, the wrong V8 context was used. Instead of being the "calling" context, it was the "called" context. Using IncumbentDomWindow instead of CurrentDOMWindow fixed the issue. See response from: https://bugs.chromium.org/p/chromium/issues/detail?id=1109153#c2 COOP access reporting: [ 1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [ 2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [ 3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [ 4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [ 5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [ 6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [ 7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697 [ 8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889 [ 9/N] https://chromium-review.googlesource.com/c/chromium/src/+/2310530 [10/N] https://chromium-review.googlesource.com/c/chromium/src/+/2315024 [11/N] this patch. Bug: 1090273 Change-Id: I3da021c33af25831a242f64ff732556aa6775a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323250Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
David Roger authored
This CL passes the profile color and the text color from native (C++) to WebUI. The text color is computed to have good contrast with the background. Light color and light mode: https://drive.google.com/file/d/1A1tdffEMp2I0zwk2fofD59_GCSY59s67/view?usp=sharing Light color and dark mode: https://drive.google.com/file/d/1FCTLApc_z5JT1tSC2yzKilSBZyzIUpbP/view?usp=sharing Dark color and light mode: https://drive.google.com/file/d/1HeH2iFhUdRMXFX6yUJOcHX68u5JfGmpF/view?usp=sharing Dark color and dark mode: https://drive.google.com/file/d/1ZYHFAcHIsU1Qa96aMsT0nalZR3an9Yjm/view?usp=sharing Bug: 1076880 Change-Id: I4ee51b8f1d178e57d3e6375b75affa72ae8e5582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324422 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#792670}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0320db93. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I28b101bf67dbaacf026407ef0ee23fc07549caf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324323Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792669}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a8af6641ce8e..14ca9390e34a 2020-07-29 dberris@chromium.org Revert "auto-triage: Revision range url support non-chromium revision" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: eseckler@google.com Change-Id: I987e4fa0e2243998b9eedc32cb1af7e45101fa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325903Reviewed-by:
-
Oleg Davydov authored
This commit moves expire date of the following histograms: * Extensions.ExtensionCacheCount * Extensions.ExtensionCacheSize Also ownership of these histograms is now in sync with other histograms related to policy-based extensions. This makes sense since cache is used on Chrome OS for them. Bug: 975705, 984259 Change-Id: Ie8d364df4cefeeb5d16ca1d7ef872c8cc7a8dcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260640 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#792667}
-
Oleh Lamzin authored
Use closure compiler for browser tests. Fix compilation error for MessagePipe.sendMessage since it expect object or undefined. Bug: b:158566609 Change-Id: I0c3cc042d9fbfd6da801d67ac8d6f27b37ffaa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320593 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#792666}
-
Gauthier Ambard authored
Fixed: 1106735 Change-Id: Ib40832dff0096b0c01788a9209b3bc45f440e8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317950Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#792665}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4866d0ad5f3c..c34efe0da102 2020-07-29 thestig@chromium.org Fix use of undefined TARGET_OS_SIMULATOR for Non-Metal builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I3592e18d1a0f82e1358acad7eecc3c073c0adcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325896Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bf57c8f..3bb07848 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I618efa9bf562701eb428357f80491599d59e6700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324508Reviewed-by:
-
