- 15 Feb, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0aebddcb..d8c8ba85 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d893611fb1ad4c75b168d7d1fe544fd4b162e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057010Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741713}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bb7534ee99ce..12a36dd9ea4a git log bb7534ee99ce..12a36dd9ea4a --date=short --first-parent --format='%ad %ae %s' 2020-02-15 jmadill@chromium.org Vulkan: Add debug utils functions to wrapper. Created with: gclient setdep -r src/third_party/angle@12a36dd9ea4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I566f4f529ab5d4a18d2b4cfcaee073e303c7f1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741712}
-
rbpotter authored
- Autogenerate P3 versions of prefs.js and prefs_behavior.js - Add targets as necessary, add files to grdp - Autogenerate tests for P3 version of prefs. Bug: 1026426 Change-Id: Ia54cbced589fdb4bc1af4cd08f33e78a8396ac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058009 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#741711}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5e12e8b1512f45419345a90637daaadc0ab30058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057246Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741710}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: Iaa7e9ac65f55b49c2a656e17794f5892248cbece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053867 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#741709}
-
Amy Huang authored
This change makes clang build with a new debug info mode (added to LLVM in https://github.com/llvm/llvm-project/commit/651128f5) with the goal of reducing debug info size. The new debug mode only emits class type info when a constructor is emitted. This avoids emitting class type info everywhere a class is used. I built chrome with and without this change on Windows and Linux: Change in .obj files on Windows: Before: 38416945 kb After: 22485379 kb % diff: 41.5% Change in .o and .dwo files on Linux: Before: 12996366 | 16508965 kb After: 12155224 | 6409893 kb % diff: 6.5% | 61.2% Change in total build directory size on Windows | Linux: Before: 51483873 | 37913685 kb After: 35213926 | 26766367 kb % diff: 31.6% | 29.4% I did some local non goma builds and they seem to be slightly faster some of the time. For the full chrome build, before | after Linux: 1:47:11 | 1:45:52 Windows: 52:55 | 50:26 In an incremental build, linking chrome.dll on Windows took around 32-37 seconds before and 28-31 seconds after. I can't see a noticeable difference for incremental builds on linux. I also built a random cc_unittest on Windows and the debug info in Visual Studio looks the same. Change-Id: I02b86d74a859922274be292d1af49fc6030476f0 Bug: 1050118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040441 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741708}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/71b3dd56da8d..215b5370bc4f git log 71b3dd56da8d..215b5370bc4f --date=short --first-parent --format='%ad %ae %s' 2020-02-15 cwallez@chromium.org CMake: Add support for the OpenGL backend Created with: gclient setdep -r src/third_party/dawn@215b5370bc4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7493a6a9f106cd3861c5260be8a63eebe7afb4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056572Reviewed-by:
-
Demetrios Papadopoulos authored
Originally landed at https://chromium-review.googlesource.com/c/chromium/src/+/2045171 but reverted because of a test failure in linux-chromeos-dbg. Fix for the test failure is included here. Bug: 1026426 Change-Id: Ia8b824ac020239b1c041f24c71c5e8da1a6706ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051028 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#741706}
-
chrome://extensionsToby Huang authored
This CL reverts the changes in crrev.com/c/1956227 and restores the enable toggles instead of buttons on the chrome://extensions page to ask for parental approval. This design reversal was made after deciding to launch the parent approval dialog on the chrome://extensions page directly instead of jumping to Chrome Web Store in a new tab. If an extension is disabled pending custodian approval, clicking the enable toggle should launch the parent approval dialog on the chrome://extensions page directly, once the dialog is ready. If the enable attempt succeeds, the toggle remains enabled. Otherwise, the toggle automatically goes back to the off state. Bug: 1045509 Change-Id: Ib2e0995942568027ea70168f16ccc00ac51aba40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040195 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Sammie Quon authored
It was a clause that was always returning true, thus skipping the next clause which happens only if: 1) User is in snapped splitview with desks. 2) User drags window on top of splitview window, up to the same side as the desks bar, and then across to the desk bar (and reverse), almost as if to intentionally avoid the desk bar. With this CL, users who follow the above steps will get a slightly better UX. Test: manual Bug: none Change-Id: Ib7d352466fadaf4a61e3a0534c66982a42752380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057595 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#741704}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab921263..0aebddcb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I451e6783490515ca9ffff1f763e8f371fd78e216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057824Reviewed-by:
-
Robbie McElrath authored
This CL makes WebView record a new Variations.DownloadJobFetchTime metric from WebView's service via a new IVariationsSeedServerCallback AIDL interface. See doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw for more details. Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'AwVariationsSeedFetcherTest#*' Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedLoaderTest#*' Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedServerTest#*' Test: Manually verified correct metrics were being recorded by adding Test: logging when recording the metrics. Bug: 1047536 Change-Id: I5a34df24a3dc9c6250a45dce976c2f759fd8c0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039812Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#741702}
-
rbpotter authored
- Replace exportPath() with updatePrefPath_() in prefs.js - Make exportPath() fully private in cr.js and remove parameters that are only used from prefs.js. Bug: 1026426 Change-Id: I58e1da64902ee07ad4298060544056d16cce3413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056609Reviewed-by:
-
Matt Mueller authored
Bug: 991247 Change-Id: I598a9130b5d5f15aa24041a6f739abf578842c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052612Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#741700}
-
Philip Rogers authored
This treewalk can eventually move into the prepaint tree walk but for now just put it in the correct lifecycle step. When CompositeAfterPaint launches, much of the descendant dependent update will be removed and it will be easy to incorporate it into the existing prepaint walk. Bug: 941180 Change-Id: I53f38f36552a824fe6086f37e90c4f958e969f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044453Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741699}
-
Thomas Guilbert authored
The fix in 0b6135a7 introduced a new flake. It's possible for the video.rAF callback to be fired by the second video's first frame size, before the seek even completes. This CL fixes the issue by queueing the video.rAF call for the second frame size after the first frame size has painted. Bug: 993671 Change-Id: Iecf1601cdc5b76361ddfb9a62a718092ace90468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033628 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741698}
-
Regan Hsu authored
This CL records user action focus when the settings window focuses and blurs when the settings window blurs. Bug: 1049830 Change-Id: Id229e6baae50daa3ef44d7b58497004ce25e5941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042748Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Chris Harrelson authored
It launched a few releases ago. Bug: 603193 Change-Id: Ie91cdc164ea86eb4dcd702fb8a898fee7a481c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057867Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741696}
-
Andrew Xu authored
There is the legacy code in ScrollableShelfView::HandleMouseWheelEvent: if the shelf is horizontally aligned, ScrollableShelfView checks whether it should handle the mouse wheel event and if not it will redirect the event to Shelf (to affect the launcher visibility). In fact, event redirection is unnecessary in the current code. On one hand, for the touchpad scroll (which may be also received by View::OnMouseEvent), ScrollableShelfView::OnScrollEvent will check whether the scroll event should be handled here or by Shelf. In addition, OnScrollEvent is hit before OnMouseEvent. On the other hand, for the real mouse wheel event, from the perspective of the expected UI behavior, it does not make sense that ScrollableShelfView redirects the event to Shelf. Because when scrollableShelfView receives the mouse wheel event, it implies that the mouse cursor is within the bounds of ScrollableShelfView. In this CL, this part of legacy code is removed. Besides test cases related with the touchpad event and mouse wheel event are created. Bug: 1052191 Change-Id: I8b42545ad89edba23ebec2b4ae19f4c5dbf2505c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057095 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741695}
-
Alex Cooper authored
This is a reland of 96d43c20 Changes for reland: * SERVER_PORT variable moved from individual tests to XrTestFramework * XrTestFramework configures embedded test server to use HTTPS * RenderTests set their port explicitly. * Tests that were setting server port/not expecting HTTPS were updated * Re-add GetFileUrlForHtmlTestFile for use by testFileUrlEmphasis * Update Goldens as a result of URLs changing from file to server, and from the default http to https. (Goldens pulled from Patchset 3 of this CL). Original change's description: > Switch Android VR tests to use embedded test server > > As part of the work to use the permissions prompt by default, instead of > the custom consent dialogs, tests will need to be updated to use the > embedded test server rather than directly navigating to a file. This is > due to the fact that the Permissions code will DCHECK if saving the > permission for a file-type URL. > > Bug: 1043241 > Change-Id: Iaa820812fac0bc389af47c22f8e069e81929b05a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047987 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740399} Bug: 1043241 Change-Id: I208c6f0517bfc2f382466631f3844fc11cec5375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049839 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741694}
-
Jazz Xu authored
This CL fix the issue by updating pip availability when media loading is complete. Bug: 1051142 Change-Id: Iea84f73aca6af85d951f4e7ca20240b597ef0ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044657 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741693}
-
Vikas Soni authored
Use ExternalVkImageFactory as an interop factory instead of SharedImageBackingFactoryAHB for software decode video path on android. This is because AHB backing do not support single channel formats used by video frames in this path. Bug: 985387 Change-Id: I31243c34a8b72beb0a7af0bec7e54bd326e9a203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045130 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741692}
-
Kurt Horimoto authored
This DCHECK assumes that every |-scrollViewDidEndDraggingWithGesture: targetContentOffset:| callback is received following a corresponding |-scrollViewWillBeginDraggingWithGesture:|. This is not always the case though, since sometimes the begin dragging signals is not sent if the drag begins at the same time as WKWebView events like page loads or navigations. This CL removes the DCHECK and updates FullscreenModel to send the FullscreenModelObserver::FullscreenModelScrollEventStarted() callback when |scrolling_| is set to true, which occurs when the scroll view is either dragging or decelerating. This allows for this callback to be handled even if the drag begin callback was skipped. Bug: 1001872, 1048010 Change-Id: I6dec6280ba738ecdd4eb035e1133bae7fe7868ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057809 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#741691}
-
Toni Barzic authored
For test that test home button specifically, for the button to be shown by setting an accessibility feature that overrides shelf navigation buttons hiding in tablet mode. For others, use GoHome instead of tapping home button to trigger logic if the feature to hide the buttons is enabled. BUG=1051714 Change-Id: I843d3c537df05835682b67aa71a54fa39ef6f99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057594Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741690}
-
Chris Lu authored
FullscreenWebViewResizer's |-updateForCurrentState| is only called in response to webview's frame KVO, but it also needs to be called when the toolbar heights are changed since it changes the visible viewport. Fixed: 1039658 Change-Id: Ib1afae58facfa85c358df0fc20f1aac7a2337acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052247 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#741689}
-
Hiroki Sato authored
This CL adds a new accessibility private API where extensions will be able to listen a ChromeEvent which is dispatched when TalkBack state in ARC accessibility gets changed. Android side change is http://ag/10260750. Bug: 981964 Test: unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*" Change-Id: I9012e9761d3995bd686c2651ecc9921ed8fc15e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037187Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#741688}
-
Sylvain Defresne authored
As a first step towards using Firebase via the internal framework, and thus removing the dependency upstream on Firebase, add a method to AppDistributionProvider to initialize Firebase. Bug: 1049042 Change-Id: Ifbbb211b844eeb564462586755f66913a01d5bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057750 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#741687}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9f4ab98d1264..bb7534ee99ce git log 9f4ab98d1264..bb7534ee99ce --date=short --first-parent --format='%ad %ae %s' 2020-02-14 ynovikov@chromium.org Use ASSERT() instead of assert() when possible. Created with: gclient setdep -r src/third_party/angle@bb7534ee99ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I1fbf495549351ec9fd513c3b5fc2d759af1ee9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057739Reviewed-by:
-
Yuichiro Hanada authored
This CL rewrites RewriteMouseWheelEvent to use new API. Bug: 1049489 Test: unit_tests Change-Id: I97aa14f7b51cd7c5d07125abe74848fa1b445e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055948 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#741685}
-
Scott Violet authored
Chromedriver is responsible for writing the flags file, so there is no need for run_android_wpt to do it. BUG=1049426 TEST=none Change-Id: Ib77b06756a9e6ea6c35995e4ea86a0476f9630bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056754 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741684}
-
Daniel Clark authored
Prior to this change the picker indicator element (the element inside the control's text box that can be clicked on to open the popup) for date, time, datetime-local, week, and month input controls all had an aria-label of "show date picker". This change updates the picker indicator's aria-label for each of these control types so that it actually corresponds to the control type ("show time picker", etc). Bug: 1026537 Change-Id: Id93ea60e6481d3996b5c663ff8b1a3baf703a168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052608Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741683}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/149341bb048d..38e9e47300ac Created with: gclient setdep -r src-internal@38e9e47300ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifa2dafb594a4ced4daf266bff20549e5431c5e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741682}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ieda03af232a15869edd2e252ea2d38475b36881f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058029Reviewed-by:
-
Jarryd authored
Match origin string representations on the SiteDetails pages with how they are represented on the AllSites page by displaying host only, except in cases where a non-default scheme or port is used. Bug: 997258 Change-Id: I17fda8124f9d4ac3dade15889f65e0a32f111b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043862 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
Per https://groups.google.com/a/google.com/g/chrome-speed/c/J1O_3GXF00Q and https://docs.google.com/document/d/1ntZVHyapCVuNMDjbEblI7za7GX_T96oV-FSmKtrEefA/edit#heading=h.a0tfb17lbj4z Turn off benchmarks that do not explicitly opt in to run on Win 7 Perf, Win 7 Nvidia GPU Perf, and Nexus 5. Also I fixed a bug in bot_platforms.py to make it more usable for this and fixed the sharding script deschedule command to additionally work for executables (gtests), not just benchmarks. I ran the following two commands after making the code changes to generate the autogenerated files: ./generate_perf_sharding.py deschedule ./generate_perf_sharding.py update-timing --filter-only Note that after this change these platforms will become extremely unbalanced. I will reshard them this weekend to reduce the potential culprit list if there is a silicon-lottery related regression as low as possible. Note that it turns out that passthrough_command_buffer_perftests and validating_command_buffer_perftests were only scheduled on the Win 7 Nvidia GPU Perf bot. Since they were not opted in, they became removed from all bots. I sent an email directly to the owners of those executables to ask them if they wanted those executables scheduled on the win 10 perf bots. Bug: 1030840 Change-Id: I66b282ec9a312f58c822c3f06a9f845226b6ce20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056564 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741679}
-
Alex Cooper authored
When run in parallel, the test can sometimes fail complaining that "device.mojom.Gamepad" is not a constructor; however, this does not seem to repro when run indepdently. Changing this to use a map with the appropriate default properties set seems to fix this issue when run in parallel. Fixed: 1052539 Change-Id: I24877e8bad709abda69e13b94455a174a100c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058005 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741678}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b444ec4d1fa9..05676f7bc238 git log b444ec4d1fa9..05676f7bc238 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 iapres@microsoft.com Reland: Ensure arcTo (SVG) ends at the targeted point 2020-02-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-14 khushalsagar@chromium.org images: Fix fuzzer crash for creating raster SkImage with invalid data. 2020-02-14 reed@google.com Defensively reset aa[] value when we call a blitter repeatedly Created with: gclient setdep -r src/third_party/skia@05676f7bc238 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1001768,chromium:1050445 Tbr: stani@google.com Change-Id: Ia095d229a95165fda0549f9c40c02a7c40febb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058023Reviewed-by:
-
Yuichiro Hanada authored
This CL changes RewriteMouseButtonEvent to use the new API. Bug: 1049489 Test: unit_tests Change-Id: Id06008eae4073bb072a3d07b0ce1c7b825c53eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043614 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741676}
-
Oksana Zhuravlova authored
This change replaces InterfaceProvider references with BrowserInterfaceBroker in the context of interfaces exposed by the browser. Change-Id: I6ee3e4b97cfd84a4c0fdc9fd968ea9184b15a306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057943Reviewed-by:
-
Jarryd authored
Adds calls to QuotaManagerProxy::NotifyWriteFailed() where write errors might occur in IndexedDB code. With this information, the quota system can reasonably guess if the disk storing the user's profile is out of space, and decide if any actions should be taken from there. Bug: 997258 Change-Id: Ifd7ea5c129a8467e47676a5d9ab157ef2015daea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029308Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#741674}
-
