GitLab

This standardizes callers on using GetLayoutConstant(TAB_HEIGHT) for the tab
height, instead of using a variety of methods.  It simplifies a few places
slightly and reduces the dependencies on tab.h slightly.

To avoid excess verbosity in tab_unittest.cc, this also gives Tab a preferred
size, solely so tests can call SizeToPreferredSize().

BUG=none
TEST=none

Change-Id: I15f22caee10f4acf5d3992d88133f5edf2d6e33a
Reviewed-on: https://chromium-review.googlesource.com/1107299
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569821}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c48318a35b17..08d753e88484


git log c48318a35b17..08d753e88484 --date=short --no-merges --format='%ad %ae %s'
2018-06-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-22 tandrii@chromium.org Revert "bot_update: Don't force solutions to be unmanaged."
2018-06-22 tandrii@chromium.org Revert "Wipe out shallow checkout support from bot_update."
2018-06-22 tandrii@chromium.org Wipe out shallow checkout support from bot_update.


Created with:
  gclient setdep -r src/third_party/depot_tools@08d753e88484

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:850812,chromium:853032,chromium:855700,chromium:855137,chromium:855700,chromium:855137
TBR=agable@chromium.org

Change-Id: I9f3c95031934c4be4cbdb53960a09bd707f61bc6
Reviewed-on: https://chromium-review.googlesource.com/1112227Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569820}

This class was the initial attempt at adding blob URL support to the
network service, but later a different approach was taken for blob
URLs where a explicit URLLoaderFactory needs to be passed in for
every blob URL fetch.

Getting rid of the old code revealed some places where the new code
doesn't pass in a blob URL Loader Factory, so fallback code is added
to those places (in NavigationControllerImpl for browser initiated
navigations and in RenderFrameHostImpl for renderer initiated
navigations) to make sure things keep working in all cases.

Bug: 800901

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icebab3007bef73910b20f6994c963c36f090605e
Reviewed-on: https://chromium-review.googlesource.com/1100100
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569819}

Change-Id: I14c3080d8b042d64339594ce5e4cbb5fcdc77034
Reviewed-on: https://chromium-review.googlesource.com/1112645Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569818}

Using the tab strip to close a tab crashes on iPad when using
multitasking. The difference when running multitasking is that
|-viewDidDisappear:| is not called on the tab grid. This may be a race
condition. The view controller lifecycle documentation shows that the
"Did" methods are not guaranteed to be called. Quick successive
presentation/dismissal calls can cycle just between the "Will" methods.

This CL changes the bookkeeping in grid view controller to use the
"Will" methods.

Bug: 849608
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idf3a95ad8d07d7f0dc1f64a6009f92eff07d5bc3
Reviewed-on: https://chromium-review.googlesource.com/1112378Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569817}

Fixes menu positioning miscalculations in ShelfView,
also refactors GetMenuAnchorRect so its more readable.

Bug: 852153
Change-Id: Ie8c377de9b2191c3ae739f5adec7f16fc8003bd7
Reviewed-on: https://chromium-review.googlesource.com/1102028
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569816}

This implements the codec string processing as described here:
https://aomediacodec.github.io/av1-isobmff/#codecsparam

Valid mime types look something like the following:
"av01.0.04M.10.0.112.09.16.09.0"
"av01.0.01M.08"

Bug: 784607
Test: New unit tests.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I320dbdc4571b49a6ccea0a464c10f8ba4e656037
Reviewed-on: https://chromium-review.googlesource.com/1109412
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569815}

Sometimes, server misidentifies countries and states,
and we can handle it with rationalization.
This usually happens when the form/field signature of
the two are identical. See go/rationalize-repeated-fields.

Tests + Refactoring.

Fixes: www.coolstuffinc.com
Bug: 850220
Change-Id: I85f601cd37f6c24b51423c8d3ccee0fc117f4f12
Reviewed-on: https://chromium-review.googlesource.com/1099559
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569814}

This will make it possible to check if the feature is enabled from
outside blink, and will also make it easier to turn the feature back off
if necesary after trying to launch it.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Bug: 800901
Change-Id: I4cba8299c9f43727b5d52cb5c329d0da296e2b59
Reviewed-on: https://chromium-review.googlesource.com/1110846
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569813}

Adds external/wpt tests for the SourceBuffer.changeType() method being
incubated in WICG/media-source spec repo's codec-switching branch.

BUG=605134

Change-Id: I52879fdff07473fbec6f5b44296dedd42619455c
Reviewed-on: https://chromium-review.googlesource.com/1111275
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569812}

ToolbarLayout has protected fields and protected getters. This seems
redundant so this CL makes the fields private and makes other
classes use the getter methods.

Change-Id: Icbab2351080ba65e1a12c70b80eee7bab5ba560a
Reviewed-on: https://chromium-review.googlesource.com/1112354
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569811}

Adds SourceBuffer.changeType() method behind MediaSourceExperimental
RunTimeEnabledFlag to implement, along with prerequisite Chromium MSE pipeline
change [a], this method being incubated for inclusion in the next
version of the Media Source Extensions (MSE) spec.

A subsequent CL will contain new web-platform-tests for this method.

See also intent-to-implement [b] and chromestatus entry [c]

[a] https://chromium-review.googlesource.com/c/chromium/src/+/1110483
[b] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/atNyZDs-WXY
[c] https://www.chromestatus.com/features/5719220952236032

BUG=605134

Change-Id: I7197bc4f30bfe70eb0733e2b06996651f708637f
Reviewed-on: https://chromium-review.googlesource.com/1111265Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569810}

https://webrtc.googlesource.com/src.git/+log/87e447992446..ac5bbd940ed3


git log 87e447992446..ac5bbd940ed3 --date=short --no-merges --format='%ad %ae %s'
2018-06-22 mbonadei@webrtc.org Reland "Enable any address ports by default."


Created with:
  gclient setdep -r src/third_party/webrtc@ac5bbd940ed3

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic9bf63e9e2d4a854c09aa9f66b324de46fd53846
Reviewed-on: https://chromium-review.googlesource.com/1112225Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569809}

Bug: 426139
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibbd9e7f0e68856583a88ede79ca9f79d9a57cb0a
Reviewed-on: https://chromium-review.googlesource.com/1112355
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569808}

Bug: 854704
Change-Id: I0900ccb649bb7c8b814b8b138bc52439d26bbb67
Reviewed-on: https://chromium-review.googlesource.com/1111651Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569807}

Using wpt-import in Chromium 77ab0de5.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19971

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: I9092f8e71becb6a05800af9fc3d0e07fefaf06da
Reviewed-on: https://chromium-review.googlesource.com/1112500
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569806}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I5e692b97d579161a212632c4644ea381757defd2
Reviewed-on: https://chromium-review.googlesource.com/1112637Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569805}

CLion is an IDE. This documentation is to make it easier to setup chromium development with CLion.

Change-Id: I020ec78e41aee54e425c40ae1ab4ee6f3cee27f9
Reviewed-on: https://chromium-review.googlesource.com/1110454
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569804}

This is a reland of 448f72d0 with a fix
to remove a static initializer, the problem was that a global variable
was initialized using a member field of another global struct.

Bug: 854896

Original change's description:
> Add the about flags for the TabManager/RC features.
>
> Change-Id: Id68cad067bb35f3b11bd8828806860110e8aaf79
> Reviewed-on: https://chromium-review.googlesource.com/1103304
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569094}

Change-Id: I1b490e126b4a4359ba6314f0e2ccc1b631cd2143
Reviewed-on: https://chromium-review.googlesource.com/1110157
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569803}

Bug: 855725
Change-Id: I91f6bab46701c9d66bc8b497661c460a7968619f
Reviewed-on: https://chromium-review.googlesource.com/1112075
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569802}

Change-Id: I74290b96dbfe84bf180c8809ad349d4ae81cb125
Reviewed-on: https://chromium-review.googlesource.com/1103596
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569801}

This reverts commit 812edd08.

Reason for revert: libuuid1:i386 should now be installed on the bots (bug 853048)

Original change's description:
> Revert "Reland "Update fontconfig to 6cc99d6a""
> 
> This reverts commit 0c91664f.
> 
> Reason for revert: Broke Linux Builder (dbg)(32)
> 
> Still missing libuuid:
> 
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697
> 
> [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
> FAILED: v8_context_snapshot.bin 
> python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
> ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
> ./v8_context_snapshot_generator failed with exit code 127
> 
> Original change's description:
> > Reland "Update fontconfig to 6cc99d6a"
> > 
> > This is a reland of e6db40d9
> > 
> > Reason for reland: All bots should now have libuuid1 installed (bug 853048).
> > 
> > Original change's description:
> > > Update fontconfig to 6cc99d6a
> > >
> > > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > > fix a use-after-free.
> > >
> > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > > dependency since we statically link fontconfig.
> > >
> > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > >
> > > BUG=831146,822737,787020,829890,847323
> > > TBR=thestig,dnicoara
> > >
> > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#567445}
> > 
> > TBR=thestig,dnicoara
> > 
> > Bug: 831146, 822737, 787020, 829890, 847323, 853048
> > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> > Reviewed-on: https://chromium-review.googlesource.com/1104759
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568221}
> 
> TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
> 
> Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 831146, 822737, 787020, 829890, 847323, 853048
> Reviewed-on: https://chromium-review.googlesource.com/1105539
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568346}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831146, 822737, 787020, 829890, 847323, 853048
Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be
Reviewed-on: https://chromium-review.googlesource.com/1112179Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569800}

Bug: 797586
Change-Id: I357e5b945886e51043d662973c9a1960f9b46929
Reviewed-on: https://chromium-review.googlesource.com/1086413
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569799}

This injects a ClientChannel into Messenger, which is used if the
chromeos::features::kMultiDeviceApi is enabled. The ClientChannel is used
to send and receive messages with the remote device.

R=jhawkins@chromium.org, khorimoto@chromium.org

Bug: 824568, 752273
Change-Id: If927eb84d013657db823f8538d138beb9c2c16be
Reviewed-on: https://chromium-review.googlesource.com/1107482
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569798}

The Content Service is a new s13n project intended to servicify
the bulk of the content layer's functionality, namely the ability for
applications to embed navigable web content views backed by isolated,
sandboxed content handlers. See https://tinyurl.com/ycrx5tgq for
a high-level overview and (eventually) links to more detailed
documentation.

This CL lands a trivial client View API with some tiny mojom surface
between it and the Content Service. The API as-is may be completely
throw-away, but this change gets all the necessary boilerplate and
plumbing landed.

The ContentServiceDelegate and ContentViewDelegate C++ interfaces are
exposed by the Content Service impl so that it can delegate to private
src/content implementation details without a dependency on src/content.

The browser itself is granted access to connect to Content Service for
now so that basic integration testing can be done via
content_browsertests. One such test is added here to verify a
functioning end-to-end connection between a client's View instance
and an actual backing WebContentsImpl.

Bug: 854365
Change-Id: Idd8e4d0e5f2922ffc48686a4057e6e7c262c3cc3
Reviewed-on: https://chromium-review.googlesource.com/1107012
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569797}

The system preferences for key repeat rate already limits the rate that
events are generated, so there's no need for another, arbitrary throttle.

Bug: 836947
Change-Id: I35927d4b475a45d7ff43d3d8f7e746e86f11f746
Reviewed-on: https://chromium-review.googlesource.com/1112561Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569796}

Also leave splitview when Chromevox is turned on. It seems strange
to quit especially if user accidentally press Chromevox but also
strange if user can get into a unsupported state.

Test: manual
Bug: 853588
Change-Id: Iff9577462ec20d379ffce96d4998fcd64dffd321
Reviewed-on: https://chromium-review.googlesource.com/1111082Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569795}

This patch updates device_settings' locale when user changes the voice
interaction pref kArcVoiceInteractionValuePropAccepted.

Bug: b/110094434, b/80431063
Test: manual. Can see updated locale in the log.
Change-Id: I80c90aca6c2e7c57cd2fd96ba998f43812e685c8
Reviewed-on: https://chromium-review.googlesource.com/1112617
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569794}

Bug: 855660
Change-Id: I26114b920ea9801a9d4bfdc74b29218dff035f41
Reviewed-on: https://chromium-review.googlesource.com/1112385Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569793}

Bug: 807764
Change-Id: I0758c2939049e22b60d653f69ce7537cb283487a
Reviewed-on: https://chromium-review.googlesource.com/1103598
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569792}

Bug: 713357
Change-Id: Iefd741be80323c322b63dd92f05b8758e96fb6ca
Reviewed-on: https://chromium-review.googlesource.com/1101490
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569791}

There were two subtle bugs in the original implementation:

i. cc::ScrollTimeline was incorrectly initialized with active_id_ ==
   pending_id_. This is incorrect as the current active tree may not
   yet have the relevant ScrollNode. Instead only pending_id_ should be
   set, and it will be promoted to active via the existing logic when
   the pending tree activates.

ii. cc::ScrollTimeline::PushPropertiesTo incorrectly updated the impl
    thread active_id_ from the main side. This is incorrect, main never
    has a valid active_id_ value (since it never gets updated by pending
    tree activations). This should only push the pending_id_ value,
    which may change e.g. if the scroller went display:none and back.

Bug: 853231
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib7bf4e82e779d11895c373f7c786727c1bcadb9d
Reviewed-on: https://chromium-review.googlesource.com/1110438
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569790}

This reduces the number of .cc files dependent on local_frame_view.h
from 2469 to 1930.

BUG=823365
R=skobes@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4631d893f47cd6a6b3768715f6328adfe17dc15c
Reviewed-on: https://chromium-review.googlesource.com/1112391Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569789}

Text input state and IME visibility are indended for PlatformWindow.
WindowTree calls WindowServiceDelegate to update them.
WindowServiceDelegateImpl forwards the states to
AshWindowTreeHostPlatfom to update the underlying PlatformWindow
if the change comes from an active window.

Bug: 852440
Change-Id: Id584ba0f5a17768fddd3d54caa2e9da051b14ee7
Reviewed-on: https://chromium-review.googlesource.com/1112069
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569788}

This reverts commit 905d2540.

Reason for revert:
After landing this patch, CrSettingsSiteEntryTest started failing on Mac 10.13 (dbg) and Win 7(dbg), though it succeeds on other platforms.

Flakiness dashboard data here:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsSiteEntryTest.All

Picking this change as a likely culprit, so we can get the tree back to green everywhere.

https://crbug.com/855687
is tracking the issue.

Bug: 855687

Original change's description:
> Reland "Settings: Content settings can now be reset for a group of origins in All Sites."
> 
> This is a reland of e2cac39f
> 
> Original change's description:
> > Settings: Content settings can now be reset for a group of origins in All Sites.
> > 
> > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
> > menu allows the entire list of origins to have all their content settings reset
> > in one go. This will be preceded with a confirmation dialog.
> > 
> > Manual test - With #enable-site-settings turned on, change a content setting via
> > Page Info > Site settings on both https://permission.site and
> > http://permission.site. Navigate to chrome://settings/content/all and see that
> > both sites are listed under 'permission.site'. Verify there is an overflow menu
> > on this entry and that inside the overflow menu, there is a 'Reset permissions'
> > option. Clicking this should bring up a reset permission dialog and confirming
> > the dialog should remove this entry from All Sites.
> > 
> > Bug: 835712, 717468
> > Cq-Include-Trybots: luci.chromium.try:closure_compilation
> > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
> > Reviewed-on: https://chromium-review.googlesource.com/1098577
> > Commit-Queue: Patti <patricialor@chromium.org>
> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568742}
> 
> Bug: 835712, 717468
> Change-Id: I6560d10b31602038daa03f57fc67b6a878794d5a
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/1109537
> Commit-Queue: Patti <patricialor@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569507}

TBR=dschuyler@chromium.org,patricialor@chromium.org

Change-Id: I18f90cd22046b3d79efae2878aaca822b26bd828
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835712, 717468
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1112122Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569787}

This is a reland of 1bd58466

Original change's description:
> [SessionStorageS13N] Enabling mojo SessionStorage by default
> 
> Bug: 716490
> Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f
> Reviewed-on: https://chromium-review.googlesource.com/1072918
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563169}

Bug: 716490
Change-Id: Ieae476bcb794047f5f57760eeb3e2e811838bc03
Reviewed-on: https://chromium-review.googlesource.com/1110777Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569786}

This injects a ClientChannel into ProximityAuthMonitor, which is used if the
chromeos::features::kMultiDeviceApi is enabled. The ClientChannel is used
to get the current RSSI of the connected remote device.

In the future, the "rolling average RSSI" that is calculated in
ProximityAuthMonitor will be moved to the SecureChannel API, and returned
by it. However, to reduce immediate migration work, that logic is kept
in ProximityAuthMonitor for now.

This CL was originally submitted as [1], but was reverted [2] due to a
subtle bug in a test, which has been fixed at [3]. This CL is unchanged
from the original.

1) https://chromium-review.googlesource.com/c/chromium/src/+/1106616
2) https://chromium-review.googlesource.com/c/chromium/src/+/1111937
3) https://chromium-review.googlesource.com/c/chromium/src/+/1112422

Bug: 824568, 752273
Change-Id: I5fba2dcb73fd4b8da08d93cbfa045b6f6888a93b
Reviewed-on: https://chromium-review.googlesource.com/1112434
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569785}

This CL removes two redundant PostTask usages from SandboxedUnpacker. In both
the cases, we are already on the correct sequence, hence we can call the
function synchronously.

BUG=None

Change-Id: I42deaad16bce1db2e2e1905aa13253251791c8b6
Reviewed-on: https://chromium-review.googlesource.com/1110839Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569784}

This patch updates device_settings' locale when starts the service,
which can handle the situtation that user changes preferred language.

Bug: b/110094434, b/80431063
Test: manual. Can see updated locale in the log.
Change-Id: I0113fc35367fff9298e5bd3c3ec6976726efaa0f
Reviewed-on: https://chromium-review.googlesource.com/1111656Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569783}

A constructor of base::{Once,Repeating}Callback takes a pointer to
BindStateBase, that is intended to be used by base::Bind*.
However, the constructor accidentally matches to nullptr parameter, and
that requires a null check of |bind_state| in the callback constructor.

This CL disables nullptr argument on the callback construction.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic74ca7ce94bc95922e122257d397ff5fbf1fa431
Reviewed-on: https://chromium-review.googlesource.com/1111179
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569782}