GitLab

Revert of Use dropdown list for admin areas in pr form. (patchset #18 id:1000001 of https://codereview.chromium.org/2680143002/ )

Reason for revert:
The patch causes chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester: crbug.com/709491.

Original issue's description:
> Use drop-down list for admin areas (state, province, ..)
>
> -- In the payment request form (instead of the previous text-field).
>
> - For this purpose, the rules of the specified country are loaded from
>  the i18n aggregate server, and the country's sub-keys are retrieved from the right rule.
>
> - If the server doesn't respond, or there is a time-out, or if no
>   admin areas are recorded for that country, show text-field.
>
>    -- Add all the fields to the form, only when admin areas are loaded.
>       This way we can have the fields in order. Otherwise, admin areas
>       would show up at the end (since they are fetched asynchronously.)
>
> - In the Payment Request tests, the admin area field would always be a
>   text field (and not a drop down). This way, the tests would be
>   independent of the network connection state.
>
> - Tests were added to the AddressValidatorTest according to the
>   changes.
>
> BUG=675634
>
> Review-Url: https://codereview.chromium.org/2680143002
> Cr-Commit-Position: refs/heads/master@{#462611}
> Committed: https://chromium.googlesource.com/chromium/src/+/69b196d676ecbbb986009aaf9f5627fd6e332de1

TBR=sebsg@chromium.org,mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675634

Review-Url: https://codereview.chromium.org/2800013004
Cr-Commit-Position: refs/heads/master@{#462867}

This method only sets the color for non-disabled states:
https://cs.chromium.org/chromium/src/ios/third_party/material_components_ios/src/components/Buttons/src/MDCButton.h?l=69

BUG=602666

Review-Url: https://codereview.chromium.org/2802033002
Cr-Commit-Position: refs/heads/master@{#462866}

This also applies when the element isn't contained by a multicol container
(which means that we shouldn't require the spanner placeholder to be present).

BUG=709362

Review-Url: https://codereview.chromium.org/2799363003
Cr-Commit-Position: refs/heads/master@{#462865}

Revert of memory-infra: Fill the memory dump callback result (2/2) (patchset #6 id:100001 of https://codereview.chromium.org/2766173003/ )

Reason for revert:
Causing build failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54494

Original issue's description:
> memory-infra: Fill the memory dump callback result (2/2)
>
> Fill in the part of the memory dump result struct
> that applies to OS's view of Chrome when finalizing
> a memory dump.
>
> BUG=703184
>
> Review-Url: https://codereview.chromium.org/2766173003
> Cr-Commit-Position: refs/heads/master@{#462849}
> Committed: https://chromium.googlesource.com/chromium/src/+/22fd5f0cf18a409dd72b96cb526a25a6cac88d24

TBR=primiano@chromium.org,fmeawad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703184

Review-Url: https://codereview.chromium.org/2806553005
Cr-Commit-Position: refs/heads/master@{#462864}

The timeline width seems to differ. https://crbug.com/709483 tracks
re-enabling these.

BUG=709483
TBR=mlamouri@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2802233002
Cr-Commit-Position: refs/heads/master@{#462863}

The test was previously disabled on Windows. It is flaky also on linux.
This CL disables the test fully.

BUG=600153
TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2803983003
Cr-Commit-Position: refs/heads/master@{#462862}

Crushed sprite resources and layers were only used for Contextual
Search. CS no longer has a use for a the animated sprite, so this
removes the crushed sprite resources and layers and replaces
the CS use with a static icon.

BUG=707001

Review-Url: https://codereview.chromium.org/2798123002
Cr-Commit-Position: refs/heads/master@{#462861}

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from onBindView.
4. Removed code to change enabled state.

BUG=none

Review-Url: https://codereview.chromium.org/2803753002
Cr-Commit-Position: refs/heads/master@{#462860}

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801983003
Cr-Commit-Position: refs/heads/master@{#462859}

This test is flaky (timeouts) in most dbg bots. Disabling.

BUG=709447
TBR=bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2803913005
Cr-Commit-Position: refs/heads/master@{#462858}

All answer text (other than the suggestion text and positive/negative
text) is now the de-emphasizing gray.

BUG=709101

Review-Url: https://codereview.chromium.org/2804143002
Cr-Commit-Position: refs/heads/master@{#462857}

Follow up to http://crrev.com/2795593006, changes Modulator::from/setModulator/clearModulator to take ScriptState* as a parameter instead of LocalFrame*

BUG=682322

Review-Url: https://codereview.chromium.org/2803843002
Cr-Commit-Position: refs/heads/master@{#462856}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b9bfcb4..05fb319

$ git log b9bfcb4..05fb319 --date=short --no-merges --format=%ad %ae %s
2017-04-07 peah@webrtc.org Adding support for handling highly reverberant echoes in AEC3.
2017-04-07 peah@webrtc.org Fixing sample-rate dependent band-split filter issues in AEC3

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2799093005
Cr-Commit-Position: refs/heads/master@{#462855}

Follow-up on https://codereview.chromium.org/2697793004 review comment.

BUG=none

Review-Url: https://codereview.chromium.org/2789123003
Cr-Commit-Position: refs/heads/master@{#462854}

This CL adds SigninAlertDialogTheme style that uses Google Blue 500 color
for button text and forces message text to use Chrome default text color.

BUG=650121,669787

Review-Url: https://codereview.chromium.org/2801213003
Cr-Commit-Position: refs/heads/master@{#462853}

BUG=704791

Review-Url: https://codereview.chromium.org/2779813002
Cr-Commit-Position: refs/heads/master@{#462852}

This test is flaky on Linux as well, and was already disabled on Mac and
Windows.

BUG=680544
TBR=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2807523004
Cr-Commit-Position: refs/heads/master@{#462851}

We were being too aggressive with our DCHECK(desc->IsObject()). The spec
says (and we even mention it in a comment) that a call to
Object.getOwnPropertyDescriptor can return undefined in addition to a proper
object descriptor.

We were only considering the latter case, and crashing on the DCHECK if we
ever received an undefined descriptor, which can happen when a Proxy is used
in JS.

This is also covered by external/wpt/fetch/api/headers/headers-record.html.

BUG=707365
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2801003005
Cr-Commit-Position: refs/heads/master@{#462850}

Fill in the part of the memory dump result struct
that applies to OS's view of Chrome when finalizing
a memory dump.

BUG=703184

Review-Url: https://codereview.chromium.org/2766173003
Cr-Commit-Position: refs/heads/master@{#462849}

IntRects can be implictly converted to FloatRect so code managed
to call enclosingIntRect on an IntRect which then converted to
FloatRect and back for an expensive noop.

R=mstensho@opera.com
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2805203003
Cr-Commit-Position: refs/heads/master@{#462848}

Adds UMA metrics to the media controls timeline <input type="range">, to
understand current usage, and detect changes in usage.

Specifically this adds:
- Media.Timeline.DragGestureDuration.<timeline width>
- Media.Timeline.DragPercent.<timeline width>
- Media.Timeline.DragSumAbsTimeDelta.<timeline width>
- Media.Timeline.DragTimeDelta.<timeline width>
- Media.Timeline.SeekType.<timeline width>
- Media.Timeline.Width
- Media.Timeline.Width.<Inline|Fullscreen><Portrait|Landscape>

BUG=693630

Review-Url: https://codereview.chromium.org/2779273003
Cr-Commit-Position: refs/heads/master@{#462847}

Add arg to MojoFrameSinkManager to pick surface lifetime type.

BUG=664547

Review-Url: https://codereview.chromium.org/2802773002
Cr-Commit-Position: refs/heads/master@{#462846}

According to the comment, this extra copy was needed when the bitmaps in a platform-canvas
wasn't ref-countable. That is no longer the case (hasn't been true for quite a while AFAIK)
so this CL removes that code.

BUG=

Review-Url: https://codereview.chromium.org/2799283003
Cr-Commit-Position: refs/heads/master@{#462845}

Screenshots: http://imgur.com/a/h8xyi

BUG=602666

Review-Url: https://codereview.chromium.org/2804853002
Cr-Commit-Position: refs/heads/master@{#462844}

Previously, when
TaskSchedulerTaskTrackerTest.WillPostAndRunLongTaskBeforeShutdown ran
with param = SKIP_ON_SHUTDOWN, these events could occur:

  Thread    Action
-----------------------------------------------------------------------
1 Main      Create a skip on shutdown task.
2 Main      TaskTracker::WillPostTask()
3 Main      Start thread to run task (SimpleThread::Start).
4 Main      Start thread to call shutdown (SimpleThread::Start).
5 Shutdown  TaskTracker::Shutdown()
              Returns immediately since the SKIP_ON_SHUTDOWN task
              isn't running yet.
6 Main      Expect shutdown to be blocked on the SKIP_ON_SHUTDOWN task.
              Error!

So far, we've been lucky and #5 never ran before the SKIP_ON_SHUTDOWN
had time to start running. However, making SimpleThread::Start()
non-blocking (https://codereview.chromium.org/2664953004) made
this series of events occur a few times on bots.

BUG=

Review-Url: https://codereview.chromium.org/2798373002
Cr-Commit-Position: refs/heads/master@{#462843}

The CSS Box Alignment specification defines a new shorthand to set the
Self Alignment properties (align-self and justify-self) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

The intent-to-implement-and-ship of CSS Box Alignment shorthands is:

https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/qCfsZJhGtOQ

BUG=668639

Review-Url: https://codereview.chromium.org/2804623002
Cr-Commit-Position: refs/heads/master@{#462842}

CSS Image Values 4 allows specifying up to two positions per color stop, e.g.:

  linear-gradient(45deg, black 0% 50%, white 50% 100%)

This is equivalent to repeating the color at the given positions:

  linear-gradient(45deg, black 0%, black 50%, white 50%, white 100%)

(https://drafts.csswg.org/css-images-4/#color-stop-syntax)

Add support for the new syntax, behind a runtime flag.

BUG=707047

Review-Url: https://codereview.chromium.org/2799793002
Cr-Commit-Position: refs/heads/master@{#462841}

The Reading List provider does not have an image to provide to the UI.
The FetchImage method runs the callback with an empty image.

BUG=702241

Review-Url: https://codereview.chromium.org/2802973004
Cr-Commit-Position: refs/heads/master@{#462840}

TestBrowserThread is deprecated. TestBrowserThreadBundle provides all
browser threads, a blocking pool and a TaskScheduler.

This CL was generated using the script posted on the bug +
git cl format +
tools/sort-headers.py +
some manual adjustments.

BUG=272091
R=gab@chromium.org
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2799253002
Cr-Commit-Position: refs/heads/master@{#462839}

This is to be consistent with our intended implementation & better
measure the metrics on vibrate blocking.

The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik

BUG=704650

Review-Url: https://codereview.chromium.org/2804913004
Cr-Commit-Position: refs/heads/master@{#462838}

This change makes V8HiddenValue class stateless, and we can remove
m_hiddenValue in V8PerIsolate.

BUG=611864

Review-Url: https://codereview.chromium.org/2774233007
Cr-Commit-Position: refs/heads/master@{#462837}

It flakily times out on the Linux Tests builder.

BUG=709202
TBR=avallee@chromium.org

Review-Url: https://codereview.chromium.org/2801943004
Cr-Commit-Position: refs/heads/master@{#462836}

The updated OrientationSensor.populateMatrix() algorithm[1] does not check sensor's state, it checks only whether the reading data are present.

BUG=661478

[1] https://w3c.github.io/orientation-sensor/#orientationsensor-populatematrix

Review-Url: https://codereview.chromium.org/2798923003
Cr-Commit-Position: refs/heads/master@{#462835}

Moved over local tests that are more comprehensive than the ones present
Adapted the moved-over local tests to use testharness
Removed old tests because they covered the same things in less detail
Un-skipped the folder in TestExpectations

BUG=694525

Review-Url: https://codereview.chromium.org/2798353002
Cr-Commit-Position: refs/heads/master@{#462834}

This change makes a difference of about 64 kB in the memory footprint of
IndexedRuleset.

BUG=708458

Review-Url: https://codereview.chromium.org/2798363002
Cr-Commit-Position: refs/heads/master@{#462833}

BUG=709394
TBR=maxmorin@chromium.org

Review-Url: https://codereview.chromium.org/2804953006
Cr-Commit-Position: refs/heads/master@{#462832}

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG=707860

Review-Url: https://codereview.chromium.org/2791363002
Cr-Commit-Position: refs/heads/master@{#462831}

This seems to cause a lost device, which causes the next test to fail.

BUG=709320
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2804963003
Cr-Commit-Position: refs/heads/master@{#462830}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2802703002
Cr-Commit-Position: refs/heads/master@{#462829}

The implentation was removed sometime ago, but I forgot to remove
the declaration.

BUG=695279
R=horo@chromium.org,japhet@chromium.org

Review-Url: https://codereview.chromium.org/2797423004
Cr-Commit-Position: refs/heads/master@{#462828}