- 21 Oct, 2019 40 commits
-
-
Francois Doray authored
This is a reland of 9d6a01ba We now handle negative values returned from ::GetThreadPriority(). https://chromium-review.googlesource.com/c/chromium/src/+/1829570 Original change's description: > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode. > > This experiment enables: > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of > background threads. This affects memory and IO priority in addition > to CPU priority. > - Increase thread priority to "normal" in scopes where background > threads load modules. > > The expectation is that this will improve responsiveness of Chrome > (input delay, first contentful paint), without regressing jank. > > We are adding the testing config in preparation for enabling this > via Finch in M79. > > Bug: 973868 > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705960} TBR=rkaplow@chromium.org Bug: 973868 Change-Id: I392cfb2f92e2ac0fa888fa1e323557ab35055b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872312Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#707822}
-
Kevin Ellis authored
This reverts commit af74d157. Reason for revert: pref regression in queuing durations Original change's description: > Web-animation: Remove some uses of PlayStateUpdateScope. > > PlayStateUpdateScope is problematic for handling timing of finished > promises in addition to not conforming with the algorithm outlined in > the web-animations spec. This patch removes several uses of > PlayStateUpdateScope and refines handling of pending flags. > > Bug: 960944 > Change-Id: I093a3aa86084adfbe128a5aedd36206d67dd12c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851927 > Commit-Queue: Kevin Ellis <kevers@chromium.org> > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705966} TBR=kevers@chromium.org,majidvp@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960944 Change-Id: Ib16d862d5834f837717e64bb86277860e50ec11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866624Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#707821}
-
Martin Robinson authored
The introduction of text-change signals for the omnibox included a regression that prevented the emission of AtkValue property change signals. Fix this error and also add an implementation of atk_value_set_value. The implementation is used in a test to verify the correct behavior. The fix is that we correct the misuse of a logical operator and now always try to emit AtkValue property change events when receiving the kValueChanged event in AXPlatformNodeAuraLinux. Bug: 1015387 Change-Id: I18baa44a52190913ff70708bd5133bdcdea83b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871692 Auto-Submit: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#707820}
-
Sergey Poromov authored
DeviceStatusCollector is used only for enterprise reporting, consumer (child) reporting is extracted to ChildStatusCollector, so it's safe to remove this flag for simplicity and ensure that DeviceStatusCollector is initialized only for enterprise reporting. Test: Run trybots. Change-Id: Ib64ca56c3e402b6c99ededc856a96674a2e025c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864992Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#707819}
-
Raymond Toy authored
The values of an AudioParam are supposed to be clamped to the nominal range. We do this already, but we forgot the case where there is a connection to the AudioParam. This can cause the values to go outside the nominal range and cause issues for the nodes that expected the values to be clamped appropriately. Manually tested ASAN build with this CL and crashes don't happen anymore. Without this, the crash was very reliable. Bug: 1015737, 1016165 Change-Id: Ia02bac7b60a7e20bdc5165dbfbb17df56d4d3171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869373 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707818}
-
Benjamin Beaudry authored
When calling AXPosition::ToPositionWithAffinity() on a position with a |container_object_| of type AXInlineTextBox, the position returned is always in the parent node, the StaticText object. Think of it as a modification from a relative position to an absolute position, based in the StaticText object. However, when an InlineTextBox object has siblings (i.e. the parent node has multiple InlineTextBox children), the position returned is only valid for the first non-empty child. This bug was due to the fact that we wrongfully assumed that the text offset in the child object would be the same as the text offset in the parent position. This is only true for the first non-empty child. This CL introduces a fix for this bug. Instead of creating a position in the parent node at the exact same offset, we add to it the sum of the previous siblings MaxTextOffset(). It also adds a unit test for this case. Bug: 928948 Change-Id: I1b52c7506e726956bca8b2d41d5a33bee3a84597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846563Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707817}
-
Yuki Shiino authored
clang-format takes care of formatting, but it's still newline- sensitive. So, make CodeNode family generate/remove appropriate newlines. Also renames |cond_node| and |body_node| simplifying to |cond| and |body|. Bug: 839389 Change-Id: Ic339fcc906ef3d9c5b26c29ebfac17291651d608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871713Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#707816}
-
Ben Mason authored
TBR=agrieve TBR_REASON=Breaking translation script Change-Id: I1e7bdbf4d4bfdba6446ed9596415bdcfb7a1ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872117 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707815}
-
Juan Antonio Navarro Perez authored
Replace instead with a simpler csv based implementation. Bug: 981605 Change-Id: I901601136a43833b8c83ef2f77117e4ba22014cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869417 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707814}
-
Francois Doray authored
As documented at https://cs.chromium.org/chromium/src/components/performance_manager/graph/frame_node_impl.h?l=215&rcl=2b413514ddc9679893b20235eb2cecbbca4d8245, lifecycle state of a frame/page is updated independently from navigations. There is no need to filter out updates generated prior to the last navigation. Bug: 857472 Change-Id: Ifd64c437349ed218847a6ca4486b8cd0248fb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869473 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707813}
-
Ella Ge authored
TBR=rsorokin@chromium.org No-Try: true Bug: 1015948 Change-Id: I971b24ba40310d9c368e26127a275e2677d51e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872150Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707812}
-
Miyoung Shin authored
This CL converts Camera3DeviceOps{Ptr, Request} in media to the new Mojo type, and uses pending_receiver<Camera3DeviceOps> in camera_common.mojom. Bug: 955171 Change-Id: I8c751cf880c39e80e00cab5055e96c583bf908ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862443 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707811}
-
Olivier Li authored
Create a function to allow clients of TestingProfile to wait on the destruction of its HistoryBackend. The HistoryServiceUsesTaskScheduler feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. Tests using TestingProfile need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: Iddb851d00ea64693f669bcb656829abcb2303b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868913Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707810}
-
François Doray authored
This reverts commit fe93195d. Reason for revert: This is a spurious failure caused by an unrelated issue https://crbug.com/1012445. Individual test should not be disabled because of this (a lot of tests are affected -- it wouldn't make sense to disable all these tests because of a single problem). Original change's description: > Disable flaky PerformanceManagerTabHelperTest.PageIsAudible > > TBR=fdoray > > Bug: 1012601 > Change-Id: I9540e12715b4b431af0b886c280f609b51851b10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852429 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704622} TBR=droger@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012601 Change-Id: Icb00d26109eac1d532740b992acba94255c023a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872310Reviewed-by:
-
Vladislav Kaznacheev authored
Currently many tests check for kShelfScrollable and return early. This causes missing regressions (such as crbug.com/1015688). This CL removes early returns at the start of test methods and instead force-disables force-disable kShelfScrollable (and also kShelfHotseat which triggers kShelfScrollable) for these methods. This ensures that these methods will be run even when kShelfScrollable and/or kShelfHotseat are enabled by default. A few tests remain that have a flag check in the middle of the test, those are left unchanged. Replacing those will require extra work. Bug: 1015891 Test: ash_unittests --enable-features=kShelfScrollable Test: ash_unittests --disable-features=kShelfScrollable Change-Id: Ic7a0987fbc4ffb8b68e262deb5830e832461583c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868984Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#707808}
-
Torne (Richard Coles) authored
Move ResourcesContextWrapperFactory to the embedder_support component so that weblayer can share it. In the process, rename it to ClassLoaderContextWrapperFactory, which better reflects what it actually does: it has little to do with resources (which are always just delegated directly to the context it is wrapping), and the primary thing it overrides is getClassLoader(). Downstream code still refers to the old class, so leave a forwarding version in place for now. Change-Id: I3c22c390012289d7c91aeb6986f1bf44fd34dda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867230 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707807}
-
Himanshu Jaju authored
SyncMode is not available when GetDeviceName is called. So we have to manually update the device name and merge it with sync data. Bug: 1009454 Change-Id: Icf0760eabf41171b9d7f222b620b0c41bc32bc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866651 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707806}
-
Yann Dago authored
Bug: 818872 Change-Id: I92a988afdae4862772717a4251f20e05d645bdc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868912 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#707805}
-
Javier Ernesto Flores Robles authored
Increased the section header. Decreased the section footer. Increased the space between title and top of the cells. Bug: 949060 Change-Id: I48501c665d7ff77388171bb0ac7bbf43ae23b976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865328 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707804}
-
Maksim Moskvitin authored
This CL adds recording for some missed histograms: CustomPassphraseKeyDerivationMethodStateOnStartup CustomPassphraseKeyDerivationMethodOnNewPassphrase CustomPassphraseKeyDerivationMethodOnSuccessfulDecryption Bug: 922900 Change-Id: I9e05b771a22c3480413d32788a2a59bd320bfa1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871549 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Marc Treib authored
Bug: 1004205 Change-Id: Ib5759c9c112cff7915eef128a21b12b89de30d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871593Reviewed-by:
-
Maksim Moskvitin authored
The test was disabled (crrev.com/c/1849426) because it instantiates FeatureLists after the browser threads have been created. It was needed to inject NigoriSpecifics with scrypt key derivation method, while test assumes that scrypt is disabled. The fix is just initialization of NigoriSpecifics in test fixture constructor, where it's safe to override features. The test also used to inject an encrypted bookmark to the server, but this part wasn't exercised further in test, so this CL just drop it. Bug: 1013073 Change-Id: I8d2947484a0192cf99fd2b84e44325ea1d6220fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872190 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Maksim Moskvitin authored
crrev.com/c/1787610 removed cryptographer checks in custom passphrase unittests, because used KeyDerivationMethod became an implementation detail. This CL restore those checks by bridge providing custom passphrase key derivation params through getter. Bug: 922900 Change-Id: I31abbf54e162c779cea50020231aed85e2e1a9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869221 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Maksim Moskvitin authored
Exposing last keystore key name allows the following: 1. Avoiding unnecessary copies of underlying CryptographerImpl in NigoriState::NeedsKeystoreKeyRotation(). 2. Removing ComputePbkdf2KeyName() from nigori_state.cc 3. Exposing HasKey(key_name) instead of HasKey(key_proto) from CryptographerImpl. This CL also adds unittests for KeystoreKeysCryptographer. Bug: 922900 Change-Id: If7004c658adeae2bd03d77f08b39fa63dd278b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868873 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/4fd355cc40..032591d692 TBR=bmeurer@chromium.org Change-Id: I8492a0fcfc98580b74b1874ee0abd6cdb3f1d2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871997Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b9f69028a0da..682dabd1c153 git log b9f69028a0da..682dabd1c153 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 cz.theng@gmail.com Add RTCStatisticsReport.h to WebRTC.framework. 2019-10-21 saza@webrtc.org Remove apm_helpers, consolidate audio config in WebRtcVoiceEngine Created with: gclient setdep -r src/third_party/webrtc@682dabd1c153 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ib23ed02b3fae86dd2ac4c03ee0c21dd80efccae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707797}
-
Ali Juma authored
The injected versions of pushState and replaceState synchronously call the built-in version of these functions, and then send a message to Chrome's process. After receiving this message, Chrome injects script to perform a replaceState with the same state and URL. Since this happens asynchronously, it will incorrectly clobber changes to history state that have happened since the original call to pushState or replaceState. These extra calls to replaceState are also unnecessary, since the injected functions already call the built-in equivalents. A previous attempt (https://crrev.com/c/1514060) at removing this logic only did so for pushState, leading to a bug (crbug.com/949305) when a page does: replaceState(someState, someTitle, "#replace"); pushState(someOtherState, someOtherTitle, "#push"); Because replaceState still had the extra asynchronous call, the actual sequence that was excecuted was: replaceState(someState, someTitle, "#replace"); pushState(someOtherState, someOtherTitle, "#push"); // A bit later: replaceState(someState, someTitle, "#replace"); This effectively erased the pushState. This CL removes the extra calls from both pushState and replaceState, and adds test coverage for back-to-back calls to replaceState followed by pushState and vice-versa. This also fixes subtests in the following two Web Platform Tests that currently fail in Chrome but pass in Safari: html/browsers/history/the-history-interface/history_pushstate_url.html html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc.html Bug: 769945 Change-Id: I34b51a0a91def67cbe85ef16761497a293f1b497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867308 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#707796}
-
Elly Fong-Jones authored
The original version of this used Cmd-Option-Up and Cmd-Option-Shift-Up; after some experimentation and further thought from UX we're going to go to Cmd-Option-Up and Cmd-Option-Down instead, which will free up Cmd-Option-Shift-{Up,Down} for another use. Bug: 956432 Change-Id: Id617bef7f94fcc35d438bf585a675a28a667bc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868914 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707795}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52e9d677c6eb..03882834cb55 git log 52e9d677c6eb..03882834cb55 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 tmrts@chromium.org [vinn] Enable snapshots and update Windows d8 binary to 7.6.303.31 Created with: gclient setdep -r src/third_party/catapult@03882834cb55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1001953 Change-Id: I66e566a214cc0754248e7e00b833061ee9a6bd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872230Reviewed-by:
-
Fergal Daly authored
- Move run-swarmed and mb.py to the top of the doc This is a great doc but after working through a lot of steps, I found that I could have just run mb.py. So this adds a "The easy way" section at the top of the doc and moves the combined tools to that. - Factor out the authentication section so that it's linkable. - Add a concrete example and advice on how to construct $criteria. Change-Id: I0e7dcbcf9ce38aeed08a614e35f3f1374d2fa8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871158Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707793}
-
Mikel Astiz authored
A privileged Javascript API is exposed to allowed origins, which requires analogous plumbing between the renderer process and the browser process. In this patch, the Mojo interface is introduced and basic implementation of both ends, with a browser test that exercises the full flow. Design doc (Googlers only): https://docs.google.com/document/d/1YNrBAzmHlhjEigpjcR_hm7yrvGIuJOZpXEhtqNloUec/edit#bookmark=id.bgwil9c791bc Bug: 984940 Change-Id: Ic3c941b5209a03bc35dce44ecdd31a8e47af0b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725913Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707792}
-
nancy authored
BUG=1009248 Change-Id: Idfd3f413054297f40814eabbc650bb70eb3049d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868210 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#707791}
-
Marc Treib authored
These were part of the old bookmark sync implementation and not used anymore. With this, the ModelAssociator interface becomes unused and is removed too. profile_sync_service_bookmark_unittest.cc basically contained unit tests for the two removed classes, also based on low-level directory code. These are not relevant anymore and so are also removed. Bug: 933756 Change-Id: I616f38ab9170d3d3fdae5eac427c8eda1c0ab658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863808 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Ella Ge authored
This reverts commit fac39a19. Reason for revert: Causing ash_unittest failing. Start from: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/35783 Original change's description: > overview: Fixed aspect ratio for overview items in splitview. > > Overview items now match the aspect ratio of the window bounds if they > get snapped. This will happen if splitview is active on either side, or > if the window is getting dragged close enough to an edge. A videos of > before and after this patch is in the bug. > > Follow up: > Make this work for tablet mode with 6 or more windows. In that case > the positioning logic follows a different path. > Match the exact dimensions in the spec, this patch only does rough > clipping. > > Test: added tests, manual > Bug: 1011973 > Change-Id: I3d9d341c54b58d0e86440045ad1408ca3a0fd27d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849175 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707426} TBR=xdai@chromium.org,sammiequon@chromium.org No-Try: true Bug: 1011973 Change-Id: I163b3ca64c454a4a202534e7ed0171e57e178e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872011 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL moves the position of a test so that these tests are grouped together. Bug: None Change-Id: Ib84a2898bb6d5566b4a4c19f37c6e85de0ccacfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872010Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707788}
-
Ella Ge authored
This reverts commit 9ed68bfb. Reason for revert: Revert to revert upstream change https://chromium-review.googlesource.com/c/chromium/src/+/1872011 Original change's description: > overview: Clipping for windows using new grid layout. > > Extracts parts of the regular grid layout function into a helper, which > is then used by the new grid layout function. > > Test: manual > Bug: 1011973 > Change-Id: I7bdf40227bbd1df467ea9d56bc84e58b01c12f33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867271 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707460} TBR=xdai@chromium.org,sammiequon@chromium.org No-Try: true Bug: 1011973 Change-Id: I675fb57809d190ca9266d012885269dcea2401c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872012 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c70966b3505e..61386966b2ad git log c70966b3505e..61386966b2ad --date=short --no-merges --format='%ad %ae %s' 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@61386966b2ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I71522c1332ff0bdf84ba55510f8133cf470565d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872229Reviewed-by:
-
Maksim Moskvitin authored
In case of implicit passphrase Nigori the only required field in NigoriSpecifics is encryption_keybag. New test covers this case and checks that passwords could be decrypted once passphrase is provided. Bug: 922900 Change-Id: I36a2e837d4150fd16b1edcf94d8adf24c34f6b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863096 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65397626..cf414fd4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I44b119873febd2eb21fece26fa0364e3c18718b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871890Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707784}
-
Jan Wilken Dörrie authored
In order to be more robust against changes to the observer list, this change modifies FormFetcher to use a base::ObserverList instead of a simple set and makes its consumers inherit from base::CheckedObserver. This allows consumers to delete the form fetcher while being notified, which previously would cause a use-after-free. A corresponding test is added. Bug: 1007556 Change-Id: I645526027e35be222479009199af6545de6a11f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855985 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707783}
-
