- 14 Apr, 2020 40 commits
-
-
Aya ElAttar authored
Changed OSSettings to be only disabled by SystemFeaturesDisableList policy as a lot of domains use ExtensionsWhiteList policy and OsSettings isn't whitelisted. Bug: 1068558 Change-Id: I6055f625993b842d2b129d2f65cad6ef344dfbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144041 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758799}
-
Yuki Yamada authored
Migrates BeginFrameProvider to use HeapMojoReceiver/HeapMojoRemote to reduce potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iecd9a91da7a8cc2fb741645da8bc22fe8d477a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145746Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758798}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@chromium.org Change-Id: Ia09f38dfa050611dc0204b00c7d43fc911c30420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145833 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#758797}
-
Jinsuk Kim authored
chrome/browser/tab:java is a new build target that modularizes Tab interface for the rest of the chrome for Android code. The target consists of following classes with plans to include more from tab/ package: - EmptyTabObserver.java - Tab.java - TabAttributeKeys.java - TabAttributes.java - TabCreationState.java - TabHidingType.java - TabLaunchType.java - TabLifecycle.java - TabObserver.java - TabSelectionType.java Bug: 995903 Change-Id: Id188c99b9e92195ce834ef7f5dc6d330d918c477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102998 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#758796}
-
Antonio Gomes authored
CL migrates clip-path-reference-nonexisting-existing-local.html to external/wpt/css/css-masking/clip-path/, adding links to the relevant specs and a test assertion describing its purpose. BUG=1063749 R=fs@opera.com Change-Id: Ic31f186879f7b37f9df9b49bfac891749d001d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144235Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#758795}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/711867566999..20220a0b0640 git log 711867566999..20220a0b0640 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 capn@google.com Reuse Store logic for Modf and Frexp output parameters 2020-04-14 capn@google.com Separate Operand store logic from EmitStore() 2020-04-14 capn@google.com Only store component count in Operand 2020-04-14 capn@google.com Rename size/sizeInComponents to componentCount Created with: gclient setdep -r src/third_party/swiftshader@20220a0b0640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic82e6573c590e1516eb2bd3c71de496b9a69496f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758794}
-
https://crbug.com/1064676arthursonzogni authored
This bug has been fortunately/unexpectedly fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2111170 The old code was trying to "guess" the document was the initial empty document. It failed. The new code is using CreateCSPForInitialEmptyDocument() to set the CSP of the initial empty document. It works consistently. Bug: 1064676 Change-Id: I3778b7a2a0e4eed0599424e3711cbaec24c80c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144012 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#758793}
-
Anqing Zhao authored
According to the request in https://crbug.com/1052664, the os version should be changed to M83 because M82 is skipped. BYPASS_POLICY_COMPATIBILITY_CHECK=Demanded in the launch review Bug: 1040078 Change-Id: I9d29dc60df4d7cd6f3fa5efbf5ba48d3c89a04de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148313Reviewed-by:
-
Ewann authored
This CL creates the Cookies view controller & coordinator and adds Cookies to the Privacy screen. 4 options have also been added to the Privacy view controller. Bug: 1064961 Change-Id: I48534388d195f15ae199d63ef995668f0b43125b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129708 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#758791}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, migrate this test from being a testRunner-based reftest with plain text expectation into a testharness.js-based test that uses check-layout-th.js instead of the utils from the Chromium-specific check-layout.js file, and drop the expectations file. Bug: 767015, 1063749 Change-Id: I3a056716ec99f979b9171aaa2a1e053f9f782e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144188 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#758790}
-
Alex Ilin authored
This CL enables Mirror for the extension consent flow: - Makes the account settings dialog appear during the consent flow when Gaia passes a Mirror response header. This allows the user to modify the list of accounts on their device. - Keeps the consent flow window opened when it happens. In the case the user don't want to modify their accounts, they could go back to the consent flow. Bug: 1026237 Change-Id: I3cdd8bb868e7ec8b80f9cd59f45aee2d06616b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144200Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758789}
-
Leszek Swirski authored
This feature has enabled by default for a couple of releases, so the feature flag for it can be removed. Bug: 945321 Change-Id: Ifed3760a46e82e0ead9d3cfc37c5e58d86beafb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134298 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#758788}
-
Marc Treib authored
This CL adds some unit tests for MultiStorePasswordSaveManager which cover saves/updates to both stores at the same time. Bug: 1060524 Change-Id: I7170b18fa313facb4203f3131e0eba1b2639a1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141593 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#758787}
-
Rune Lillesveen authored
Bug: 1069300 Change-Id: I3e1281857c54d6b21cebc5a6c58f7c114069247d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148775Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758786}
-
Zhenyao Mo authored
This triggers compile warnings for projects with -Wextra-semi-stmt. BUG=1064305 TEST=bots compile R=dcheng@chromium.org Change-Id: Ic9ae72dc4a04f410c8768614e2f6b2558ea52e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148250 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This allows subscript access into model identifiers, both direct (e.g., "my_identifier[0]" as well as indirect, e.g., "my_identifier[index]", where |index| is a model identifier that points to a single integer. This can be nested arbitrarily deeply, i.e., "a[b[c[d[...]]]]". Note that subscript access into UTF-8 model identifiers is NOT supported. Specifically, identifiers must match a regular expression \w+ for subscript support. Bug: b/145043394 Change-Id: I03ca5c2d2c11a8c9c014a8cb3ad1768b7c13a62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139725 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#758784}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/834c6893..02ab3396 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I210f9949335f395edd16cda9cd017f9407937e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144222Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758783}
-
Yuki Shiino authored
[CachedAccessor] was used only for supporting fast access to window.document in the main world. This patch extends its support to fast access to 'window', 'self', and 'frames' IDL attributes of Window interface even after window detach- ment in case of the new bindings generator (no change for the current bindings generator). In the new bindings generator, all attributes, including cross origin attributes, will be implemented as accessor properties, so the old 'lazy data property' will no longer work. 'window', 'self', and 'frames' need to be implemented with the same technique as 'document', i.e. 'cached accessor'. This patch doesn't change any user visible behavior. [CachedAccessor] on 'window', 'self', and 'frames' attributes have currently no effect because these attributes are not accessor properties. Bug: 839389 Change-Id: Id6ffa965304627f2b9ad4488d090dc62e71077d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147753 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#758782}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, migrate this test from being a testRunner-based reftest with plain text expectation into a testharness.js-based test that uses check-layout-th.js instead of the utils from the Chromium-specific check-layout.js file, and drop the expectations file. Bug: 767015, 1063749 Change-Id: I4291bedea5a83fcc9012ba7c0707238f93a6b052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144187 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I4f034c6f54893086074b200deb6c656d52b570e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147521Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dee4d7a54e44..965eedbfbf1e git log dee4d7a54e44..965eedbfbf1e --date=short --first-parent --format='%ad %ae %s' 2020-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 019f4e38eb79..f89de66a9bcb (7 commits) Created with: gclient setdep -r src/third_party/angle@965eedbfbf1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I02ffdcfe110606618007df7f4911f171376d0b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148717Reviewed-by:
-
Luciano Pacheco authored
Files app initialization uses 2 async task queue in launcher.queue and AppWindowWrapper.queue and the queue implementation relies on the task to run the callback to finish the task. However, a JS exception means the task callback is not be called, and the queue gets stuck. In the launcher.queue, the task relies on the queue from AppWindowWrapper to call its callback, which can lead to both queues getting stuck in case of the exception. This CL fixes the initialization stuck issue by removing the queue from "launcher" and replacing it with an initialization promise, because the queue was only used to wait for the base initialization to finish. Change launcher.launchFileManager() to async and use await to wait for the initialization promise to finish. In AppWindowWrapper.launch() handle the specific error condition that was causing the queue to be stuck, which is the API chrome.appwindow.create() might return undefined. Add a test helper to enable fake implementations for APIs for the background page. The integration test functions can't send functions to the background page, because the data is serialized as JSON. To be able to fake the API result the background page has a register of what kind of fake a integration test can request, currently it's only implemented "static fake" which calls the first callback in the arguments with a static value. Test: browser_tests --gtest_filter="*fileDisplayStartupError*" Bug: 1067478 Change-Id: I51bea6c9f25244601b25210209d3623aaafaa01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141566 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#758778}
-
Marc Treib authored
This CL adds profile_store_action_ and account_store_action_ to MultiStorePasswordSaveManager (in addition to pending_credentials_state_ from the base class). Explicitly tracking the two states, instead of just a single "canonical" one, allows us to be more explicit in how conflicts are resolved, and in particular it allows us to handle some edge cases that we couldn't handle correctly before. It also adds an integration test for one such edge case. Bug: 1012203, 1060524 Change-Id: I9602c3641da761a76b2dc9a1f62b630ef2fbcb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139654 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Donna Wu authored
The |resolver_| is in the reader, so no need to pass it to a closure carring the reader already. Also to align with other places, OnScanRequestCompleted() has been made to be a member method, so that |resolver_| can be cleared when settled. Bug: 520391 Change-Id: Ie5718243aa0f60498e042550b33ffcea5700ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145262 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#758776}
-
Andrei Salavei authored
Update IdentityManager initialization flow during the AccountManager migration. After the offline login the |user_context| has no token, hence the Primary account could not be setup for the IdentityManager. Add login account to the AccountManager in case it is not presented there to properly setup primary account for the IdentityManager. The primary account with token will be configured later during the AccountManager migration process. Remove |DeprecatedSetPrimaryAccountAndUpdateAccountInfo|. Bug: 987955 Change-Id: Ia1665e8337e26ca05af9a9abc43ab23816fce14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131912 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#758775}
-
Ankit Kumar authored
This CL adds restoring focus to the last focused element in PDF. Unit tests have been added to validate the scenario. Bug: 1057927 Change-Id: I760d2365671c610ce593016a0ac8fc439c7fbd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061579 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758774}
-
Victor Hugo Vianna Silva authored
A preparation for https://crrev.com/c/2087914. Expectations on the values of SyncMergeResult::num_items_{added/deleted/...} are removed. Coverage for the sync merge logic is still present, since the tests already verified it by mean of other checks. The CL complements such pre-existing checks with checks on the initial and final size of the local model. One of the implementations of GetAllSyncData that was removed in crrev.com/c/2083455 is re-added to enable this. It is suffixed with ForTesting as with all other cases in crrev.com/c/2083455. Change-Id: If83c977b8e5dac6279b3fd7fc7517dc3d2dbc1f5 Bug: 1057577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091346 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#758773}
-
Corentin Wallez authored
//third_party/dawn:dawn_end2end_tests has been moved under //third_party/dawn/src/tests. Replace the _tmp target in gn_isolate_map with the new location of dawn_end2end_tests. Bug: chromium:1064305 Change-Id: I92eb438362258c668cd3babc99be947c91ba2b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144968Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758772}
-
Hiroki Nakagawa authored
This CL also removes the outdated comments on mojom::NavigationParams::navigation_start. Bug: n/a Change-Id: I4672611f52d861b797f2a472496813da6de35875 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132069 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#758771}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/34be23373b9e..e70d25f6fa5d git log 34be23373b9e..e70d25f6fa5d --date=short --first-parent --format='%ad %ae %s' 2020-04-13 stevenperron@google.com Struct CFG analysus and single block loop (#3293) 2020-04-13 jaebaek@google.com Preserve debug info in eliminate-dead-functions (#3251) 2020-04-13 stevenperron@google.com Update acorn version (#3294) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e70d25f6fa5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I85bfde3af2be07118e03a6b2ab8c2dc9d8d17937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148716Reviewed-by:
-
Aya ElAttar authored
Disabled the settings icon in the system tray when os settings is added in SystemFeaturesDisableList policy Bug: 1066795 Change-Id: I6131e5cb05b0e305f0d9007391d7cd5c1231adf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130855Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Icaaaa15a2736ba0c4f0961bf15779d2a40008f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141502Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#758768}
-
Nohemi Fernandez authored
Use the accessibility label directly in the first run EarlGrey tests. This makes it simpler to transition to the new sign-in architecture. See go/chrome-ios-signin-migration for more details. Bug: 1005509 Change-Id: I4afa65b02169927c919cb51dd9884bb828a55fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144082Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#758767}
-
Ramin Halavati authored
Adds a OTRProfileID::CreateUnique to create a unique OffTheRecrord profile id with the given prefix. Bug: 1033903 Change-Id: Iaa6408a17d72521b8c22feec82843ad4081abece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145875Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#758766}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/kg4AQ.....vN52w... Created with: gclient setdep -r src/third_party/aemu-linux-x64@vN52w... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I18a62fbbbd39d747d8c3f0001f3d1b3b949d5aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148714Reviewed-by:
-
Yuki Shiino authored
Minor style change from V8Foo::kConstantBar to V8Foo::Constant::kBar. Bug: 839389 Change-Id: Icc2e2e0dae28cb98ea92b80dd3e13ba882d214e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147972Reviewed-by:
-
Yuki Shiino authored
Removes regular indexed properties from Window, and moves the implementation of indexed/named properties to 'api' component. Bug: 839389 Change-Id: Icb3a92938bc6cdddc01e2323e7f06cbe2f2a5b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145526Reviewed-by:
-
Donna Wu authored
Bug: 520391 Change-Id: I3c687f7af552434f0050ae4216b70b27cf06d010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143654Reviewed-by:
-
Peter E Conn authored
Bug: 1040143 Change-Id: I30c0988fe53933014805bdec25effa16002baef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135759Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/573da20d98ff..8c8408b7248c Created with: gclient setdep -r src-internal@8c8408b7248c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:138961540,chromium:149354484,chromium:153387728 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: Ib599d381d7b7a50563b2dd1815ba0d6d403dda43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758760}
-
