GitLab

BUG=452495, 452492

Review URL: https://codereview.chromium.org/1023813003

Cr-Commit-Position: refs/heads/master@{#322349}

Revert of Update V8 to version 4.3.56. (patchset #1 id:1 of https://codereview.chromium.org/1005693012/)

Reason for revert:
number of crashes in DevTools layout tests

3605	  if (p->owner()->identity() != CODE_SPACE) return false;
(gdb) bt
#0  IsOnInvalidatedCodeObject (addr=<optimized out>) at ../../v8/src/heap/mark-compact.cc:3605
#1  v8::internal::SlotsBuffer::UpdateSlotsWithFilter (this=0x51d8988d820, heap=0x51d892af040) at ../../v8/src/heap/mark-compact.cc:4725
#2  0x0000000001bf4a3f in UpdateSlotsRecordedIn (heap=0x51d892af040, buffer=<optimized out>, code_slots_filtering_required=<optimized out>) at ../../v8/src/heap/mark-compact.h:330
#3  v8::internal::MarkCompactCollector::EvacuateNewSpaceAndCandidates (this=0x51d892b4fc8) at ../../v8/src/heap/mark-compact.cc:3761
#4  0x0000000001be8838 in v8::internal::MarkCompactCollector::SweepSpaces (this=0x51d892b4fc8) at ../../v8/src/heap/mark-compact.cc:4448
#5  0x0000000001be745f in v8::internal::MarkCompactCollector::CollectGarbage (this=0x51d892b4fc8) at ../../v8/src/heap/mark-compact.cc:377
#6  0x0000000001bb662b in v8::internal::Heap::MarkCompact (this=0x51d892af040) at ../../v8/src/heap/heap.cc:1274
#7  0x0000000001bb4d31 in v8::internal::Heap::PerformGarbageCollection (this=0x51d892af040, collector=v8::internal::MARK_COMPACTOR, gc_callback_flags=v8::kNoGCCallbackFlags) at ../../v8/src/heap/heap.cc:1159
#8  0x0000000001bb46b2 in v8::internal::Heap::CollectGarbage (this=0x51d892af040, collector=<optimized out>, gc_reason=<optimized out>, collector_reason=<optimized out>, gc_callback_flags=<optimized out>)
    at ../../v8/src/heap/heap.cc:894
#9  0x0000000001bb3a46 in CollectGarbage (space=v8::internal::OLD_POINTER_SPACE, gc_reason=0x0, callbackFlags=v8::kNoGCCallbackFlags, this=<optimized out>) at ../../v8/src/heap/heap-inl.h:567
#10 CollectAllGarbage (this=0x51d892af040, flags=0, gc_callback_flags=v8::kNoGCCallbackFlags, gc_reason=<optimized out>) at ../../v8/src/heap/heap.cc:784
#11 v8::internal::Heap::HandleGCRequest (this=0x51d892af040) at ../../v8/src/heap/heap.cc:735
#12 0x0000000001b5804b in v8::internal::StackGuard::HandleInterrupts (this=0x51d892b54c8) at ../../v8/src/execution.cc:663
#13 0x0000000001fff9ac in __RT_impl_Runtime_StackGuard (isolate=<optimized out>, args=...) at ../../v8/src/runtime/runtime-internal.cc:119
#14 v8::internal::Runtime_StackGuard (args_length=<optimized out>, args_object=0x1139a18f7c28, isolate=<optimized out>) at ../../v8/src/runtime/runtime-internal.cc:109

Original issue's description:
> Update V8 to version 4.3.56.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/c5443d75..b09c6a7d
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
> BUG=
>
> Committed: https://crrev.com/16408c2845040574d5e458703f848aa04b2bb629
> Cr-Commit-Position: refs/heads/master@{#322237}

TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/997883003

Cr-Commit-Position: refs/heads/master@{#322348}

The current use-cases of the tests only consist of either running all the tests, or running individually specified tests. The information about which tests are disabled and which are supposed to pass, is therefore not useful, and making the scripts more complicated than needed.

This CL removes the support for disabling the Python tests.

BUG=369521

Review URL: https://codereview.chromium.org/1012863006

Cr-Commit-Position: refs/heads/master@{#322347}

Currently DeleteAndStartOver() is tested in memory storage (MemEnv)
supported by LevelDB for performance, but it seems preferable to test
it on real environment, that is, on disk storage because the recovery
process can be affected by characteristics of lower filesystem.

BUG=468926
TEST=content_unittests --gtest_filter=ServiceWorkerContextTest.DeleteAndStartOver

Review URL: https://codereview.chromium.org/1022363002

Cr-Commit-Position: refs/heads/master@{#322346}

BUG=none

Review URL: https://codereview.chromium.org/1037723002

Cr-Commit-Position: refs/heads/master@{#322345}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2ec400..9b70ee9

TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/1016273007

Cr-Commit-Position: refs/heads/master@{#322344}

The previous check location was forcing all apps and extensions which call
the chrome.fileSystem.requestFileSystem API, to have "fileBrowserHandler"
permission as well.

That however doesn't make much sense, as those apps are not always handlers.
This CL moves the check to FileBrowserHandler::GetHandler() so simply the
permission has to be used only if the app wants to be a handler.

TEST=unit_test: FileBrowserHandlerManifestTest.GetHandlersRequiresPermission
BUG=470494

Review URL: https://codereview.chromium.org/1030133002

Cr-Commit-Position: refs/heads/master@{#322343}

WebRTC 8857:8862
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/edd91ff..70e3d3d

Libjingle 8855:8863
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/bb52e6e..f4031d6

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/1034073003

Cr-Commit-Position: refs/heads/master@{#322342}

Otherwise the worker could get stopped if the timer happens to expire between
events while it's in a flurry of events.

BUG=462096

Review URL: https://codereview.chromium.org/1038763005

Cr-Commit-Position: refs/heads/master@{#322341}

The behavior is controlled by Finch. If user clicks "Not save" n times in row then the default value for the button becomes "Never for this site".
The previous experiment didn't pop up the bubble occasionally. We collected enough statistics and stopped it few months ago.

BUG=431739

Review URL: https://codereview.chromium.org/1022843003

Cr-Commit-Position: refs/heads/master@{#322340}

BUG=466848

Review URL: https://codereview.chromium.org/1030263002

Cr-Commit-Position: refs/heads/master@{#322339}

BUG=None

Review URL: https://codereview.chromium.org/1031253002

Cr-Commit-Position: refs/heads/master@{#322338}

BUG=none

Review URL: https://codereview.chromium.org/1008563004

Cr-Commit-Position: refs/heads/master@{#322337}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/40f80cc..f2ec400

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1034133002

Cr-Commit-Position: refs/heads/master@{#322336}

Cr-Commit-Position: refs/heads/master@{#322335}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/554befb..40f80cc

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1002443004

Cr-Commit-Position: refs/heads/master@{#322334}

BUG=439143

Review URL: https://codereview.chromium.org/992173002

Cr-Commit-Position: refs/heads/master@{#322333}

This CL adds UMA for results of SWStorage::DeleteAndStartOver() and
SWDatabase::DestroyDatabase(). Deleting the diskcache just returns
success/failure boolean and it will be recorded as a part of results
of DeleteAndStartOver().

BUG=461654,468926
TEST=n/a

Review URL: https://codereview.chromium.org/1030703003

Cr-Commit-Position: refs/heads/master@{#322332}

This is a hack to workaround a blink bug where overlay scrollbars aren't
rendered correctly in print preview. This bug is being looked at but
until then we use custom scrollbars that imitate mac scrollbars only
in this specific case.

BUG=466039

Review URL: https://codereview.chromium.org/1036943004

Cr-Commit-Position: refs/heads/master@{#322331}

In order not to block IO of directory scan by IO of thumbnail fetch,
do not run thumbnail fetch when directory scan is running.

BUG=470462
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/1031293005

Cr-Commit-Position: refs/heads/master@{#322330}

[Sync] Server side update the protocol version, because server side adding a error type, which is partial_faulure. we already support this error type, so this change just need to update default version.

BUG=470736

Review URL: https://codereview.chromium.org/1030293002

Cr-Commit-Position: refs/heads/master@{#322329}

Currentl we are intercepting ctrl+p on PDF to print, which is interfering
with ctrl+shift+p. There is no need to intercept either of these commands
anymore, the default handling should work correctly.

BUG=466600

Review URL: https://codereview.chromium.org/1031293004

Cr-Commit-Position: refs/heads/master@{#322328}

Don't track windows that were interacted (restored/minimized) by user while wallpaper picker application is opening.

BUG=323252
TEST steps:
1. Open a browser window.
2. Open the wallpaper picker application while keeping the browser window open. The browser window gets minimized as expected.
3. Restore the browser window and minimize it again
4. Close the wallpaper picker application. The browser window should not be restored since user has minimized it intentionally.

Review URL: https://codereview.chromium.org/1023863003

Cr-Commit-Position: refs/heads/master@{#322327}

We stopped showing "Inspect Element" on dev/beta/stable, therefore
TestContextMenu does not seem to find any menu item when right-click
is performed.
This CL makes sure we always have an <input> on the right-click target
so that we have some items to show in the context menu.

BUG=470300
Test=None, internal test only change.

Review URL: https://codereview.chromium.org/1016033010

Cr-Commit-Position: refs/heads/master@{#322326}

BUG=464002, 466685, 469012

Review URL: https://codereview.chromium.org/1030073003

Cr-Commit-Position: refs/heads/master@{#322325}

This CL fixes an issue with the initial app sync on sign-in causing many
taskbar flashes due to icon creation always sending a SHChangeNotify.

This shouldn't be necessary for icon creation due to shortcut creation so
avoid SHChangeNotify in this case.

BUG=470002

Review URL: https://codereview.chromium.org/1026113003

Cr-Commit-Position: refs/heads/master@{#322324}

Review URL: https://codereview.chromium.org/1035533006

Cr-Commit-Position: refs/heads/master@{#322323}

This CL stops AppListServiceAsh handling an event it shouldn't care about,
preventing the AppListServiceViews on Linux handling it correctly.

BUG=469032

Review URL: https://codereview.chromium.org/1020133002

Cr-Commit-Position: refs/heads/master@{#322322}

app-streaming builds, cleanup definition of those variables.
Move variables to common include file.

Tested by building in a shell with only
GYP_DEFINES': 'component=shared_library use_goma=1

BUG=

Review URL: https://codereview.chromium.org/1031203004

Cr-Commit-Position: refs/heads/master@{#322321}

This causes wrong fallback fonts to be picked leading to text displaying badly.

To avoid duplicate fonts from being processed, the proposal is to use a set to track those
and skip them.

BUG=470397

Review URL: https://codereview.chromium.org/1037863002

Cr-Commit-Position: refs/heads/master@{#322320}

The physical keyboard autocorrect feature (crbug.com/422869) is targeted to
be launched in M43.
The feature should be turned off if the input field is marked as
autocorrect==off, which is only supported by web input field for now.

This cl is to make certain native fields (views::TextField) to be marked
as autocorrect==off so that physical keyboard autocorrect feature can
stop working on it.

Note: this cl will also impact virtual keyboard. The suggestions on virtual
keyboard will also stop working on those input fields.

BUG=455865
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/1029543002

Cr-Commit-Position: refs/heads/master@{#322319}

Before this CL, no GC was run in between test, so setting --pageset-repeat > 1
lead to increased memory usage per test run, reporting inaccurate results.
This CL forces V8 GC (and attached Oilpan GC) after each test run for stable result.

More background:
Blink used to trigger V8 major GC after page unload, but this was changed to
less aggressive GC since r181187, suspected as source of this "leak".

BUG=465997

Review URL: https://codereview.chromium.org/1027133002

Cr-Commit-Position: refs/heads/master@{#322318}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9c59ebc..05035d4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1031213003

Cr-Commit-Position: refs/heads/master@{#322317}

In some languages, the current logic (iteration over code
points and then get the glyphs by CharRangeToGlyphRange)
makes wrong effect, because both a character and its
diacritic marks can point to the same glyph range and
it misunderstands the width of the word for wrapping.

This CL changes the iteration logic for clusters so that
it skips the code points for the diacritic marks.

BUG=470073
R=msw@chromium.org, ckocagil@chromium.org
TEST=the new test case covers

Review URL: https://codereview.chromium.org/1036663003

Cr-Commit-Position: refs/heads/master@{#322316}

These fields are often grouped together, but in different orders.
In several cases, fields have labels that are ambiguous but names that
are not. When there is ambiguity, parse fields with the name and label
separately and see which field type they best match.

BUG=442552

Review URL: https://codereview.chromium.org/1028633004

Cr-Commit-Position: refs/heads/master@{#322315}

BUG=466847

Review URL: https://codereview.chromium.org/1015063003

Cr-Commit-Position: refs/heads/master@{#322314}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/34f0727..554befb

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1025323006

Cr-Commit-Position: refs/heads/master@{#322313}

- Modify unit tests to test relevant field types.
- Cleanup code.
- Update heuristics test expectations.

Review URL: https://codereview.chromium.org/1010743007

Cr-Commit-Position: refs/heads/master@{#322312}

Updated the formatting for the app remoting test driver files using clag-format for consistency.  No logic changes.

BUG=

Review URL: https://codereview.chromium.org/1037723003

Cr-Commit-Position: refs/heads/master@{#322311}

BUG=470754

Review URL: https://codereview.chromium.org/1036513007

Cr-Commit-Position: refs/heads/master@{#322310}