GitLab

This fixes the FrameViewer json serialization of annotatedInvalidationRects.
This CL fixes the format from (x, y, maxX, maxY) to (x, y, width, height).

BUG=402033

Review URL: https://codereview.chromium.org/659003002

git-svn-id: svn://svn.chromium.org/blink/trunk@183829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rather than NULL-checking it directly, I've instead plumbed through
ActiveDOMCallback::canInvokeCallback(), which handles all the logic
MutationObserver was doing previously and also handles the NULL check.

The test case is crazy-looking because it was generated by ClusterFuzz.
I've simplified it as much as possible.

BUG=410755

Review URL: https://codereview.chromium.org/657983002

git-svn-id: svn://svn.chromium.org/blink/trunk@183827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=373552
R=eroman
Tests= crypto/ LayoutTests

Review URL: https://codereview.chromium.org/595873003

git-svn-id: svn://svn.chromium.org/blink/trunk@183826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/661793002

git-svn-id: svn://svn.chromium.org/blink/trunk@183825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=392606
TEST=RecordingImageBufferSurfaceTest

Review URL: https://codereview.chromium.org/659873002

git-svn-id: svn://svn.chromium.org/blink/trunk@183824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we decide to promote all children of an anonymous block and then
nuke it, ignore any continuation set on the new parent of the children,
to make sure that the children are in fact inserted as children of said
new parent, and not somewhere else in the tree.

This is a hack that's needed as long as we keep the old multicol
implementation. The root cause is probably buggy block continuation
handling, but fixing that would be risky.

BUG=421720

Review URL: https://codereview.chromium.org/656143003

git-svn-id: svn://svn.chromium.org/blink/trunk@183823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 9c188b20fbb4d4c2006ab1a611ed8a9b971e7cee.

Broke several browser_tests which depended on the previous behavior:
BrowserEncodingTest.TestOverrideEncoding
EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/16
BrowserEncodingTest.TestEncodingAutoDetect
EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/3

E.g.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserEncodingTest.TestOverrideEncoding&testType=browser_tests

TBR=jshin@chromium.org
BUG=412053
NOTRY=true

Review URL: https://codereview.chromium.org/658193002

git-svn-id: svn://svn.chromium.org/blink/trunk@183822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are some legal tricks used to encode JSON. But JSON.parse rejects
to parse it, whereas XHR response is correctly transformed to JSON.

BUG=406900

Review URL: https://codereview.chromium.org/654083006

git-svn-id: svn://svn.chromium.org/blink/trunk@183821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, SASSSourceMapping polls CSS for 5 seconds after the SASS
change, and this turns out to be insufficient in case of complex
css-processing build steps.

Instead of adding one more setting "css polling duration", this patch
tries to solve most of the problems by increasing polling duration
to 30 seconds.

BUG=421925
R=vsevik, apavlov

Review URL: https://codereview.chromium.org/658123002

git-svn-id: svn://svn.chromium.org/blink/trunk@183819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a bug that I introduced in r164832.
This caused SMIL animation targeting <marker>'s refY to animate refX attribute instead.

TEST=svg/markers/animate-refY.svg
BUG=None

Review URL: https://codereview.chromium.org/661733002

git-svn-id: svn://svn.chromium.org/blink/trunk@183818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The expected result of fast/canvas/webgl/draw-webgl-to-canvas-2d.html
is failure because this test uses setTimeout to go to next frame.
testRunner.displayAsyncThen() can fix this test.

BUG=423674

Review URL: https://codereview.chromium.org/655133003

git-svn-id: svn://svn.chromium.org/blink/trunk@183817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Improves code readability

BUG=none
TEST=no layout test failures

Review URL: https://codereview.chromium.org/642293004

git-svn-id: svn://svn.chromium.org/blink/trunk@183816 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of RELEASE_ASSERT if last resort fallback font cannot be loaded. (patchset #1 id:1 of https://codereview.chromium.org/641763003/)

Reason for revert:
Reverting per request.
https://code.google.com/p/chromium/issues/detail?id=421370#c11

Original issue's description:
> RELEASE_ASSERT if last resort fallback font cannot be loaded.
> 
> This will help confirm the suspicion that a number of ClusterFuzz reports
> from constructTextRun are a result of this failing. There's probably nothing
> useful that can be done with a font that lacks any font data anyhow.
> 
> BUG=421370
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183470

TBR=eae@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=421370,423643

Review URL: https://codereview.chromium.org/659073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=393913
NOTRY=true

Review URL: https://codereview.chromium.org/662633002

git-svn-id: svn://svn.chromium.org/blink/trunk@183814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The glasspane should be a component-root so that it inherits all the
basic styling.

R=pfeldman

Review URL: https://codereview.chromium.org/659043002

git-svn-id: svn://svn.chromium.org/blink/trunk@183813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183802

BUG=397902
TBR=kouhei@chromium.org

Review URL: https://codereview.chromium.org/664503002

git-svn-id: svn://svn.chromium.org/blink/trunk@183812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=393913
R=pfeldman@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/657063002

git-svn-id: svn://svn.chromium.org/blink/trunk@183810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch prevents ElementTreeELements from selecting if they have
inner inplace editor.

BUG=423720

Review URL: https://codereview.chromium.org/663453003

git-svn-id: svn://svn.chromium.org/blink/trunk@183809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423737

Review URL: https://codereview.chromium.org/655273002

git-svn-id: svn://svn.chromium.org/blink/trunk@183808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Section 10.4 of the specs forces us to ignore items spanning tracks with
flex sizing functions when resolving the content-based track sizing
functions. Items with span < 2 are not affected by this rule (as they will
belong to a single track). This way the algorithm ensures that min-content
and max-content restrictions are fulfilled before distributing the extra
space.

BUG=392200

Review URL: https://codereview.chromium.org/448993002

git-svn-id: svn://svn.chromium.org/blink/trunk@183807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

the current stacking context.

If a stacking context element has descendants with blend mode, it should
create a new transparency layer, so that blending descendants will blend
only with the content within this stacking context (stacking context
will isolate blending).

With this CL, hasDescendantWithBlendMode will be set only if
the descendant is right inside the current stacking context, without
looking into nested stacking context elements. It also renames
hasDescendantWithBlendMode to hasNonIsolatedDescendantWithBlendMode,
which is more self-explanatory.

This change is necessary after https://codereview.chromium.org/466193002
(Disentangle blend mode from updateDescendantDependentFlags).

The "isolating" state used to be tested with DRT, but this property has
been removed with https://codereview.chromium.org/466943002/
(Remove isolatesBlending from render tree dumps).

We cannot test this change using layout tests. The effect is that
RenderLayer doesn't create any aditional and unnecessary skia
transparency layers.

Review URL: https://codereview.chromium.org/478333002

git-svn-id: svn://svn.chromium.org/blink/trunk@183806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When I shipped marquee-in-JS, it increased UseCounters for Web Animation APIs because the marquee-in-JS uses the Web Animation APIs. This was an unexpected outcome because what we want to count is the number of JS APIs used by web developers, not the number of JS APIs used internally (i.e., private scripts).

Given the above, this CL adds UseCounter::countIfNotPrivateScript() and uses it in a binding layer so that we can count only the number of JS APIs used by web developers.

BUG=341031

Review URL: https://codereview.chromium.org/656693002

git-svn-id: svn://svn.chromium.org/blink/trunk@183805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Current WebGL relies on glDiscardFramebufferExt() to clear FBO, but the API
doesn't guarantee clearing FBO.

TEST=fast/canvas/webgl/draw-webgl-to-canvas-2d.html,
fast/canvas/webgl/webgl-composite-modes-repaint.html
BUG=423674

Review URL: https://codereview.chromium.org/656053002

git-svn-id: svn://svn.chromium.org/blink/trunk@183804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=420005
R=sergeyv, pfeldman

Review URL: https://codereview.chromium.org/653413002

git-svn-id: svn://svn.chromium.org/blink/trunk@183803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SVGFitToViewBox::parseAttribute handled negative width, height
errors inline. To migrate parsing to property map (crbug.com/397902), we want
to delegate this to SVGAnimatedProperty::setBaseValueToString implementation.

This CL introduces SVGAnimatedViewBoxRect which is a SVGAnimatedRect implements
handling of negative width/height.

TEST=svg/custom/viewbox-syntax.svg
BUG=397902

Review URL: https://codereview.chromium.org/664433002

git-svn-id: svn://svn.chromium.org/blink/trunk@183802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When checking 'frame-ancestor', we end up asking for the SecurityOrigin
of the protected resource before we actually have a protected resource
whose origin we could ask for. This, unsurprisingly, crashes.

This patch adds a protocol property to the ContentSecurityPolicy object
so that we can perform all the checks for source expressions that don't
specify protocols without crashing the renderer.

BUG=424074
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/658073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[WillBeGarbageCollected] is already inherited from the parent EventTarget.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/653263006

git-svn-id: svn://svn.chromium.org/blink/trunk@183800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's easy to miss adding USING_GARBAGE_COLLECTED_MIXIN macros to classes
that inherit from GarbageCollectedMixin. To avoid the programming error,
this CL adds a pure virtual method to the GarbageCollectedMixin class.
If we miss the USING_GARBAGE_COLLECTED_MIXIN macro, we'll hit a compile error.

This CL also fixes existing programming errors.

BUG=420515

Review URL: https://codereview.chromium.org/659953002

git-svn-id: svn://svn.chromium.org/blink/trunk@183799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=126902
TEST=None

Review URL: https://codereview.chromium.org/637873006

git-svn-id: svn://svn.chromium.org/blink/trunk@183798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=355467
NOTRY=true

Review URL: https://codereview.chromium.org/660723003

git-svn-id: svn://svn.chromium.org/blink/trunk@183797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1) Fix "estimated" row height.
2) Make "time" column sortable.
3) Make table stick to bottom.
4) Add new frames as they arrive.

BUG=142280

Review URL: https://codereview.chromium.org/643873003

git-svn-id: svn://svn.chromium.org/blink/trunk@183796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

::-webkit-scrollbar-back and ::-webkit-scrollbar-forward had PseudoType
constants, but the strings were not recognized and no other code for
handling them present.

Review URL: https://codereview.chromium.org/659833002

git-svn-id: svn://svn.chromium.org/blink/trunk@183795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no behavioral change.

BUG=n/a
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/660723002

git-svn-id: svn://svn.chromium.org/blink/trunk@183794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/657493002

git-svn-id: svn://svn.chromium.org/blink/trunk@183793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=400937
R=eustas, pfeldman

Review URL: https://codereview.chromium.org/657873002

git-svn-id: svn://svn.chromium.org/blink/trunk@183790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=363099,371084
TBR=mkwst@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/659013002

git-svn-id: svn://svn.chromium.org/blink/trunk@183789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL more or less rewrites the parser with the goal of improving our
adherence to the spec. We now have reasonable error messages for parse
failures, and have tests for the individual components of the parser
(algorithms and digests). We also now correctly require 'ni:///' as the
URL prefix (we were previously ignoring the last '/').

BUG=355467

Review URL: https://codereview.chromium.org/656063002

git-svn-id: svn://svn.chromium.org/blink/trunk@183788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We started sending accessibility events to the frame client instead of
the view client, to prepare for site isolation. However, a single
AXObjectCache still spans all *local* frames, so accessibility events
should be fired on the axObjectCacheOwner's frame, not on the event
target's frame.

BUG=424046

Review URL: https://codereview.chromium.org/637223005

git-svn-id: svn://svn.chromium.org/blink/trunk@183787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bindings gyp files support but gn files are old and doesn't support binding modularization. e.g.
- create WindowCoreConstructors.idl and WindowModulesConstructors.idl instead of WindowConstructors.idl,
- ditto (SharedWorkderGlobalScope, DedicatedWorkerGlobalScope, ServiceWorkerGlobalScope).

BUG=358074

Review URL: https://codereview.chromium.org/633913002

git-svn-id: svn://svn.chromium.org/blink/trunk@183786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424021
NOTRY=true

Review URL: https://codereview.chromium.org/658043002

git-svn-id: svn://svn.chromium.org/blink/trunk@183785 bbb929c8-8fbe-4397-9dbb-9b2b20218538