GitLab

This test is failing only on Win7 and a DISABLED_ prefix couldn't
disable it. Make sure this test is disabled for now.

TBR=kalman@chromium.org
BUG=314971

Review URL: https://codereview.chromium.org/59383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233024 0039d316-1c4b-4281-b951-d872f2087c98

It is renamed because we're going to add new "services" directory which holds all google services related codes, like sync, invalidation and signin. We do not want to have both "service" and "services" to cause the confusion. Since all codes under "service" deal purely with service process, we would like to rename it to "service_process".

BUG=none
TEST=none due to that this is just a dir renaming
R=thakis@chromium.org, vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/57383010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233023 0039d316-1c4b-4281-b951-d872f2087c98

(Likely) caused timeouts in webgl_conformance_tests on Win and Mac Debug GPU bots.
See Issue 314375 for more details.

> [Telemetry] Fix image_decoding_measurement timeout.
> 
> util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate.
> 
> Since DispatchNotifications blocks in recv until it gets some data, there is no
> need to poll at an interval. Instead, we should call recv again as soon as
> possible after dispatching a notification.
> 
> In the case of the image decoding measurement, it runs timeline recording. There
> were so many timeline messages to receive that we were not always getting to the
> important Page.navigate message before timing out.
> 
> Example:
> http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098
> 
> BUG=314375
> 
> Review URL: https://codereview.chromium.org/47013004

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/60233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315079

Review URL: https://codereview.chromium.org/59993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233016 0039d316-1c4b-4281-b951-d872f2087c98

NOTIFICATION_APP_TERMINATING could happen before closing app list bubble
on shutdown and breaks the assumption that start page contents should
out-live app list.

BUG=314567
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/57943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233015 0039d316-1c4b-4281-b951-d872f2087c98

This change is being reverted due to some problems seen in integration testing.
See http://crbug.com/314884 for test failure details.

> Pepper: Move FileIO host from renderer to browser.
> 
> This change is large because it moves QuotaFileIO and PepperFileIOHost all at
> once to the browser process. Some code in the refactored PepperFileIOHost is
> moved from what's provided in FileAPIMessageFilter.
> 
> Tested locally with Bastion, From Dust, and Angry Bots.
> 
> TBR=jschuh
> BUG=246396
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232440
> 
> Review URL: https://codereview.chromium.org/33053002

TBR=teravest@chromium.org
BUG=246396,314884

Review URL: https://codereview.chromium.org/60323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/57833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233013 0039d316-1c4b-4281-b951-d872f2087c98

I had centralized this in DesktopNativeWidgetAura, but it needs to be
in the DesktopRootWindowHost implementations as it may be invoked
during construction so that state can be set up. Otherwise we may
crash if during init state isn't set up.

I added test for coverage.

BUG=313780
TEST=covered by unit test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/49303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233012 0039d316-1c4b-4281-b951-d872f2087c98

* Move observation of NOTIFICATION_BROWSER_WINDOW_READY to Chrome
* Remove remaining references to Profile
* Tidy up ChromeTestSuiteInitializer

BUG=313481
TEST=unit_tests and browser_tests ExtensionProcessManager*
R=sky@chromium.org, yoz@chromium.org

Review URL: https://codereview.chromium.org/56253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233011 0039d316-1c4b-4281-b951-d872f2087c98

This breaks some tests in official builds.

BUG=None
TEST=browser_tests ExtensionProcessManagerBrowserTest
R=dpolukhin@chromium.org, yoz@chromium.org

Review URL: https://codereview.chromium.org/56003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233008 0039d316-1c4b-4281-b951-d872f2087c98

R=darin
NOTRY=True

Review URL: https://codereview.chromium.org/56973010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=312241

Review URL: https://codereview.chromium.org/50903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233005 0039d316-1c4b-4281-b951-d872f2087c98

Break runs for symbols like musical note ♫ '\x9835'.
Breaking runs prevents using fallback fonts excessively.
This CL builds on the prior work of http://crrev.com/232076
See before/after pics at http://crbug.com/278913#c21
Add IsUnusualBlockCode helper function; refactor slightly.

BUG=278913
TEST=The musical note symbols, etc. Do not break fonts for subsequent normal text. (Copy and paste "♫" into a bookmark title or similar).
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/46873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233003 0039d316-1c4b-4281-b951-d872f2087c98

The input field in a suggestion section should always have a fixed width.

BUG=none
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/58823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233002 0039d316-1c4b-4281-b951-d872f2087c98

hash_pair.h was moved from cc/ to base/ in r207475.

BUG=None
TEST=None
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/58723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233001 0039d316-1c4b-4281-b951-d872f2087c98

Added a condition to avoid the DCHECK for a valid situation where the
check should have been applied.. A test was added to capture the
specific case that was triggering the DCHECK.

BUG=303413
TEST=SourceBufferStreamTest.Remove_PreviousAppendDestroyedAndOverwriteExistingRange

Review URL: https://codereview.chromium.org/58663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232998 0039d316-1c4b-4281-b951-d872f2087c98

crtbeginS was removed from PNaCl as part of PNaCl+glibc
cleanup. If we continue listing crtbeginS as part of the
gyp outputs list, ninja will think we need to rebuild.

BUG=313636
TEST=ninja nop build && browser_tests --gtest_filter=*Pnacl*

Review URL: https://codereview.chromium.org/58343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232997 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix for the old M-31 multi profile mode in M-32.

BUG=314286
TEST=visual

Review URL: https://codereview.chromium.org/55143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298036

Review URL: https://codereview.chromium.org/50883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232995 0039d316-1c4b-4281-b951-d872f2087c98

> Disable AppRTC test on win until we can figure out symlink problem.
> 
> BUG=
> TBR=xians@chromium.org
> 
> Review URL: https://codereview.chromium.org/40143004

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/60183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314809
R=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/59133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232993 0039d316-1c4b-4281-b951-d872f2087c98

Add a VLOG(1) message containing event details to
UserActivityDetector. This makes it easier to debug
unexpected user activity, which we've seen in the past.

BUG=none
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/58293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232985 0039d316-1c4b-4281-b951-d872f2087c98

UMA reporting values are temporarily broken. This change will fix the
value and add a definition for the new item.

TEST=unit_tests
BUG=n/a

Review URL: https://codereview.chromium.org/58253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313809
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/59763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232983 0039d316-1c4b-4281-b951-d872f2087c98

 - Updating unittests to conform to Compositor constructor change.

BUG=

Review URL: https://codereview.chromium.org/57803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286528
TEST=Top notification in Wallet mode (i.e. when signed in) should have a subtle
     darker gray border.
R=groby@chromium.org

Review URL: https://codereview.chromium.org/55973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232981 0039d316-1c4b-4281-b951-d872f2087c98

Add ResourceMetadataStorage::RecoveredCacheInfo
Recover title in ResourceMetadataStorage::RecoverCacheInfoFromTrashedResourceMap
Use title in FileCache::RecoverFilesFromCacheDirectory

BUG=277333
TEST=unit_tests

Review URL: https://codereview.chromium.org/55713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/55413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232979 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/54983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232977 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the MustRemainDisabled function to the ManagementPolicy::Provider
interface and calls it in appropriate places.

BUG=314276

Review URL: https://codereview.chromium.org/54903011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232976 0039d316-1c4b-4281-b951-d872f2087c98

to not set any of the output parameters unless all of them are valid.
Before we could set e.g. the session_id but return false.

BUG=315051
R=xians@chromium.org

Review URL: https://codereview.chromium.org/59763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232975 0039d316-1c4b-4281-b951-d872f2087c98

The mostly_smooth metric doesn't show up on the dashboard,
because it is a boolean value (False/True). Switch to float (0.0/1.0).

R=dtu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/54793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313168
TEST=RemoteDebuggingTest.RemoteDebugger

Review URL: https://codereview.chromium.org/54333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232973 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies the compositor rate limiting code to only rate limit the
shared main thread context, which as it happens is the only context that uses
this feature at all.

BUG=181120

Review URL: https://codereview.chromium.org/53153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232972 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=302284

Review URL: https://codereview.chromium.org/52823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232971 0039d316-1c4b-4281-b951-d872f2087c98

Desired behavior: Clicking on a field or giving it focus via tab should
result in the validation error message coming up, if any.
Clicking on an already focused field should toggle autofill suggestions
with validation messages.
Leaving an input field with either a validation message or an autofill
suggestion should hide both.

The tricky part: distinguishing mouse clicks that would give focus, and
mouse clicks that are on a focused field. Since mouseDown: messages in
OSX are only sent to fields that already have firstResponder status,
this requires a bit of trickery - this CL exploits the fact that for an
NSTextField, the first click goes to the NSTextField, and subsequent
ones go to the field editor.

Bonus trickery: Rapid clicking on an NSTextField prevents the field
editor from taking over until the user has calmed down, so the code
filters only the first click after becomeFirstResponder.

R=rsesek@chromium.org
BUG=308156

Review URL: https://codereview.chromium.org/51933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232970 0039d316-1c4b-4281-b951-d872f2087c98

We're getting close to actually swapping RenderFrameHosts instead.

BUG=99379, 314791
TEST=none

Review URL: https://codereview.chromium.org/53153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232969 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug where incognito split mode extensions were getting clicks from incognito browsers sent to the regular profile.

BUG=314142

Review URL: https://codereview.chromium.org/50433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232968 0039d316-1c4b-4281-b951-d872f2087c98

R=arv@chromium.org
BUG=305742

Review URL: https://codereview.chromium.org/49903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232966 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232964 0039d316-1c4b-4281-b951-d872f2087c98