GitLab

This CL implements the BluetoothAdvertisingIntervalClient which will set
the advertising interval for Nearby Sharing. It will also handle
restoring the default advertising interval when advertising stops.

Bug: 1119970
Change-Id: Ia4c0febed23dcd751f9e72dace37dd7069b3f33e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466263Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Cr-Commit-Position: refs/heads/master@{#818633}

This reverts commit ea79bdd2.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 818611 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2VhNzliZGQyNjk1ZTQ0ZTdmZTIxNWNiMjk2ZTIzZDgzZWZhMTBjNmIM

Sample Failed Build: https://ci.chromium.org/b/8865978629264367456

Sample Failed Step: compile

Original change's description:
> Mojo JS: Use BigInt consistently for 64-bit int fields
> 
> This changes 64-bit integer fields to be deserialized as
> BigInt values consistently, rather than sometimes being
> BigInts and sometimes being Numbers.
> 
> Fixed: 1102217,1009262
> Change-Id: I9cc8d767058938e9c39f62f139737e512f47cdb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466398
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Shik Chen <shik@chromium.org>
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#818611}


Change-Id: I789f68f9390c4b1c67d96850ab118a92008a8a7d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485560
Cr-Commit-Position: refs/heads/master@{#818632}

Extend the forced colors mode flag from M88 to M90.

Bug: 970285
Change-Id: Id83da842a7704336686d97409639b34b411ed854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486034Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818631}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/375e574d..55926e1a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If4e264ff191349ff5d6f59c92ebc3438388af5c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485758Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818630}

The drag offset was slightly off as it didn't adequately account for
insets added for shadow rendering. If the elevation of dragged items
was increased, the drag offset could become severely off.

Now, drag offset is calculated correctly with respect to shadow margins
as well as insets added to accommodate the overflow badge (when present).

Bug: 1139113
Change-Id: I18f1aebd8818203196787c8b587ad1c2e55ecbc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485338
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818629}

Bug: 1108016
Change-Id: I5e63664b302698c805361043113d940432c5907e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485050Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818628}

Currently, this file checks for a build header, just in case it defines
WORDS_BIGENDIAN. However, this build file never defines this, so it's a
useless include. This breaks attempts to depend on this library from
third party projects, namely Open Screen.

Change-Id: I9e02e530a68423af13a9a2fa0da81f4947dc37e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481665Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818627}

Bug: 1137487
Change-Id: I42be555e181abb32053492f130fa735dec45d705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468342
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818626}

A previous CL (*) made PaintLayerCompositor::CanBeComposited
depend on throttling state. CanBeComposited in turn affects compositing
inputs. Therefore when throttling state changes, compositing inputs
need to be re-computed.

(*) https://chromium-review.googlesource.com/c/chromium/src/+/2277332

Bug: 1139116

Change-Id: I1152e447ade9f2f848707f992f9c4fc1574bba7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485438
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818625}

This change makes davidbienvenu@ and jessemckenna@ the owners of
histogram Stability.Internals.SystemCrashCount, and extends its
expiration date.

Bug: 1123582

Change-Id: Id1c825dd42ee896141817a697c781d975d6b82e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485833Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#818624}

Roll Chrome Linux PGO profile from chrome-linux-master-1603107412-6ef156ac52bac5f4e53402d26e81a7a7c88be584.profdata to chrome-linux-master-1603130327-dbd07cac207addae1d1c691d346f030844c1739d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I57ade640ddcbfc13967bab4bd8ad810f7e9c5697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486135Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818623}

Removed TODO(crbug.com/1103614) comments as this
bug is already fixed and all the Clipboard::Read*
references are updated with the proper data destination
objects.

Bug: 1103614
Change-Id: I702d1e9ba5005cba5a3b96e698a5b10b55ec0549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484448
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818622}

In order to use PredictionMetricsHandler for calculating various
prediction metrics when predicting points for delegated ink trails,
PredictionMetricsHandler needs the frame time. Frame time isn't readily
available in viz, so it will need to be plumbed in on the
DelegatedInkMetadata object from the renderer. This change adds that
member to the metadata and related plumbing and tests to get it to viz.

Bug: 1052145
Change-Id: I052c8786f70b07b058a0958226eb7f8dfec3d8aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451594
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818621}

Bug: 1140120
Change-Id: If3b8675731a305b511eacbaab9a7b02c8e0c520a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485045
Auto-Submit: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818620}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec6bccd90081..c81dc527120b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC rdcronin@google.com,lanwei@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: rdcronin@google.com,lanwei@google.com
Change-Id: I4f802237fa34819ee41f4048360d7b5acc5b3b0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485603Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818619}

Result_adapter cannot handle them currently, disable resultdb for them for now.

Bug: 1139149, 1137507
Change-Id: If2a28cbf60ee159fbecd84bce3aadee550b5d594
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476731
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#818618}

Bug: 1139816, 1047994
Change-Id: I7e9334af0611de67ee94c351dbc46068001a2938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485151Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Sergey Silkin <ssilkin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818617}

Messaging in cr-toasts were not being read out consistently, especially
in cases where the toast text stays the same for multiple actions (for
example, "Bookmark removed." for multiple different bookmarks).

This CL updates the cr-toast's show method to remove the role="alert"
attribute and re-add it to better ensure screen readers recognize to
read out the cr-toast's contents, and fixes one use of cr-toast to use
the show method instead of data-binding a property as the open
attribute.

Using a method is better than using an attribute because each call to
the method is a signal to read out the cr-toast, while using an
attribute will not trigger for any toasts that are shown while a toast
is already visible. For example, setting |open| to true while it is
already set to true will not trigger any JS, but calling |show()| is
guaranteed to always trigger the method's contents.

The plan is to replace all uses of the open attribute to the show method
for better consistency, and to eventually change the open property on
cr-toast to read-only.

Previous params for show were not being used.

Fixed: 1055842
Change-Id: I6c545814a4fc4b465b35708abbfa746c4acbb69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477663
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818616}

This is a follow-up to http://crrev.com/c/2472897 and
http://crrev.com/c/2476906 - updates the test to ensure that
on Mac, the caret browsing toggle shortcut is only active
when web contents has focus.

Bug: 1138475
Change-Id: Ida525b95473be042bbf7bb4bff52d866ef4d821f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476910
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818615}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/840ce58f94ba..80389cab7f58

$ git log 840ce58f9..80389cab7 --date=short --no-merges --format='%ad %ae %s'
2020-10-19 bungeman Test early to prevent overflow.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng
Change-Id: I783148718474ae66f66316f15852259280a41f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485196Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818614}

This is made for the consistency where all mocks and fakes are located.
Some classes are moved from sync/model to sync/test/model.

This CL also removes some unused classes.

The rest of fake classes will be moved in the following patch.

Moved classes:
* FakeModelTypeControllerDelegate
* FakeModelTypeSyncBridge
* StubModelTypeSyncBridge
* TestModelTypeStoreService

Deleted unused classes:
* DataTypeErrorHandlerMock

Bug: 948661
Change-Id: I8796b427942b65508bbde529f9d2829c01840fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470081
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818613}

Bug: chromium:1138953
Change-Id: I251cfaeef59846061c887a1d58f798cd1abef330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485871Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Ryan Heise <heiserya@google.com>
Auto-Submit: Ryan Heise <heiserya@google.com>
Cr-Commit-Position: refs/heads/master@{#818612}

This changes 64-bit integer fields to be deserialized as
BigInt values consistently, rather than sometimes being
BigInts and sometimes being Numbers.

Fixed: 1102217,1009262
Change-Id: I9cc8d767058938e9c39f62f139737e512f47cdb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466398Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#818611}

Bug: 1138911
Change-Id: I134cf9837c141e77155573574125b27e01c3728f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481074
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818610}

The WidgetHostMsg_Close_ACK message was overloaded to keep view state
around until the widget (which is owned by the view) was fully destroyed.
This can be accomplished by using a callback on the DestroyView mojom
message instead of waiting around for the Widget to be destroyed.

BUG=1097816

Change-Id: Ibbb92eaaba7e8c4a6b05217072a5367355fac708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471260
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818609}

This CL copies existing feature policy WPT tests to a permissions-policy
directory with permissions policy header syntax.

PS1 is the exact copy, reviewer can compare latest PS with PS1 to view
the actual changes.

Bug: 1095641
Change-Id: I56b767a7f2372f58ab086b3cc4f945398d2877c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432665Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#818608}

IndexedDBPreCloseTaskQueue runs compaction tasks that block shutdown.
This didn't used to happen in the past when it was run on a separate
thread, but now that these are run via the task scheduler they are
causing hangs during shutdown.

During shutdown there is (presumably?) a race between
~IndexedDBContextImpl and ~IndexedDBOriginStateHandle.  If the context
is destroyed first, it calls IndexedDBOriginState::ForceClose which
prevents the pre close tasks from running.  If the handle is destroyed
first, it starts a 2 second timer in origin state, and then starts
running the pre close tasks.

Although the compaction tasks cannot be interrupted, this patch makes
it so that if the last handle is destroyed first, and the context is
destroyed before the compaction starts, then it will not run the pre
close tasks and will stop any running timers.

Future follow-ups to consider include making the grace period timer
longer than 2 seconds.

Bug: 1086185
Change-Id: I9f9276c6e18d00f43a43d5d002ce85c7cf5240ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476721Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818607}

Unless |fast_timeout| is used (which will maintain previous behavior
of timing out immediately after the last attempt), on fallback of the
last attempt, a timer is run to time out the transaction.

Also doing the same on errors with the last attempt as long as at least
one previous attempt is still pending. And the transaction will also
return errors immediately if it was from the last pending attempt.

Bug: 1109792
Change-Id: Ibc8ed54428fcba247ed3526fa41584e27a118e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464068
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818606}

the formatted tree

Correct implementation of
https://chromium-review.googlesource.com/c/chromium/src/+/2412192:
* optimal since children are not populated and not appended into
a tree dictionary structure
* clean because all logic is kept by tree formatter

Bug: n/a
Change-Id: Ic4108c407d6f6d9b4786dd188efbd57b4648684d
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481762Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#818605}

Convert and simplify all the type-specific builders to use them. Also
convert integrity tests to just use a generic builder because the
integrity-specific builder only ever took raw bytes anyway.

Change-Id: I1972c9aaf79b749ed82516fccd473547b2c931ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477535Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818604}

Introduces a browser test with nested cross-origin (out of process)
iframes that transforms the child iframe into the viewport. The
test then verifies that the intersection observer reports that the frame
intersects the viewport.

This test catches the breaking behavior in https://crbug/1084786.

BUG=1088458

Change-Id: I2ec2f9635cad2ab54d07e5f04757348042b30597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231498Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#818603}

#1 Rather than assigning the atomic plane props and setting them on
property_set, split the operation into 2 disctinct actions:
1. Assign the props into local properties pending to be committed.
2. Set the properties on the property_set.
This means, to set the plane props, we assign the properties in
SetPlaneData then SetPlaneProps on property_set right before we're about
to atomically commit. (operations can happen at 2 different times)

#2. Also. always set fence_fd even if the value is invalid as long as the prop ID is valid.

BUG=1082882
TEST=planes are visible on displays.

Change-Id: If12b15025e3fcabb72d26959a77c695f63a6388b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481523Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#818602}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c45ca0dd90a..792630c498fc

2020-10-19 tandrii@google.com git cl try-results: show running jobs in YELLOW color.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: Ic65815bafdd39f44bdbea21979759d74766a6da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485599Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818601}

The video file handler is responsible for creating the
webm file in preparation for appended the successive video
chunks as they get received from the recording service.
Since there can be hundreds of chunks received per second,
it also takes care of buffering those chunks to save on
file IO operations.
It guarantees all IO operations are done on a blocking
thread as well as its destruction to assert that all cached
contents are flushed to the file.

BUG=1126586
TEST=Manually, added new tests.

Change-Id: I304f3abdb0b225b24ccbbdb0db8e3cc877512bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463457Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818600}

There's no reference to these methods.
GetAcceptLanguageList()
Added in https://crrev.com/397723002
Usage removed in https://crrev.com/c/602884 (file deleted)

GetCurrentKeyboardLayout()
Added in https://crrev.com/417103003
Usage removed in https://crrev.com/c/907973

Bug: none
Change-Id: I068165ffb17f3e024027e03263476d0acd4a595c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473859Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818599}

Test was added on 10/12/20 with crrev.com/c/2464202.

Bug: 1138113, 45260
Change-Id: I7621a5316a4bc14be55f63cd9716c12ffb772aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485844Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818598}

This CL:
- Generates monochrome_python_tests.pydeps using --gn-paths flag
- Adds run_isolated_script_test.py data deps to
  monochrome_public_apk_checker.py
- Adds //testing:run_isolated_script_test target to collect the data
deps for monochrome_public_apk_checker.py

BUG=1138758

Change-Id: Ifffa033368980923e2587e52ff50d35eeae2f271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483664Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818597}

This removes the remaining DictionaryValue usage from shill client and
fake client classes.

For minor apitest.cc change to c/b/e/api/vpn_provider:
TBR=emaxx@chromium.org

Bug: 1137487
Change-Id: Id3a84f1392f0d1586342b4441ad200f0a41110e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466931
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818596}

action-link no longer exists on the NTP.

Bug: none
Change-Id: I4df61932f6b1885bd98a56f4963aead4dafe352c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480889Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818595}

Change AppShimManager::AppState::ShouldDeleteAppState to return true
if the app is not installed for any profiles. Previously, the app
would continue running even after it had been deleted, resulting in
all sorts of cool behaviors. This winds up being hit in two paths.

First path is the AppShimManager::OnAppDeactivated call that is made
when a profile closes its last app window. This fixes crbug.com/1139254
where an app kept running even after it was uninstalled.

Second path is AppShimManager::OnProfileMarkedForPermanentDeletion,
for when a profile is deleted. This is for crbug.com/1132223 and is
a bit more involved.
* Listening for chrome::NOTIFICATION_PROFILE_CREATED/DESTROYED has
  been deprecated for a half-decade, so change AppShimManager to be
  a ProfileManagerObserver instead.
* Inline AppShimManager::CloseShimsForProfile to be a lambda inside
  of OnProfileMarkedForPermanentDeletion.
* Of note about ProfileManagerObserver is that closing app shims
  inside OnProfileMarkedForPermanentDeletion can cause crashes
  because it is not expected that Browser instances will be closed
  inside that call. For that reason, post a task to do the work.

Update tests (because now they're affected by the AppShimRegistry)
and add tests for both paths (shim installed vs uninstalled).

Since AppShimManager is now a ProfileManagerObserver we have to
make sure that the AppShimManager stops observing the ProfileManager
before the ProfileManager is destroyed. To do this, a new call,
BrowserProcessPlatformPart::BeginStartTearDown, which happens at
the beginning of BrowserProcessPlatformPart::StartTearDown.

Bug: 1139254,1132223
Change-Id: I19990f6ae5ff8d8727e1fb0ecf46d1142b543764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481790Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818594}