- 29 Sep, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601315959-4ec2d6a153e04750c200a2fe71bb63fd4f2d802c.profdata to chrome-linux-master-1601337561-307983a438d89a0d060ed0a79e008eada61629c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org Change-Id: I4f5536ecc77a4bb7de555059c5ec9269c3c95415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811518}
-
Peter Kasting authored
I didn't realize this existed when I wrote the initial change. Bug: 772945 Change-Id: Ib4dd142fc06b42f02c38811a7684f5564481471f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433587 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#811517}
-
Rachel Wong authored
There are several AutocompleteMatch fields that provide rich entity information but are currently not used by the launcher. This CL adds rich entity fields to the omnibox results, which will then be forwarded to ash. Any changes which may override existing behaviour are gated behind a feature flag. Bug: 1130372 Change-Id: Ia92aaa88cc1c6af41bd3b820b85b978c7b108e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409685 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811516}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/21e6e530cf90..18d69fb4e7b2 2020-09-28 wangxianzhu@chromium.org Let --interval-profiling-period cover legacy page interactions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132070 Tbr: rmhasan@google.com Change-Id: I2d6d25a8dd199772f3412be9899cc4aaea80d930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437409Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I81bdb9ed1de679f6b726c672bbd1519c0fcb2c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436413 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#811514}
-
zhaoyangli authored
Accept Xcode GM license as version from CIPD, instead of throwing a KeyError when 'IDEXcodeVersionForAgreedToGMLicense' key doesn't exist in '/Library/Preferences/com.apple.dt.Xcode.plist'. Bug: 1131413 Change-Id: Ic383174232d02e37a53da20b74680609b2743ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432874Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#811513}
-
Piotr Pawliczek authored
This patch adds support for new error codes defined in CL:2420496 and translates them to chromeos::PrinterSetupResult values. It also unifies error messages attached to chromeos::PrinterSetupResult values. BUG=chromium:1069844,chromium:1123268 TEST=tested on atlas as a part of larger patch Change-Id: I5eab4139a4a0dbdc878ef79de23ed35dca94cdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420497 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Alexander Surkov authored
TreeSelector suggests the wider range of application selection including handy browser selectors like --chromium Bug: 1131921 Change-Id: I658684bdf45efde747f5ae5311dc819c369fe1c6 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432105Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#811511}
-
Lei Zhang authored
Do not re-invent base::DoNothing() poorly. Bug: 537099 Change-Id: I837c8995686d1fa87779b58ab621d0e712803864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430824 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811510}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e41ad708. With Chromium commits locally applied on WPT: 6bdcd688 "[COOP] access reporting: split property.https.html test." 95fddf83 "[css-flex] Fix flex base size for aspect ratio items of column flexboxes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I919b1e8e2a7e44c5fc593f8fa153cbe3e45fb3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436803Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811509}
-
Jeffrey Kardatzke authored
When allocating buffers for the output (capture) queue with the new VD, we should add extra buffers to what the driver says we need to account for delays with the rest of Chrome's rendering pipeline. BUG=b:165647432,b:157703889 TEST=Playback no longer stutters on trogdor Change-Id: I782377dd10e3ac0c63ce12d12b6ac3c49c370b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433591 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#811508}
-
Darren Shen authored
The fields defined on a Mojo lite struct should not be renamed, as they are expected verbatim by the Mojo struct encoder. However, if compiled with property_renaming=ALL_UNQUOTED, the current generated struct fields will be renamed, which breaks the encoder. Use @export to prevent these fields from being renamed. Bug: 1132645 Change-Id: I0f4678c5ebf7d54ddd53c75eb3e7f0a4db94a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432235 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#811507}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ui/webui/chromeos/crostini_upgrader This CL was uploaded by git cl split. R=joelhockey@chromium.org Change-Id: Ia2ce23323e4f98ea6c9205d707d53866026e6244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434775 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811506}
-
Darren Shen authored
This reverts commit 96c22a25. Reason for revert: Seems to break the tree: https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-rel/38070? Original change's description: > [CrOS PhoneHub] Hook up quick actions UI to controllers. > > - Create a base class for quick actions controller. > - Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states. > - Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL. > > BUG=1106937,1126208 > > Change-Id: I3eb511e1843cd4cb6b80316a706a2dcbc61a8e49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419552 > Commit-Queue: Andre Le <leandre@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811478} TBR=khorimoto@chromium.org,tengs@chromium.org,leandre@chromium.org Change-Id: I36f2df2386549b01b802481f0cf2a65fa27d424c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Bug: 1126208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437538Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#811505}
-
Daniel Classon authored
Renames "Reverse scrolling" to "Enable reverse scrolling" on the settings page for Mouse and Touchpad, as per the bug. Fixed: 1132398 Change-Id: I173fe20f95a21c3909e8fa766cc8bfaac62258b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434211Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29d2aa6ec8cc..306abde46d50 2020-09-28 vidorteg@microsoft.com Locking user agent shadow dom from translation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6bbd5e92c6b5a8bd8d830d661030f6de08abf587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437091Reviewed-by:
-
David Bertoni authored
The conditional check for a null pointer value for g_test_clock is unnecessary, since the constructor of net::BackoffEntry will initialize the value to a nullptr anyway. This allowed removing the constructor completely. Change-Id: I02d62a79aba3257f50a0d5aae91d54ec9a612e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430449Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811502}
-
Xiaohan Wang authored
This reverts commit 87c8ae14. Reason for revert: Reland with fix Change-Id: I2778e8a68ba0c804b7795cade0ca9f8ed69838cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435781Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811501}
-
Stefan Zager authored
When calculating the viewport intersection of an iframe, we walk up the LayoutObject hierarchy, mapping the iframe's bounds into the coordinate system of each of its ancestors. When we encounter an ancestor with a clip, we take the axis-aligned enclosing rect of the iframe bounds to calculate the clip, and continue with that. As a result, the final computed intersection rect can be *larger* than the initial rect. This patch clamps the size and location of the viewport intersection to the size of the iframe's contents. Change-Id: Ie78cd824d68509ede748a906cefad4d611642388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427187 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#811500}
-
Bartek Nowierski authored
This is in preparation for transition to CheckedPtr (see go/miracleptr). Assigning 0 to CheckedPtr is ambiguous. Double = can be a problem, if only one of the fields gets converted to CheckedPtr. Bug: 1080832 Change-Id: I0ebc75e89b8d2ea0e7d63f4c0dcbcaab8aecf7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434022Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#811499}
-
Melissa Zhang authored
This CL removes unused constructor code and fixes crash when sharesheet is launched from non-files app. Bug: 1132697 Change-Id: Ib61cf18393eaec5eae9b9f6ea7d16b2bfe6153fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434069Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811498}
-
Giovanni Panaro authored
directory is hidden unless show hidden files is checked. Bug: 1119701 Change-Id: I35a5ce9ce867570d29e549c04f456519a08e0365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432444 Commit-Queue: Giovanni Panaro <tsrwebgl@gmail.com> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#811497}
-
Peter Kasting authored
* Convert PressedCallback into a class to allow it to be constructed from the various different callbacks and listeners. This reduces the number of overloads needed in APIs (though, sadly, not by as much as I'd hoped, since the ButtonListener constructor is two-arg and thus cannot be implicitly run in all the existing locations). * Convert various APIs to take a PressedCallback primarily, with a temporary ButtonListener* overload. Bug: 772945 Change-Id: Idde520cce7edd8f37a7a83ec0317bb453b9666e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433586 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811496}
-
David Tseng authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2424854 we slightly changed some of the enum key literals e.g. activedecsendantchanged to activeDescendantChanged. This undercovered an issue where methods like chrome.automation.AutomationNode.prototype.addEventListener appear to receive no validation. Callers can do |node.addEventListener(undefined)| and reach the native bindings. This change is a quick fix to make it so we don't crash. R=dmazzoni@chromium.org AX-Relnotes: n/a Fixed: 1132662 Change-Id: Idf4effeb29a6974df6d2d0a933f157c3aed705ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433997 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
My Nguyen authored
Record user action when an emoji is suggested to get timestamp. This is to figure out if some users get emoji suggested in a short timespan. Bug: b/168692236 Change-Id: I5ceb7c3c1846b9cae5a3c44a0ccc0bf62b7cb756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434186 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811494}
-
Nate Chapin authored
Change-Id: I72116e0417261f70826303cfc7d239ecb86b0dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427079Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#811493}
-
Khushal Sagar authored
Verification is expensive because of the need for sync IPCs and unnecessary unless resources are shared across processes. This was inadvertently added for cases where the resource is used within the same process, for instance a canvas to canvas draw. R=sunnyps@chromium.org Bug: 1131916 Change-Id: I54dcf298f185928faaa5a9caa9198b3815b6fa8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432859 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#811492}
-
Scott Violet authored
This renames UpdateAncestorOverflowLayer() to AncestorScrollContainerLayer. BUG=1087667 TEST=purely rename. Change-Id: I039b08c9378d74e015cbe334aed595ecc06ffd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432079Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811491}
-
Avi Drissman authored
This reverts commit 26aa33d2. Reason for revert: trybots are failing https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/685012 [4694/19597] CXX obj/ash/ash/silence_phone_quick_action_controller.o FAILED: obj/ash/ash/silence_phone_quick_action_controller.o ../../build/toolchain/clang_code_coverage_wrapper.py --target-os=chromeos --files-to-instrument=../....(too long) ../../ash/system/phonehub/silence_phone_quick_action_controller.cc:35:20: error: no member named 'SetDoNotDisturbState' in 'chromeos::phonehub::DoNotDisturbController' dnd_controller_->SetDoNotDisturbState(!is_now_enabled); ~~~~~~~~~~~~~~~ ^ 1 error generated. In renaming SetDoNotDisturbState you missed the call in ash/ash/silence_phone_quick_action_controller Original change's description: > Reland "[CrOS PhoneHub] Add setter functions to various manager classes" > > This is a reland of 6a3c229f > > Original change's description: > > [CrOS PhoneHub] Add setter functions to various manager classes > > > > The added setters are going to be used by a future Cl that implements > > the PhoneStatusProcessor class. > > > > Bug: 1106937 > > Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346 > > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810084} > > Bug: 1106937 > Change-Id: I02ac4d496d9493c7b52de7d6bb36eb61517caa16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429290 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811479} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org Change-Id: I4d5edab201fa06caa630678a9b18d4d85f235e0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437016Reviewed-by:
-
Hirokazu Honda authored
Bug: 1030199 Test: None Change-Id: I2aba6e2b92e5db749d4faa389d01bfbeab1dbad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428515Reviewed-by:
-
Hiroki Sato authored
CL:2261179 added a definition of this API, but there was no implementation for it. This CL adds it. Bug: 1127721 Test: browser_test AccessibilityFeaturesApiTest Change-Id: I131406370e6e81599286bb02b5dd3e0dd6761aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407937 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix potential crash found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Iba1093736fa49775ad0c3605bc78e0a65cb890d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431487Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#811487}
-
David Black authored
Focused state: - Blue ring drawn outside of view. Selected state: - Blue ring drawn at border of view. - Semi-transparent blue overlay drawn over view. This CL also updates size of the pin icon. Bug: 1131267 Change-Id: Ia3e45e0c42cbe99e40893ab5efc2e085eb91f2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434766 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#811486}
-
Bartek Nowierski authored
There are a couple reasons for this change: 1. Avoid copying a struct larger than a pointer. 2. If the pointer in the struct gets replaced by CheckedPtr with a non-trivial constructor, the compiler will complain. See go/miracleptr for more details on the experimental CheckedPtr project. Bug: 1080832 Change-Id: I5d0718a351af253bd3917bef87d417f9f0d71b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435033 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#811485}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601098956-d2e0aa4048f1f94bf1822bc14b11121ebd74fc3b.profdata to chrome-win32-master-1601294375-ec6f4fd0c2345f1003140fa4e4e991347147fa6d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iba5a5de5a45f756dbe315fc8ff3a5f186b4a0e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435632Reviewed-by:
-
Isuru Pathirana authored
This is a reland of f2f4de88. The original version of this change caused crashes when running the capture unit tests on Win7 (due to the MF DXGI Device Manager not being supported on Win7). The capture unit tests have been updated to skip MF D3D11 tests on Win7 or earlier. Original CL description: [Win Camera Capture] Use D3D11 with Media Foundation Video Capture This CL updates the VideoCaptureDeviceFactoryWin/VideoCaptureDeviceMFWin implementations to use D3D11 with the MF device source and capture engine. The VideoCaptureDeviceFactoryWin creates and manages an IMFDXGIDeviceManager and associated D3D11 device instance. It provides the IMFDXGIDeviceManager to the MF device source and also plumbs it to the VideoCaptureDeviceMFWin implementation. The VideoCaptureDeviceMFWin implementation subsequently provides the IMFDXGIDeviceManager to the MF capture engine on initialization. Providing a MF DXGI device manager to the MF device source and capture engine is required for zero-copy capture (it allows the Windows frame server service and MF capture engine to keep captured video frames in GPU memory and expose MF samples backed by D3D11 textures). Bug: 1120900 Change-Id: I41f1ef14e7040c84fa63e0ad2618330d73e7cdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434469Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811483}
-
Michael Hansen authored
This adds support for validating the device name that a user enters. Validation happens as the user types and also when they try to save the name. If an invalid name is detected, an error message will appear and the "Done" button will be disabled. Screenshots: https://screenshot.googleplex.com/3gnC6aQVyj4YmkX.png https://screenshot.googleplex.com/5arMAbok2MgfioU.png https://screenshot.googleplex.com/BEbCJ9LteRAYFpv.png Bug: b:161297140 Change-Id: I3290eb92222cd796a1dede3ce603da5cc44940bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424675 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#811482}
-
Daniel Hosseinian authored
Send a request to the plugin upon detecting a 'paint-thumbnail' event. Set the thumbnail's image data upon receiving a response. Bug: 652400 Change-Id: I3e8faa5a1cc15fbd274c9e641078d6aa8de7ec8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412968 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811481}
-
Evangelos Foutras authored
Video decoding was being accelerated on Linux even though the newly added "enable-accelerated-video-decode" flag was not specified. The chrome://gpu page was misleadingly showing this feature as disabled: > Video Decode: Software only. Hardware acceleration disabled This change adds a check for --enable-accelerated-video-decode when considering if video decoding should be activated. (Only on Linux.) Extra context: https://crbug.com/1097029#c18 (and also comment 20). Bug: 1066176, 1097029 Change-Id: I534115f5f6ceed0ee3511fcf5c2d0f1dd04b9b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431434Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Jimmy Gong authored
This is a reland of 6a3c229f Original change's description: > [CrOS PhoneHub] Add setter functions to various manager classes > > The added setters are going to be used by a future Cl that implements > the PhoneStatusProcessor class. > > Bug: 1106937 > Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810084} Bug: 1106937 Change-Id: I02ac4d496d9493c7b52de7d6bb36eb61517caa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429290 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
