GitLab

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6292003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71669 0039d316-1c4b-4281-b951-d872f2087c98

subdirectories of chrome/browser/ui/gtk/:
 (notifications, options, status_icons, tabs, translate)

Update all chrome/browser/gtk references & copyright dates of touched files.

Re-alphabetize include lists as necessary from this change.

Remove the chrome/browser/gtk subdirectories & stubbed headers.

BUG=69289
TEST=None

Review URL: http://codereview.chromium.org/6328002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71668 0039d316-1c4b-4281-b951-d872f2087c98

It looks like l10n_util_dummy.cc isn't needed anymore: The function
in the file doesn't match any functions in l10n_util.h.

Convert BidiLineIterator to use string16.  I don't see any unittests
for this file. :(

BUG=23581
TEST=None

Review URL: http://codereview.chromium.org/6315002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=No DCHECK when triggering tabpose

Review URL: http://codereview.chromium.org/6320005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no code change
R=pinkerton
Review URL: http://codereview.chromium.org/6372002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69941
TEST=None
TBR=isherman

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=mnissler

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=57910
TBR=glider
TEST=remoting_unittests should become green under Dr. Memory
Review URL: http://codereview.chromium.org/6336007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71662 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6277007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71661 0039d316-1c4b-4281-b951-d872f2087c98

Update Dr. Memory ToolsSanityTest suppressions to account for the base:: enclosure; Suppress a leak under SHFileOperation
TBR=glider
TEST=DrM FYI bot should go greener
Review URL: http://codereview.chromium.org/6328003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67422, 69293
TEST=None
TBR=hans

Review URL: http://codereview.chromium.org/6374003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71659 0039d316-1c4b-4281-b951-d872f2087c98

browser processes on a crash. The exception handler was not registered correctly.

BUG=none
TEST=none
TBR=amit

Review URL: http://codereview.chromium.org/6343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71658 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6293008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64877
TEST=Existing unittests; manual testing.

Review URL: http://codereview.chromium.org/6079012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71656 0039d316-1c4b-4281-b951-d872f2087c98

The GPU process cannot be placed on a UI thread in --single-process mode because glib is not thread safe. This patch moves it onto a IO thread instead.

Connections to the X server are not thread safe. I've made changes so that each thread gets it's own connection.

Finally, GpuHostMsg_GetViewXID needed to be needed to be sent from the thread added to GpuChannel instead of ChildThread::current().

BUG=69674
TEST=try --single-process with --enable-accelerated-layers on http://webkit.org/blog/386/3d-transforms/

Review URL: http://codereview.chromium.org/6340004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71655 0039d316-1c4b-4281-b951-d872f2087c98

Failing browser_tests on some platforms with JavaScript ReferenceError.

BUG=none
TEST=none

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/6309006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71654 0039d316-1c4b-4281-b951-d872f2087c98

TEST=`./tools/valgrind/waterfall.sh fetch` then `./tools/valgrind/waterfall.sh match`
Review URL: http://codereview.chromium.org/6057006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69941
TEST=None
TBR=isherman

Review URL: http://codereview.chromium.org/6336006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66414
TEST=none
TBR=dtu

Review URL: http://codereview.chromium.org/6289008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71650 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6296008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71649 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses all the memory errors in LayoutPluginTester.FLAKY_SelfDeletePluginInvoke started since r71589 <http://crrev.com/71589>. I'm wondering if these suppressions are good ones, though.

TBR=thestig,timurrrr
BUG=69934
TEST=make the "Linux Tests (valgrind)(4)" bot green.
Review URL: http://codereview.chromium.org/6320006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71648 0039d316-1c4b-4281-b951-d872f2087c98

For ChromeOS: when starting session: if locale was changed (as a result of sync or because user preference differs from login locale): show notification.

BUG=chromium-os:9164
TEST=Manual

Review URL: http://codereview.chromium.org/6249009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles with use_openssl=1 flag.

Review URL: http://codereview.chromium.org/6338004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71645 0039d316-1c4b-4281-b951-d872f2087c98

This change just re-adds SpeexEncoder::~SpeexEncoder(), which has been deleted by r71599 <http://crrev.com/71599> to delete the speex resources allocated in SpeexEncoder::SpeexEncoder().

BUG=69906
TEST=make the "Linux Tests (valgrind)" bot and green.
Review URL: http://codereview.chromium.org/6294005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71641 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71639 0039d316-1c4b-4281-b951-d872f2087c98

Deleted kEnableLoginImages flag.

BUG=chromium-os:7214
TEST=Old login screen should not show up even under automation tests for login.

Review URL: http://codereview.chromium.org/5809001

TBR=avayvod@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69193
TEST=No direct test; watch crash reports to see if the crash that's supposed to be fixed by this still occurs.

Review URL: http://codereview.chromium.org/6316003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71636 0039d316-1c4b-4281-b951-d872f2087c98

The former members of the dict are now included directly in the policy definitions.

BUG=64898
TEST=existing unit tests in tools/grit/grit/format/policy_templates/

Review URL: http://codereview.chromium.org/6360002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71635 0039d316-1c4b-4281-b951-d872f2087c98

TopSites has been enabed since r64072. It's now time to remove
the dead code.

BUG=69492
TEST=Make sure thumbnails are correctly updated as before. try bots.

Review URL: http://codereview.chromium.org/6283001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71634 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses occasional leaks for Bug 69919. (Even though these leak do not happen always, they happen pretty often.)

TBR=thestig,timurrrr
BUG=69919
TEST=make the "Linux Tests (valgrind)(1)" bot green.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71633 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

BUG=69918
TEST=browser_tests
Review URL: http://codereview.chromium.org/6304008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71632 0039d316-1c4b-4281-b951-d872f2087c98

This change temporarily suppresses the leaks caused by r71599 <http://crrev.com/71599>.

TBR=thestig,timurrrr
BUG=69906
TEST=make the valgrind bots green.
Review URL: http://codereview.chromium.org/6260008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71631 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6312004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71629 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6368002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71628 0039d316-1c4b-4281-b951-d872f2087c98

twice if we have previously received payment notification.

BUG=chromium-os:10075, chromium-os:10428
TEST=tough one to test - requires OTA-SP activation of number of devices until reproduces. we should make sure that we 1) don't get stuck in 'Conneting...' phase after payment and 2) we never see the payment portal twice for the same device once the payment is processed. 

Review URL: http://codereview.chromium.org/5861001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71627 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6348005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71626 0039d316-1c4b-4281-b951-d872f2087c98

dataType has been required for <select pref=...> since
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284

BUG=to be filed
TEST=confirmed that the punctuation style setting worked for mozc.
also confirmed that all <select> elements with 'pref' attribute have dataType:
% perl -n0e 's/(<select[^>]*pref.*?>)/print "$ARGV:$1\n"/gse' *.html > all_select_prefs
% perl -n0e 's/(<select[^>]*dataType.*?>)/print "$ARGV:$1\n"/gse' *.html > select_prefs_with_datatype
% diff all_select_prefs select_prefs_with_datatype

Review URL: http://codereview.chromium.org/6286002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71625 0039d316-1c4b-4281-b951-d872f2087c98

The issue was probably introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284
that made undefined dataType to be an error.

BUG=chromium-os:10878
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/6246005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71624 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6307005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71623 0039d316-1c4b-4281-b951-d872f2087c98

Fix PRESUBMIT.py to exclude Makefile.

BUG=none
TEST=presubmit check is less noisy

Review URL: http://codereview.chromium.org/5976009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98