- 04 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f3c5fefedbf9..94c33f91b3c2 git log f3c5fefedbf9..94c33f91b3c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@94c33f91b3c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Id6cff5d3dc7f19147f798f320b4d4b3b32f45177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702725}
-
Eric Willigers authored
The WebDisplayMode enum is redundant in C++ now that we have blink::mojom::DisplayMode. The following header is no longer needed: third_party/blink/public/common/manifest/web_display_mode.h // TODO(dgozman): instead of this enum, use blink.mojom.DisplayMode directly. WebDisplayMode.java is added to chrome/android/java/..., replacing the WebDisplayMode.java file that was previously generated from the above header. (The mojom-generated Java class DisplayMode is not a direct replacement for the Java annotation type @WebDisplayMode.) The DisplayMode enum constants now following the naming guide: kUndefined kBrowser kMinimalUi kStandalone kFullscreen https://google.github.io/styleguide/cppguide.html#Constant_Names TBR=jochen@chromium.org TBR=reillyg@chromium.org TBR=yusufo@chromium.org Bug: 1009909 Change-Id: Ida01048bd5001e9217601d35a2ef3770d4d7bf54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834804 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#702724}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2cf50492a3f..35a60f622c58 git log d2cf50492a3f..35a60f622c58 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@35a60f622c58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I49a58d5fbc518a1adec7d6d3d660ec195ea4efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839415Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts UDPSocket from udp_socket.mojom to new Mojo types using PendingRemote, Remote, PendingReceiver, Receiver, and UniqueReceiverSet. Bug: 955171 Change-Id: I344a2808ca8da42a1a5c0cb6166c8916a5159a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831623Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Julie Kim(OoO until 4 Oct) <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#702722}
-
Ankit Kumar 🌪️ authored
Document links may have zoom values defined in the PDF. Currently the zoom values are not taken into account during navigation of document links. This CL adds the zoom value for document links. Tests have been modified to validate the zoom value. Bug: 982176 Change-Id: Ibcd585b20eb2506a1c01066de2548e36da6ffc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811408Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702721} -
Yu-Hsuan Hsu authored
The change is related to CL:1813257. Add histogram information in histograms.xml to make the histogram visible on chromedashboard. BUG=b:141286272 Change-Id: Ic8f94aa183decb6f108954c1249428af6f00d4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837450Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702720}
-
dpapad authored
In Polymer3 relative CSS url()s inside style modules are resolved by default with respect to the main HTML document, which results in incorrect URLs. In Polymer2 these were resolved with respect to the location of the HTML file hosting the style module, but in Polymer3 styles are hosted in JS. Explicitly adding an |assetpath| attribute to auto-generated Polymer3 style modules fixes the issue. Bug: 965770 Test: Use css_icons_css.m.js from a Polymer3 WebUI page. Verify that icons are properly displayed. Change-Id: I12b3e9283bded368976469bdd7ab5e2ef0c79a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838554 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#702719}
-
Nate Fischer authored
No change to logic. This updates C++ code in the metrics component to use nullptr instead of NULL. This is to align with the chromium C++ styleguide. Bug: 1010369 Test: git cl presubmit --upload Change-Id: Ib4133584972ae6069e469c58798cd1a323b4eeec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835091Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702718}
-
Andrew Luo authored
Change-Id: I7a84805a01edad11df3ba65762aec013bdf2488a Bug: 1010211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832482Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702717}
-
Yoichi Osato authored
TBR=achuith@chromium.org Bug: 1010866 Change-Id: Idb04a7a87cfd1bf71e79e90f2202010954f711ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838793Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#702716}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1f08ab28305d..5549ef0451f9 git log 1f08ab28305d..5549ef0451f9 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 m.maiya@samsung.com Vulkan: Fix content synchronization for textures bound to images 2019-10-03 timvp@google.com Trigger a flush() when the command graph contains too many objects Created with: gclient setdep -r src/third_party/angle@5549ef0451f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I5a3085c3ee848b7f47fcc232a17145550f13b6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839204Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42e79b023ed5..595c588d9706 Created with: gclient setdep -r src-internal@595c588d9706 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie081fa70c99d08b625ad752f8a39763c2dc3d99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702714}
-
Alexey Baskakov authored
According to go/chrome-bmo design doc sync data model, we should have two copies of app's name and theme_color fields. Rename specifics to sync_data. Rename proto to local_data. Add is_sync_placeholder flag. Add comments. All these fields will be used in WebAppSyncBridge implementation: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 Bug: 860583 Change-Id: Idce95b5fdd4843cf9a8e290fe61293bffb938bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833347 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#702713}
-
Yoichi Osato authored
TBR=bengr@chromium.org Bug: 1010865 Change-Id: I01a9b4390fb0147c95c7f915d4a15d442a0faddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838778Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5407542ba98db5c8ed0d0efaf1362f508eb68561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838387Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702711}
-
Nico Weber authored
Move GOOGLE_CHROME_BUILD into just the cc files, so that the dep on //build:branding_buildflags doesn't have to be a public_deps and to make branding affect internal APIs less. Bug: 961769 Change-Id: I41f0dfc5df304ea34b35d4298e389573a1bd2119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830088Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702710}
-
Ramya Nagarajan authored
Bug: 1010782 Change-Id: Iadba4ee9eaf703d05c38de9154cf17925b4050f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838955 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702709}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/67840e16ec81..f518a2641c6d $ git log 67840e16e..f518a2641 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 vasilvv gfe-relnote: Call NeuterHandshakePackets() once per connection. Protected by reloadable flag quic_neuter_handshake_packets_once. 2019-10-03 vasilvv gfe-relnote: Call NeuterHandshakePackets() once per connection. Protected by reloadable flag quic_neuter_handshake_packets_once. 2019-10-03 bnc Remove SETTINGS_NUM_PLACEHOLDERS. 2019-10-03 nharper Call ProofHandler::OnProofVerifyDetailsAvailable in TLS handshake in QUIC 2019-10-03 bnc Remove QpackEncoder::DebugVisitor. 2019-10-03 vasilvv [build] Include ostream in quic_ip_address.h 2019-10-02 bnc Fix QPACK crash by unregistering observers with QpackHeaderTable. 2019-10-02 bnc Enable histogram logging events in QpackEncoder even if there is no debug_visitor_. 2019-10-02 bnc Change QpackHeaderTable::observer_ type and swap RegisterObserver() argument order. 2019-10-02 fayang gfe-relnote: Check for partial write when crypto frame gets retransmitted. This only affects T099 which supports amplification factor. 2019-10-02 wub gfe-relnote: (n/a) Rate limit a QUIC_LOG(ERROR) in BandwidthSampler. Logging only. 2019-10-02 vasilvv Implement a QuicSession subclass for QuicTransport client. 2019-10-02 fayang gfe-relnote: In QUIC, consider packets (which cannot be sent because of write blocked) as sent from unacked_packet_map and congestion control's perspectives. Protected by gfe2_reloadable_flag_quic_treat_queued_packets_as_sent. 2019-10-01 quiche-dev Enable QUIC v48 for Quartc 2019-10-01 wub gfe-relnote: (n/a) Add unit tests for quic::MaxAckHeightTracker. Test only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I7ec255e103eb06aa47d9611f7888f71b8014af11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838167 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#702708}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68d22ef43dcd..d2cf50492a3f git log 68d22ef43dcd..d2cf50492a3f --date=short --no-merges --format='%ad %ae %s' 2019-10-04 tandrii@google.com Revert "Roll recipe dependencies (trivial)." 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-03 rmistry@google.com Revert "Roll recipe dependencies (trivial)." 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@d2cf50492a3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ic349f0af6224e6649029060e37e643f97d9094bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839182Reviewed-by:
-
Yoichi Osato authored
TBR=changwan@chromium.org Bug: 1011204 Change-Id: Ib740b099ed79125201df083d85669610de8f649f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839273Reviewed-by:
-
Regan Hsu authored
screenshot: https://screenshot.googleplex.com/4Mrmorn61Ep Bug: 993828 Change-Id: Ief3e762760989d92403dcf3c350d608bfa06c545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828130 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702705}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I07952bc30df770f98c100b64e5083d7d67b38e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838982Reviewed-by:
-
Yoichi Osato authored
TBR=wangxianzhu@chromium.org Bug: 1011191,1011188 Change-Id: I3ebc1ef0c5c5553e21b6c8fb09cd5ce81b810838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838777Reviewed-by:
-
Fred Mello authored
Also renamed param from status to errorCode. Bug: 1005802 Change-Id: Iee6991724fb10b9e30ca7919ae21e5a4829e3324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838415 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702702}
-
Yoichi Osato authored
TBR=battre@chromium.org Bug: 1011194 Change-Id: Ibefb2fa2483c7d20633159a07180127cc15c8b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838776Reviewed-by:
-
Yoichi Osato authored
TBR=csharrison@chromium.org Bug: 1011205 Change-Id: I91122be48ec9968746a601440556b8d9000aaac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839216Reviewed-by:
-
Yoichi Osato authored
TBR=mastiz@chromium.org Bug: 1011196 Change-Id: Icd3cfd3860068b1530d5393868fedd2b6bcb2c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839312Reviewed-by:
-
Yoichi Osato authored
TBR=csharrison@chromium.org Bug: 1011203 Change-Id: Ie9807b09fb16726f117c02507a3a200d22acfe0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839311Reviewed-by:
-
Yoichi Osato authored
TBR=dvadym@chromium.org Bug: 1011192 Change-Id: If41454368e54755056d36ff2bf258b8a1decd2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839275Reviewed-by:
-
Yoichi Osato authored
TBR=battre@chromium.org Bug: 1011200 Change-Id: I44f5b3ba33c861b2885da30ea561a68adba014bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839153Reviewed-by:
-
Yoichi Osato authored
TBR=drubery@chromium.org Bug: 1011197 Change-Id: Ice7d23afd629d392a3d3b8df037ccb21834ad75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839274Reviewed-by:
-
Yoichi Osato authored
TBR=battre@chromium.org Bug: 1011202 Change-Id: Id1b6f02e796fb6f411a5b2145a24d794f83149a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838894 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Dan Beam authored
WebContents::GetURL() wasn't the right place to query a URL from when checking whether to override the webkit pref sent to the RenderViewHost when creating a renderer. Instead, use rvh->GetSiteInstance()->GetSiteUrl(), which is correct at the time we need to query. The reason for this code is to ensure that: @media (prefers-color-scheme: dark) { /* bunch of dark mode styles go here */ } Does not apply as we have code shared across different platforms (i.e. Linux, Windows, Mac, ChromeOS, etc.). Only Mac & Windows currently support dark mode (and hence, are the only platforms in which all the web UI has been audited and/or updated). So in order to change shared code that also runs on Linux/CrOS, we put both light/dark style into the CSS, but disallow the dark styles from running on non-dark-mode-enabled-platforms (Linux, CrOS). Bug: 1007892 Fixed: 1007892 Change-Id: I1076e48eaa160a23213e6873f1d857cf54935f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825936Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702693}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fe87ab48664..42e79b023ed5 Created with: gclient setdep -r src-internal@42e79b023ed5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I9799ee3aa216f080469d3bec385ed4a1b82dea1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838542Reviewed-by:
-
chrome://flagsAdam Langley authored
There is an entry in chrome://flags for caBLE, but caBLE has been default enabled on Windows, macOS, and Chrome OS for some time. It's not default-enabled on Linux and we are not moving towards getting it working on Linux, so chrome://flags isn't really the right place for that. Instead, take that entry and repurpose it to enable caBLE v2. This will allow easier testing on Chrome OS. (It'll be rather hard to use on Windows at the moment too since the UI won't appear, but that's why it's not enabled by default.) Enabling this will happen to also enable caBLE v1 should anyone really want to test it on Linux. BUG=1002262 Change-Id: I8d83cf0fcf0ab711cb521b67084d4b80c2dc21af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838478Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#702691}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4167aa75260f..614d79248ef2 git log 4167aa75260f..614d79248ef2 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 rharrison@google.com Revert "Add spvc compiler to returned result (#821)" (#827) 2019-10-03 rharrison@google.com Add spvc compiler to returned result (#821) Created with: gclient setdep -r src/third_party/shaderc/src@614d79248ef2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I8df67446264fd8484f1bb15e089e1c9247eab772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838541Reviewed-by:
-
Eric Lawrence authored
Log the operation ("store" or "send") when logging a cookie operation that has been blocked. If the NetLog is configured to log sensitive data, also record the blocked cookie's name. Bug: 1005217 Change-Id: I90dff3a5df87ca3fe3869c90a7bf7a99843043b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837047 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:Eric Roman <eroman@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#702689}
-
nancy authored
This CL is used to add profile_ as the AppServiceProxy class member variable, as profile_ will be used to create the Uninstall_dialog, which is created by crrev.com/c/1833024. BUG=1009248 Change-Id: I7ec432dafbf4a58a01f5f3d3114dacea19e1fb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837554Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702688}
-
Darwin Huang authored
BlobData is never referenced in SystemClipboard, so remove the include. No intended functional changes. Change-Id: I34936a04bdcd1caac97e209568886cb054b0fb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832884Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702687}
-
Sanket Joshi authored
This is a reland of 73ace883 The original change was missing some mac10.10 images. Original change's description: > ColorPicker: Fix vertical alignment of the up-down arrow icon > > The up-down arrow is currently slight off vertical center. This CL > fixes that and updates all affected test baselines. > > Bug: 1010330 > Change-Id: Id1965a6243046816207bf521e25bb06413e6c77d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832720 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#702218} Bug: 1010330 Change-Id: I7d664c9fe99cff4ccf62213b991bb40f6c8b0e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837204 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#702686}
-
