- 10 Apr, 2020 39 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1eaaf114..9173e675 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I72335a45456579601412dc1fd0eaac3f9695a15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144237Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758119}
-
Hiroki Nakagawa authored
This reverts commit 21cd313b. Reason for revert: These tests are already disabled by https://chromium-review.googlesource.com/c/chromium/src/+/2144426 Original change's description: > Revert "Disable regression tests for bug 1042010 only on Windows." > > This reverts commit 2500b17b. > > Reason for revert: > These tests are failing on several Mac bots: > https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3215 > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33296 > https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/49144 > > Original change's description: > > Disable regression tests for bug 1042010 only on Windows. > > > > Also add comment linking the related issue. > > > > Bug: 1042010 > > Bug: 1068579 > > Change-Id: Ia956aef5d609261f543c1a3eb0e06da80fc64eb9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139763 > > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#757824} > > TBR=dmazzoni@chromium.org,bsep@chromium.org,jaragunde@igalia.com > > Change-Id: Ia2cb645cb260074bb4667787612e2470feceb132 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1042010, 1068579 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144795 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758114} TBR=dmazzoni@chromium.org,nhiroki@chromium.org,bsep@chromium.org,jaragunde@igalia.com Change-Id: I9ffee3bd997776308032777f0b8f459ed5350cf5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042010, 1068579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142880Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#758118}
-
rbpotter authored
- Move CreateCloudPrintSigninTab() to the c/b/ui/webui/print_preview/ directory in a new file, since it's only used by the print_preview_handler. - Delete print_dialog_cloud_posix.cc since it only contains a NOTIMPLEMENTED() function, and instead make the caller and print_dialog_cloud.* Windows only. Bug: 982641 Change-Id: Id292511b4c2b418a809f25957f99f76f9cdcb6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143112Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#758117}
-
rbpotter authored
Mirror only exists on Chrome OS, which doesn't have the avatar row. https://chromium-review.googlesource.com/c/chromium/src/+/1763413 added the correct handling for the Chrome OS case, so per https://crbug.com/982641#c28 this code never executes. TBR=sinhak@chromium.org Bug: 982641 Change-Id: I00e810d16c5a8c61a5fd846c9e6041f28b489bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145092 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
David Bertoni authored
This test was disabled in 2013. It needed to be rewritten for the modern era. After testing 3000 iterations on the bots, there were no flakes with the new version. Bug: 174934 Change-Id: I102482ad66025eb1061e916455b565be0d959acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144613Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758115}
-
Hiroki Nakagawa authored
This reverts commit 2500b17b. Reason for revert: These tests are failing on several Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3215 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33296 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/49144 Original change's description: > Disable regression tests for bug 1042010 only on Windows. > > Also add comment linking the related issue. > > Bug: 1042010 > Bug: 1068579 > Change-Id: Ia956aef5d609261f543c1a3eb0e06da80fc64eb9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139763 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757824} TBR=dmazzoni@chromium.org,bsep@chromium.org,jaragunde@igalia.com Change-Id: Ia2cb645cb260074bb4667787612e2470feceb132 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042010, 1068579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144795Reviewed-by:
-
Esmael El-Moslimany authored
Frontend for selecting and showing the selection when no background and a background image is selected. Bug: 1032328 Change-Id: Iff7864dd54ef0a2eb7b7bfb186178ef6d4d0b30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136035 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758113}
-
Matt Falkenhagen authored
To get a rough idea if there is any performance benefit to combining the two messages into one (of course, even if there is none, there is still the primary benefit of code simplification). This adds the UMA for navigation loads only, in the browser process. I tried doing the same for all loads in the renderer process in url_loader_client_impl.cc, but testing locally there was up to ~1 second of delay, which means likely there are some loaders that don't send the two messages immediately after each other. So, holding off on the UMA for the renderer until we understand what it's measuring more. Bug: 1017710 Change-Id: Ica7452e834a6583a763422ae356d75423fbf5fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141482 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#758112}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6574f92747a2..ab2c84ffd2a4 git log 6574f92747a2..ab2c84ffd2a4 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 brandon1.jones@intel.com Residency 6: Enable D3D12 Residency and Add Tests 2020-04-09 brandon1.jones@intel.com Residency Bug: Make Setting Heap's Last Submission Serial Optional 2020-04-09 enga@chromium.org Fix use-after-free if BindGroup is the last owner of its BindGroupLayout Created with: gclient setdep -r src/third_party/dawn@ab2c84ffd2a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib548fabc724d328e6e38160336d7356635cb3b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758111}
-
Jon Mann authored
The Polymer binding to the translated string was using single quotes around the i18n() function call, but in Dutch the string actually contained an apostrophe/single quote which caused broken syntax. Bug: 1069632 Change-Id: I2dd4e094f683ab3ce9875ec2db22ccd7e9b6cb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144408Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#758110}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: If6c3b2e16b99f3fd252a4d02244cab3c93e19c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140977 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758109}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c12c1f571aec..df3cc205af96 git log c12c1f571aec..df3cc205af96 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src bb32b2a70168..ae6787114fb5 (4 commits) 2020-04-09 timvp@google.com Vulkan: Support Program Pipeline Objects Created with: gclient setdep -r src/third_party/angle@df3cc205af96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ic1ba13bfc52fbac61f66bbbcd5df640f917274a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145172Reviewed-by:
-
Kevin Marshall authored
Allows the WebEngine to connect to an Agent-published MetricsRecorder service. Some simplification of CastRunner code, eliminating the need for an alternate constructor for "isolated runners" by decoupling service publishing from runner construction. Added an integration test. Bug: 1060768 Change-Id: Ia36a13cbd9a68565bd80bb32facf393b23d3cfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133056 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758107}
-
Jinsuk Kim authored
Browser controls state is for WebContents in base (main) tab. Preview Tab contents (or any ThinWebView clients) doesn't need to have it enabled. This CL turns it off. Bug: 1068944 Change-Id: I07396406c57a56db6e8452fce677433bfab74530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143072Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#758106}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I2f5c8c7fccb2734dca3f53a44be9c155e32a5f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144424 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#758105}
-
Hiroki Nakagawa authored
This reverts commit cce3bf4a. Reason for revert: Looks like lint failure fails the compile step on android-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10732 Original change's description: > Android: Use lint from cmdline-tools > > This version of lint is up-to-date with Android Studio and the lint team > intends to keep it that way. > > We no longer need a separate tools-lint directory for an up-to-date > version of lint. > > Bug: 1069186 > Change-Id: I8846406c4787d36863718489c3c54c4b1438d79b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144367 > Auto-Submit: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758085} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I9d6c6abfc06089372ef2bf6314bfa3d6ab0cb25e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143786Reviewed-by:
-
Ayu Ishii authored
This change adds cleanup and comments we discussed during code walk through. Change-Id: I0b5ce06501257c1285c7e907d77fd942bbc076f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140906Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#758103}
-
Hiroki Nakagawa authored
This test frequently fails on multiple bots (Linux, Mac, Win). Bug: 1068681 Change-Id: I8a0708a5bb9ecd37cd1e1363e07ca7acc3fe7db9 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143784Reviewed-by:
-
Aaron Leventhal authored
Nodes that are now ignored should not be considered cells. Bug: 1061248 Change-Id: Ic0118c58a696dc52f6528e7a9e1da34cc1eef885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144423Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#758101}
-
Esmael El-Moslimany authored
When an OGB overlay is open, a backdrop is shown essentially making the overlay modal. The embedder is notified using an 'activate' message. The embedded updates the z-index of the OGB to be on top while the overlay is shown. Bug: 1039913 Change-Id: Ie9c1dd436bb43d6366b198d2d8aa839f58679635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142103Reviewed-by:
-
Alan Cutter authored
This CL fixes the following warning in components_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ActivationStateComputingThrottleMainFrameTest> The ActivationStateComputingThrottleMainFrameTest tests were not being run. All/ActivationStateComputingThrottleMainFrameTest.NoPageActivationNotification_NoActivation/0 regressed during this time. Bug: 1069398, 1045846 Change-Id: I694129e58ba5272863ee810ee7949d7e34bc72ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143779 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#758099}
-
Alan Cutter authored
This CL removes the uninstantiated test suite GestureEventQueueWithSourceTest to fix the warning in content_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<GestureEventQueueWithSourceTest> Bug: 1045846 Change-Id: I82146898d77e36240b0e26a0dcf551228435cf35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143874 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758098}
-
Gyuyoung Kim authored
This CL migrates clip-path-columns-shape[-expected].html tests from css3/masking to external/wpt/css/css-masking/clip-path with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to clip-path-columns-shape-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: I146b61e8f0a841e71a05e7f93d823939e1a11ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143055Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#758097}
-
Gyuyoung Kim authored
This CL migrates clip-path-css-transform-mutated[-expected].html tests from css3/masking to external/wpt/css/css-masking/clip-path with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to clip-path-transform-mutated-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: Ibf032f065eefdbc6300255aa7a6a0e58066acd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143420Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e2c5bcf86884..854ac61e90a4 git log e2c5bcf86884..854ac61e90a4 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 zmo@chromium.org Roll Dawn 11652ff8f8b3..6574f92747a2. Created with: gclient setdep -r src/third_party/skia@854ac61e90a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064305 Tbr: csmartdalton@google.com Change-Id: I7d729e9868ae9d1d54a1bd7120ec7fe8ac83deb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144988Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates clip-path-columns-svg-clippath-usou[-expected].html tests from css3/masking to external/wpt/css/css-masking/clip-path with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to clip-path-columns-shape-002[-ref].html because this test was added by the same bug which added clip-path-columns-shape-001.html. Bug: 1063749 Change-Id: Ia2e300f39879db657e8d3246ae2e507f2518c3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143872Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates drop-shadow-clipped[-expected].html tests from paint/filters to external/wpt/css/filter-effects with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to drop-shadow-clipped-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: I503b5833769e7563bae92e2777dc9e2280a76ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141496Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#758093}
-
Xida Chen authored
In this test, there are quite a few functions that returns certain member of a tracker_. This CL changes these functions to take the tracker_ as a function parameter because we are seeing some tests that is getting the members of some other trackers. There is no behavior change. Bug: None Change-Id: I7662ae052766bebd2961d034511e66bc1c7ba41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137824 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#758092}
-
Sammie Quon authored
The stack points right at that line so it was pretty straightforward. I tried reproing locally and writing a regression test but it was a strange timing I couldn't get to work. The best I discovered was a semi-repro steps which showed |overview_item_| was indeed a nullptr. Test: manual Bug: 1069533 Change-Id: Ia525a029e5afbdf863880cd888135c9f105d503c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144677Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#758091}
-
Alexander Cooper authored
This reverts commit 6bd4213d. Reason for revert:crbug.com/1068989 NOTE: While a local rebase was needed, it auto-resolved all conflicts. Original change's description: > Move VRService and dependencies to content > > Moves chrome/browser/vr/service and corresponding dependent metrics code > into content. Also moves not-yet published statics into content/public. > > As a result of the move a few changes had to be made: > * VRService needed to switch to PermissionControllerImpl > * Swapped two "NULL"s to "nullptr" > * Renamed usages of XRRuntimeManagerStatics to XRRuntimeManager > * Deleted WebVRServiceProvider and directly hooked up VRServiceImpl in > browser_interface_binders > * Switched ChromeXrIntegrationClient::GetInstance usages to use > ContentBrowserClient->GetXrIntegrationClient (and removed > ChromeXrIntegrationClient::GetInstance) > * Created GetXrDeviceServiceForTesting to manage dependencies for tests > * ukm::GetSourceIdForWebContentsDocument replaced with > WebContents::GetLastCommittedSourceId > * XrRuntiemManagerUnitTest needed some singlethreaded task environments > added due to changes in tests (requirements from using mojom) > > It seems like linking //device/vr into a source_set causes one of the > static initializers from gvr_shim to get counted now (perhaps being > optimized out when in a static library?) > > Bug: 1031622 > Change-Id: Id856e6cb68471a9960f54c663ece417461067541 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125016 > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756439} TBR=avi@chromium.org,dcheng@chromium.org,rockot@google.com,agrieve@chromium.org,klausw@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031622 Change-Id: I53417c92341f7fe32cb0ad5f7e845a477006db77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144834 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#758090}
-
Trent Begin authored
Errors from cros_healthd can be reported back to the DeviceStatusCollector. Update telemetry handling code to check for and log any errors. Bug: chromium:1041153 Change-Id: I264011d1d36bf3f2ec44c81e23256f1125156a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140717 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#758089}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ia0b022f289860602db81cb3e0c5c619adeddf210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143421Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#758088}
-
Reilly Grant authored
These tests are flaking on macOS and Linux. Bug: 1068579 Change-Id: Ic4f541261efa0962fcebcabccff7c23fc7ffa12a Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144426Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758087}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 841beecf. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" c53a40f4 "Update size.attributes.parse.trailingjunk" 162244b5 "[css-filters] Move multiple-references-id-mutate-crash-2.html to WPT" f33018d0 "Handle k-rate AudioParam inputs for OscillatorNode" 6ddc6aba "Fix flakiness in FCP-only tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7da21102250a6ce11be051aaeec3c8903e3523c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144514Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758086}
-
Peter Wen authored
This version of lint is up-to-date with Android Studio and the lint team intends to keep it that way. We no longer need a separate tools-lint directory for an up-to-date version of lint. Bug: 1069186 Change-Id: I8846406c4787d36863718489c3c54c4b1438d79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144367 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#758085}
-
Reilly Grant authored
This change disables the following tests which have been observed to be flaky: * ActionsMatchedCountAsBadgeText * BlockAndRedirect * BlockRequests_Incognito * BlockRequests_MultipleExtensions * MultipleRulesets * RendererCacheCleared Bug: 1069665 Change-Id: Ic37473d4c318f24820721bd623eac8804ee1b987 Tbr: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144410Reviewed-by:
-
Becca Hughes authored
Right now we have a lot of strings in the schema_org generated code and this adds overhead and can be a bit slower. This adds a "schema_org_name_generator" build task that generates unsigned int hashes for all names in the schema. Unfortunately this is separate because the hash function is not available in Python. Change-Id: I567a48b388d1e9f5e20e6f5e153402e736c4d0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144773 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#758083}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I44232fadd22401237f6d6d351ed9ebc672c2168a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140602 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e9a5bd129758..90ff937ff645 git log e9a5bd129758..90ff937ff645 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 chonggu@google.com [Telemetry] Add support to get Fuchsia system log file when tests fail. 2020-04-09 dproy@chromium.org [telemetry] Update docs about how to do measurements today Created with: gclient setdep -r src/third_party/catapult@90ff937ff645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064398,chromium:1069256 Tbr: oysteine@google.com Change-Id: I0e5528eba855026eb0e4f1f2ddda10f9c2824b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144986Reviewed-by:
-
- 09 Apr, 2020 1 commit
-
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/masking/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I1870b644bf10b10947e897027aeb5765aac388a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143821Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
-
