- 05 Nov, 2020 6 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f12d05d125a8..57154998a866 2020-11-04 tdenniston@google.com [svg] Add plumbing for bottom-up attribute parsing 2020-11-04 bungeman@google.com Implement font family names on iOS. 2020-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 068bb086e1c8 to 6372a56f3a15 (53 revisions) 2020-11-04 johnstiles@google.com Poison the GrMemoryPool's sentinel field when ASAN is enabled. 2020-11-04 herb@google.com constexpr SkCLZ and functions that use it 2020-11-04 adlai@google.com Revert "Reland "Notify RTC when OpsTask is closed so it can drop ownership"" 2020-11-04 brianosman@google.com Move GrShaderCaps from Program::Settings to Compiler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Test: Test: Test: dEQP-GLES31.functional.shaders.opaque_type_indexing.atomic_counter.*vertex Change-Id: Ie6e22c6566091c77a6c2bd8d5ad26ec1478dd680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824224}
-
Erik Chen authored
This CL has no intended behavior change. Static Lacros configuration should be performed in Lacros rather than Ash. This is because configuration can cause Lacros P0 blockers, but we don't want to delay Ash releases for Lacros P0 blockers. The result is that Lacros can be DOA or have functionality regressions. Change-Id: Id3df0b8c49059ac1353e8e57044cbf5538f2b710 Bug: 1145713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518422Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824223}
-
Lukasz Anforowicz authored
This CL tries to track down the flakiness of the following tests: - SavePageOriginalVsSavedComparisonTest.ObjectElementsViaHttp - SavePageOriginalVsSavedComparisonTest.CrossSiteObject where the test will sometimes/flakily see that all the expected frames are present, but find-in-page will fail to find text that is expected to be found in one of the subframes. After this CL, we should be able to verify if the problematic subframe has finished loading - if it executed `window.name = ...` or not. Bug: 1070597, 1070886 Change-Id: I7d499cbb228663b63030fac7dab37140b7c9be7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510913Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#824222}
-
Eric Orth authored
Forgot to update it to not try to cast to service type without checking for malformed. Fixed: 1145485,1145466 Bug: 1138620 Change-Id: Ifee9b59a4678ffe607dc9cc21cdd456e3675a53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520138 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#824221}
-
Joel Hockey authored
Refactor some duplicated code in a number of unit tests into a shared test helper. Bug: 1144138 Change-Id: I03b2b5eeb75b636014b60a683501d6f2498bf405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517403 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#824220}
-
Xiaodan Zhu authored
This CL enable the feature of reverse scrolling gestures. - Enable reverse scrolling gesture feature. - Get rid of the notification for overview gestures. - Add toast for the gestures entering overview when the natural scrolling is OFF. Bug: 1107183 Change-Id: Ibbabca1b5deb5b37c8b697ff732f5312519e3adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510350Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824219}
-
- 04 Nov, 2020 34 commits
-
-
Darwin Huang authored
This thread hop isn't necessary, because raw data doesn't require decoding. Bug: 897289 Change-Id: Id3c75b2a0dcde2b6950d3a1a3085db6e73ffd273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406695Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824218}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d75314bf680f..84e62ab4804c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115463,chromium:1119406,chromium:1145376 Tbr: xhwang@google.com Change-Id: I016f006e0becf526e8746e20cfdde39bc7c3fe5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520004Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824217}
-
Dirk Pranke authored
As a prelude to starting to move the build fully over to Python 3, this CL changes all of the GN `action` and `action_foreach` targets that appear to require Python 2 over to `python2_action` and `python2_action_foreach`. This CL by itself should produce no functional change since we'll still be using Python 2 by default, and the new templates are passthroughs in that config. To start using Python3, you can run `gn gen --script-executable=python3 //out/Default` on Unix; on Python3 you need to point to an actual python3.exe and not the python3.bat wrapper in depot_tools; once we can roll GN forward to a version that contains https://gn-review.googlesource.com/c/gn/+/10560 (which will hopefully happen in the next day or two), that won't be necessary. The Fuchsia build will not work until http://fxrev.dev/446479 lands and is rolled in. No-Presubmit: true Bug: 1112471 AX-Relnotes: n/a Change-Id: I891155502e0940a8075cf26d675f54b803d91242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510878Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#824216}
-
Victor Costan authored
This CL replaces the test's base::test::TaskEnvironment with a content::BrowserTaskEnvironment. The QuotaClient mojofication benefits from having this test use a content::BrowserTaskEnvironment, which can supply a TaskRunner for the IO thread. Bug: 1016065 Change-Id: Ia5cbe1a1ecafc6fd0d37972c28a44dfb5bc2d0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519884 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#824215}
-
Nico Weber authored
...and re-enable building arm64 isolator runtimes on regular tot bots. The theory is that this didn't work because system Xcode on these four bots was too old, so make it less old and try again. Bug: 1145151 Change-Id: Ic996a91bba98e53934af8db90fdc912b8dae147b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519206 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824214}
-
Michael Thiessen authored
Part 3 of a 3-sided change to move CriteriaNotSatisfiedException to base/ No changes from review on https://chromium-review.googlesource.com/c/chromium/src/+/2515520 This was originally reverted due to the clank roll this change depends on failing. TBR=yfriedman@chromium.org Bug: 1134178 Change-Id: Ieebd237859cbf1d818ef502b68dd4c14c1b4f210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518698Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#824213}
-
Tommy Li authored
We're removing the invariant that two non-extension search engines cannot share the same keyword. This invariant was untenable because of Sync, Play API, and Policy. It was also kind of a weak invariant because extensions have always been able to create duplicate keywords. The invariant was costly, because it was a big source of duplicate search engines caused by appending underscores to uniquify keywords. And the invariant was not needed, because AddToMaps() already handles duplicate keywords by choosing the best engine, since extensions have always been able to introduce duplicate keywords. This CL changes the Update() method to no longer attempt to keep non-extension engine keywords unique, for a couple of reasons: 1. Simplify the code. 2. The conflict avoidance logic only worked as long as we keep the invariant true, and we're removing the invariant. Concretely, we plan on having Add() no longer uniquify keywords, and this logic crashes in that world. See: https://chromium-review.googlesource.com/c/chromium/src/+/2515679 3. Having Update() sometimes silently fail to update the keyword actually seems a bit strange to me, and is potentially a source of Sync conflicts, since two clients could disagree on whether they update the keyword or not. Bug: 1022775 Change-Id: I97d2379414dbe7e7ea9e12148428cc3c17d0bba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519775 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#824212}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I372d3e7920d461329870b3f97935c25d5d87a4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520000Reviewed-by:
-
Alex Gough authored
This is a reland of afc72427 Same as before but now avoids a hidden memset from auto-var-init that broke during early loading on component builds. We immediately populate the memory so this is safe. Original change's description: > Reland "Only pass executable sections to OnDllLoaded for patching" > > This is a reland of df9e203b > > Original change's description: > > Only pass executable sections to OnDllLoaded for patching > > > > On recent Windows insider builds GetModuleHandleExW loads sections for > > inspection as non-executable images, rather than as files. This leads > > to our hooks detecting the SEC_IMAGE attribute and potentially patching > > functions (e.g. for user32.dll). > > > > This caused content_browsertests to fail as it pinned user32.dll in some > > processes. With this change, the tests run again. > > > > See crbug.com/1143397 for a full discussion. > > > > Bug: 1143397 > > Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531 > > Reviewed-by: Will Harris <wfh@chromium.org> > > Commit-Queue: Alex Gough <ajgo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823354} > > Bug: 1143397 > Change-Id: Ibacc1ba6105665c32ea445a7f63178163585efbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515783 > Auto-Submit: Alex Gough <ajgo@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823679} Bug: 1143397,1145558 Change-Id: I06e3f945dc4829a9d8787d787111639e8d655624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519835Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#824210}
-
Kenichi Ishibashi authored
ServiceWorkerDiskCache was forked from AppCacheDiskCache. It should have tests similar to AppCacheDiskCacheTest. This CL ports three non-disabled tests. Bug: 1117369 Change-Id: Ibb30a043d21bec7f7d003ea0768504e944248721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505702 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824209}
-
Alex Moshchuk authored
It's not clear what the cause of flakiness was in this test, as the available logs are stale. The test currently fails on a WaitForLoadStop() in one of the test's custom navigation helpers, when used on an initial navigation. These helpers seem unnecessary, and the first navigation simulates something that can't normally happen (renderer-initiated OpenURL() request from an initial blank tab). Rewrite the test to use existing navigation helpers, and re-enable the test to see if it's healed itself and to gather more data if it hasn't. Bug: 1014175 Change-Id: I6f48a2ff25d7fff23002611fe3e4f67c82d09cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518494Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#824208}
-
Wei Li authored
ToggleImageButton should exhibit similar behaviors as ImageButton: focusable by default depending on the platform. Bug: 1001103 Change-Id: I16f5fcf698b224864eac46e4c22ab57df7cb9641 Fixed: 1144611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513177Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#824207}
-
Sajjad Mirza authored
Bug: 1090653 Change-Id: If66e60bf98a908b5e214971b3892f555f74974c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519058 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#824206}
-
Becca Hughes authored
This is a reland of a656f852 The fix is to remove the include for media_session_service.mojom that has been deleted. Original change's description: > Reland "[Media Session] Convert interface from mojo to CPP" > > This is a reland of 530c8fd2 > > The fix is to remove the include for media_session_service.mojom > that has been deleted. > > Original change's description: > > [Media Session] Convert interface from mojo to CPP > > > > Context: https://crrev.com/c/2485850 > > > > This converts the MSS interface to CPP since it does > > not need to be mojo. > > > > BUG=1140215 > > > > Change-Id: I595bef21cddf755bc0fb423f87db9e620227d3e6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503393 > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823358} > > Bug: 1140215 > Change-Id: I23a4043529e236174f44377402a8e1fbc5a23600 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518085 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823718} Bug: 1140215 Change-Id: I4e514807faef4a1fa4374c07661fdd8eb59f2d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519716 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824205}
-
Yicheng Li authored
Fetch the name of the website/app that we are authenticating for from dbus method call and show it in the dialog. This improves security and is also the same behavior for WebAuthn on other platforms. Bug: b:156258540, b:144861739 Change-Id: I05f64e80f555cd7a74e8e8372e54bf3c05483bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414624 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/4735f01193b8..88dc2a4895c3 2020-11-04 bclayton@google.com wsgl parser: Unify logic for all decorations 2020-11-04 bclayton@google.com wsgl parser: Add expect_block(), use it 2020-11-04 bclayton@google.com wsgl parser: Add expect_builtin() 2020-11-04 bclayton@google.com wsgl parser: pipeline_stage() -> expect_pipeline_stage() 2020-11-04 bclayton@google.com wsgl parser: Use match() for more trivial patterns 2020-11-04 dsinclair@chromium.org [wgsl-reader][wgsl-writer] Support new sampled texture syntax. 2020-11-04 bclayton@google.com wsgl parser: Add optional Source* out params 2020-11-04 bclayton@google.com wsgl parser: Use expect_ident() 2020-11-04 rharrison@chromium.org [inspector] Refactor to handle access control wrapped uniform-buffers 2020-11-04 bclayton@google.com wsgl parser: Use expect() for call r-parenthesis 2020-11-04 bclayton@google.com wsgl parser: Use expect_[nonzero_]uint() 2020-11-04 bclayton@google.com wsgl parser: Use expect() for parenthesis checks 2020-11-04 bclayton@google.com wsgl parser: Use match() for trivial patterns 2020-11-04 bclayton@google.com wsgl parser: Use expect() for semicolon checks 2020-11-04 bclayton@google.com wsgl parser: Add match() and expect() helpers 2020-11-04 bclayton@google.com Fix build 2020-11-04 bclayton@google.com wgsl parser: Replace set_error() with add_error() 2020-11-03 rharrison@chromium.org [inspector] Extract Read Only Storage Buffer data 2020-11-03 bclayton@google.com Add Source parameter to decoration constructors 2020-11-03 bclayton@google.com ast: Have all decorations derive from base class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ib02bd4c3052c10db9b591fe8227ae8db88a12630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520037Reviewed-by:
-
Emircan Uysaler authored
This CL merges acquire fences for primary plane and overlays so that the updates happen at the same time. We could see artifacts when they were out of sync, as the underlay strategy expects a perfect fit under transparent layer. This CL makes sure that the updates happen in sync. Bug: 1144320, 1127984 Change-Id: I4b6bc776e0f3c2c8b0d6c4811245cc2cbcc3b9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514465Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824202}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I49569382a033fc8cc4f3e37a1b7a5d46c22ca501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518802Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824201}
-
Leonard Grey authored
Bug: 1014639 Change-Id: I6f06f2fb7cce2588130c2e2e7be323c778a683cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518748Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824200}
-
Erik Språng authored
Bug: chromium:934391 Change-Id: I63c35a4954e3405217db5fd7820fb187242a8bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518863 Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#824199}
-
Roberto Carrillo authored
TBR=nodir,bsheedy,vadimsh,gbeaty Bug: 1145735 Change-Id: Id7921fbacb0fedfd3500fd86953173fa63eb80b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518699Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#824198}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/419b7d7bd164..ad54c71632cc 2020-11-04 capn@google.com Fix Vulkan benchmarks build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6daec4ca1bb9ed9e96a990cbb08210ef871923cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520035Reviewed-by:
-
Alexander Surkov authored
dumptest helper * tree formatters should be kept generic, because they are not scoped to testing only, and thus should implement no test logic; * event recorders implicitly relies on tree formatters test expectations code, which requires event recorders always used in conjunction to tree formatters; * there is no need to have a separate interface for test expectations, since there's only small amount of callers which all depend on dumptest helper, and thus all logic can be implemented inside dumptest helper; * simpler code, less error prone Bug: 1133330 Change-Id: I21de46bb01a2c9b3dce42aa1229a568e6bf94e0a AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502729Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#824196}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/6MHYJ8TDtszEqfw Bug: 889763 Change-Id: I7cca271a77160b2746809ee8d295e258452989f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517223 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* && autoninja Change-Id: I3c3438545ebd4209da697aa36fe6cf8ede6448a6 webui: closure_compile Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511255 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#824194}
-
Lily Chen authored
Change-Id: I7780c3040d2ac3e4d67c394fe34abeadc1e9612b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518918Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#824193}
-
Emircan Uysaler authored
This CL fixes the error from the previous CL where we always registered videos with an image pipe. Bug: 1127984 Change-Id: I54a90068a96145c354a6ec2f874e415b8824e422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518136Reviewed-by:
-
Ken Rockot authored
The js_type_check for some WebUI test mojom was inadvertently broken to no longer perform most of the useful type checks. This fixes that. Bug: 1004256 Change-Id: Ic8e9d4bdc098daa84c591a72f9c82e53b9e7d87f Tbr: dpapad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517486Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#824191}
-
Sergey Ulanov authored
VideoCaptureDeviceFactoryAndroid was enumerating list of supported formats for each device every time when enumerating devices. This was problematic on some devices where opening a camera breaks existing stream for that camera. This CL adds cache of supported formats in VideoCaptureDeviceFactoryAndroid. This allows to workaround the bug by enumerating formats only once for each device. Also updated VideoCaptureFactory.java to make it possible to get unique device IDs, not just indices. Bug: 1138608 Change-Id: Ib397b6cbe1f3e343fbb1e2187e91859576b6acc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494030 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824190}
-
Roberto Carrillo authored
TBR=nodir,bsheedy,vadimsh,gbeaty Bug: 1145735 Change-Id: Ia6793aa3c3198ab0b425ec9048c15490f353c32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519879Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#824189}
-
Chan Li authored
https://chromium-review.googlesource.com/c/infra/infra/+/2516252 added a new adapter for such test suites, so resultsink should be able to support them. The test suites are: - content_shell_crash_test - flatbuffers_unittests - resource_sizes_cronet_sample_apk Bug: 1137507 Change-Id: Ib194a54ae7e171ce7efe02080f9fb9a6a5eeb551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519036Reviewed-by:
-
Karan Bhatia authored
This reverts commit 89891098. Reason for revert: The original test failures were caused due to crbug.com/gn/215 which caused spurious failures in incremental rebuilds. The corresponding GN roll has now been reverted. Original change's description: > Revert "JsonSchemaCompiler: Raise error on parse failures of optional properties." > > This reverts commit eec7bff8. > > Reason for revert: > After this change, JsonSchemaCompilerErrorTest.* are failing on > several linux bots: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95122 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/92709 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21165 > > Original change's description: > > JsonSchemaCompiler: Raise error on parse failures of optional properties. > > > > Currently when an optional property fails to parse and error generation > > is enabled for the schema, the auto-generated Populate function > > continues parsing the type but still populates error. This CL changes > > the code to ensure that we raise an error in these cases. > > > > We also don't raise an error on unrecognized keys any longer since we > > shouldn't be raising an error while returning a parse success: Most > > consumers currently don't distinguish between the two cases and this can > > lead to the returned error being a concatenation of unrelated errors, > > which is not ideal. > > > > We now enforce the constraint that Populate only returns an error iff > > there is a parse failure. We DCHECK the same in the auto-generated > > FromValue function. > > > > This also brings the code more in-line with what we do for > > auto-generated manifest parsing. > > > > Currently only 3 schemas use error generation: > > - declarative_net_request.idl > > - extensions_manifest_types.json > > - manifest_types.json > > > > The latter two may be affected by the change. In particular, parsing > > manifest types declared by them may lead to a hard error when an > > optional property can't be parsed now. > > > > BUG=1113513 > > > > Change-Id: I63966389e25f7591b4425815d32d9da59d35c3fb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500425 > > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823545} > > TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org > > Change-Id: I3b26905381996192b377f79abcde757efaf08f31 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1113513 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519330 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823902} TBR=rdevlin.cronin@chromium.org,nhiroki@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1113513 Change-Id: I57d4725126af7c019518cd2bff000403a8b749b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519173Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824187}
-
Rouslan Solomakhin authored
Before this patch, payment credential storage and retrieval did not cancel database operations when secure payment confirmation was being torn down, so the database operation callbacks could use secure payment confirmation code path after free. This patch cancels the payment credential storage and retrieval operations during the tear down. After this patch, there is no use-after-free errors when a database operation is in flight during secure payment confirmation tear down. Bug: 1136078 Change-Id: I2a02089f4ab5c3c8ae5ebed91304b11e1c1eaf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518924Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824186}
-
Erik Chen authored
This CL does not currently change any configuration. Lacros is still disabled by default on stable channel. Bug: 1144323 Change-Id: I99354aa334931c8688d3eb46ef9e6bca1431efb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518753 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
