GitLab

Not all GoogleServiceAuthErrors are possible on iOS.
See //ios/chrome/browser/sync/sync_setup_service.cc for comparison.

Bug: 867548
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3eab6314ddb10e9d3f68b018494846b1257226aa
Reviewed-on: https://chromium-review.googlesource.com/1252378Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595538}

This filed is unused and should not be used by embedder.
NavigationManager provides enough methods to get last committed, pending
or visible URLs.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I44bece041b41a784512cb9a738dcd346ba71ddbd
Reviewed-on: https://chromium-review.googlesource.com/1251982Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595537}

BUG=890467

Change-Id: Ie0e7fc413c068a83c9e225c63bc3e3abdebf3120
Reviewed-on: https://chromium-review.googlesource.com/1252636
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595536}

This fixes an issue, where we didn't copy across any shape exclusion
data when inserting a new shelf between two other shelves.

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib26359ab8ac677034ec4e51f2adf1987dadbd91c
Reviewed-on: https://chromium-review.googlesource.com/1255145Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595535}

The bug they were meant to help track down is now fixed, so no
reason to keep them around.

(Previously added in https://chromium-review.googlesource.com/c/chromium/src/+/1224670)

Bug: 882246
Change-Id: I4ada70dd810e07f6fc7ecaaf873fa99d4cf6263b
Reviewed-on: https://chromium-review.googlesource.com/1254464Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595534}

TBR=haraken@chromium.org

Bug: 885297
Change-Id: Ic7a6df89b771062e3327736fec64aff3d124286f
Reviewed-on: https://chromium-review.googlesource.com/1254322Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595533}

We don't want to require the feature to be on when *forcing*
dark mode.

Bug: 850098

Change-Id: Ie6a7f8e7a34e1436136664cf08db2015e69a790e
Reviewed-on: https://chromium-review.googlesource.com/1254862Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595532}

Currently extensions can intercept browser initiated requests using the web
request API which potentially allows them to interfere with browser
functionality in various ways. This CL makes the following changes:
  - All browser initiated non-navigation requests are now hidden from
    extensions.
  - All webui requests are now hidden from extensions. (WebUI shouldn't be
    making network requests anyway).
  - Restructure code in WebRequestPermissions::HideRequest for better
    efficiency.

BUG=884932

Change-Id: I90f37a46e851c04fa949a1427665ecf8286210af
Reviewed-on: https://chromium-review.googlesource.com/1242296
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595531}

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=rohitrao@chromium.org

Bug: 874080
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id297ebc108dc8f8915402602ae12a63e5a3131d0
Reviewed-on: https://chromium-review.googlesource.com/1191186
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595530}

The lifecycle API is the interaction point for Chrome-side application
lifecycle events that the Feed Library cares about for the purposes
of maintaining its internal state.

Dummy files have been added so that compilation succeeds when the
Feed is disabled via buildflag.
This CL also adds a presubmit whitelist for all android/feed/dummy files.

(Google-internal design doc:
http://doc/1NyFLrqEAOoZe7MU2qy7bHYB6Rlp7c6lz22Zqzh-Cbo4)

Bug: 866950
Change-Id: Ie118c991aabb906e88344b5c96ab3b09e77c620f
Reviewed-on: https://chromium-review.googlesource.com/1231992
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595529}

SetupForInOutAnimation (in IconLabelBubbleView) sets
'EnableFlippingFoRTLUI' to true in all cases. Since only
ContentSettingImageView needs it set to true, removed it from the
method and it is now set separately in that subclass

Bug: 881798
Change-Id: I2d570cc84d9d4f9443b39ffa51d943d938624dbe
Reviewed-on: https://chromium-review.googlesource.com/1250055Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595528}

isHTML(), isScript(), isScriptURL() and isURL() added to
TrustedTypePolicyFactory class as part of Trusted Types API update to
current JS polyfill.
The methods require additional code to be fully matched to polyfill
expected behaviour.

Added a helper private method GetWrapperTypeInfoFromScriptValue.

Bug: 739170
Change-Id: I027e43ab6432405c686255a4d0ce24248c59a4dc
Reviewed-on: https://chromium-review.googlesource.com/1238433
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595527}

Mash implementation is a TODO.

Test: put in tablet mode, go to [1], press Lock in Current Orienation

[1] https://whatwebcando.today/screen-orientation.html

Bug: 889981
Change-Id: I19192a92ba927eba76c63089fa57c1288b34ff1c
Reviewed-on: https://chromium-review.googlesource.com/1252525
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595526}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Icc149b76bb5dc5abe436eac8e10ae9935f66fa69
Reviewed-on: https://chromium-review.googlesource.com/1251528Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595525}

Bug: 832676
Change-Id: I3088c0fa54d5b549f27dd158bbe46ec7834360a8
Reviewed-on: https://chromium-review.googlesource.com/1255207
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595524}

This CL does the following:

1. Use VpxVideoDecoder in utility process to do software decoding for
vp8, vp9 video files.

2. Simplify the class to render media::VideoFrame into bitmap, since
PaintCanvasVideoRenderer works for all kind of VideoFrames.

3. Do not retrieve poster image from metadata. The mime type of the
poster image is inferred from mime sniffer, and needs to be
processed in sandbox process.


Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I91c9cf72a75be4bc3a95203a40633647e079a40a
Reviewed-on: https://chromium-review.googlesource.com/1234859
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595523}

The function is somewhat slow; just get it from the constraint space
where we have one.

R=eae@chromium.org,mstensho@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I08e8ba0a5d15d90f9a3ae4545302e0af618e73f4
Reviewed-on: https://chromium-review.googlesource.com/1254141
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595522}

There exist two interface through which a views::View is stitched to
a content::WebContentsView
- the ui::Layer is attached via a cr_setParentUiLayer method
- accessibility is attached via the accesibilityHostable protocol

Lifetimes of the embedding are slightly unclear because the attached
WebContentsView may be destroyed the NativeViewHost detaches it.

Replace the AccessibilityHostable protocol with a ViewsHostable
protocol, and add a C++ interface, ui::ViewsHostableView, which provides
a single place through which a views::View and a content::WebContentsView
are stitched together
- have content::WebContentsViewMac implement ui::ViewsHostableView
- have views::NativeWidgetHost implement ui::ViewsHostableView::Host

Use this explicit interface to ensure that the views::NativeWidgetHost
detaches from the content::WebContentsViewMac before it is destroyed.

Additional parameters and method will be added to the
ui::ViewsHostableView interface to enable stitching together
out-of-process NSViews.

R=lgrey
TBR=avi (content/ OWNERship)

Bug: 821561
Change-Id: Iddc46278cd06b9e27d3f12aa5a9e830273f3b562
Reviewed-on: https://chromium-review.googlesource.com/1252641
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595521}

Only DetachTimeFg16x is added because it is the most
different variation from control, while other variations
test values in between.


Bug: 847501
Change-Id: I12da837873f86345e36cfb9577a7a803015baa40
Reviewed-on: https://chromium-review.googlesource.com/1249805Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595520}

There were two possible users of this logic:

1. RenderFrameImpl::LoadDataURL. This one is done during a commit time,
and it seems strange to reuse previous request for data urls, while
not reusing it for all other requests.

2. NetErrorHelper::LoadErrorPage. This one is called from
NetErrorHelper::DidFinishLoad through a chain of callbacks, so
there should not be a provisional document loader at the time of
commit and the logic is wasted.

Note that error page loads did switch to CommitDataNavigationWithRequest
recently, so are not using this logic anymore.

Bug: none
Change-Id: I3b00921c2c6441a007e8391ba3a4a8119d08c5bb
Reviewed-on: https://chromium-review.googlesource.com/1246599Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595519}

Also document GetCatalogTask and update the version checking logic to
be more accurate and clearer.

Bug: 889104
Change-Id: I2467dd767c7a19e5454d4b31412061ea884b2b7e
Reviewed-on: https://chromium-review.googlesource.com/1254741Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595518}

Bug: 878390
Change-Id: I163448cb47ebd21e0c078a6b372466d163336186
Reviewed-on: https://chromium-review.googlesource.com/1228113Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595517}

We are not ready for flatten in frames - the TargetRegistry is null.

Bug: 890760
Change-Id: I8bbffad4f74ffa12f371ce7feef32cae3d6f6304
Reviewed-on: https://chromium-review.googlesource.com/1255122Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595516}

Adding myself there to be able to track things easier.

Change-Id: Ia1228e69de4da77630208d12016754086f28b1be
Reviewed-on: https://chromium-review.googlesource.com/1253622Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595515}

This patch fixes a few issues found while trying to hook up image
decoding end-to-end:
* The images are improperly inserted into the database, since binding as
  string uses the text type, which tries to use UTF8 encoding (which
  doesn't work for binary blobs.)
* Decode failures used to cause a DCHECK, now just bail out with an
  error value
* A callback was called one too many times, even after std::move.
* A crash would happen if a category had no images.

Bug: 867488
Change-Id: Ie28c01e28bd746b9a90563c228775ff3b5a8f83f
Reviewed-on: https://chromium-review.googlesource.com/1248041Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595514}

This CL adds logic to automatically grant notification permissions for
Android Messages for Web immeadiately after the PWA installation.

Bug: 875511
Change-Id: I3ff64ad1439ecaf1ea57e11609a8bcf2cf4b34bf
Reviewed-on: https://chromium-review.googlesource.com/1252903Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595513}

This adds HostFrameSinkManager::FindRootFrameSinkId() to find the root
frame sink id. This is necessary as
window->GetHost()->compositor()->frame_sink_id() is not the root frame sink in
mash.

BUG=879791
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5a1520b2ba144cb231d254059810ff153add3a49
Reviewed-on: https://chromium-review.googlesource.com/1249152
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595512}

Part of ongoing effort to eliminate duplicate code
introduced when automation API was added to Chromecast.

Making Chromecast's copy of AXTreeSourceAura derive from
AXTreeSourceViews.  The two now nearly identical copies of
ax_tree_source_aura.cc will be merged and moved up to
ui/views in a subsequent CL.

Bug: 837773
Test: Manual verification on chromecast and chromeos (tidus)
Change-Id: I1b083280ce280ec0bd25324778f5d84ec3a7e9cf
Reviewed-on: https://chromium-review.googlesource.com/1249682
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595511}

https://android.googlesource.com/platform/external/perfetto.git/+log/5cfa93810a40..7f61afaa6ec3


git log 5cfa93810a40..7f61afaa6ec3 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 fmayer@google.com Disable ubsan on Travis.


Created with:
  gclient setdep -r src/third_party/perfetto@7f61afaa6ec3

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I2db8442bb7cf4d197282e11e5a5e7e1562b2d255
Reviewed-on: https://chromium-review.googlesource.com/1254842Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595510}

Bug: 872688
Change-Id: Ia54b127e61d0eb16d673e2b2ae13c4e3aa220b96
Reviewed-on: https://chromium-review.googlesource.com/1208360Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595509}

When the test was added in https://codereview.chromium.org/26678004/
it only passed on macOS. Since macviews it no longer passes anywhere,
so just delete it.

Bug: 832676
Change-Id: Ie5b3f476f96d7f750612f58ac0c4f9016166ab11
Reviewed-on: https://chromium-review.googlesource.com/1255205Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595508}

This does the same edit to SVGImageElement::InsertedInto as
https://chromium-review.googlesource.com/1141121 did to HTMLImageElement.

Bug: 864306
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I74696c16c27eba363e4965d996f3ae688ef27c91
Reviewed-on: https://chromium-review.googlesource.com/1254265Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#595507}

BUG=737995,881371
R=pkasting

Change-Id: I4dc5b47f91c4330497bd26f3ae7ff4affe7ff193
Reviewed-on: https://chromium-review.googlesource.com/1250166
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595506}

This test switches a <frameset> to a <body>. For framesets, LayoutView::CalculateScrollbarModes
forces the user scrollable bit to be false. It excluded layout object is not LayoutFrameset
but it is of type of Frameset.

In this patch, we changed the Frameset check to body->GetLayoutObject()->IsFrameSet().

Bug: 875287
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icefcc3801dc79b39576f1248a07e43f905279e13
Reviewed-on: https://chromium-review.googlesource.com/1254470Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595505}

Bug: 807714
Change-Id: Ib6a6b2fce7ddb494741364976c73569ce87756f8
Reviewed-on: https://chromium-review.googlesource.com/1228881
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595504}

UMA logging added here:
https://chromium-review.googlesource.com/1232615

Bug: 877671
Change-Id: Icf550ec0dd047462fcf385a7fbf830099c487407
Reviewed-on: https://chromium-review.googlesource.com/1238470
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595503}

Bug: chromedriver:2543
Change-Id: I929e5a37607b596d169534dff87c2e5cbb817538
Reviewed-on: https://chromium-review.googlesource.com/1252983Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595502}

This adds a bit of padding after the checkboxes and makes entire
rows clickable.

Bug: 887678
Change-Id: I89d6d7f1901170d6178b3b5e0fce228b3d584d00
Reviewed-on: https://chromium-review.googlesource.com/1252524Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595501}

This CL replaces Chrome-specific tinting view classes with their
AppCompat equivalents: TintedImageView -> AppCompatImageView and
TintedImageButton -> AppCompatImageButton.
1. Entries in XML layouts have fully qualified names because some
   layouts are inflated outside AppCompatActivity, so AppCompat magic
   doesn't work for them.
2. AppCompatImageView doesn't have setTint, so
   ImageViewCompat.setImageTintList is used instead.
3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint',
   so these are replaced, too.

Bug: 727723
Change-Id: Id1614af64fa6ddd7cfdc6e12ad565ed32628d3c1
Reviewed-on: https://chromium-review.googlesource.com/1245786
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595500}

Charlie points out a bug at https://crbug.com/863471#c2: |name_|
and |value_| should be cleared if |other| is of LOOKUP type
but |*this| is not.  This does not cause any leaks or undefined
behavior, but is potentially a waste of memory.

As much as I would love to remove spdy::HpackEntry::operator=()
altogether, this causes the compile to fail on Windows.  Somehow
assignment operator is needed to put HpackEntry in a std::dequeue.
See win_chromium_compile_dbg_ng trybot failures on Patch Set 2.

This CL lands server changes 212433946 and 215208407 by bnc.

BUG=488484

Change-Id: Ia64c9a50232297f333f587c0d68de650d93f77db
Reviewed-on: https://chromium-review.googlesource.com/1252085
Commit-Queue: Bence Béky <bnc@chromium.org>
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595499}