- 16 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf0cc7170286..157451f9900a git log bf0cc7170286..157451f9900a --date=short --first-parent --format='%ad %ae %s' 2020-04-16 sigurds@chromium.org [issues] Make types more precise Created with: gclient setdep -r src/third_party/devtools-frontend/src@157451f9900a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I346e72163dc23813fd45be0be730525d5d66ef4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759568}
-
Mike Dougherty authored
Returning a PolicyDecision which was created with CancelAndDisplayError from ShouldAllowRequest will cancel the request and display the error to the user. This can be used to display to the user why a request was cancelled. Bug: 1065161 Change-Id: I4418cb099aa7fab01a3bca6fa08d3c5e67fce986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140958 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759567}
-
tby authored
Link the OS settings search provider with the settings SearchHandler, by querying it for results on each search. These results: - Set their metadata from the returned SearchResultPtr. - Launch the settings app via chrome::SettingsWindowManager::ShowOSSettings. Bug: 1068851 Change-Id: I2f7236fcec3401c14f54934dee03302c3fbf7ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147132Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#759566}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6364c48eb481a4d8d289e7506b70d019bda1b90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152345Reviewed-by:
-
Alice Wang authored
This CL fixes the flaky test testDialogIsDismissedWhenRecreated by replacing the original Activity.recreate() with a blocking call to ensure the execution is blocked till the activity is resumed. Bug: 1054855 Change-Id: I841cbc6668dc0d8df3ccbc9c9005023baebdc07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144026Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759564}
-
Anders Hartvoll Ruud authored
I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/tOHolEkBeY8/jX0jvQqkBAAJ Bug: 579788 Change-Id: I7282552f4b8339adc63ffc262cfb59cda2c3f7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146908Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#759563}
-
Guido Urdaneta authored
This reverts commit b79724f8. Reason for revert: Causing flaky failures in Mac10.14 Tests bot. First failure here: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3374 telemetry_perf_unittests on (none) GPU on Mac failed because of: measurements.rasterize_and_record_micro_unittest.RasterizeAndRecordMicroUnitTest.testRasterizeAndRecordMicro Original change's description: > Collect reasons of disallowing LCD text > > (TBR for passive change in tools/perf/measurements/rasterize_and_record_micro.py.) > TBR=wangxianzhu@chromium.org > R=pdr@chromium.org > > Bug: 642885 > Change-Id: Ia5c8313ea9e34139e06ff11fcc5d751ff0768c75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149914 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759474} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ic25a88c23e6f504461d3100fbf3bc8f8429c81f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 642885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151450Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759562}
-
Miyoung Shin authored
CL migrates grid-baseline-margins-2.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-003.html. BUG=1063749, 767015 Change-Id: I24861becfc1be0554f02e3a3491398a07b0f039d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145747 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759561}
-
Miyoung Shin authored
CL migrates grid-baseline-margins-1.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-002.html. BUG=1063749, 767015 Change-Id: I704b393b1c257c9a79b70903014f13fc5cf54039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143188 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Miyoung Shin authored
CL migrates grid-baseline.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-001.html. BUG=1063749, 767015 Change-Id: Ia642e5876f5a936f11fc268adf93dd9ddf9479c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147988 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Add checks for the completion. Call completion when |fileURL| is nil. Completion is always called on the main thread. Bug: 1045457 Change-Id: I74be7d0cf110efe30be6ced0ce4172395d966193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148324 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#759558}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf321a18..a887423b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2303169cf49925203f887fb591ce5766af98707c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151967Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759557}
-
Guido Urdaneta authored
This reverts commit ca4ccac9. Reason for revert: Suspect of causing consistent failure in Win7 Tests (1) bot. First failure: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/101716 device_unittests failed because of: All/BluetoothRemoteGattCharacteristicTestWinrt.WriteRemoteCharacteristic/1 All/BluetoothRemoteGattCharacteristicTestWinrt.ReadRemoteCharacteristic_WritePending/1 All/BluetoothRemoteGattCharacteristicTestWinrt.RemoteCharacteristic_Nested_Read_Write/1 All/BluetoothTestWinrtOnly.ConstructFakeAdapterWithoutRadio/0 ...46 more failure(s) (50 total)... [ RUN ] All/BluetoothRemoteGattCharacteristicTestWinrt.Notification_During_WriteRemoteCharacteristic/1 ../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc(1544): error: Expected equality of these values: notification_value Which is: { '\xDE' (222) } characteristic1_->GetValue() Which is: {} Original change's description: > Remove BluetoothTest::PlatformSupportsLowEnergy() > > Remove BluetoothTest::PlatformSupportsLowEnergy() since it always > returns true (all dead code hiding behind it is also removed). > Note: BluetoothLowEnergyWrapper::IsBluetoothLowEnergySupported() is left > as-is since it's still used, but no longer used > BluetoothLowEnergyWrapperFake::IsBluetoothLowEnergySupported() is > removed. > > Bug: 971817 > Change-Id: I6d2b53bf6b840d3015a736c56a58055863ba6a3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144190 > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759318} TBR=nsatragno@chromium.org,odejesush@chromium.org,bershanskiy@pm.me Change-Id: I7ce54a52b9f4f3082ad2f5e168d829c972c91980 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 971817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151566Reviewed-by:
-
Koji Ishii authored
This patch changes |NGFragmentItemsBuilder| to make an initial reservation when the inline formatting context is expected to be huge. r759327 crrev.com/c/2150327 changed to expand more aggressively than before, but still a huge inline formatting context can require several buffer reallocations. This patch computes an estimated size from the text of the inline formatting context, and make an initial reservation when it's large enough. Also contains changes for: * |NGFragmentItemsBuilder| constructor was changed to take |NGInlineNode|. The old argument |NGBoxFragmentBuilder| was removed because it was not used any longer. * |SetTextContent| was removed. Inline pre-layout is already ran at the point |NGFragmentItemsBuilder| is constructed. * Some |NGBlockLayoutAlgorithm| functions are changed so that it can keep once computed |FirstChild()| and pass to |NGBoxFragmentBuilder|. Bug: 982194 Change-Id: I62837da60d6651dad36880639880f605d5a46212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149487Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759555}
-
Guido Urdaneta authored
This reverts commit e4effcd8. Reason for revert: Suspect of causing consistent failure First failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/49293 browser_tests on (none) GPU on Mac failed because of: WebBluetoothTest.NavigateWithChooserCrossOrigin SerialTest.NavigateWithChooserCrossOrigin WebUsbTest.NavigateWithChooserCrossOrigin [ RUN ] WebBluetoothTest.NavigateWithChooserCrossOrigin [2504:3843:0415/131012.437247:WARNING:notification_platform_bridge_mac.mm(563)] AlertNotificationService: XPC connection invalidated. ../../chrome/browser/bluetooth/web_bluetooth_browsertest.cc:492: Failure Value of: waiter->has_shown() Actual: false Expected: true Stack trace: 0 browser_tests 0x0000000101095a49 (anonymous namespace)::WebBluetoothTest_NavigateWithChooserCrossOrigin_Test::RunTestOnMainThread() + 617 1 browser_tests 0x0000000106fff6ee content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 718 2 browser_tests 0x0000000106a5b62a ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 3994 ... Original change's description: > device chooser: de-flake tests > > Right now, the count of extant bubbles is used to keep track of > how many bubbles exist. This leads to flaky tests though: the bubble's > view is only deallocated after closing the bubble finishes, and since > closing the bubble is async, whether the view has been deallocated or > not at the end of the test is variable. > > This change has the tests instead ensure that the close process has > *started* at the end of the test, which is always true. > > Bug: 1069695 > Change-Id: I29535149fd3f318c22b44d8f93d22c5b248816da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149685 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759330} TBR=ellyjones@chromium.org,reillyg@chromium.org Change-Id: I380bb34779c4623775826d02ce6bd10a7d1c6870 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151507Reviewed-by:
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fit, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: I6191eede67d85a8c84bca16a52fdc43e2249541c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148894Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#759553}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/694ec49ed075..8c22240b1a04 git log 694ec49ed075..8c22240b1a04 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 582e5284d0f6..0721c1cf2a52 (14 commits) Created with: gclient setdep -r src/third_party/skia@8c22240b1a04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I90003d70f73c0467c23d230fd49c3c3f6c6d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151059Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 555fd40a. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 788a3bf1 "[css-grid] Migrate grid-auto-repeat-intrinsic.html to WPT" f9b790bb "[css-grid] Fix percentage track sizing functions in size containment" a2328fd6 "[css-grid] Migrate grid-element-remove-svg-child.html to WPT" 3fb5d786 "Roll external/wpt/webgpu and create wpt_internal/webgpu" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I4f6559885bc0fd542d3bb473f290ae27a64824a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151966Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759551}
-
Kent Tamura authored
- Make LayoutNGMixin<LayoutRubyBase> a friend of LayoutRubyBase because LayoutNGMixin<LayoutRubyBase> accesses some private functions. - Add an Element* argument to LayoutRubyBase constructor. LayoutNGMixin assumes that the constructor of its base class has an Element* argument. This CL has no behavior changes because changes are behind a runtime flag. Bug: 1069817 Change-Id: I0876d76efa8a66a39ba06b4c6df3ccd6f7e3f31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151378Reviewed-by:
-
Luciano Pacheco authored
The code was performing a regex in all open windows several times, refactor to perform only once. Bug: 1067478 Change-Id: I31d481dfb153f0f47f65bac081f1b4d73dccc8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148793 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759549}
-
Jesse Schettler authored
Make the scanning UI a page of the Print Management app. This allows the page to share API setup and resource loading with the rest of the app. The scanning page can be accessed by navigating to chrome://print-management/scanning.html when the print-job-management-app and scanning-ui feature flags are enabled. Bug: 1059779 Test: browser_tests --gtest_filter=ScanningPageBrowserTest.All Change-Id: I90c235bdc00d7c2599d790b819fa5ced19ad3711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109819Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#759548}
-
Yuki Shiino authored
The behavior of On{BeforeUnload,Error}EventHandler has already been supported, but the notation in *.idl files has not yet been supported. This patch makes it possible to write them in *.idl files, and helps the new bindings generator dintinguish error handler types. Bug: 839389 Change-Id: I1cc52407f634bc6ecfd740cf488413901e75cc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150352Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759547}
-
Findit authored
This reverts commit d69aec62. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 759540 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q2OWFlYzYyZjkyY2QyMDY2MTE0ZTBkMWFmNGUwODk5MzU3NTUxMmQM Sample Failed Build: https://ci.chromium.org/b/8882888412342833920 Sample Failed Step: compile Original change's description: > Add ServiceWorkerStorageControl::UpdateToActiveState() > > This is a wrapper of ServiceWorkerStorage::UpdateToActiveState(). > > Bug: 1055677 > Change-Id: I1444227429fd4c4647198702db79b0d414514571 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147983 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759540} Change-Id: I7b8266d5bc681ca86618ab2993efab0a42a396d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152213 Cr-Commit-Position: refs/heads/master@{#759546}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, this migration makes the test and actual crash test as it was meant to be originally, by adding the -crash suffix to its name, and replaces the 'stack' value for grid-auto-flow, deprecated as of 5 years ago, with the 'dense' value, which should be equivalent for the purpose of exercising the engine to ensure no crash happens. Bug: 767015, 1063749 Change-Id: I0b58ad320aaed07d0d76bb31729ee861f7dd4228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149360 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Alexey Baskakov authored
Design doc: go/chrome-bmo-migration. This CL unifies sync-initiated install for server-side bookmark apps to BMO-enabled clients and BMO-disabled clients. We try to install the web app as if the user had requested to install it (in background mode, no dialog). If online install fails, we fallback to WebApplicationInfo data received form the sync server. Note that user_display_mode field from server (aka open_as_window bool) always overwrites a default value. - Extract GetIconSizes() / ContainsOneIconOfEachSize test utils. - Extract SetAboutBlankResultLoaded TestUrlLoader method. Bug: 1020037 Change-Id: I109fa884af1c3b373b2b5922527c98ff6b06a921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126339Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#759544}
-
Kenichi Ishibashi authored
This reverts commit 6d769734. Reason for revert: Broke fuchsia build Original change's description: > Add ServiceWorkerStorageControl::UpdateLastUpdateCheckTime() > > This is a wrapper of ServiceWorkerStorage::UpdateLastUpdateCheckTime(). > > Bug: 1055677 > Change-Id: I3bf89d2c227d5b6f0a1c41e108843ae1d51a778b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147435 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759541} TBR=kinuko@chromium.org,bashi@chromium.org,shimazu@chromium.org Change-Id: I489f5363ac6460958c723f6b1d95660d7193fd5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152128Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759543}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile without argument is getting deprecated. Use cases of this call that only refer to incognito or guest mode can use GetPrimaryOTRProfile() instead. All calls to this function in StartupBrowserCreator and StartupTabProvider test are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I15ae29ced658772423994bf5429eeb483b13593a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131327Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#759542}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::UpdateLastUpdateCheckTime(). Bug: 1055677 Change-Id: I3bf89d2c227d5b6f0a1c41e108843ae1d51a778b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147435Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759541}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::UpdateToActiveState(). Bug: 1055677 Change-Id: I1444227429fd4c4647198702db79b0d414514571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147983Reviewed-by:
-
Jan Wilken Dörrie authored
This change makes util::StrongAlias's APIs constexpr and adds small API improvements, such as a mutable overload for value() and an explicit operator bool for IdType. Bug: 954080 Change-Id: I66fe9e407b9e2b6e64f6a0d8a5664b4573aa26bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150431Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#759539}
-
Alan Cutter authored
This CL fixes the warning in app_shell_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ValueStoreTest> value_store_unittest.cc defines a TestWithParam class without instantiating it. Targets that include this via test_support that don't instantiate the test for themselves (dozens) will trigger the warning. Bug: 1045846 Change-Id: If6a87e19af1783a8f58ec3e0ff1f03d933c0251e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143776 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759538}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::GetNewVersionId(). Bug: 1055677 Change-Id: Ia68260e56d0dfa6ade1b32d06d86f8caac52aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145384Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, this migration makes the test and actual crash test as it was meant to be originally, by adding the -crash suffix to its name, and replaces the 'stack' value for grid-auto-flow, deprecated as of 5 years ago, with the 'dense' value, which should be equivalent for the purpose of exercising the engine to ensure no crash happens. Bug: 767015, 1063749 Change-Id: I16250f5c32a5bbd334509d34c49ec6da7900e00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f1eb13a3e372..bf0cc7170286 git log f1eb13a3e372..bf0cc7170286 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@bf0cc7170286 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d78cce86a926c10d9a3f54b62fa92d3db0a6eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151843Reviewed-by:
-
Hesen Zhang authored
This is a reland of 02f002af Original change's description: > [Upboarding]: Add a tile group proto. > > Bug: 1068368 > Change-Id: I1a2da9a32a71537abb3fd3626ef2614dcd24e0ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145703 > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758600} Bug: 1068368 Change-Id: I1a935a01394b0fed138581ad293c8c2378290163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148118 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759534}
-
Luciano Pacheco authored
Given that this function is async, we can remove callback and the caller sites can use then() or "await" to chain additional work. This simplifies the logic inside launchFileManager() method. Bug: 1067478 Change-Id: I203370d5ff9dbb351df8bcd68696bae39630e5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147438Reviewed-by:
-
Curtis McMullan authored
Previously the bounds given to SetContainerType from the vk were ignored when showing the floating vk in its initial position. Now with this commit, the bounds given to SetContainerType will be used for the initial position of the floating vk. BUG=1019990 Change-Id: I7909b1745b0bcd8ba28c5657de81fa558a8ad19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138992 Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#759532}
-
llin@chromium.org authored
More detail at: go/opa-cros-media-context-consent Bug: b/140531944 Test: Manual Test Change-Id: Ic6527fe70a053e475e6b07034cccf0923e6c6c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142959 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#759531}
-
Alex Danilo authored
The share menu button was using 'cr-button', while the other menu hosting buttons on the action bar were changed to use 'button'. See CL:2143415 for another case where this needed to be changed. Styling targeting files-ng action bar menu hosting buttons was not being applied to the 'cr-button'. Changes the share-menu button to 'button' element so the correct files-ng styles for drop-down menu buttons apply. Bug: 1070604 Change-Id: I6d3da19339ba1fb9ae7ce50cfef88ebc09e785c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148896Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL addresses comments that arose in crbug.com/2120663 . Adds comments in the implementation and fixes the test nits. Bug: 1064517 Change-Id: Id616a4bc8de5c35c1ebd2168bc2e45170dc18442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144797 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
