- 22 May, 2019 40 commits
-
-
Toni Barzic authored
TBR=alemate@chromium.org Change-Id: I9377203afcf10794cd542af6192dceedd4f2ffd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618078 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662186}
-
Steven Bennetts authored
Ths CL renames TrayNetworkStateObserver -> TrayNetworkStateModel to better reflect its purpose. Bug: 862420 Change-Id: I129419cb6278401bd2f6f710aecf633e8e71501f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622427Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662185}
-
Mario Bianucci authored
A CL[1] over a year ago added an if check that caused autoscrolling to stop if the cursor left the page and the middle button wasn't held in. Since other Windows apps allow auto scrolling to continue in this case, it makes sense to match that behavior and also allow it. [1] https://crrev.com/5971e47dc08dbb773f58fd6fb13b1df7917fd295 Bug: 806562 Change-Id: Id7259b5242f21c2042f300d7f0a606179be89b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618141 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662184}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1af92be6b977ca537ba668573029b03518e9e6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662183}
-
David Bokan authored
We can't assume a FrameOwner's content view is a local frame view here since we might be removing a root scroller because it's no longer valid; it could be that it once was a LocalFrameView but has since been replaced by another type of view. No test since this came from the fuzzer and only causes an issue when run under UBSan. Bug: 961597 Change-Id: Ia24c000ac53a795d0325c2aa8825e901344f3ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618203Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662182}
-
Moe Ahmadi authored
Removes the Translate Settings entry from the Content Settings page if the Language Settings UI feature is enabled. Bug: 957688 Change-Id: Iee16ac5ca00bae2f14f398e80427cbcd23ac3984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622988Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662181}
-
Moe Ahmadi authored
Bug: 957688 Change-Id: I3d4afd4dadbabfb544b7741ae9365aac8bee29cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622326Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662180}
-
David Bokan authored
The root scroller doesn't account for non-overlay scrollbars correctly. This will be a non-trivial fix and require some more time to think through so this CL disables root scroller on non-Android platforms until the issue can be fixed. Bug: 948059,953285 Change-Id: I2425c907d7a2c9363cce39e69183063fafbed65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617378Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662179}
-
Mark Cogan authored
This CL creates public/browsing_data/ and moves these headers into it: browsing_data_removing_util.h system_cookies_store_util.h To match this, in //ios/web/, the following files are moved from net/cookies to browsing_data/: system_cookie_store_util.mm system_cookie_store_util_unittest.mm READMEs are added as well. Bug: 942244 Change-Id: I509c1fc170952f8a4a72977dcc2b8d880b837610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624571 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#662178}
-
Hans Wennborg authored
This should pass now. Bug: 961204 Change-Id: I78274311f576bb22ee96526e14cf16352c218090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624907 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662177}
-
David Benjamin authored
The original event_sigcb and event_gotsig race conditions were resolved by https://crbug.com/605894. However, the suppression was so broad that it covered every event loop iteration using libevent. Several other bugs have crept in in the meantime. Add finer-grained suppressions for those bugs. Bug: 23244, 965714, 965717, 965719, 965722, 965724, 965726 Change-Id: I646da30f7df1d0a19a4c1eb6ad7aebcd93ba099b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620705Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#662176}
-
Nina Satragno authored
For light illustrations, use a translucent white instead of solid off-white to frame the pictures. For dark illustrations, remove the black background and use a translucent black instead of solid gray to frame the pictures. Also, remove the solid dark gray fill of the clouds some of the illustrations had. Light mode screenshot: https://screenshot.googleplex.com/VknVOdbx3Yu Dark mode screenshot: https://screenshot.googleplex.com/fc0qf1Kot7p Bug: 955462 Change-Id: Ica39d681d684ac29b51fdc123d402d6611f2507d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622871 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#662175}
-
Morten Stenshorne authored
When a table-cell changes between having a restricted block-size and not having one, that doesn't imply that we have to re-lay out all children. Move the bit out of ConstraintSpaceFlags, so that we don't force a cache miss on all children when this happens, but rather check if the size of the children will actually change. This is a follow-up on https://chromium-review.googlesource.com/c/chromium/src/+/1621166 Bug: 964282 Change-Id: I56bca9eb820a008b54dfb7279860114939a1fe8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624325Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#662174}
-
Andrew Moylan authored
This CL sorts all the flag_descriptions in the OS_CHROMEOS section of flag_descriptions.{cc,h} according to the ordering prescribed in the comments at the top of flag_descriptions.h. I did this previously in crrev.com/c/1477140 but it got out of order pretty promptly, so this CL also tries a friendly reminder at the bottom of the OS_CHROMEOS section ... Bug: none Test: unit_tests --gtest_filter=AboutFlag* Change-Id: Ib1b9741656055208d5a5693f020e79e92e3ec0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623651 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#662173}
-
Maksim Ivanov authored
Remove "@private" from these <pin-keyboard> properties that are actually public and are used by consumers of this Polymer module: * enable-password * password-element * value Bug: 964069 Change-Id: I2178de7e8ac9ff7e10ca24b5cb40ef723a0fd1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622169Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#662172}
-
Rune Lillesveen authored
Make the content property of the meta name=color-scheme parse as a CSS color-scheme property value and add it at the presentation level as specified in css-color-adjust. Bug: 925935 Change-Id: I0d6d9faa3cbf782f2be3e6b4b09d8f1b951e9efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605907Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#662171}
-
Nazerke authored
When the DSE changes, the empty text icon in the omnibox should become the new DSE favicon or the default loupe. Flags: kNewOmniboxPopupLayout and kOmniboxUseDefaultSearchEngineFavicon are separate flags but "DSE in omnibox" feature is dependent on "new omnibox popup layout" feature, i.e. first one is not working without second, however the second one can work independently. Bug: 945313 Change-Id: I6d46de24e284baef99be3c215e0c3c30e3d0ff53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617821Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#662170}
-
Sahel Sharify authored
This cl enables the NoCreditCardAbort flag on ToT before landing the finch experiment for stable: https://critique.corp.google.com/#review/248771530 Bug: 955857 Change-Id: I5e41b09eed0fa18affa0749d8b43e0f78ba229de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622414Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662169}
-
Mikel Astiz authored
This reverts commit cda7826e. Reason for revert: launch approvals pending. Original change's description: > Enable new session sync logic by default > > The new logic has better privacy and reliability properties, and has > been experimented with on dev and canary channels. We now enable it by > default to launch with M75. > > Some unit tests had to be updated to reflect the new behavior, and some > additional refactoring is used to improve the accuracy of some function > names. > > Bug: 882489 > Change-Id: I9eb0816cbec1024581efc227b551781a6fbd6559 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543389 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645925} Bug: 882489,965951 Change-Id: I04b12de7ab33368fbfe4e5579b2ed974ba78a7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624574 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662168}
-
Oleh Lamzin authored
Handle unknown Mojo enum values in PerformRequest function. BUG=b:129432579 TEST=unit_tests Change-Id: Ie48643728a1d22b97b135f983ee05f1b78a8af59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611600 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#662167}
-
Varun Khaneja authored
SB2.Delay was removed via https://crrev.com/c/847819/ SB2.Network was removed even before that. Change-Id: Ifea605183c4774deec9ff94a501815c7d14bc94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623527 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#662166}
-
Andreas Haas authored
All flags we have at the moment for WebAssembly features are still in use. Therefore we extend the expiration milestone by one year. We adjust the expiration dates of the other WebAssembly flags so we can take a look at all of them once a year. Here is why we want to keep the flags: * code caching - There is a finch trial which tests code caching at the moment. * baseline - We are about to start a finch trial with the baseline compiler on Android. * threads - This flag allows our partners to test the use of WebAssembly threads on their websites more easily. R=adamk@chromium.org, ellyjones@chromium.org CC=bbudge@chromium.org, binji@chromium.org, clemensh@chromium.org, mstarzinger@chromium.org, titzer@chromium.org Change-Id: I1b52bf085cc25db9be81e66df5bc43855f241985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623946Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#662165}
-
Friedrich Horschig authored
Up until now, it was possible to change between sheets by swiping left or right. This is okay if the keyboard accessory doesn't change (like in V1) but not if the accessory bar is specific to a sheet (like in V2). Since we have only one sheet in V1, there is no harm in disabling this feature since it won't visibly change. Next to the swipe gesture, this also disables the smooth transition that is used by default. It manifests as a page-flipping effect when a new sheet was selected. The reason is the same: pages are no longer connected to each other. Bug: 905348 Change-Id: Icd01f958b9ada1c28e1a88fb7ce7b8c4cc4ca8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621179 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#662164}
-
Abigail Klein authored
This reverts commit 8e606757. Reason for revert: Caused crbug.com/964244 Original change's description: > webvtt: Add background opacity in mac > > To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html is a nice example. > > Introduce new background opacity text track property for webvtt captions and wire it to apply opacity to the WebVTT caption HTML element. > > Bug: 897730 > Change-Id: Ic8dabc2279117b7ff12eb75a9daa8d26c9d9bb25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592622 > Commit-Queue: Abigail Klein <abigailbklein@google.com> > Auto-Submit: Abigail Klein <abigailbklein@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659116} Bug: 964244 Change-Id: I76ce88cee600ed98d48426b49d1d88a40d95e507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622433 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#662163}
-
Hans Wennborg authored
Bug: 897796, 965937 Change-Id: Ie20a43b1b7cd46574a9940ae5e3f8c6555e7c76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624570 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662162}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04f39242c2ee..23aff9b73788 git log 04f39242c2ee..23aff9b73788 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 hbos@webrtc.org Implement RTCOutboundRtpStreamStats.totalEncodedBytesTarget. Created with: gclient setdep -r src/third_party/webrtc@23aff9b73788 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I600d6ecf555ea6e3db5b70836179e6065ad06aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662161}
-
Rune Lillesveen authored
Trying to remove the forced UpdateStyleAndLayoutTree on finished parsing caused svg image regressions becaused it relied on it. Instead make that dependency explicit for svg images. Bug: 742413 Change-Id: I74b5f238651348dbb0dff4fa3002525a526e5275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624565 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#662160}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/354bf5128d91..2efe6ea070c5 Created with: gclient setdep -r src-internal@2efe6ea070c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I8c6aa2f409cc9c0b4e1e1e169db59b8d9efa7a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624252Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662159}
-
Gauthier Ambard authored
This CL extract the WKUIDelegate code out of CRWWebController to CRWWKUIHandler. Bug: 956524 Change-Id: Ib2864ac23b8c73ec4523ae2236a7c206ef65f6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622206 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662158}
-
John Delaney authored
The member num_resources_ is not currently initialized. This should be initialized to zero. Change-Id: I8038313c28b28284cab0ef7290ecc1f1aaf39abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623208Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662157}
-
Armando Miraglia authored
The non-standard googTypingNoiseDetection is a constraint that is used to enable or disable getStats behavior, rather than controlling processing. This means that enabling or disabling this non-standard constraint only affects a non-standard stat behavior. Further, looking at the usage of the constraint internally and externally, the flag is almost always disabled. This CL silently removes the constraint by removing the processing logic in the select-settings algorithm and sets the flag associated to typing noise detection to off (false). BUG=924485 Change-Id: Id2a0696b3264c985d170e8c7afac1c228a7fa4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617352 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#662156}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/05c11164f801..dad31e0cc1e9 git log 05c11164f801..dad31e0cc1e9 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 lalitm@google.com systrace: update trace_to_text sha Created with: gclient setdep -r src/third_party/catapult@dad31e0cc1e9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=eyaich@google.com Change-Id: I07d352a85e976dd2c68de058617119263ac91598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662155}
-
Ian Vollick authored
It was possible to invoke onResumeWithNative without a coordinator which could cause a crash. Bug: 965767 Change-Id: Id89b35c5b8f54a5c82b0443cc7f1b67a56728e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623627Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#662154}
-
Jonathan Backer authored
This CL adds SII to DCP so that GLRendererCopier can create a texture when the CopyOutputRequest asks for a texture to be returned. Notable changes: (a) Added DirectContextProviderDelegate to wrap GL service side dependencies that cannot be accessed directly by DCP (see comment in direct_context_provider.h). (b) Created a new SyncPointClientState for use by DCP. GLRendererCopier wants insert SyncTokens. CopyOutputRequest clients expect to wait on them. By giving DCP a SPCS, DCP can insert it's own SyncTokens. The are released immediately because the GL was issued already (commented in skia_output_surface_impl_on_gpu.cc). DirectContextProviderDelegate cannot wait on SyncTokens, but it never really has to because the SyncTokens that it is given were previously generated by it (documented with DCHECKs). Bug: 948128 Change-Id: I51cd6b80e98cbd1c0b2ecb2db399e6466182f287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621629 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#662153}
-
Rune Lillesveen authored
Bug: 332189 Change-Id: Iba629f1bcc11c02a5af59cdff8c2824f42a86bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624569Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#662152}
-
Mohammad Refaat authored
All their usages have been removed. Bug: 911350 Change-Id: Iadf2b47bdb9166906d0d9f9c6298ab8d04e8963e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621033Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#662151}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/17ea5f8c844e..2961ddb9eacc git log 17ea5f8c844e..2961ddb9eacc --date=short --no-merges --format='%ad %ae %s' 2019-05-22 jcgregorio@google.com Add Huawei P30 to the tree. Created with: gclient setdep -r src/third_party/skia@2961ddb9eacc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I2c4a689abc52bb52f79e24ba770b7ef0e5cce59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662150}
-
Doug Arnett authored
This simply adds a new Feature (disabled by default) and corresponding new PreviewsState bit without using them yet. This is preparation for landing experimental support for this new intervention. Bug: 965277 Change-Id: Ib12340779a888d4d5fd7775dd7f7c22d9399e60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621191Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#662149}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from //third_party/blink/renderer/core/dom/dom_exception.h. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> Bug: 939691 Change-Id: Ic38e5f561a0aa1c4e8b476adbac47e0c09003bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621165 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662148}
-
Morten Stenshorne authored
Before we do "a lot of" work to check if we can use the cached fragment, check if we have one at all. Change-Id: I13662fbf2a1bd3b377ba91e9b345fd5093b060ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624328 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#662147}
-