- 31 Jul, 2020 40 commits
-
-
Anton Bikineev authored
Bug: 1072560 Change-Id: If307b3c2ff6a694013dcaaa5767be8dc3ce7f149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316197 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#793753}
-
James Long authored
The page's URL now automatically updates itself to match the page state whenever the page state is changed. Also, more of the page's state is stored in the URL - previously it was only the node filter, now the following graph settings are stored as well: * Inbound/outbound depth * Display settings (curved edges, coloring on hover, color schemes) * Convex hull display (for class graph only) As a result of the change, the URL generator component is now redundant. It has been removed. Bug: 1106944 Change-Id: I617640d7648b8083dbdff41522f1c1f914496fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324491 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#793752}
-
Michael Crouse authored
This is a reland of 57fd8da7 The browsertest is really flaky because of the timeout. The test is not there to verify the code being added so I'm going to decouple adding these tests. I removed or disabled the tests causing failures so hopefully this resolves it. Original change's description: > [LiteVideo] Observe MediaPlayer rebuffer events to stop throttling. > > This change adds plumbing to allow the LiteVideo optimization to > observe when rebuffer events occur so that all throttling can be > stopped. > > A future change will record the even in the user blocklist and > record the event in UKM. > > Bug: 1082554 > Change-Id: I9109fe221800b355e46c78e80254f75f433f9448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316849 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793232} TBR=tbansal@chromium.org,kinuko@chromium.org,dalecurtis@chromium.org Bug: 1082554 Change-Id: I5b11eb841a62b1c90f465c84eb68df6fcd0e573d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332684Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#793751}
-
Xinghui Lu authored
In RTL layout, the aux button of the RadioButtonWithDescriptionAndAuxButton widget is pointing to the wrong direction. Fix it by setting a different rotation degree in RTL layout. Also rename ic_expand_more_right_black_24dp.xml to ic_expand_more_horizontal_black_24dp.xml to reduce confusion. Before: http://screen/h3HRvuXJgJF After: http://screen/8LDgx4Z8m9U Bug: 1105998 Change-Id: I2856b64d66deb7afccc00e1ed2c66e54285848f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327394Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793750}
-
Dale Curtis authored
Resolves some post-commit comments. R=pkasting, wtc Bug: 1008448 Change-Id: I02e503c0284726e7f5bf122130b330ecc3659901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332279 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793749}
-
Michael Crouse authored
This looks to be the only place that the timer can be running and ScheduleFetch can be called. Bug: 1111815 Change-Id: Ic7e3bdacb610e48ac7934e2ec2712ef80c92edb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332298 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793748}
-
Joey Arhar authored
Original Patch: http://crrev.com/c/1986972 Revert: http://crrev.com/c/2148472 Reland #1: http://crrev.com/c/2150765 Revert #2: http://crrev.com/c/2322006 Reland #1 was reverted because of rendering differences between the windows 7 bots and the windows 10 bots - I forgot to include the windows 7 bots in "Choose tryjobs." I am addressing this by adding a fuzzy pixel comparator for windows. Bug: 1038425, 1022122, 1039866, 1091661 Change-Id: I810048e85dc12d8f3ecdf8f3dddc70b081afd653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323706 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793747}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be774187b1ce..bd7cef282080 2020-07-31 jmadill@chromium.org Trace Tests: Fix Win/x86 crash. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1111764 Tbr: tobine@google.com Change-Id: I8992eb9e010d93fa2555464383956192e0720764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793746}
-
Zhaoliang Ma authored
This CL refined the decoding thread number for vp9. the thread number before and after this CL: resolution before after 640x360 2 2 1280x720 4 4 1920x1080 4 4 2048x1080 8 4 2560x1440 8 8 3840x2160 8 16 4096x2160 16 16 Bug: None Change-Id: I1a8d76b518dc27152fd52b0e807b666f924f077c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332338Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#793745}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596193635-6128c4835e91dec9617eb88a5ffdf98aa76979d0.profdata to chrome-mac-master-1596218359-82effd1166d6978a93311943498771c13a6160db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia590558ced9327e41253b7d0744a539bd02d9451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333228Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/759f7034..3dcdde92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie10c1df7d46e70a15f75e3c6b3f37450477f891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332499Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793743}
-
Egor Pasko authored
The test loads a resource that goes through revalidation each time and returns with status 304 (Not Modified). The test checks that revalidation causes flushing of hte code cache on disk. Whether this is intentional behavior or not, I am not sure. Just wanted to document the current behavior and compare it to cache discarding later. Bug: 1045052 Change-Id: I629ae3789811cfce53558a13795060b6c6895a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327492 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#793742}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I1f2209e75c8dd3ae89247806130932861deb5290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333226 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#793741}
-
Aaron Colwell authored
StoragePartitions can be directly fetched using a StoragePartitionConfig now so the test was updated to not rely on webview site URL behavior. Bug: 1085275 Change-Id: I027dd7069926f2d5bceda4245b57dc70000160a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327848 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793740}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4766bd88cf78..22b8657a5558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4c8837f0174f10b42ce2d829aadc6bfc24b5adb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332575Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f6c424bb5923..22b8657a5558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia1986094c5250cee6c31269be8bfb872640e433e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bc6aebc6f315..37710e42bb90 2020-07-31 jalyn@microsoft.com Clarify missing shortcuts for screen reader users 2020-07-31 tjaneczko@google.com Add 'Copy message' context menu item for EventSource messages. 2020-07-31 janscheffler@chromium.org Migrate `front_end/security` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1111375,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I704c842d89f202a8b1c006fead31829d3a3de600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333097Reviewed-by:
-
Thomas Lukaszewicz authored
This CL introduces the following UMA histograms: TabSearch.WebUI.InitialTabsRenderTime TabSearch.WebUI.LoadCompletedTime TabSearch.WebUI.LoadDocumentTime TabSearch.WindowOpenDuration These histograms aim to measure various duration related metrics for the Tab Search feature. See the spreadsheet below for more details: https://docs.google.com/spreadsheets/d/15ygVicrrbJUJOzTn6IlnogxktExXJQzZ2PCSGMQFpWg Bug: 1099917 Change-Id: I9d9db7abe2554d682fb0211eceaa6a07a567ba24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321232Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#793736}
-
Behdad Bakhshinategh authored
This reverts commit 9bf3843a. Reason for revert: This CL was used to verify the reported UMA values. Original change's description: > Reporting latency metrics for UI > > This change is to verify the changes in latency metrics reported, and make sure there has been no other chanegs responsible for recent changes in the values of latency metrics. > > TBR=jonross@chromium.org > > Bug: chromium:1096661 > Change-Id: Iafac9541c2b773cba52c3693c61d8cfb0c184064 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317829 > Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791538} TBR=jonross@chromium.org,behdadb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1096661 Change-Id: I028144de4eb49964710355eb5a6d30f143367924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332683Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08057456d373..56387075825a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1111681 Tbr: pkasting@google.com,nicolaso@google.com Change-Id: I0936eec86bd73fc4032b99f916159b196c2f5328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793734}
-
Ana Salazar authored
When we enter cardified state, we need to make sure the apps grid pages are masked to the container of the background cards. Icon animations should not be displayed beyond these bounds. Bug: 1108642 Change-Id: Ic0e3f951cb221d95f99c89d66e4e2e398df9217c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321713Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#793733}
-
Caitlin Fischer authored
For histograms without an appropriate primary owner, add either the placeholder text or add an appropriate individual. Note that this is enforced for only non-obsolete histograms. While this should encourage people adding new histograms to have an appropriate primary owner, it is still technically possible for them to list the placeholder text as the owner to get around this. I think this is okay because reviewers would presumably not approve this. Bug: b/147376752, b/162326579, b/160411669 Change-Id: I6a3df3d8326528572a4606a1baa0c2ddc8ea7f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329737 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#793732}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3d1b4c6fd29de0c08468b1a3178cdbb4cd7c2f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333096Reviewed-by:
-
David Bertoni authored
This test needs to be cleaned up so it can be run by a Service Worker-based extension. This cl removes the use of window.setTimeout and cleans up the tests to be clearer and more concise. Bug: 1093066 Change-Id: I738005fec7414ebd8967c84c6e56c6e1c82d20fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317771Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793730}
-
Mike Jackson authored
Add support to the manifest update tasks to account for changes to the display_override field. If the contents of the display_override field change, regardless of resolution, trigger an web app manifest update. Add tests to validate we detected a manifest change under the following conditions: - values change - both valid and invalid fields. - display_override added to manifest - display_override removed from manifest Added tests to validate we don't update manifest under the following conditions: - display_override added to manifest, but contains only invalid values - values change - but only different is new invalid values. Explainer: https://github.com/WICG/display-override/blob/master/explainer.md Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Bug: 1092667 Change-Id: I1411ae6bb8685d9a4ddad44a0c8a5a73bc06bb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330338 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#793729}
-
chrome://app-disableddpapad authored
Bug: 1111690 Change-Id: Ie2385352cd31fc6261011eacd78fbaea6e038c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332047 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793728}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22b8657a5558..39c302bccf3a 2020-07-31 primiano@google.com Merge "Update CHANGELOG for v6 release" 2020-07-31 aninditaghosh@google.com Move error handling into api instead of http for Python API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:162168559 Tbr: perfetto-bugs@google.com Change-Id: Ic9de702a79cf1d298476ce5e04908bc0e1052808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333093Reviewed-by:
-
Josh Nohle authored
We store a hash of the last successfully enrolled ClientAppMetadata. On startup, if we detect that the metadata has changed since the last successful enrollment, we force a re-enrollment. Note: We do *not* force an enrollment if the persisted hash has not been set. So, a user will need to enroll before this check takes effect. --- This is ClientAppMetadata change-detection CL [4/4]: This chain of CLs relates to the end goal of re-enrolling if ClientAppMetadata has changed since the last successful enrollment. For example, when Phone Hub become supported, we will want to re-enroll. We were previously only fetching ClientAppMetadata on demand, for instance, right before a periodic enrollment. Now, we need to fetch the data every time the service starts up to see if it changed. We continue to make the assumption that the data will not change during a user session. Bug: 1105703 Change-Id: I6bb868e325498c91f90a3965fb31e3237eb0df65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300879 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Dale Curtis authored
Apparently JS can synchronously run during promise fulfillment, so we need to avoid doing that inside of an iterator they can invalidate. Since we didn't have any tests for ImageDecoder yet, this adds a bunch of basic ones and fixes the issues that arose from them. Specifically: - GIFImageDecoder allows decoding of any image SkCodec can decode. - There was no exception for empty image data. - MaybeSatisfyPendingMetadataDecodes() always satisfied regardless of whether or not the size was actually available yet. R=pkasting, tguilbert Fixed: 1108535 Test: New tests. Change-Id: I96d6d37fc7ba7b6bec409330c6c0e654fd3ff202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331131 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#793725}
-
ckitagawa authored
Like link rects in the prior CL subframe rects were not accounting for the total global transform position. This CL fixes that. See the bug for a HTML repro testcase. Bug: 1110227 Change-Id: Ib4a690be4b7a0f906f82d06aa4cdb363d0e5eb2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329931 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793724}
-
Ian Clelland authored
Blink Intent to Ship discussion: https://groups.google.com/a/chromium.org/g/blink-dev/c/Za159T1QOek/m/lewQUFlBCQAJ Bug: 1064579 Change-Id: I56ae6bc744dddf2dcc47f62dec9d1c9545115bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331742Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#793723}
-
James Cook authored
Don't check for /mnt/stateful_partition being executable, because that path doesn't exist on regular linux. Bug: none Test: can launch lacros chrome on gLinux and on device Change-Id: I54e0369c099f954f5b439ba966e07edcfbacca7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332573 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793722}
-
Muyao Xu authored
- Log "LaunchSession Succeeds" message after receiving success response from the receiver. - Add logs when session is removed by the receiver. Bug: 687380, b/154273698 Change-Id: Ie12590c98a34d3743e4b78cd36b4da278b9dac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315249 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#793721}
-
Regan Hsu authored
* Renames CellularSetup Polymer component to PsimFlowUi. * CellularSetup now includes an IronPages element that can switch between the PsimFlowUi, EsimFlowUi (to be written), and SetupFlowSelectionPage (to be written). * Moves ButtonBar into new CellularSetup. Bug: 1093185 Change-Id: I69bc4fd331cedab6cc28b4068ed613a6ad097656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324068Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793720}
-
yilkal authored
This cl corrects the logic in AppServiceWrapper::IsHiddenArcApp. Bug: 1093072 Change-Id: I216107716c98a941790147773c907189291df0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333052 Commit-Queue: Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#793719}
-
minch authored
Bug: None Change-Id: I43a5853962dc49dc5e2da3ea88c26c4aa2004be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332320Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#793718}
-
Guillaume Jenkins authored
Moves ChromeBrowserCloudManagementController from chrome/browser to components/enterprise so it can be used on Android and iOS. Bug: 1092442 Change-Id: Ieb883dceebfeea74496eb38ad0546678f7823c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314760Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
-
Rakesh Soma authored
in the reauth flow. https://screencast.googleplex.com/cast/NDgxMTU5NjA4Nzk1MTM2MHxkODI0NThkYS00OQ Bug: 1111561 Change-Id: Ia54f09152ed57d1f16132c916d55ae58094e386d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330821Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#793716}
-
Oksana Zhuravlova authored
This change populates host_app_package_name field of the ChromeProcessDescriptor message. It will be used to match renderer and browser processes to host apps. Bug: b/159477965 Change-Id: I49316a2e0e82a67366fa452a03bd795579723be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311125 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#793715}
-
John Lee authored
Bug: 642982, 1084620 Change-Id: I397768b3cb48d3c357365e32ee2130ceed720523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323724Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#793714}
-
