GitLab

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visually tested on desktop, iOS
TBR=blundell

Review-Url: https://codereview.chromium.org/2889453004
Cr-Commit-Position: refs/heads/master@{#472311}

The layout tests reports:
external/wpt/shadow-dom/slots-fallback-in-document.html passed unexpectedly

Note that this CL is not directly related to https://codereview.chromium.org/2842263004.

Review-Url: https://codereview.chromium.org/2887473003
Cr-Commit-Position: refs/heads/master@{#472310}

- Uncomment line at third_party/closure_compiler/compiled_resources2.gyp:36
- Execute ./third_party/closure_compiler/run_compiler main

The dummy compilation target will facilitate the work needed to
fully type check the PDF Plugin's JS codebase.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2879543002
Cr-Commit-Position: refs/heads/master@{#472309}

Tilt data was lost during event conversion. This patch fixes the code
path.

BUG=715289
TEST=Add log to ui event and compare it with javascript log of
event.tiltX and event.tiltY

Review-Url: https://codereview.chromium.org/2860793003
Cr-Commit-Position: refs/heads/master@{#472308}

AwContentsClientBridgeBase was a browser/ layer interface
for AwContentsClientBridge, since we can make jni calls from
browser/ already, we don't need this interface anymore.

This CL removes AwContentsClientBridgeBase, and put code into
AwContentsClientBridge.

BUG=716604

Review-Url: https://codereview.chromium.org/2888623004
Cr-Commit-Position: refs/heads/master@{#472307}

When a renderer-initiated form-submission targets an OOPIF iframe, the
navigation uses the OpenURL path. Renderer-initiated form-submission was
not implemented here with PlzNavigate.

This CL makes it work. As a consequence, it fixes the XSS Auditor
issue (https://crbug.com/710937).

BUG=710937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2879853002
Cr-Commit-Position: refs/heads/master@{#472306}

Revert of Disable blink_perf.bindings benchmark on Android Svelte (patchset #1 id:1 of https://codereview.chromium.org/1489013002/ )

Reason for revert:
Hoping that this is no longer broken; most of the data that would be helpful in debugging is gone to the sands of time (see bug).

Perf sheriffs: if blink_perf.bindings starts failing on Svelte, this CL is the culprit and you should revert it.

Original issue's description:
> Disable blink_perf.bindings benchmark on Android Svelte
>
> The benchmark is failing on downstream Android Svelte bots.
>
> NOTRY=true
> TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org
> BUG=563979
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575
> Cr-Commit-Position: refs/heads/master@{#362404}

BUG=563979

Review-Url: https://codereview.chromium.org/2890623002
Cr-Commit-Position: refs/heads/master@{#472305}

This feature has been supported under ThinLTO for some time now.

BUG=660216
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2890573002
Cr-Commit-Position: refs/heads/master@{#472304}

if the navigation is browser-initiated. The "stay in current
process to prevent privilege escalation" strategy is only valid
when the navigation was initiated by that process.

(As an aside, it is worth pointing out that current_frame_host is
not necessarily the initiator process.)

This change prevents a CheckWebUIRendererDoesNotDisplayNormalURL browser
crash in the scenario where the current page is chrome://settings, and
the user types in an URL that happens to be blocked by a
NavigationThrottle. This scenario starts being possible once
ExtensionNavigationThrottle starts doing more aggressive blocking of
top-level navigations.

BUG=661324
TEST=ToolbarModelTest.ShouldDisplayURL
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2884123002
Cr-Commit-Position: refs/heads/master@{#472303}

Also add links to cc/README.md for two recent talks on property trees
that provide helpful overview background on the current and future
state of things.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2883713002
Cr-Commit-Position: refs/heads/master@{#472302}

This CL removes the global .secondary-button class. At one point we had
several types of buttons, but we eventually narrowed down to two buttons:
.primary-button and .secondary-button; though some buttons were not
specified as either. That meant we effectively had three button classes.

Rather than add .secondary-button to each paper-button that isn't
explicitly secondary already, I've removed that class. Now there are
.primary-buttons and normal buttons; i.e. any non-primary-button is a
secondary button (aka normal) button.

Note: The references to .secondary-button are still in place (based on
Steven's review comment below) and there are a couple places where a
.secondary-button is used locally within a dom-module; those have been
left unchanged.

BUG=721268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889493002
Cr-Commit-Position: refs/heads/master@{#472301}

When show emoji/voice/handwriting vk with opt-in IME menu with virtual
keyboard disabled, the virtual keyboard will be forced shown once.
Thus, after the virtual keyboard hidden, the menu will disable the vk
to make sure it won't automatically brown.
The menu listens on KeyboardController::OnKeyboardHidden() event to
disable the vk, where SIGSEGV will cause.

Fix the issue by posting the task of disabling virtual keyboard.

BUG=721673
TEST=Verified on local build

Review-Url: https://codereview.chromium.org/2884873002
Cr-Commit-Position: refs/heads/master@{#472300}

This adds a feature flag which (when enabled) blocks pepper plugin media
(camera and mic) requests from insecure origins. A console message is logged
in those cases.

These checks happen in the renderer, but checks will also be added to the
browser in a followup.

BUG=526324

Review-Url: https://codereview.chromium.org/2882133002
Cr-Commit-Position: refs/heads/master@{#472299}

Cr-Commit-Position: refs/heads/master@{#472298}

This CL makes content settings exceptions that have an embeddingOrigin
read-only. That means they may be removed (deleted), but they cannot be
edited (not even changing the category).

BUG=716687
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2868223002
Cr-Commit-Position: refs/heads/master@{#472297}

https://pdfium.googlesource.com/pdfium.git/+log/58854942e06d..d3a3cc24a034

$ git log 58854942e..d3a3cc24a --date=short --no-merges --format='%ad %ae %s'
2017-05-16 thestig Handle when XFA parser error handlers cannot format error messages.
2017-05-16 dsinclair Add formcalc lexer tests.
2017-05-16 dsinclair Update formcalc return types
2017-05-16 dsinclair Do not walk off end of formcalc string
2017-05-16 dsinclair Minor xfa_lexer.cpp cleanup

Created with:
  roll-dep src/third_party/pdfium
BUG=708428,721533


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I3fe337c83eaa5f58ee723b5111bc9dcc2b2adcd9
Reviewed-on: https://chromium-review.googlesource.com/506659
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472296}

Revert of Make /deep/ as no-op and remove ::shadow in dynamic profile (patchset #9 id:160001 of https://codereview.chromium.org/2778983006/ )

Reason for revert:
(from the right account this time) Completely breaks Chrome OS login UI

Original issue's description:
> Make /deep/ as no-op and remove ::shadow in dynamic profile
>
> Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
>
> To make this CL small one, and easy to be reverted, all tests which depend on /deep/
> (or ::shadow) were either removed or updated in another CL:
> https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
>
> This CL only touched the small part so that users can't use /deep/ or ::shadow
> in CSS dynamic profile in M60. The further internal clean up is needed in other CLs.
>
> BUG=489954
>
> Review-Url: https://codereview.chromium.org/2778983006
> Cr-Commit-Position: refs/heads/master@{#471684}
> Committed: https://chromium.googlesource.com/chromium/src/+/a7ab8a110bd6b5339c03a34a5a6bb9a419a49e60

TBR=achuith@chromium.org,alemate@chromium.org,kochi@chromium.org,hayato@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=489954

Review-Url: https://codereview.chromium.org/2885153003
Cr-Commit-Position: refs/heads/master@{#472295}

Add _env_version attribute for each cros component update check.
Remove dir field in configuration and use name to be dir name.

BUG=chromium:690521
TEST=Run on a chromebook to download escpr successfully.

Review-Url: https://codereview.chromium.org/2882133003
Cr-Commit-Position: refs/heads/master@{#472294}

Traffic type will be used in data saver site-breakdown code to ignore
non user initiated traffic.

BUG=718656

Review-Url: https://codereview.chromium.org/2865913002
Cr-Commit-Position: refs/heads/master@{#472293}

replace is2D() method with attribute in CSSTransformValue.

https://drafts.css-houdini.org/css-typed-om-1/#csstransformvalue

BUG=545318

Review-Url: https://codereview.chromium.org/2884963002
Cr-Commit-Position: refs/heads/master@{#472292}

It caused double-click-copy to copy the path along with the period.

TBR=estevenson

Review-Url: https://codereview.chromium.org/2886963002
Cr-Commit-Position: refs/heads/master@{#472291}

Doesn't fix the original issue of notifications failing after reconnect
https://crbug.com/680099 correctly.

Introduces new issue:
startCharacteristicNotifications returns 'Operation failed' after disconnect
https://crbug.com/719581

This reverts commit db614933.
originally from https://codereview.chromium.org/2625013003/

TBR=ortuno@chromium.org,rkc@google.com,scheib@chromium.org,perja@opera.com
BUG=680099,719581

Review-Url: https://codereview.chromium.org/2888663002
Cr-Commit-Position: refs/heads/master@{#472290}

The support in Chromium is still under development. Adding test to make
sure we don't accidentally enable them before we can actually handle
them.

BUG=707128
TEST=This CL addes more test cases.

Review-Url: https://codereview.chromium.org/2889653003
Cr-Commit-Position: refs/heads/master@{#472289}

This CL gets the DataSaver setting on the main thread and pass it to
WebWorkerFetchContext (WorkerFetchContextImpl, ServiceWorkerFetchContextImpl).
WorkerFetchContext::AddAdditionalRequestHeaders() will check the flag on the
worker thread and set "Save-Data" header if enabled.

BUG=443374,722774

Review-Url: https://codereview.chromium.org/2886663002
Cr-Commit-Position: refs/heads/master@{#472288}

This CL:

 - Moves about 80 [ Skip ] lines from TestExpectations into NeverFixTests.
 - Sorts the expectations lines for imported web-platform-tests.
 - Changes the comment at the top of NeverFixTests to suggest that the file
   can also be used for manual tests that we never want to run automatically.

Review-Url: https://codereview.chromium.org/2888543003
Cr-Commit-Position: refs/heads/master@{#472287}

Two unit tests are crashing a lot on Android, disabling those
tests in background_loader_offliner_unittest.cc for Android
only.

BUG=722556
TBR=dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2891623002
Cr-Commit-Position: refs/heads/master@{#472286}

Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default (patchset #1 id:1 of https://codereview.chromium.org/2887773003/ )

Reason for revert:
Reverting based on findit-for-me notification

Original issue's description:
> [PageLoadMetrics] Enable AdsPageLoadMetrics by default
>
> Now that we've addressed all of the known causes of crashes, it's time to
> reenable.
>
> BUG=708570
>
> Review-Url: https://codereview.chromium.org/2887773003
> Cr-Commit-Position: refs/heads/master@{#472248}
> Committed: https://chromium.googlesource.com/chromium/src/+/6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26

TBR=jkarlin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708570

Review-Url: https://codereview.chromium.org/2890603005
Cr-Commit-Position: refs/heads/master@{#472285}

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledInEditableText to fix
the behavior of these commands:

BackwardDelete
DeleteBackward
DeleteBackwardByDecomposingPreviousCharacter
DeleteForward
DeleteToBeginningOfLine
DeleteToBeginningOfParagraph
DeleteToEndOfLine
DeleteToEndOfParagraph
DeleteToMark
DeleteWordBackward
DeleteWordForward
ForwardDelete
IgnoreSpelling
InsertBacktab
InsertHTML
InsertLineBreak
InsertNewline
InsertParagraph
InsertTab
InsertText
MoveBackward
MoveDown
MoveForward
MoveLeft
MovePageDown
MovePageUp
MoveParagraphBackward
MoveParagraphForward
MoveRight
MoveToBeginningOfDocument
MoveToBeginningOfLine
MoveToBeginningOfParagraph
MoveToBeginningOfSentence
MoveToEndOfDocument
MoveToEndOfLine
MoveToEndOfParagraph
MoveToEndOfSentence
MoveToLeftEndOfLine
MoveToLeftEndOfLineAndModifySelection
MoveToRightEndOfLine
MoveToRightEndOfLineAndModifySelection
MoveUp
MoveWordBackward
MoveWordForward
MoveWordLeft
MoveWordRight
Yank
YankAndSelect

BUG=713607, 722925
TEST=editing/selection/arrow_key_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2886933002
Cr-Commit-Position: refs/heads/master@{#472284}

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //chrome

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2871303004
Cr-Commit-Position: refs/heads/master@{#472283}

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to visual_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938

Review-Url: https://codereview.chromium.org/2884833003
Cr-Commit-Position: refs/heads/master@{#472282}

Revert of Rename AXObject to AXObjectImpl in modules/ and web/ (patchset #9 id:160001 of https://codereview.chromium.org/2858493002/ )

Reason for revert:
Landed wrong patchset.

Original issue's description:
> Rename AXObject to AXObjectImpl in modules/ and web/
>
> Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an
> empty abstract parent class in core/. This is pre-work to remove usages
> of AXObjectImpl from web/, which will use AXObject instead.
>
> This patch does not rename the usages in core/ since these should use
> the new abstract object.
>
> BUG=715382
>
> Review-Url: https://codereview.chromium.org/2858493002
> Cr-Commit-Position: refs/heads/master@{#471663}
> Committed: https://chromium.googlesource.com/chromium/src/+/234813ae8d52f622a1664e11365642751e8f26ba

TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=715382

Review-Url: https://codereview.chromium.org/2887613002
Cr-Commit-Position: refs/heads/master@{#472281}

This file does not exist under src/util/ anymore and thus should not be listed in the GN file.

Checked on Linux with the following command line:

$ gn check --force gn-ninja-out/local-dbg --args='is_debug=true
is_component_build=true symbol_level=1' //third_party/leveldatabase/*

BUG=502447

Change-Id: I9ce11e7f575b82345b95def661e5bb11396ba124
Reviewed-on: https://chromium-review.googlesource.com/503707Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472280}

I got back some preliminary UMA data from Canary experiment that
confirm the timestamp drift relative to the timing of v-sync signal
which makes BeginImplFrameLatency2 UMA to be all over the place with
a distribution that is spread evenly in the entire 0 - 16667 range.

This happens because D3D V-sync signal is generated based on v-blank
event for a display that contains contains the window (the current
display), but the timestamp is obtained from DWM which is based on
the most recent v-blank timing for the primary monitor. So if a
secondary monitor frequency is even slightly different that causes
v-sync / RAF timestamp drift that is clearly visible on some websites
like vsynctester.com.

One possible solution is to capture the timestamp when v-blank event
is received, but that seems to be a bit less smooth than the DWM
timestamp. So the compromise is to use DWM timing only when running on
a primary monitor; otherwise use the v-blank wake-up timestamp.
I've verified that this fixes BeginImplFrameLatency2 UMA distribution on
my setup where the secondary monitor refresh rate seems to differ from
the primary monitor by about 0.15 Hz.

BUG=467617,680639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2874833003
Cr-Commit-Position: refs/heads/master@{#472279}

BUG=708175
TBR=pwnall@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2893513002
Cr-Commit-Position: refs/heads/master@{#472278}

Add tests for certificates that pass X509CertificateBytes parsing, but fail in CertVerifyProc. Fix iOS.

BUG=711077,671420

Review-Url: https://codereview.chromium.org/2889813002
Cr-Commit-Position: refs/heads/master@{#472277}

This CL removes both android_webview_apk and android_webview_test_apk
build targets as we are deprecating those two names.

Please refer the crbug for more info, and the new target names are
webview_instrumentation_apk and webview_instrumentation_test_apk
correspondingly.

New build names are WebViewInstrumentation.apk and
WebViewInstrumentationTest.apk

BUG=701938

Review-Url: https://codereview.chromium.org/2879723002
Cr-Commit-Position: refs/heads/master@{#472276}

BUG=722320,722307

Review-Url: https://codereview.chromium.org/2883983005
Cr-Commit-Position: refs/heads/master@{#472275}

BUG=596760

Review-Url: https://codereview.chromium.org/2885003003
Cr-Commit-Position: refs/heads/master@{#472274}

The code related to update-webgl-conformance-tests hasn't been
touched in a long time, so I suspect it's unused.

BUG=677561

Review-Url: https://codereview.chromium.org/2890663002
Cr-Commit-Position: refs/heads/master@{#472273}

Setting the "WindowsTargetPlatformVersion" XML element seems to
be necessary in VS2017. Single-file compilations do not work
without it. It does not cause any problems in older VS versions.

R=brettw@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2858273002
Cr-Commit-Position: refs/heads/master@{#472272}