GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/6c448e3f5b2f..c67f445aea5f


git log 6c448e3f5b2f..c67f445aea5f --date=short --no-merges --format='%ad %ae %s'
2018-10-21 primiano@google.com Merge "Docs: add docsify support"


Created with:
  gclient setdep -r src/third_party/perfetto@c67f445aea5f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I6110a926374d829bb2cdb1bfc35b38484724bc54
Reviewed-on: https://chromium-review.googlesource.com/c/1292971Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601434}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/410c469a02ae..3a188b76c8da


Created with:
  gclient setdep -r src-internal@3a188b76c8da

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I4d589cc5f3e58a131736cd4f9bf096b9462264c2
Reviewed-on: https://chromium-review.googlesource.com/c/1292972Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601433}

https://skia.googlesource.com/skia.git/+log/47133fdb992a..8f8c43c97599


git log 47133fdb992a..8f8c43c97599 --date=short --no-merges --format='%ad %ae %s'
2018-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d4f07760e9ee..0cc11c684b54 (1 commits)
2018-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b8eec4a4ab53..d4f07760e9ee (1 commits)
2018-10-20 mtklein@google.com rename some flattenable routines
2018-10-20 mtklein@google.com move all registration into optional hooks
2018-10-20 mtklein@google.com remove old type deserialization aliases
2018-10-20 mtklein@google.com small tweaks to SkFlattenable::Register
2018-10-20 mtklein@google.com remove unused SkReadBuffer features


Created with:
  gclient setdep -r src/third_party/skia@8f8c43c97599

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I3b41c105ada357e2082e7558346604219eab421c
Reviewed-on: https://chromium-review.googlesource.com/c/1292973Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601432}

This CL marks AppCache clases with WeakPtrFactory members as final, and
removes WeakPtrFactory members from classes that have subclasses.

The superclasses of AppCache classes with WeakPtrFactory members were
checked for WeakPtrFactory members, resulting in minor cleanups.

This CL does not tackle AppCacheUrlRequestJob, because net:URLRequestJob
(which has a WeakPtrFactory) has 35 subclasses. This case will be
addressed separately.

TBR=kinuko

Change-Id: I04bb0757c34fa03620517d04571cba5a0e4a77a5
Reviewed-on: https://chromium-review.googlesource.com/c/1267337
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601431}

This reverts commit c7e36b09.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 601422 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M3ZTM2YjA5MDEzYzA0NmUyNjVkNzBkZmVkMGNhNDBiNzNiYzIzZGEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-dbg/1239

Sample Failed Step: compile

Original change's description:
> Migrate chrome/test/chromedriver/net/net_util.cc using SimpleURLLoader
> 
> URLFetcher will stop working with advent of Network Service, and
> SimpleURLLoader is the replacement API for most clients.
> This CL migrates chromedriver and its respective unittests away from
> URLFetcher.
> 
> Note that because of the multithreaded nature of the code, the natural
> approach was to simply call SharedURLLoaderFactory::Clone and pass
> the "info" mojo handle accross threads, until the operational thread.
> However, the structure holding this mojo handle is called/passed from
> 
>   (i) an indirect chain of BindRepeating calls,
>   (ii) various threads.
> 
> Given that network::mojom::URLLoaderFactoryPtrInfo and
> network::SharedURLLoaderFactoryInfo are both move-only object
> (which does not comply with BingRepeating) and that raw
> a network::SharedURLoaderLoader instance must operate on the same
> thread it was created on, this CL comes up with a local thread-agnostic
> "wrapper" to mojom::URLLoaderFactory, named WrapperURLLoaderFactory
> (see chrome/test/chromedriver/server/http_handler.cc).
> Its instance replaces URLRequestContextGetter instead across threads
> and BindRepeating chains just fine.
> 
> This CL is based on the original work of Sergio Villar (svillar@igalia.com)
> on [1].
> 
> TBR=johnchen@chromium.org (John +1'ed the original incarnation of this CL at [1]).
> 
> [1] https://crrev.com/c/1221256
> 
> Bug: 872887
> 
> Change-Id: I21386edb04b25438ba3aa40dd5ecc1461342aecf
> Reviewed-on: https://chromium-review.googlesource.com/c/1289849
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601422}

Change-Id: I0bb5f07fde222dacb7e34892d907458c8b8535a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 872887
Reviewed-on: https://chromium-review.googlesource.com/c/1293041
Cr-Commit-Position: refs/heads/master@{#601430}

BlinkGenPropertyTrees (BGPT) is an incremental step towards making
compositing decisions after the paint lifecycle phase. The primary
changes are to build property trees in blink and send a layer list to
the compositor, rather than building property trees in cc from a layer
tree. This patch marks the project as experimental which will give us
test and perf coverage on the bots.

Sheriffs: This shifts time (e.g., we now run PaintArtifactCompositor
and no longer run the cc property tree builder) and will likely change
performance benchmarks. Because this is an initial trial, feel free to
roll this patch out.

Bug: 836884
Change-Id: Ia1073bdd0922503925c17161f052bdfcd94196b7
Reviewed-on: https://chromium-review.googlesource.com/c/1292555Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601429}

This patch prepares for promoting BlinkGenPropertyTrees (BGPT) to
experimental by ensuring all unit tests pass. This patch has three
changes:
1) The foreign layer BGPT code has been disabled when SPV2 is on in
LocalFrameView::PaintTree.
2) Some CompositedLayerMapping tests of non-BGPT code have been changed
to only run without BGPT.
3) ScrollingCoordinatorTest of sticky have been updated to look up
sticky constraints on property trees when BGPT is enabled.

Bug: 836902
Change-Id: If5c32b3e02c0908bf505bddbb2d4b635b8049555
Reviewed-on: https://chromium-review.googlesource.com/c/1287169Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601428}

Subclasses of BrowserNonClientFrameView that contain a HostedAppButtonContainer
child view have duplicate logic outside of creation, colors and layout.

This CL dedupes the logic involved in having a HostedAppButtonContainer
in preparation for adding one to BrowserNonClientFrameViewMac.

Bug: 895690
Change-Id: If2e5d58af58cd72ea9d0902d3a15f3375a9e1585
Reviewed-on: https://chromium-review.googlesource.com/c/1288092Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601427}

This is a reland of 310c6fa1

This was caused by a CL that landed on Friday morning that was missing a
RunUntilIdle (that was added for the rest of the tests in the file).

https://chromium-review.googlesource.com/c/chromium/src/+/1289086 added
the failing test. The delta for the reland is adding a RunUntilIdle.

Original change's description:
> Switching Previews triggering from the IO thread to the UI thread
>
> This CL moves previews triggering from the IO thread
> (ChromeResourceDispatcherHostDelegate) to the UI thread
> (ChromeContentBrowserClient). The new call sites occur in
> NavigationRequest and update the previews_state in
> CommonNavigationParams held by the NavigationRequest directly. This
> means PreviewsDeciderImpl is being moved to the UI thread.
>
> Significant changes:
> - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of
> profile IO data.
> - PreviewsUserData is now entirely a UI thread notion. For now, we use
> PreviewsUITabHelper to manage its lifetime, but it could move to
> NavigationHandle (if NavigationHandle already supported UserData,
> that solution would be ideal).
> - ChromeNavigationData is update to remove PreviewsUserData and
> PreviewsState (the latter has moved into PreviewsUserData and there is a
> notion of Allowed PreviewsState and committed PreviewsState)
> - Offline Previews committed checks use the OfflinePreviewsTabHelper
> instead of PreviewsUserData now that we are on the same thread.
> - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well
> as cleanup to remove PreviewsState from being passed back out of the
> loader code into NavigationRequest.
> - There is a TODO to re-evaluate PreviewsState during redirects, which
> will *not* be plumbed into the network service, so DataReductionProxy
> Previews will not be updated.
>
> Bug: 842233
> Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb
> Reviewed-on: https://chromium-review.googlesource.com/c/1266196
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601298}

Bug: 842233,897385
Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8

TBR=jochen@chromium.org,clamy@chromium.org,tbansal@chromium.org,mmenke@chromium.org,jianli@chromium.org

Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8
Reviewed-on: https://chromium-review.googlesource.com/c/1292955Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601426}

This CL changes the WebAPK autoplay logic to canonicalize the scope URL
prior to checking whether the document URL is within the WebAPK's scope.
The scope passed to the renderer comes from a <meta-data> tag in the
WebAPK's Android Manifest.

The value of the scope <meta-data> tag comes
from the scope URL sent by Chrome to the WebAPK Minting server during
WebAPK creation (which is canonicalized). Right now the <meta-data> tag
in the Android Manifest is always canonicalized. We should not assume
this.

Change-Id: I9982420fda7da53ca9a77ed90e9f35de7b00bd28
Reviewed-on: https://chromium-review.googlesource.com/c/1068252
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601425}

https://skia.googlesource.com/skia.git/+log/0c226492507a..47133fdb992a


git log 0c226492507a..47133fdb992a --date=short --no-merges --format='%ad %ae %s'
2018-10-20 jvanverth@google.com ColorType fixes for wacky_yuv_textures.


Created with:
  gclient setdep -r src/third_party/skia@47133fdb992a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: Ia4ed4a9c06331797744bafbc16f8b54c2896db42
Reviewed-on: https://chromium-review.googlesource.com/c/1292801Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601424}

The new API supports getting the creation time of any process (not just
the current process).

This will be used to get a (pid, creation time) pair identifying a
renderer process and sending it to the resource coordinator service
via Mojo. Ideally, we would send a process handle, but this is not
supported by Mojo, and if it was, it would have undesirable security
implications.

Bug: 885293
Change-Id: Ic3a24c93e5352767eb8e6fb025eeacdbc0d23109
Reviewed-on: https://chromium-review.googlesource.com/c/1273607Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601423}

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates chromedriver and its respective unittests away from
URLFetcher.

Note that because of the multithreaded nature of the code, the natural
approach was to simply call SharedURLLoaderFactory::Clone and pass
the "info" mojo handle accross threads, until the operational thread.
However, the structure holding this mojo handle is called/passed from

  (i) an indirect chain of BindRepeating calls,
  (ii) various threads.

Given that network::mojom::URLLoaderFactoryPtrInfo and
network::SharedURLLoaderFactoryInfo are both move-only object
(which does not comply with BingRepeating) and that raw
a network::SharedURLoaderLoader instance must operate on the same
thread it was created on, this CL comes up with a local thread-agnostic
"wrapper" to mojom::URLLoaderFactory, named WrapperURLLoaderFactory
(see chrome/test/chromedriver/server/http_handler.cc).
Its instance replaces URLRequestContextGetter instead across threads
and BindRepeating chains just fine.

This CL is based on the original work of Sergio Villar (svillar@igalia.com)
on [1].

TBR=johnchen@chromium.org (John +1'ed the original incarnation of this CL at [1]).

[1] https://crrev.com/c/1221256

Bug: 872887

Change-Id: I21386edb04b25438ba3aa40dd5ecc1461342aecf
Reviewed-on: https://chromium-review.googlesource.com/c/1289849
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601422}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I9b8f18ea1cd663e98f956cbe45675794a0e9ff12
Reviewed-on: https://chromium-review.googlesource.com/c/1292970Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601421}

Merge internal change: 217957275

R=rch@chromium.org

Change-Id: I07eef67fd54b96f37d6ee234c5cfb247a9472c74
Reviewed-on: https://chromium-review.googlesource.com/c/1292443Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601420}

This patch adds an API to gfx::Canvas to draw skottie directly on the
backing canvas. It also removes the bitmap rasterization of each
animation frame from the ui thread and offloads it to cc.

Bug: 890224
Change-Id: Ibf8d9b682428be26c12caa4cccaae9bd53bb255a
Component: gfx, canvas, skia vector animation
Reviewed-on: https://chromium-review.googlesource.com/c/1292527
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601419}

https://chromium.googlesource.com/angle/angle.git/+log/b8eec4a4ab53..d4f07760e9ee


git log b8eec4a4ab53..d4f07760e9ee --date=short --no-merges --format='%ad %ae %s'
2018-10-20 jmadill@chromium.org GL: Apply dirty bit mask on sync state.


Created with:
  gclient setdep -r src/third_party/angle@d4f07760e9ee

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I0f9ea47bc1738ec75f18d2e8ab6f31fe8defbf7e
Reviewed-on: https://chromium-review.googlesource.com/c/1292969Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601418}

This test leaks process-global GCPhase state, potentially crashing
tests which run later in the same process, e.g several
IncrementalMarkingTest suite tests expect GCPhase to be None when they
start executing.

Bug: 897400, 879806
Change-Id: I8071fded78038b9c77a4cb6d3a5e1b258a4bbd49
Reviewed-on: https://chromium-review.googlesource.com/c/1292895
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601417}

This patch is updated duplicate code of tooltip text and accesible name

Bug: 890465
Change-Id: I74ba045aab1f5668db0e10c279c8ce99f993238d
Reviewed-on: https://chromium-review.googlesource.com/c/1278076
Commit-Queue: Jongheon Kim <sapzape@gmail.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601416}

Fixing the following issues:
 - take into account AudioContext stopping;
 - removes 10 seconds limitation.

Bug: 897451
Change-Id: I63b22fc20ded193cd032e30722ab35571adba56c
Reviewed-on: https://chromium-review.googlesource.com/c/1292378
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601415}

I've replaced two ref tests with image tests.  The diffs there are both the same root cause, basically moving from one approximation of a rounding divide by 255 to another, and some low bits move.

I could have updated the ref tests with new numbers, but if you look at them, they're basically bitmaps already.  And we actually use different div255 approximations per platform, so I think it's a little more "right" to make these image tests.  (If we were running ARM layout test bots, we'd see slightly different results than these Intel ones.)

Weeeeeellllllll.... that was my plan, but I ran into an issue where Macs would end up with a slightly different expected.txt file, and I don't really know what I'm doing with those, so I've switched it back to a ref test updated with the new colors.  :(

Change-Id: I20cbfa886f71cb509d5e60e0d7cd40af5bca13ea
Reviewed-on: https://chromium-review.googlesource.com/c/1291810
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601414}

Plumb HitTestLocation into clip-path handling and
LayoutSVGShape::*Contains.

Change-Id: Ibd4e433e868ac427e637f906ff3d778fd33e1a80
Reviewed-on: https://chromium-review.googlesource.com/c/1291409Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#601413}

This CL converts the current "animations" feature policy to
"layout-animations" feature policy: the former policy is about blocking
non-composited animations whereas the new policy only blocks a handful
of CSS animations which are known to (potentially) cause re-layout and
are also widely used. The current set of CSS properties considered in
the new policy is: {bottom, height, left, right,top, width}.

Bug: 874218
Change-Id: I97f08ce6b2b902c7057ea821416a9c145d26f068
Reviewed-on: https://chromium-review.googlesource.com/c/1235055
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601412}

This is a reland of 02cb80e6

The issues seems to have been the test case {'a', 'b', 'b'} where
apparently the failed navigation still fires a load event which might
arrive sooner than fallback update. The reland modifies the test file
to suppress sending 'OBJECT_LOAD' event from the test page.

Original change's description:
> Implement fallback content for RemoteFrameOwner
>
> RemoteFrameOwner does not implement the logic for fallback content. This
> means if a cross-origin navigation fails with some error, the owner
> element (in this context, <object>) in the parent process does not get
> notified and will not use its fallback content (instead the frame might
>  show an error page).
>
> When the <object> has fallback content, it should always use that over
> the frame's error message. To support this matter, this CL implements
> fallback methods in RemoteFrameOwner. Essentially,
>
>   * When <object> creates a local frame, the corresponding frame tree
> node will be marked as the type that "can" render fallback content. This
> will propagte everywhere using FrameReplicationState.
>
>   * When the provisional loading of a frame fails, RemoteFrameOwner will
> notify the browser through the current proxy for navigation. The browser
> then uses the parent frame to notify the renderer process that the owner
> element should render its own fallback content.
>
>   * If the <object> does not specify fallback, the navigation to error
> page commits and the error page is shown.
>
>   * When the <object> renders its own content, the remote frame stays
> alive. This is a bug but not a new one; It will be fixed in future CLs.
>
> Bug: 853140
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: Icad3934ccfc1823c0cdecd8e1223e6370ea4b3bb
> Reviewed-on: https://chromium-review.googlesource.com/c/1105635
> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
> Reviewed-by: Wei Li <weili@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601194}

TBR=dcheng@chromium.org,alexmos@chromium.org,weili@chromium.org

Bug: 853140
Change-Id: Ib1594aa642ea238f745fd29d191818fddc503afc
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1292899Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601411}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91b0f1063bdf..410c469a02ae


Created with:
  gclient setdep -r src-internal@410c469a02ae

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I082bcad16b0770c4256cd13c0415236859dc78f9
Reviewed-on: https://chromium-review.googlesource.com/c/1292799Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601410}

With MacViews, it is now very rare to actually need a
RenderWidgetHostViewMac to have its own compositor. The only
circumstances where this happens are
- content shell
- popup windows (the date/time picker)
- tab capture of backgrounded tabs

Remove the concept of having a "detached" compositor, and simplify
the transitions between states. This change will introduce flashes to
paths that rely on the RenderWidgetHostViewMac having its own
compositor (which are now vanishingly rare).

Change-Id: I0feeec67a42f05de05aa4d72fe9af93f033d9d64
Reviewed-on: https://chromium-review.googlesource.com/c/1292377
Commit-Queue: ccameron <ccameron@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601409}

Sometimes EmbedSurface is called right before WasShown when the tab
is hidden. When frame evictor is notified of this new surface, it
might immediately evict it because it doesn't know the tab will be
visible soon. This will result in an evicted surface getting embedded
which will show blank. Do two things:
- Only call SwappedFrame when the tab is visible so don't have the
problem mention above. Generally there is no point in calling
SwappedFrame when it's invisible because even though a new id
is allocated, there will not be any CompositorFrames submitted to this
surface until the tab is shown, so there is no point in notifying the
frame evictor.
- Notify RHWVAndroid via WasEvicted when the surface is evicted so that
it can allocate a new id for the next time it's shown.

Bug: 896633,893731
Change-Id: I6fbc339f606d70e65ecc79b0f74bcd44133bd4fc
Reviewed-on: https://chromium-review.googlesource.com/c/1289953
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601408}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I4859bb33a11bff11c65a9568155e3fb114039193
Reviewed-on: https://chromium-review.googlesource.com/c/1292381Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601407}

https://skia.googlesource.com/skia.git/+log/773e141a83e3..0c226492507a


git log 773e141a83e3..0c226492507a --date=short --no-merges --format='%ad %ae %s'
2018-10-19 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bc6f52f36d5f..b8eec4a4ab53 (6 commits)


Created with:
  gclient setdep -r src/third_party/skia@0c226492507a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: Iefdc61468817dea12cdda2a769ee8dedf5e94f3d
Reviewed-on: https://chromium-review.googlesource.com/c/1292795Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601406}

This CL reverts https://crbug.com/307333 for WebAPKs but not webapps.
That CL made webapps reload when a user:
- navigated back to a webapp via Android Recents
AND
- the webapp had been killed (which means that it is likely that a
  long time elapsed since the webapp was launched has passed)

A WebAPK user is using window.history.pushState() to cache that a web page
was reached by launching a WebAPK instead of by navigating on the web.
The behaviour introduced in https://crbug.com/307333 was preventing the
history state from getting restored when the user navigates back to the
WebAPK via Android recents and Chrome has been killed.

The rationale for reverting the behaviour for WebAPKs but not webapps is
that WebAPKs are supposed to be sophisticated apps. Reloading the page
takes control away from web developers.

BUG=888100

Change-Id: Icb4803b0ee8b3444e0aade2acc2473b8ce1c23b7
Reviewed-on: https://chromium-review.googlesource.com/c/1275290
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601405}

Since skia's internal caching is keyed on text blobs, its important to
reuse the same object. Make sure we cache text blobs in the
ServiceTransferCache to get a cache hit in skia.

R=enne@chromium.org

Bug: 894200
Change-Id: I8808d649ca3520211d034e07e7d4670ffb39094c
Reviewed-on: https://chromium-review.googlesource.com/c/1292722
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601404}

To avoid confusion when there is no internal keyboard connected:
- We should not show the option to remap the internal "Search"
key since that key doesn't exist.
- We should also avoid labeling the options to remap the external
meta keys as "External Meta" or "External Command", and just say
"Meta" or "Command" as "External" here is redundant.

TBR=stevenjb@chromium.org
BUG=890522, 890950
TEST=Expanded existing tests.

Reviewed-on: https://chromium-review.googlesource.com/c/1253022Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599409}
Change-Id: I3136efe54d2544423e4dd9b23fe8ffabffe3caf0
Reviewed-on: https://chromium-review.googlesource.com/c/1292890Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601403}

This got fixed by recent work to be pickier around function
pointers.

Bug: 719699
Change-Id: I684c0ee1d9866ef5517fe983f6e86ab44fb16689
Reviewed-on: https://chromium-review.googlesource.com/c/1282202Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601402}

At this point, normal/hybrid should behave identically to refresh, and
touchable identically to touchable refresh.

Bug: none
Change-Id: I616e35e50a95d467c361bc40eacbb738a3368665
TBR: nektar
Reviewed-on: https://chromium-review.googlesource.com/c/1287929Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601401}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=timvolodine@chromium.org

Bug: 681136
Change-Id: I98dd1c92df3d38301e0394e44cea06263f54beaf
Reviewed-on: https://chromium-review.googlesource.com/c/1288512Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601400}

Crash can locate particular entries in a stack by scanning for start &
end markers with unusual values.  We add start & end markers around the
|str_stack| copy of the LogMessage string, created when we're about to
crash the process due to a FATAL level log message.

This was originally landed with review:
https://chromium-review.googlesource.com/c/1201344
which was reverted because MSan bots (correctly) failed due to the test's
scanning of uninitialized stack memory. Since the test can't avoid doing
that, we simply disable it under both ASan and MSan.

Bug: 802393
Change-Id: Icd87f258aeb9556ab8e68d3e3431e80c01f1d3f0
Reviewed-on: https://chromium-review.googlesource.com/c/1292597Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601399}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90b15ebffc98..91b0f1063bdf


Created with:
  gclient setdep -r src-internal@91b0f1063bdf

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I19f17d8611f627c323d6a840c897ad57bf21f845
Reviewed-on: https://chromium-review.googlesource.com/c/1292797Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601398}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286016

This CL was uploaded by git cl split.

R=dpranke@chromium.org

Bug: 753973
Change-Id: Ie5be77df8c85eff62c9e0bb7bee0e20bbc4c367a
Reviewed-on: https://chromium-review.googlesource.com/c/1288172Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601397}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: Ia7a55dae442fdf272becf47532ad20dfd551e349
Reviewed-on: https://chromium-review.googlesource.com/c/1292374Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601396}

Since our primary objective is to reduce the cycle time for repo-wide
code coverage reports, we'd do better to have compilation and test
running on separate builders.

R=stgao,liaoyuke,jbudorick

Bug: 896446
Change-Id: Ic8b7f6319b208405a310694134da6011b485d8f1
Reviewed-on: https://chromium-review.googlesource.com/c/1289075
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601395}