- 04 Dec, 2017 40 commits
-
-
Gyuyoung Kim authored
base/memory/ptr_util.h includes are changed with <memory> as well. Bug: 755727 Change-Id: I1beb698b992a863896bd1a63c4ed3801a9a87a5a Reviewed-on: https://chromium-review.googlesource.com/802850Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#521347}
-
Camillo Bruni authored
Change-Id: Ib50dbd2d3785cb5e72a5dd8381db8d7220a86446 Reviewed-on: https://chromium-review.googlesource.com/803475 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521346}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/8509d3eaec1b..c5bfeec86aa7 $ git log 8509d3eae..c5bfeec86 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Add functions for common code in CFX_ImageTransformer. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I64e311ac738a97512495998c177e0f31d1800291 Reviewed-on: https://chromium-review.googlesource.com/806434 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521345}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/79ee73938d7d..a0985d960fb7 $ git log 79ee73938..a0985d960 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 borenet Removed general bot upload permissions, whitespace change to test Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I939b011c46d7e6025c29a582dc85ce653756b24c Reviewed-on: https://chromium-review.googlesource.com/805677Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521344}
-
Morten Stenshorne authored
This may have been correct with some version of the spec, but the current one just says to use column-count as specified, if column-width is auto. There's nothing that suggests that the width of column-gap should affect used column-count. https://www.w3.org/TR/css-multicol-1/#pseudo-algorithm See line 04 below. (01) if ((column-width = auto) and (column-count = auto)) then (02) exit; /* not a multicol element */ (03) if column-width = auto then (04) N := column-count Bug: 788337 Change-Id: I583aa0c3752a9a43b9b59725be2aa67d947487c9 Reviewed-on: https://chromium-review.googlesource.com/805975Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521343}
-
Samuel Huang authored
OutlierDetector is a component of (upcoming) ensemble patching. Its goal is to reduce the likelyhood of false-positive matches by applying simple statistical tests on BinaryDataHistogram scores. Bug: 778316 Change-Id: I57e9859b73b9fc62ffffe973ca47ac723e64f6fd Reviewed-on: https://chromium-review.googlesource.com/798899Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#521342}
-
Justin Cohen authored
Bug: 789151, 789633, 791040 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic0db7db4255f01d5875e0072707886746e58274a Reviewed-on: https://chromium-review.googlesource.com/803079Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521341}
-
Bence Béky authored
In preparation for moving UnclaimedPushedStreamContainer functionality into Http2PushPromiseIndex, rename UnclaimedPushedStreamContainer::find() to FindStream() and rename Http2PushPromiseIndex::Find() to FindSession(), so that when both methods live in Http2PushPromiseIndex, there will be no name collision. Also, remove publicly exposed UnclaimedPushedStreamContainer::iterator, instead introduce new constant kNoPushedStreamFound to be returned by FindStream() if no stream is found. (This will also be used by other Http2PushPromiseIndex methods, see https://crrev.com/c/734223 for proof of concept.) Also, remove empty(), size(), begin(), end(), count(), lower_bound(), and erase by iterator methods from UnclaimedPushedStreamContainer, and rename size to CountStreamsForSession(). New method names will make sense when they all are moved to Http2PushPromiseIndex in the next CL. Bug: 791054 Change-Id: I8a3e34b0af78480b1bb3cd22cba2fccf4c6e3e39 Reviewed-on: https://chromium-review.googlesource.com/805074Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521340}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89d1f5af..fb9e2b3a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icc126dfaaa520e9ab6fa6195407fb2f7c6fb2965 Reviewed-on: https://chromium-review.googlesource.com/806015Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521339}
-
Mike West authored
Intent to Deprecate: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/0sJ8GUJO0Dw/iMmcXLIGBAAJ HTML discussion at https://github.com/whatwg/html/issues/3076. Bug: 767813 Change-Id: Ibbbce7794c6802e66eeb4e8e6d95acedebbe840c Reviewed-on: https://chromium-review.googlesource.com/800290Reviewed-by:
-
Sylvain Defresne authored
Bug: 785248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icc7ca4649797a1d6f69e0b32af447db6e7a6982e Reviewed-on: https://chromium-review.googlesource.com/789332 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521337}
-
Paul Jensen authored
On certain devices ConnectivityManager.registerNetworkCallback fails unexpectedly. Handle this by disabling network-specific callbacks and network binding. Bug: 791025 Change-Id: I41054c8e373d9ae6cca99d845280ca56575ccf54 Reviewed-on: https://chromium-review.googlesource.com/803115Reviewed-by:
-
Sylvain Defresne authored
The tab_private.h file exposes Tab private APIs that are deprecated so remove includes that are no longer necessary. Bug: 620465 Change-Id: I7afca1fb2346405c06f4a7eae50041aa9891ae91 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/806176Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#521335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34537983. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6889 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc TBR=qyearsley No-Export: true Change-Id: I380011fc8fbd7659e6f896c3e0acafc41aeba565 Reviewed-on: https://chromium-review.googlesource.com/805876 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521334}
-
Alexandr Ilin authored
Page load metrics observers in Java are not tied to a single navigation as in C++. Instead of that they receive all metrics events as long as they are registered in a global observer list. Even though a pointer to web contents is passed in each function, it's impossible to attribute a given event to particular navigation. This CL fixes this by passing a navigation id along with web contents pointer to all page load metrics observers in Java. Bug: 778302 Change-Id: I753a44abde849ce34b9472a57f14b23465e17982 Reviewed-on: https://chromium-review.googlesource.com/801015Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521333}
-
Peter Beverloo authored
Passing `null` no longer is allowed by testharness.js, which caused this test to start failing. Easy fix :) Bug: 711529 Change-Id: I6667c6fc86bafab0dae0607b44f80aed40e192bd Reviewed-on: https://chromium-review.googlesource.com/802557 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#521332}
-
Mikhail Pozdnyakov authored
Content shell autogrants permissions for sensor APIs. Thus content_shell binaries can be used for testing these APIs (e.g. on Android). Change-Id: Idc5e3c890b30582961ef0da421a815fd03342964 Reviewed-on: https://chromium-review.googlesource.com/776598Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#521331}
-
Miguel Casas authored
This CL moves the (remaining) vaapi related files from //media/gpu to the existing//media/gpu/vaapi. Fully automatic: $ git mv media/gpu/vaapi_* media/gpu/vaapi/ $ git mv media/gpu/va_s* media/gpu/vaapi/ $ tools/git/mass-rename.p TBR= sadrul@chromium.org, avi@chromium.org for the two first files that just get an include path udpate. Bug: none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia1dcbdef3695bae5879d0951fc78cf6dcef3325f Reviewed-on: https://chromium-review.googlesource.com/801636 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521330}
-
Greg Thompson authored
Disabling ParamaterizedFullscreenControllerInteractiveTest.MouseLockSilentAfterTargetUnlock on Windows. BUG=791539 TBR=schieb@chromium.org Change-Id: I758c5e3aed0957b9b8d905905e49d101239742b2 Reviewed-on: https://chromium-review.googlesource.com/806214Reviewed-by:
-
Philip Jägenstedt authored
Imported wpt@a6dde4dc7201641112eca93a3eb48a69bb843a42 using wpt-import in Chromium 419d8078. No-Export: true Change-Id: Ife0c8f2b529125b83dfed9d86e3474f0d505203a Reviewed-on: https://chromium-review.googlesource.com/806114Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#521328}
-
Marc Treib authored
This CL #ifdef's out a bunch of Instant-process-related functions in chrome/search/search.h/cc on Android. This code was never used on Android and doesn't make sense there; let's make that obvious. Bug: 787830 Change-Id: I74d51009010df4633631102bacf051a5d1a52583 Reviewed-on: https://chromium-review.googlesource.com/803443 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#521327}
-
Boris Sazonov authored
This CL links signin javatest and junit OWNERS to the main OWNERS file. Bug: None Change-Id: I70b10eb8d62f2b2b9573cb28c9f037a0177d1f69 Reviewed-on: https://chromium-review.googlesource.com/803514 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521326}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/da5ae1256303..22a77a1b1d9c $ git log da5ae1256..22a77a1b1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iab76c3faaedd12a265c65fef8adab94ab2b7350c Reviewed-on: https://chromium-review.googlesource.com/805637Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521325}
-
Matthew Cary authored
Bug: 791524 TBR: xlai@chromium.org, junov@chromium.org Change-Id: I2e6e0085277d4f26e57327605e0e79bf344dbba4 Reviewed-on: https://chromium-review.googlesource.com/805818Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#521324}
-
Bhagirathi Satpathy authored
https://html.spec.whatwg.org/multipage/dom.html#documents With this CL, |domain| and |referrer| that includes unpaired surrogate codepoint are replaced by \uFFFD. Since in case of both DOMString and USVString, same exception ("Uncaught SecurityError: Failed to set the 'domain' property on 'Document': 'text is �' could not be parsed properly.") is thrown, so no test is added. Bug: Change-Id: Ie01fdc71fd9a540f2df4a71ff8cafbd205fe96ef Reviewed-on: https://chromium-review.googlesource.com/795592 Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership complex. After this CL, the clock instances are always un-owned by injectees. Instead, an injecter owned one is used on testing, and the shared instance is used on production path. Bug: 789079 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I19035597d971a8d1e98290437bfc0bcf603b312a Reviewed-on: https://chromium-review.googlesource.com/803176 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#521322}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0b24b652..89d1f5af Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2397a77e64a55a04f80784e320c8364815e1e015 Reviewed-on: https://chromium-review.googlesource.com/805159Reviewed-by:
-
Matthew Cary authored
Bug: 788788 TBR: iclelland@google.com, fmalita@chromium.org Change-Id: I12071e09b6a7e06e9a5c8e6df1b3e259b8a24125 Reviewed-on: https://chromium-review.googlesource.com/805834 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
The build target //content/test:content_unittests was depending on libyuv without declaring the dependecy in deps because the WebRTC target //third_party/webrtc/api:video_frame_api was exposing it via public_deps but in [1] public_deps will be replaced with deps. [1] - https://webrtc-review.googlesource.com/c/src/+/28120 Bug: webrtc:8603 Change-Id: I3d0735e08f57b78a6f9d98c5ea1428f53f12a354 Reviewed-on: https://chromium-review.googlesource.com/805242Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#521319}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If410f208f9c2f6ef0d2b4e19c7e1896c1f6beee1 Reviewed-on: https://chromium-review.googlesource.com/805245Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521318}
-
Daniel Bratell authored
Jumbo is a unity build system aimed at dramatically reducing compilation times by merging cc files into larger translation units. This change will remove about 6 CPU minutes from the effort to compile chrome+content_shell+blink_tests on the reference hardware. This is slightly less than 1% of the total effort in a jumbo build. Bug: 746953 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I19856815c50724004d11a7e5342e84bff802e6f4 Reviewed-on: https://chromium-review.googlesource.com/801013 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated methods from WebStateObserverBridge as they are now unused. Bug: 775684 Change-Id: I7c6cf9ef3dff9fa2e88851c9eecdd2242e5f6286 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/779004 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521316}
-
Gauthier Ambard authored
This CL fixes the color of the clean toolbar's omnibox in incognito. Bug: 791462, 791461 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I63644f78f348b2553a1bd5ac6b2ef33f3d3f12bb Reviewed-on: https://chromium-review.googlesource.com/805694 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
* The current histogram code assumes single-threaded usage (hits thread kassertion if resource loading from workers frun). * Currently we classify all non-main-resource requests as subframes, but it's not really true if we include non-main-thread traffic. (This could be a temporary work-around fix) Bug: 789354 Change-Id: I321cc6a3cbc39cb10c2b4ad8c110760f839a282f Reviewed-on: https://chromium-review.googlesource.com/805674 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#521314}
-
Scott Chen authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icc329bd6f5754a1bb043c80d2e477cbbb893febf Reviewed-on: https://chromium-review.googlesource.com/803485Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521313}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/c4a9e5ff69d2..da5ae1256303 $ git log c4a9e5ff6..da5ae1256 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I52fad26fa0ff982eb43377c927813e73343d8422 Reviewed-on: https://chromium-review.googlesource.com/805634Reviewed-by:
-
David Bokan authored
This patch fixes client and page coordinates on touch events when root layer scrolling is turned on. This is the touch equivalent patch of https://crrev.com/c/798537. Coordinates that are transformed by the viewport's scroll offset need to account for whether that offset is represented in the FrameView (today) or root PaintLayer's PaintLayerScrollableArea (root-layer-scrolls enabled). Using LocalFrameView::LayoutViewportScrollableArea uses the correct area. Additionally, conversions based on absolute coordinates also need adjustment since "absolute" means the root layout coodinate system. Since RLS makes the LayoutView (the root) clip and scroll its contents, absolute coordinates with RLS become equivalent to frame coordinates. Prior to RLS, absolut coordinates were equivalent to "document" coordinates since the LayoutView was the size of the entire document and scrolling happened outside the layout hierarchy. The new conversion methods in LayoutFrameView abstract the differences correctly so we make use of them in this patch. Bug: 781431 Change-Id: Ie84d81b4bc30b468d800e0e5a2867012f7760114 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/802142 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521311}
-
Yuta Kitamura authored
This ensures all call sites of WTF::Function::Run() are rvalue, i.e. any WTF::Function variable must be wrapped with std::move() before calling Run(), such as "std::move(function).Run()". This improves WTF::Function's compatibility with base::OnceCallback, and makes WTF::Function ready to be replaced with base::OnceCallback. Thanks to tzik@'s prior work to introduce std::move()s to the whole codebase, the number of extra modifications needed is very small. Bug: 771087 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3e366365ecfa6fed6dac141f04f83cfae781401f Reviewed-on: https://chromium-review.googlesource.com/803199Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch makes only-internal-used functions declared in header to local. This patch also moves internal functions from anonymous namespace to ShadowBoundaryAdjuster. Bug: 787295 Change-Id: I4420a2f7364cd41b8a6bf25aefbce79b7991c1f3 Reviewed-on: https://chromium-review.googlesource.com/803177Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#521309}
-
Peter E Conn authored
By setting layout_gravity to include start, the containing FrameLayout will position the More button correctly on RTL devices. Bug: 789752 Change-Id: Ifa5b1c6af7639f466ebf75224b75e694c9a88366 Reviewed-on: https://chromium-review.googlesource.com/803476Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#521308}
-
