Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 26 Oct, 2020 38 commits
  3. 25 Oct, 2020 2 commits
    • Jinsuk Kim's avatar
      Revert "Toolbar: Remove dependencies on NewTabPage" · 2fc6005e
      Jinsuk Kim authored 
      This reverts commit e1fcf7ac.

Reason for revert: identified as culprit for crbug.com/1141360

Original change's description:
> Toolbar: Remove dependencies on NewTabPage
>
> With this CL, toolbar/ classes are free of dependencies on
> chrome/browser/ntp. A new interface NewTabPageDelegate plus its
> implementation in ToolbarManager replaces the references to
> NewTabPage. Dependencies on static URL util methods in NewTabPage,
> NativePageFactory were addressed by moving the methods to
> modularized targets - components/embedder_support/android:util_java
> and chrome/browser/ui/native_page, respectively.
>
> Bug: 1127732
> Change-Id: I8619db6454b1aa274328a3a243b977cbd87aac02
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467578
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Filip Gorski <fgorski@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819204}

TBR=fgorski@chromium.org,tedchoc@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1127732, 1141360, 1141362
Change-Id: Ib77ad0c85d2b7313954729110f3510f096fd4d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495501Reviewed-by: default avatarJinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820644}
      2fc6005e
    • mlcui's avatar
      Shortcut viewer: Determine string to use based on shortcut · 6f245b1e
      mlcui authored 
      Most shortcuts in the shortcut viewer use one of four strings,
representing a single key with 0-3 modifiers. This is currently
hard-coded with the shortcuts. This CL refactors that to automatically
determine the correct string based on the number of modifiers,
eliminating the need to specify the shortcut string for most shortcuts.

This refactor is intended to make way for having a runtime-determined
number of modifiers for a given shortcut, as #new-shortcut-mapping
changes shortcuts involving Shift - for those shortcuts, we need to
display the shifted key instead of Shift + unshifted key.

Bug: 1139080
Change-Id: I8bb2c71a31fb1eb546aee88d6690990afd6c2f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494205
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: default avatarTao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820643}
      6f245b1e