- 07 Apr, 2020 40 commits
-
-
Mitsuru Oshima authored
* This CL changes the accelerator matching logic so that it uses DomKey and convert to VKEY+modifier as if it happened on US Keyboard Layout. This allows a user to use the key that produces the same key on the other layouts, with additional modifiers. * Reject "ASCII punctuation + shift only" acccelerator because this will not work well on non US keyboard. (We don't and shouldn't have such shortcut even now but added just in case) * Add new shortcuts that doesn't rely on ASCII punctuation for virtual desks and display zoom (uses Arrow keys) * Add new shortcuts for shortcuts that uses alt + punctuation, because it can cause ghosting when combined with altgr. (snap/minimize/maximize) See bug for design doc and new shortcut key combination. Bug: 1067269 Test: covered by unittests. manually tested on chromeos devices. Change-Id: I1f2eb31923abf9c9b1a901eb6a84689c813d8b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124867 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#757052}
-
Aaron Leventhal authored
TBR=adithyas@chromium.org,dmazzoni@chromium.org Bug: None Change-Id: I05c520ed1ce9e0405e7db2cbc671ea245c834962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138220Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757051}
-
Aaron Leventhal authored
Hit testing needs the document lifecycle to be in kCompositingClean. Fortunately, the lifecycle already is in kCompositingClean. - Expect caller of hit testing to ensure correct lifecycle - Add DCHECK for this expectation - No further lifecycle adjustments in AXLayoutObject::AccessibilityHitTest() Bug: None Change-Id: Icd9f78fd7d1e96f0d04c5a070ec4640fb6156248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136038Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757050}
-
Wolfgang Beyer authored
The probe sets DevToolsId and DevToolsToken, so that they can be sent to the DevTools frontend whenever an issue is detected in the mixed content check. Previously DevToolsId and DevToolsToken were set in PrepareRequest(), which is executed only after the check for mixed content has already happened. When generating a DevTools issue in the mixed content check, we need DevToolsId and DevToolsToken to be available. Therefore this CL adds a core probe, which allows setting DevToolsId and DevToolsToken earlier. Bug: chromium:1053468 Change-Id: I42f50ae34dad7a09095447fb398f2af2cc23bd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117735 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#757049}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c3c6694d8f0f..2d10e954cec2 git log c3c6694d8f0f..2d10e954cec2 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 cwallez@chromium.org BUILD.gn: rename libdawn_native/wire to dawn_native/wire 2020-04-07 cwallez@chromium.org Split dawn_(native|wire|platform) to their own BUILD.gn files Created with: gclient setdep -r src/third_party/dawn@2d10e954cec2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I5ee81bc3302286abea38e25f50c2a0fc9acf14e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139942Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757048}
-
Domenic Denicola authored
Fixed: 1051170 Change-Id: I50cc48e9e6acaa3e8b8d835be048ebeff041dfb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106568Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#757047}
-
Boris Sazonov authored
Replace ChromeSigninController in SigninManager.isSignInAllowed with IdentityManager.GetPrimaryAccountInfo(). This is safe to do, because the native side is already loaded if SigninManager exists. Bug: 1058981 Change-Id: I34d469463fe6d5f03ba8ce02a9efd326474b7ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089763Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#757046}
-
Juanmi Huertas authored
ImageDataBuffer may trying to be copying an uninitialized SkImage. Adding an MSAN check to check before doing the copy to ensure that has been initialized. Bug: 1052492 Change-Id: I6cfefffe42f5cf11eaf5119df1352338c2b00010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134662 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Auto-Submit: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#757045}
-
Greg Thompson authored
- Wait to perform the exhaustive cleanup operation until all uninstallers have been run. - Fix a bug in CleanRegistryEntry whereby the contents of a "forbidden" key were removed but not the key itself. BUG=698997,1059314 R=zmin@chromium.org Change-Id: Ib5632dfa5e37631ca7908b2e9833990b4d104fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139721 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757044}
-
James Cook authored
This is the "V1" feature. It: * Creates a new "Sync your settings" section in Chrome OS settings * Provides a separate toggle for OS preferences, distinct from browser preferences * Moves "Apps" and "Wallpapers" to OS settings * Makes the OS ModelTypes run in sync transport mode, controlled by a master pref for the OS sync feature This also unblocks the launch of Wi-Fi configuration sync. Bug: 1013466 Change-Id: Ie203fc96a1cf6a812d4c2b1a7c994d2978964b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137999Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#757043}
-
Rune Lillesveen authored
Bug: 1065608 Change-Id: I06a99fbe1ad2d3168ed08503da6b13f7433e906d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139751Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#757042}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e29095b1961e..8e129de0bc1a git log e29095b1961e..8e129de0bc1a --date=short --first-parent --format='%ad %ae %s' 2020-04-07 tmrts@chromium.org [deps] revert "Update DevTools DEPS." containing a depot_tools bug 2020-04-07 sigurds@chromium.org [issues] Add issue counter to console counters in top menu bar 2020-04-07 wolfi@chromium.org Reland "Add infobar about issues panel to console" Created with: gclient setdep -r src/third_party/devtools-frontend/src@8e129de0bc1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057979,chromium:1061876,chromium:1068126 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5737b9d9e8ba09452b11351105bd123dfc20280e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139941Reviewed-by:
-
Hwanseung Lee authored
Currently payments uses the deprecated org.chromium.url.URI class, so we should replace URL class with GURL class. this patch replace it at PaymentHandler area. Bug: 1065577 Change-Id: I980546c6c57bde62e10401e34cf2cb09a4f814b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126333Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#757040}
-
Peng Huang authored
The crash is because the VulkanSurface::Reshape() could be fail for some reason, and then swap_chain_ in VulkanSurface could be nullptr, accessing the nullptr swap_chain causes the crash. Fix the problem by checking the return value of Reshape call of VulkanSurface. If it returns false, VulkanSurface::Reshape() will return false too. So the SkiaOutputSurfaceImplOnGpu will handle it, and mark context lost. TODO: investigate why reshape() fail with NVIDIA GPU. Bug: 1062728 Change-Id: I3defd05466d98448599e5fc836ac229c2ce35b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139938Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757039}
-
James Cook authored
"Settings sync" (aka OS sync) has a gear icon. "Chrome sync" has the sync arrows logo. https://screenshot.googleplex.com/R1h1o2EfxMY The spacing of the second icon is still wrong, but I'll pursue that in a follow up CL, because I may have to restructure the HTML. Bug: 1067212 Change-Id: Ie40e75b1d245c8b0c4f74799204f61f295e61a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137869Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#757038}
-
Abhijeet Kandalkar authored
This reverts commit b4687c72. This WPT testcase is failing on FF and Safari because its chrome specific behaviour. feConvolveMatrix does specify conditions for attributes but does not specify what happens if those conditions were not fulfilled by the author and there is a on going dicussion in W3C github [1]. [1] https://github.com/w3c/fxtf-drafts/issues/237 Bug: 1063749 Change-Id: I56ae0883f9891ff336128e5b3e15014c7e4b384f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138937Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#757037}
-
Javier Ernesto Flores Robles authored
Change files from cpp to objc++. CredentialProviderService will use Objective-C classes, and needs to be converted to Objective-C++ instead of C++. Bug: 1066803 Change-Id: Ibd74a815177cb05b84bf05ee423ad3342c02a53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139652 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#757036}
-
Guido Urdaneta authored
This CL ensures that a sender or receiver gets at most one transformer and that the transformer is of the correct type. Prior to this CL, it was possible for an audio sender or receiver to get a video transformer if insertable streams were enabled for video. This resulted in data not flowing due to no transformer being set, or in crashes due to the wrong type of transformer being executed. Tests added in https://chromium-review.googlesource.com/c/chromium/src/+/2139213 Bug: 1068125,1068164 Change-Id: I68a701098b09e0dfc8edaec82bc7161ae686b915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139231 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#757035}
-
Mark Cogan authored
This CL removes unneeded public API from the BVC, primarily the public dispatcher property. The NTP perf test and the BVC unit tests were the remaining places where these dependencies were used. In addition to the command dispatcher, the public TabModel and BrowserState properties of the BVC are removed. Some other properties (FullscreenController, TypingShield) are just moved internally. The ContentArea property was only used in the BVC unit test, and only to check that the BVC was attached to the containing view controller. Since the container is provided to the BVC as well, that can be tested without using any direct BVC API. Other minor cleanup: - Some BVC includes are pruned. - Internally, the protocols that the dispatcher conforms to are reduced in number. - The internal -shieldWasTapped: method was removed, since it just forwarded to the dispatcher. Change-Id: I2f0ae3382e32867e5aad7a083b8fcbbb384b5c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135620 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757034}
-
Jérôme Lebel authored
Enforcing the layout constraint for 20% image height in the sign-in view. https://drive.google.com/open?id=1hwaiM1Oj3C_mLUQQqvzwNwSmJwVB_rIk (blue and yellow color are just for debug reasons, not part of this patch) Related: https://chromium-review.googlesource.com/c/chromium/src/+/1543399 Bug: 971989 Change-Id: Id4f1792203dfb11e70dea715ef2700b74e1b5cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139714Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#757033}
-
Jérôme Lebel authored
The -[GradientView updateColors] needs to be called at least once, to initialize correctly the gradient colors. Before: https://drive.google.com/open?id=1WJnG8ahbljpr0hSR8fut8ezGyIJ1i9s6 After: https://drive.google.com/open?id=1y0xTlrpu3ssvrlw7Kx05d5lqK56a1-Ko (the blue background was set just for the screenshots) Bug: 971989 Change-Id: I08c1fe12f5b142fde038da9b779a7399f1771f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133937 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#757032}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/852ebea2d55d..24627887555a git log 852ebea2d55d..24627887555a --date=short --first-parent --format='%ad %ae %s' 2020-04-07 westont@google.com Changing ~everything (mostly recipe related stuff) to reference Debian10 jobs Created with: gclient setdep -r src/third_party/skia@24627887555a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ib85001ffe182a5126854da6ac85422dc2d4e22c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139934Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b5757b95005b..9c3204a1fde0 git log b5757b95005b..9c3204a1fde0 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 cepheus@frii.com Error message: Finish addressing #2097, better texture error message. Created with: gclient setdep -r src/third_party/glslang/src@9c3204a1fde0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ibdb9205a6f3ce9c832352d5059f073ffe7701f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139376Reviewed-by:
-
Nikita Podguzov authored
Bug: 1068257, 858980 Change-Id: Ie801f5f084ac99beaf874a0b71a2d62f502dc0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137330 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#757029}
-
Ali Juma authored
This adds a field trial testing config entry for the SafeBrowsingAvailableOnIOS feature. Bug: 1059911 Change-Id: Iaba96f738087e95d8886b54871e1177451c2e64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137654Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#757028}
-
Corentin Wallez authored
libdawn_native_sources is an implementation detail of dawn_native and shouldn't be depended on. There are no uses of symbols that would be visible with that library so it is safe to remove the dependency. Bug: chromium:1064305 Change-Id: I363e7e62c18995b6c4d222962cb32cecd827b8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134023Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757027}
-
Milica Selakovic authored
[Autofill Assistant] Ensure |AutofillAssistantMode| is reset even if AA didn't reset for some reason This CL also corrects disabling PM's prompts. They should be disabled only when UI is successfully attached. Bug: 1065361 Change-Id: Id698b730e259e15a72b67c82693a4cedab2d9e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128126 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#757026}
-
Armando Miraglia authored
Fixed: 1055409, 1055408 Change-Id: I40eb1d7c0448e63da134f0cf4a09c841388b34da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118051Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#757025}
-
Dominik Röttsches authored
Add WPT test for ensuring shaping of system font Tibetan when common ligatures are disabled. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/014e038b2c2f..0d5695983e8b $ git log 014e038b2..0d5695983 --date=short --no-merges --format='%ad %ae %s' 2020-04-05 qxliu [subset] fixes dangling object_t issue in FeatureVariationRecord Fixes https://crbug.com/oss-fuzz/21560 revert () does not clean up useless object_t. Adjust the order of subsetting substitutions and conditions to avoid dangling object_t. 2020-04-05 ebrahim [subset] Fail ClassDefFormat1 serialization if no space available 2020-04-02 qxliu fix issues in ClassDefFormat1 serialize: glyph ids in Iterator may be non-consecutive, so the number in classValue might be larger than length of the Iterator 2020-04-03 ebrahim [tests/macos] Adopt added Apple Chancery tests with older macos versions 2020-04-03 ebrahim [aat] minor spacing 2020-04-03 ebrahim [aat] add the bug link, minor 2020-04-03 jfkthame Add a test for #2307. 2020-04-03 jfkthame Special-case 'smcp' when checking for exposed AAT features. 2020-04-03 jfkthame Add tests for #2305. 2020-04-03 jfkthame Fix sense of comparsion in hb_aat_map_builder_t::feature_info_t. 2020-03-30 jfkthame Set sequence number when adding feature to aat map builder, to support stable sort. 2020-04-03 ebrahim [ci] Update macOS 10.15's version 2020-04-03 ebrahim [aat] minor over previous feat related changes 2020-04-02 jfkthame Add a couple testcases for issue 2285. 2020-04-02 jfkthame [AAT] Don't map OT tags to AAT feature types that are not exposed. 2020-04-01 qxliu typo fix 2020-04-01 ariza minor; fixes #2292 Created with: roll-dep src/third_party/harfbuzz-ng/src Bug: 1036390 Change-Id: Icffdaf7aec234fcd50420a4f9f6eac5cbdd07836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134234 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757024}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91aecef3b39e..177d32254ec8 git log 91aecef3b39e..177d32254ec8 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 ddrone@google.com Merge "Support process association for global tracks" Created with: gclient setdep -r src/third_party/perfetto@177d32254ec8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id6154a407fadb92fc1727b032f9a772f731fe33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139387Reviewed-by:
-
Kevin Ellis authored
Bug: 933761 Change-Id: I78faca1d6f63e28749d91ad837a04a6fc31f0c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135543Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#757022}
-
Mathias Carlen authored
Before this patch, the observer/listener for navigation state changes were implemented using a std::vector. This would lead to null pointer dereferencing when adding and removing listeners while handling an event due to std::vector::erase reordering elements (pointers). This patch uses a checked observer and ObserverList instead to properly handling adding and removing observers/listeners. This bug was uncovered while working on the bug linked in this patch. R=arbesser@google.com Bug: b/152724265 Change-Id: Ia59bfca5bec5ce326394668eb7d8d62004fc16fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139691 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
This patch implements the advanced settings sign-in for the first run sign-in. SigninCoordinatorCompletionCallback is updated from: typedef void (^SigninCoordinatorCompletionCallback)( SigninCoordinatorResult signinResult, ChromeIdentity* identity); to: using SigninCoordinatorCompletionCallback = void (^)(SigninCoordinatorResult result, SigninCompletionInfo* info); The |SigninCompletionInfo| is a class that owns 2 values: + |identity| + |signinCompletionAction| SigninCompletionAction is an enum 2 values: + SigninCompletionActionNone + SigninCompletionActionNeedsAdvancedSettingsSignin The seconde value is only used for the first run sign-in since it can't open the advanced settings sign-in as long as the first run is not finished. Bug: 971989 Change-Id: Id9041def2bf872c0c10b7d21d7bcfe42eff7960e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130852 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: -
sauski authored
To ensure that the two related preferences, cookie_controls_mode and block_third_party_cookies remain in a consistent state, this CL updates the existing block_third_party_cookies toggle located in settings to update both preferences. Bug: 1068144 Change-Id: Ia64cb37c766a3143c6ac986efc67e87283852a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134261Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#757019}
-
Swapnil authored
When update manifest is fetched from the server, we receive an update check status from the server. We want to gather statistics about the status by using UMA statistics to investigate into this and improve installation reliability for the force installed extensions. Following histogram is added: Extensions.ForceInstalledFailureUpdateCheckStatus Bug: 1064202 Change-Id: Ie489e9b4b20888876869c42ca476fa3c6647b4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116438Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#757018}
-
sreejakshetty@chromium.org authored
Currently, renderer-initiated same-document navigation using NavigateToURLFromRenderer results in runloop timeout as TestFrameNavigationObserver::DidStartNavigation is excluded for SameDocumentNavigations. This CL proposes a fix to this scenario. Bug: 1065868 Change-Id: I9d2e7c619f3fce756d3b3f6d2196aa86820208d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127028 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757017}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I6d13ced16e45f608f044d783529003c700ab3ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131807 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#757016}
-
Nathan Zabriskie authored
This CL disables ContextGL() on the shared main thread context which will now log an error and return nullptr. This is being done to enable OOP Rasterization for Canvas2D which requires RasterInterface in place of GLInterface. New APIs should be added to RasterInterface as GLInterface will be deprecated on the shared main thread context after this CL. Bug: 1018898 Change-Id: Ic36e15b4558cbe70ea213ebf7d5c0f1751b40b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134916Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757015}
-
Jacobo Aragunde Pérez authored
Add two tests for the focus dialog and rotate pane focus accelerators. We create a "restore pages" bubble and then simulate the corresponding key press events, finally we check if the bubble is focused. Bug: 1042010 Change-Id: Ie8f44615c63386d62fbf5d32d6ff9b55c6704b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095066 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#757014}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/461f9ab12106..d14735b25df3 git log 461f9ab12106..d14735b25df3 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 0e78ffd1dcfc..b4b0f994204e (1 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e95fbfb1f509..4af38c49bfee (1 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src dbd073615280..004b2914bfe3 (5 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b8d47928094f..bdb6807825ac (4 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 698d82e38b39..1fbefe048387 (2 commits) Created with: gclient setdep -r src/third_party/angle@d14735b25df3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I5e92d94c92305582957addc825eddcf17d02dfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139381Reviewed-by:
-
