- 21 Nov, 2019 40 commits
-
-
Hiroki Nakagawa authored
is_parent_frame_secure() is a public simple getter. The getter is called only from ServiceWorkerProviderHost, so it is not necessary. Bug: 931087 Change-Id: I5ad034634db977f57caddf22fbe08e85e8dc858f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928514 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#717510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/65ccdcb8da70..604d935d2770 git log 65ccdcb8da70..604d935d2770 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 vapier@chromium.org signer_payloads_client: rework bytes/strings handling Created with: gclient setdep -r src/third_party/chromite@604d935d2770 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If6cd694f75da5a03ca808d9abc7fafbeb9337299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717509}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL adds ServiceWorkerContainerHost::type() and client_type() that are equivalent to ServiceWorkerProviderHost::provider_type() and client_type(). This is useful for moving functions in ServiceWorkerProviderHost to ServiceWorkerContainerHost in subsequent CLs. In the final state, ServiceWorkerProviderHost will be renamed to ServiceWorkerHost, and its provider_type() and client_type() will be removed. This is because ServiceWorkerHost will work only for a service worker execution context, and those types will be meaningless. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I7ec982ca6cf39519411d897fa78c942a1c37f7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928452 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add aria-hidden to xf-display-panel element so it doesn't grab the focus when it doesn't have any content. Remove |hidden_| attribute which was defined and never used. Test: browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Bug: 1026535 Change-Id: I4c2a74c7ffe3865a299df3d427bb3fcb806d975f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926089Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#717507}
-
Tim Song authored
This CL should now make the collapse/expand feature functional during in-app tablet mode. To make the calculation clean, this CL also refactors the tray buttons, treating them as a vector rather than individual member variables. TEST=manual + unit tests BUG=982511 Change-Id: Icfb0aadc2d4089cb6f77e1cb64fb412f625b3776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923502 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#717506}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/988a272841b9..bb9ade82457a git log 988a272841b9..bb9ade82457a --date=short --no-merges --format='%ad %ae %s' 2019-11-21 dberris@chromium.org Implement a Job Serializer Evaluator Created with: gclient setdep -r src/third_party/catapult@bb9ade82457a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:988912 Change-Id: I6c128365e25e7415b245197d618b748b6a026661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928112Reviewed-by:
-
Connor Clark authored
Bug: 772558 Change-Id: If545da902c199f4162698052cd57a26795337071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928088 Commit-Queue: Connor Clark <cjamcl@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#717504}
-
Alex Danilo authored
Adding role='alert' on the summary panel item type has the side effect of the screen reader repeatedly reading the panel message for each progress update which is excessive. Removes the role='alert' for summary panels only and moves the role='alert' setting to the text on other panel types so that the screen reader reads just the text on the panel for an alert. Bug: 1026501 Tests: browser_test --gtest_filter="*FilesDisplayPanel" Change-Id: Idd7e50690a7e8f36236933f5314d73e016190a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928456Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#717503}
-
Matt Mueller authored
Change-Id: I00c4eec7db9823146a6c776e95c9b7d10d2d5b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915192 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#717502}
-
Eric Lawrence authored
The registerProtocolHandler() and unregisterProtocolHandler() functions should only be permitted for secure contexts. When called on non-secure contexts, a SecurityError should be thrown. Bug: 882284 Change-Id: Iacf3d31f80f5118e9e9aacad2c99a0111d6e7cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892213Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717501}
-
Alexander Timin authored
Ensure that we always pass the main document to CanStoreDocument as CanStoreDocument always returns false for non-main documents, which then will lead to eviction even when we still can store the document in the cache. R=arthursonzogni@chromium.org,hajimehoshi@chromium.org Change-Id: I021ef8fa0505c9d8eef0d423cde319439f4c612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905688 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#717500}
-
Darren Shen authored
Was failing just on Mac, but now fails on all bots: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZU5ldHdvcmtTZXJ2aWNlQnJvd3NlclRlc3QuRW5jcnlwdGVkQ29va2llcww TBR=wfh Bug: 1019655 Change-Id: I0d2025b90d10ac38c28a5f3070adb42cc0a5ae1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928511 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#717499}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e2f58756d1c..65f6b45d6d3f git log 2e2f58756d1c..65f6b45d6d3f --date=short --no-merges --format='%ad %ae %s' 2019-11-21 ehmaldonado@chromium.org gclient: Assert invokations of gclient succeed when running smoketests. 2019-11-21 ehmaldonado@chromium.org depot_tools: Run watchlists tests on Python 3 Created with: gclient setdep -r src/third_party/depot_tools@65f6b45d6d3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1024683,chromium:1002209 Change-Id: Ie711c876235fede3548c71353bea70e63a210319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928155Reviewed-by:
-
Keith Lee authored
This change updates: ArcImeService::ConfirmCompositionText(bool keep_selection) ArcImeService::SetEditableSelectionRange(const gfx::Range& range) This was made in 1 CL so that I could use the setEditableSelectionRange function to test the keep_selection param. Implementing these 2 functions will make the following APIs work correctly: chrome.inputMethodPrivate.finishComposing() chrome.inputMethodPrivate.setSelectionRange() Since they depend on the updated TextInputClient functions being implemented correctly. Bug: b/134473433 Change-Id: I9ef52f4ece76d78161a833c2adf91f974dab5c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909065 Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#717497}
-
Kenichi Ishibashi authored
Before this CL ServiceWorkerDatabase included trial_token_validator.h just for a type alias. Since ServiceWorkerDatabase will be moved into the storage service and we generally don't want to have a dependency from the storage service to blink, remove the include. The downside of this change is that we now need to have a dup of FeatureToTokensMap, but we don't have to use the same data structure actually. It's kind an internal representation in ServiceWorkerDatabase and we can use arbitrary data structure for that. I think it would make sense to have a separate definition. Bug: 1016064 Change-Id: Ie9bb7ba329e3de2dd1c207b1b05e75a909eae06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928472Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#717496}
-
Samuel Huang authored
TBR: agrieve@chromium.org NOTRY: True Change-Id: Ie0afde0dffbbe2862f040119b6b4af02053730d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928161Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
-
Sammie Quon authored
This will help with future work for improving smoothness of animation and drag. Adds a UI interactive test as well. A tast test was underway but due to having to wait until new uprevs as well as apis still underway (launcher, accelerator autotest private api) i think the interactive UItest still has some values. Test: added tests Bug: 1024679 Change-Id: Ib95a1fc0a129404dff4b260bfb2527780afb7f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925715Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#717494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1376c050383..2b5d61e4c5f5 Created with: gclient setdep -r src-internal@2b5d61e4c5f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ie7c5f01ec1edbd20c2a2ca1eae3cf69ccd75ff7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928154Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717493}
-
Alexander Timin authored
Ensure that RenderFrameHostImpl::EvictFromBackForwardCache trace event also exposes the reasons why the frame was evicted from back-forward cache. Also remove RenderFrameHostImpl:L:UpdateActiveSchedulerTrackedFeatures and OnSchedulerTrackedFeatureUsed because EvictFromBackForwardCache covers these cases and exposes the reason. R=arthursonzogni@chromium.org,hajimehoshi@chromium.org CC=bfcache-bugs@chromium.org Change-Id: I42c63c9aa31af5086f1a56286f475fedad60436c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905706 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::MediaController with using Receiver instead of Binding. Bug: 955171 Change-Id: Ia89a66fbf407f9be492db856237b0b8643015f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923974Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#717491}
-
Rakina Zata Amni authored
Text within <legend> are displayed normally and should be findable. Bug: 1014432 Change-Id: I3c0028a4e7572374fe0ea6d338fb0f72970b6da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926271Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#717490}
-
Ken Rockot authored
This removes Service Manager API dependencies from the Tracing service and its clients. A new TracingService mojom interface is introduced to own and control a singleton Tracing service instance. This interface allows for client registration and ConsumerHost binding. The browser maintains a registry of active child processes, updated explicitly by RenderProcessHostImpl and BrowserChildProcessHostImpl. The registry is used to keep the Tracing service connected to all child processes while it's running. Bug: 977637 Change-Id: I7c67399fd03b78f68c997a26d89561fc71512cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918311 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#717489}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. As the first step, this CL introduces ServiceWorkerContainerHost, and moves the responsibilities for managing service worker JavaScript objects and service worker registration JavaScript objects from ServiceWorkerProviderHost to ServiceWorkerContainerHost. ServiceWorkerContainerHost is tentatively owned by ServiceWorkerProviderHost, and has the same lifetime with that. In the future, the container host will be owned by execution context hosts (i.e., RenderFrameHostImpl, DedicatedWorkerHost etc). See the design doc for details. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: Ice3c76e92748e3d39b740d89d93d62d36d1c70ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921597 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Leon Han authored
This CL fixes a bug introduced by crrev.com/c/1824395 that attempts to access null pointer, also adds a wpt to cover it. BUG=520391,1026541 Change-Id: I62d5b28c3c6d39cbb27c2f21ca4d5ca91e54d892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925494 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#717487}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1879202b. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If2e8f48bd216845564a00345a6167f58ea4bdf4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928391Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717486}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for AudioOutputStreamObserver with using PendingAssociatedRemote. Bug: 955171 Change-Id: I6da76343e19402650916e3e7aba79ff103fbd2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924185 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717485}
-
Ken MacKay authored
* Make sure volume map doesn't require thread pool. * Reduce task posting. * Add standalone service config. Bug: internal b/138938216 Change-Id: I05603a87f9b4afbf40140ac379a17af146409601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925346 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#717484}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2885ac3fe4f6..4e0255508749 git log 2885ac3fe4f6..4e0255508749 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-21 herb@google.com Remove device paths from SubRun Created with: gclient setdep -r src/third_party/skia@4e0255508749 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I97ad0a2a0dac89b488bdc72d9d390866d75faf9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928175Reviewed-by:
-
Darren Shen authored
This reverts commit 137e8082. Reason for revert: Seems to break compile https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/148873 Original change's description: > Remove global CrOncStrings. > > This was used to access translated strings from networking > components inside cr_elements/, now that they have moved to > cr_components/ this workaround is no longer needed. > > Fixed: 990121 > Change-Id: Ie62c0fb5bd5e5cce7f3d916e975f41701b4b2aa5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923608 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717477} TBR=stevenjb@chromium.org,khorimoto@chromium.org,jonmann@chromium.org Change-Id: Iae76ef0ebf69e116dc0f0d1c6276c8c03d32c3f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928454Reviewed-by:
-
Findit authored
This reverts commit 29c8bb39. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 717476 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI5YzhiYjM5NGRkOGI4YzAzZTAwNmVmYjM5ZWM3N2ZjNDJmOTY5MDAM Sample Failed Build: https://ci.chromium.org/b/8896211200981346592 Sample Failed Step: compile Original change's description: > Creates a WebUI-based Crostini Upgrader > > The UI is behind the new crostini-webui-upgrader flag > (currently disabled by default) > > The main areas for review are > > calamity@: > html/js - chrome/browser/chromeos/crostini_upgrader/ > mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/ > > davidmunro@ > crostini business logic - chrome/browser/chromeos/crostini/ > > In this CL, the optional container backup stage is stubbed, and will be > in a subsequent CL. > > A suite of unit/browser tests are also currently lacking. I intend them for > follow-up CLs. > > > Bug: 930901 > Change-Id: Ic52c5242e6c57232ffa6be5d6af65aaff5e8f4ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900520 > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#717476} Change-Id: I704f549216a7d1dc21942fbf6cf4ab9a1d600380 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928159 Cr-Commit-Position: refs/heads/master@{#717481}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ie337e4c3cee186e19d9c1847b50dbe3b623fb5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928631Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717480}
-
Maggie Cai authored
This CL syncs the preferred apps deletion from ARC to app service. BUG=853604 Change-Id: I6dbb292cb4607c5e2457966917b582e18948543f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921590 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#717479}
-
Andrew Moylan authored
Hoping to experiment with this flag outside dev/canary from M80. Bug: no Change-Id: I9e105127e942e9ab39d07683c89ebb545cb645b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926093 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717478}
-
Jon Mann authored
This was used to access translated strings from networking components inside cr_elements/, now that they have moved to cr_components/ this workaround is no longer needed. Fixed: 990121 Change-Id: Ie62c0fb5bd5e5cce7f3d916e975f41701b4b2aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923608 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#717477}
-
Nicholas Verne authored
The UI is behind the new crostini-webui-upgrader flag (currently disabled by default) The main areas for review are calamity@: html/js - chrome/browser/chromeos/crostini_upgrader/ mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/ davidmunro@ crostini business logic - chrome/browser/chromeos/crostini/ In this CL, the optional container backup stage is stubbed, and will be in a subsequent CL. A suite of unit/browser tests are also currently lacking. I intend them for follow-up CLs. Bug: 930901 Change-Id: Ic52c5242e6c57232ffa6be5d6af65aaff5e8f4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900520 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Lorne Mitchell authored
1. Added certificateHasSha1SignaturePresent (boolean) to Security.visibleSecurityStateChanged.certificateSecurityState.CertificateSecurityState to warn when SHA1 is present in the signature chain 2. Added certificateNetworkError (optional string) to Security.visibleSecurityStateChanged.certificateSecurityState to indicate the highest priority network error code, if the certificate has an error. 3. Added 'cert-missing-subject-alt-name' to Security.visibleSecurityStateChanged.securityStateIssueIds to warn about a missing subject alt name. These properties were missed when creating the Security.visibleSecurityStateChanged event, which is replacing Security.securityStateChanged. Bug: 946860 Change-Id: I40f21c19a58aa7a560adf5c27a3879aa5a3f143e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921334 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#717475}
-
Kyle Horimoto authored
This CL fixes the buttons of the setup flow UI to the bottom of the dialog, even if there is more contents to flow. The contents can scroll freely behind the buttons. Screenshot - at top: https://screenshot.googleplex.com/1ODKMEHrNOL Screenshot - scrolled: https://screenshot.googleplex.com/1XnccGjf9Ki Bug: 1001901 Change-Id: I923df4df68f1f098ee0b9e07f96c8de97596083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928193 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#717474}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=wtlee@chromium.org Bug: 1023677 Change-Id: Ia62dc0aa35221d412f016a5d53f0ee9f7cf98586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926918 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#717473}
-
rbpotter authored
Change the history Web UI build to be more similar to other Web UI pages (e.g. extensions, settings, Print Preview) by adding individual grd files for its resources, and building the optimized page from an unpak folder. This will allow the page to leverage existing logic in unpack_pak to place generated Polymer 3 JS files and non-generated JS module files in the same folder structure for bundling when the page is migrated to Polymer 3. Bug: 715296 Change-Id: I9d95fe251b5671d40f6979be7902e48deb08bad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925703 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#717472}
-
Piotr Bialecki authored
Change mojo to account for latest version of hit test API Bug: 997369 Change-Id: Ib63118a3e1bf0ef29ae7e3e2cced903993cff5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915179 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#717471}
-
