- 20 Sep, 2018 40 commits
-
-
Xiyuan Xia authored
- Add content_browsertests in single process mash mode to bots; - Add a filter file of the failed/flaky tests; Bug: 874089 Change-Id: I806556b0de0b4ee154d03395a566d0e6610eb5c3 Reviewed-on: https://chromium-review.googlesource.com/1234258Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592839}
-
Gauthier Ambard authored
This CL removes the class triggering the animations for the tools menu button in the toolbar. It is now directly triggered by the BVC. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I19feafb03776741bbde51fe54ace27b990811b2e Reviewed-on: https://chromium-review.googlesource.com/1236655 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592838}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5e97145328bd..3d81f7cc222b git log 5e97145328bd..3d81f7cc222b --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dtu@chromium.org [pinpoint] Add try job and latency stats. Created with: gclient setdep -r src/third_party/catapult@3d81f7cc222b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887168 TBR=sullivan@chromium.org Change-Id: I182425628bb8f5540341ea21ff8da31cfca3104b Reviewed-on: https://chromium-review.googlesource.com/1236516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592837}
-
Mugdha Lakhani authored
when one of the settled fetches has a response with a bad status. Bug: 876691 Change-Id: I45af6b792a6a43e5b091bc5fe6f40d011bdabac5 Reviewed-on: https://chromium-review.googlesource.com/1233693Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592836}
-
Rune Lillesveen authored
Change-Id: I7d928fc9847413805dd3179d49b13736fb8f6450 Reviewed-on: https://chromium-review.googlesource.com/1235993Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592835}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/207cfdfbd889..0ad0c27a0bce git log 207cfdfbd889..0ad0c27a0bce --date=short --no-merges --format='%ad %ae %s' 2018-09-20 buildbot@webrtc.org Roll chromium_revision cc7b9c68..a7544fa3 (592452:592771) Created with: gclient setdep -r src/third_party/webrtc@0ad0c27a0bce The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4f478b6b1fd08dfe415a8435c5f5b28c32ea3f23 Reviewed-on: https://chromium-review.googlesource.com/1236515Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d2918e8ee83..e6dfe41ffa6e git log 5d2918e8ee83..e6dfe41ffa6e --date=short --no-merges --format='%ad %ae %s' 2018-09-20 hjd@google.com perfetto-ui: Rename rawQuery to query 2018-09-20 hjd@google.com Merge "perfetto-ui: Remove engine worker proxy hacks" Created with: gclient setdep -r src/third_party/perfetto@e6dfe41ffa6e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I524fc5b7b49b9ec91b5d513f48d0344d937e38c2 Reviewed-on: https://chromium-review.googlesource.com/1236474Reviewed-by:
-
Finnur Thorarinsson authored
The SelectableListToolbar is setting FocusInTouchMode to true for all its children. This is problematic for the Done button, as it then requires two taps to click. Also, while I was at it, use the same styling for the Done button as the Done button in the Contacts Picker. Bug: 813422, 656015 Change-Id: I277626563885621b3bf677697d464a3299e6658f Reviewed-on: https://chromium-review.googlesource.com/1236435 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#592832}
-
Weiliang Chen authored
Skip GLImageNativePixmap tests and GLSurfaceEGLTest.SurfaceFormatTest for MSAN. TBR=kbr Bug: 886995 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1b29243bd8219e81187aa0e8c5d8f50371423126 Reviewed-on: https://chromium-review.googlesource.com/1236833 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592831}
-
Sergey Poromov authored
AuthFailure was remembered in OnAuthFailure() by a pointer and was freed after that leading to strange failure reason on next read. It was introduced 5 years ago in https://crrev.com/22900017 [719:719:0918/112724.240220:ERROR:auth_status_consumer.h(95)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240293:ERROR:device_event_log_impl.cc(159)] [11:27:24.240] Login: cryptohome_authenticator.cc:725 Login failed: [719:719:0918/112724.240371:ERROR:login_performer.cc(63)] Login failure, reason=0, error.state=0 [719:719:0918/112724.240414:ERROR:kiosk_profile_loader.cc(202)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240458:ERROR:auth_status_consumer.h(95)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240445:ERROR:kiosk_profile_loader.cc(188)] Kiosk auth failure: error= [719:719:0918/112724.240674:ERROR:kiosk_profile_loader.cc(50)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240732:ERROR:app_launch_controller.cc(526)] Kiosk launch failed, error=4 Bug: 885346 Change-Id: I46ca3b3630aa42e25a25d9cfecb3a16e3c361b9f Reviewed-on: https://chromium-review.googlesource.com/1236265Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592830}
-
James Cook authored
ArcAppWindowLauncherController was observing the wrong aura::Env for window creation, so it wasn't calling AttachControllerToWindowIfNeeded to set the correct ShelfID on the window. Bug: 887129 Test: pin Play Store icon, then tap on it Change-Id: I2239a032962b783a50e562b822f021ef6e0a7511 Reviewed-on: https://chromium-review.googlesource.com/1235152Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592829}
-
Guido Trotter authored
Both policies are deprecated and will always be false. Remove SupervisedUsersEnabled code, for ChromeOS Remove SupervisedUserCreationEnabled code, for Chrome Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Bug: 834488 Change-Id: Iab2fad3d396ab5d68bbd0072da742fadeb64d367 Reviewed-on: https://chromium-review.googlesource.com/1224033Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592828}
-
Cathy Li authored
mv ntp/ContextMenuManager.java to native_page/ mv suggestions/SuggestionsNavigationDelegate.java to native_page/NativePageNavigationDelegate.java and remove suggestions-only methods cp suggestions/SuggestionsNavigationDelegateImpl.java to native_page/NativePageNavigationDelegateImpl.java and remove suggestions-only methods have suggestions/SuggestionsNavigationDelegate.java extend native_page/NativePageNavigationDelegateImpl to contain suggestions-only methods update all references thereof Bug: 867488 Change-Id: I64cb9bb6864da2a90b9358ec2a4f339d76df1cdc Reviewed-on: https://chromium-review.googlesource.com/1232336 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I2bf66fbb151b60c3a26a2d0082ab760720a926d9 Reviewed-on: https://chromium-review.googlesource.com/1236497 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592826}
-
Kevin Bailey authored
Previously OmniboxTabSwitchButton::IsSelected() wasn't asking if *this* result was selected, only if "the tab switch button" was focused. This could refer to another result. This change narrows the implementation of IsSelected() to check if this particular result is also selected. Bug: 886606 Change-Id: I463151848e6cefdbe3afa360d3dbc0e03d2c40ee Reviewed-on: https://chromium-review.googlesource.com/1234033Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592825}
-
Mark Cogan authored
This CL: - Removes support for non-GRID tab switchers from the feature engagement egtest. - Simplifies tab_usage_recorder_test_util to only support the tab grid. - Removes non-grid support from the UKM egtest - Moves the TabletTabSwitcherOpenButton() helper function to chrome_matchers, out of the moribund tab_switcher/ directory. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6cbcfa88f13bdad6407e56746e9e76bd9e4a5d38 Reviewed-on: https://chromium-review.googlesource.com/1233195 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592824}
-
Arthur Sonzogni authored
Renderer initiated back/forward navigations must not be able to cancel ongoing browser initiated navigation if they are not user initiated. Note: 'normal' renderer initiated navigation uses the FrameHost::BeginNavigation() path. A code similar to this patch is done in NavigatorImpl::OnBeginNavigation(). Test: ----- Added: NavigationBrowserTest. * HistoryBackInBeforeUnload * HistoryBackInBeforeUnloadAfterSetTimeout * HistoryBackCancelPendingNavigationNoUserGesture * HistoryBackCancelPendingNavigationUserGesture Fixed: * (WPT) .../the-history-interface/traverse_the_history_2.html * (WPT) .../the-history-interface/traverse_the_history_3.html * (WPT) .../the-history-interface/traverse_the_history_4.html * (WPT) .../the-history-interface/traverse_the_history_5.html Bug: 879965 Change-Id: I1a9bfaaea1ffc219e6c32f6e676b660e746c578c Reviewed-on: https://chromium-review.googlesource.com/1209744 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592823}
-
Paul Meyer authored
These reports are only used for testing, are not web exposed, and the flag only covers the IDL file anyway, which is unnecessary. This patch removes that flag. TBR: japhet@chromium.org Change-Id: I3a1c63bbbaa2f50cec7c42217a7ce2882ae6f6c2 Reviewed-on: https://chromium-review.googlesource.com/1226077Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592822}
-
Tao Bai authored
These resources are used by hueristic field type prediction. Bug: 849913 Change-Id: Iab2935bce88984c604ac87f0148910c1a4b343c2 Reviewed-on: https://chromium-review.googlesource.com/1231819 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592821}
-
jchen10 authored
It causes no-over-optimization-on-uniform-array cases failing consistently. TBR=kbr@chromium.org Bug: 884210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5e61cdcfd793fb3a7916b9c25acca535d61771fd Reviewed-on: https://chromium-review.googlesource.com/1235327Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592820}
-
Nico Weber authored
Bug: 832676 Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f Reviewed-on: https://chromium-review.googlesource.com/1236178 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592819}
-
Chris Lu authored
- Updates _currentPage properly in response to 3-finger accessibility swipe. This will now properly read out the currently visible page if a user swipes to a different page. - Ensures that only the currently visible page's elements can be selected in the scroll view. This resolves an issue VoiceOver was having with what page to readout and to focus on. Oftentimes the visible page was not readout or selectable. Video: https://drive.google.com/open?id=1Q62MUlrVcNlqnFIQOfw_YiGHinTKb_45 Bug: 880079 Change-Id: I0696786292bec375af9d5326a790700000114559 Reviewed-on: https://chromium-review.googlesource.com/1221474 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592818}
-
Mounir Lamouri authored
Adding a DCHECK() and a null check. Bug: 883329 Change-Id: I56efb844c7cc6788ac04e9f494608ef18e94cd78 Reviewed-on: https://chromium-review.googlesource.com/1236454Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#592817}
-
Josh Nohle authored
The current implementation of DeviceReenroller uses the incorrect callbacks to signal when an enrollment and device sync are complete. Specifically, the ForceEnrollmentNow() and ForceSyncNow() callbacks were used instead of the DeviceSyncClient::Observer callbacks, OnEnrollmentFinished() and OnNewDevicesSynced(). Here, we use to the correct callbacks along with a more appropriate and simplified retry mechanism. Namely, the complete re-enrollment process of enrollment --> device sync --> verification is retried every 5 minutes or until success. Note: The OnEnrollmentFinished() and OnNewDevicesSynced() callbacks might be invoked due to enrollments or device syncs external to the DeviceReenroller class. Regardless of how the functions are called, the two sets of supported software features (from GCM device info and local device metadata) are compared. If they disagree, the re-enrollment process is triggered. Bug: 870770 Change-Id: If33320386cd8ce5d5639082009291b935ec6e471 Tested: Manual and unit tests Reviewed-on: https://chromium-review.googlesource.com/1228311 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592816}
-
braveyao authored
In a recent cl, https://chromium-review.googlesource.com/c/chromium/src/+/1171562, it starts to use singleton to create AcceessibillityRecorder instance. This causes a problem in crbug.com/883136, that because the dtor will never be called, windowns event will still be caught and processed during destuction period, which may randomly crash due to race condition. This cl is to partially revert the changes to stop listening correctly at destruction. Bug: 883136 Change-Id: I1bd8d3e00b23590c222652c15632e33b4e3667e9 Reviewed-on: https://chromium-review.googlesource.com/1234853 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592815}
-
Kevin McNee authored
The embedder has been migrated to Custom Elements V1, so there is no longer any need for Custom Elements V0 to register elements with non-standard names. Bug: 867831 Change-Id: I96a48fcf8560e08c8286081b844be93a3a630159 Reviewed-on: https://chromium-review.googlesource.com/1220036Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#592814}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6fb5c9cdd1b..fd2e62420dba Created with: gclient setdep -r src-internal@fd2e62420dba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie7d505fac21293dd4d8d80608cb28e8755dc9607 Reviewed-on: https://chromium-review.googlesource.com/1235843Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592813}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/985f6fe58181..5e97145328bd git log 985f6fe58181..5e97145328bd --date=short --no-merges --format='%ad %ae %s' 2018-09-20 sadrul@chromium.org trace-viewer: Allow filtering processes. Created with: gclient setdep -r src/third_party/catapult@5e97145328bd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I53f0902ab938016d3e3c60e6638a3efbd0abf7cf Reviewed-on: https://chromium-review.googlesource.com/1235842Reviewed-by:
-
Adithya Srinivasan authored
Moves functionality from content/renderer/fileapi to blink/renderer/modules/filesystem: - Moves most functionality in content::FileSystemDispatcher and content::WebFileSystemImpl into blink::FileSystemDispatcher - Moves all functionality in content::WebFileWriterBase to blink::FileWriterBase - Moves all functionality in content::WebFileWriterImpl to blink::FileWriter and blink::FileWriterSync - Move web_file_writer_base_test.cc to blink - Removes WebFileWriter, WebFileWriterClient, WebFileSystemCallbacks, WebFileError, WebFileInfo, WebFileSystemEntry - Makes AsyncFileSystemCallbacks and FileSystemCallbacks use base::File::Error directly instead of using blink::FileError. Bug: 787281 Change-Id: Iff0ca3e9fe20d0586709c5efbce4cd1cc79c1419 Reviewed-on: https://chromium-review.googlesource.com/1195098Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#592811}
-
Egor Pasko authored
I've got an email suggesting to add a Monorail component for benchmark startup.mobile. I think "Speed>Metrics>SystemHealthRegressions" is the component that best matches the bug target for startup.mobile. The description for this component says: "Any performance regressions detected in the lab, in production or extraneous to automated tool that need a human step .." Bug: None Change-Id: Idf857073114886f00c4772a02643d402997ee9e1 Reviewed-on: https://chromium-review.googlesource.com/1233741Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592810}
-
Antoine Labour authored
This path has been disabled since crrev.com/c/1024703, so remove dead code. Bug: 882513 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2b6e076bd97b62464c3c1d9508827f7ac4be4561 Reviewed-on: https://chromium-review.googlesource.com/1234238 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#592809}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates URLDownloader and the respective unittests away from URLFetcher. BUG=773295 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8abfd9c9d9e66757c555479fe6a153e3dc08b9c5 Reviewed-on: https://chromium-review.googlesource.com/1234635Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#592808}
-
Vaclav Brozek authored
AssemblePasswordForm inside components/password_manager/core/browser/form_parsing/form_parser.cc currently gets a pointer to SignificantFields and checks it for being null. However, it is never called with the pointer being null. To clarify the code, this CL changes the AssemblePasswordForm signature to expect a reference instead. Bug: 883633 Change-Id: I2a81350836074ca60e925a2a0bd28b5fa0169281 Reviewed-on: https://chromium-review.googlesource.com/1235582Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592807}
-
Sylvain Defresne authored
Bug: 809610 Change-Id: Ib9403a5a18424fe37a7a85ab9c3b6ff90e59b614 Reviewed-on: https://chromium-review.googlesource.com/1235719Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592806}
-
Justin Cohen authored
Bug: 766206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifb5996a5491bde08885517ad56a539d73cf60260 Reviewed-on: https://chromium-review.googlesource.com/1235223 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#592805}
-
Boris Sazonov authored
This CL modifies SyncAndServicesPreferences to check off and disable 'Activity and interactions' checkbox if history sync is turned off. The same restriction is already implemented for Autofill and Payments checkboxes, so this CL just uses the existing pattern. Bug: 885356 Change-Id: I40913c0c71dd1b8ad399c81b0031e623c7d74e6d Reviewed-on: https://chromium-review.googlesource.com/1236273Reviewed-by:
-
Alexandre Frechette authored
Simplify logic and code by getting rid of the secondary priority queue that was tracking the times at which ProcessRipeTasks() was scheduled, and replacing it by a simple boolean flag for each delayed task. See https://chromium-review.googlesource.com/c/chromium/src/+/1196844/13/base/task/task_scheduler/delayed_task_manager.h#89 Change-Id: I1ea6312183eaf8fc4ce45c5d668e4e5a13506e11 Reviewed-on: https://chromium-review.googlesource.com/1230694 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592803}
-
Dan Sinclair authored
Roll src/third_party/SPIRV-Tools/src/ 0cd3e599a..6e2dab2ff (3 commits) $ git log 0cd3e599a..6e2dab2ff --date=short --no-merges --format='%ad %ae %s' 2018-09-19 chaoc Add support for Nvidia Turing extensions 2018-09-19 stevenperron Add unrolling to the legalization passes (#1903) 2018-09-17 jaebaek Specified clang-format version in README.md Created with: roll-dep src/third_party/SPIRV-Tools/src Roll src/third_party/spirv-headers/src/ dcf23bdab..d5b2e1255 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/dcf23bdabacc..d5b2e1255f70 $ git log dcf23bdab..d5b2e1255 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 cepheus Fix D -> d typo in previous commit. 2018-09-19 cepheus Add enumerants for six Nvidia extensions: Created with: roll-dep src/third_party/spirv-headers/src TBR=dneto@chromium.org Change-Id: I024cb5917c5b0aaf61110a534ffa7d7b6664ab15 Reviewed-on: https://chromium-review.googlesource.com/1236373Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#592802}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79023740..08b9e376 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0857369ad18bd563030d6f83d3ede03cd12b6743 Reviewed-on: https://chromium-review.googlesource.com/1235896Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592801}
-
Max Morin authored
Make ForwardingAudioStreamFactory hosting the source streams to be aware that it's being captured by a loopback sinks. Notify loopback sinks when the source ForwardingAudioStreamFactory (i.e. WebContents whch owns it) is being destroyed. Bug: 866440,852880,866442 Change-Id: I4a46952cafd378f87ceb7da4a1c1ce27341babd9 Reviewed-on: https://chromium-review.googlesource.com/1221318 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592800}
-
