- 14 Oct, 2020 40 commits
-
-
Ian Kilpatrick authored
Previously when building the constraint spaces we didn't set the fallback inline-size, this prevents the DCHECK: Check failed: orthogonal_fallback_inline_size_ != LayoutUnit(-1) ("-1" vs. "-1") Bug: 1045599 Change-Id: I57261e8390613ddec8ef8c8f85d3b378ff89b478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468707Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#816885}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/095444c21262..0150a791fcb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1b5b6aa2a1e185123425a74f16c118cfd468bdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816884}
-
Austin Tankiang authored
This text, contained in the .xf-panel-text element, can have two different widths depending on the Files Transfer Details flag, so make it flex to fill up the entire space in both cases. Bug: 1137316 Change-Id: Ibea7905e7c764e0e5d1a0caf096fdba427cbb911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467498Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#816883}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ice473442cf6dd2017012ef65d0ab6e2cfef51d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469480Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibb217565c576fb9439e0e127e9da4d4302557cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469717Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816881}
-
Andrey Kosyakov authored
Bug: 1137291 Change-Id: Id9ae17cce017e977adac8d6fee3f2d265f6ad89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468945 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816880}
-
Alexander Alekseev authored
Implemented permanent ScopedAnimationDuration object to persist animation duration changes. Bug: 1137643 Change-Id: Iacaad772114ff4bc262080f809ad37fb009f642a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466841 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#816879}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aa45aa62c3c6..6e970e597b25 2020-10-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I84626fa149dadfc498ef91d0caf88b667f6e5a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469656Reviewed-by:
-
bttk authored
LocationBarCoordinator (LBC) - the public API for location bar. This class implements LocationBar, but is not a View. Interfaces LocationBar.Phone and LocationBar.Tablet are now replaced by LBCPhone and LBCTablet. Interfaces were removed in an effort to reduce the method count. Views LBPhone and LBTablet no longer need to be visible outside of their package. LocationBarLayout can't be hidden, since SearchActivityLocationBarLayout depends on it. Bug: 1133482 Change-Id: I5f8bbc3b8cfd6c896aca41482d3c271be957f352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446826 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#816877}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602590170-40f871c7cd5f95ac04c91a2fc42fd5651e0714b3.profdata to chrome-win64-master-1602622713-d22858ceb9d9ad4a4a6268ac3709afaee3037eec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I803d47b08106b0d66d875130700ea49aa9238b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469698Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602611974-a7265b2715cbc4cd86dbab6cb07ce46a3b6949bc.profdata to chrome-mac-master-1602633476-0a6cb13b3824485740d2ed9816cdaa54debab52e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9f6fce1650a30e3db5f36d2682c9d16760cf470f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469668Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a08dc37d19e5..095444c21262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie3028abd2dd13f30218899df25e41da11d8ae86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469778Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602611974-f7262751d1dc906200528d84bf62f89d4908c5e2.profdata to chrome-linux-master-1602633476-bff3708a6ce1ff631b23d1b618c56f8a3baedfe0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie5a36b737145e367bf5e678f08646da2518749ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470116Reviewed-by:
-
Taylor Brandstetter authored
Bug: chromium:1025302 Change-Id: Iadbcb87f0f3f3a1845e925aed8f52685d78e740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108066Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#816872}
-
Brian Sheedy authored
Enables the GPU pixel test on the ARM-based Mac DTKs now that we can keep the results separate in Gold and the crashing we were experiencing in the Telemetry-based tests on these devices has been fixed. Bug: 1113308 Change-Id: I1fb5f52d33eecf45b38873777126abfd44170415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468287 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816871}
-
Toby Huang authored
This CL adds 9 UMA histogram metrics for the number of installed apps and extensions. At most once a day and when the user signs out, the number of recently used apps is summed up in a snapshot and uploaded to UMA. This CL also reports the number of installed and enabled non-component browser extensions and themes, regardless of when they were last used. Bug: 1110557 Change-Id: Ia0b7c180581b040fe77929d545ae46383576afca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350543 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#816870}
-
My Nguyen authored
Update as per http://go/cros-lang-settings-ux-writing Screenshot view: http://screen/9F2Fojjr8QvdVjL Bug: 1113439 Change-Id: I1f5ce8b827770a1d172bd4052e82670e3e868122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469916Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#816869}
-
Wenyu Fu authored
Due to issues in Android ViewPager, screen reader can lose a11y focus sometimes when switching between pages. As work around, this CL adds an interface for each FirstRunFragment to specify a11y focus when each page is populated on the screen. Bug: 1094064 Change-Id: I44a3162834744980bc0a2a72c192b465d3c2211f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458880 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#816868}
-
Jamie Madill authored
Also separates out GLES 1 tests into its own definition. Bug: angleproject:5124 Change-Id: Id0936d7b5e835ac48f621df2ac0620b40e3e70a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469518Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#816867}
-
Nicholas Verne authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/16aafbd27d09..ebddc236e489 $ git log 16aafbd27..ebddc236e --date=short --no-merges --format='%ad %ae %s' 2020-09-29 nverne permission_broker: separate lifeline_fd for usb driver tracking. 2020-10-05 acostinas system_api: Go proto bindings for patchpanel 2020-10-08 yich cryptohome: add has_reset_lock_permissions in RPC 2020-10-05 yichengli system_api: Add method name to cancel user authentication dialog 2020-09-16 vovoy system_api: Rename GetMemoryMarginKB to GetMemoryMarginsKB 2020-09-23 yhong system_api: append USB removable info in runtime_probe's D-Bus response Created with: roll-dep src/third_party/cros_system_api Bug: 1128866 Change-Id: Ia13ad55a3c3ebb514533634e77d7e11f5c33a1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469339 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#816866}
-
Rakib M. Hasan authored
Several web platform tests do not have physical files checked into the WPT repository. Instead they are generated and mapped to test harnesses checked into the WPT repo. When those test harnesses are deleted then we should delete all tests mapped to those files. Only affects the behavior of the script when --clean-up-affected-tests-only is used. Bug: 1050760, 1110003, 801357 Change-Id: Id1c30b096c73974ed0ded2d74284fbe43005ee0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439417 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#816865}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e2893f2df8b2..6b8b2ea6be63 2020-10-14 mtklein@google.com move cfi stifle post-refactor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1137652,chromium:1137958 Tbr: robertphillips@google.com Change-Id: I2878b278e9687861fde17b195722628f90c95e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469702Reviewed-by:
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //extensions/browser/api. R=karandeepb@chromium.org, rockot@google.com, shend@chromium.org, tbarzic@chromium.org Bug: 1113033 Change-Id: I93f0000e3d7c657eddb8b077df18b26e01245dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468712 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#816863}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1f28a40. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3c18112d8fa6fa2c11f93b2e4f19c3eb138ef326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469816Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816862}
-
Tomasz Tylenda authored
This changelist tackles code locations where the caller explicitly requires base::RepeatingCallback (or RepeatingClosure). BUG=764795 TESTED=build Change-Id: If4ab805076529ffbe76443849761bacda2b724af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463051Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#816861}
-
Pilar Molina Lopez authored
Change expiration date of histograms: ConfigureDisplays.External.Modeset.Resolution ConfigureDisplays.Internal.Modeset.FinalStatus ConfigureDisplays.Internal.Modeset.RefreshRate Bug: 1130632,1121213 Change-Id: Ieb934bb15f48495f7832376d2b58fd5d875b2a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457046Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#816860}
-
Lukasz Anforowicz authored
content::PepperPluginInstance::Navigate was never called or referenced. Therefore, this CL removes this method and its overrides. Bug: 1064652 Change-Id: I20301b34f2d4775205cd9cedcf100457996966ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463852 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#816859}
-
Kenichi Ishibashi authored
The helper function can be replaced with BindLambdaForTesting. Using BindLambdaForTesting allows us to use references instead of raw pointers for out parameters. Bug: N/A Change-Id: I864cbb4a74054fe53d1c45c937d7b25f06b7222b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469919 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816858}
-
Sunny Sachanandani authored
TBR=zmo@chromium.org Bug: 1136971 Change-Id: I7cdb1c6e93f36a53a1e650ad2a1aff5da963adbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469899Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#816857}
-
Weilun Shi authored
This is a no-op for histogram generation but it brings a huge benefit for us to migrate suffixes to patterned histograms. i.e. '.' in the string placeholder is not supported in string.format(). This is generated by a script: histogram_suffixes.setAttribute('name', histogram_suffixes.getAttribute('name').replace('.', '_')) Bug: 758782 Change-Id: Ie0315911fc1d635fd5c697c198c013ee7a88037b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466900 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by: -
Jamie Madill authored
This forces the test suite off of some one-off Android configs and some Linux configs. Re-enables the test suite on AMD 550 RX because it seems to be passing without issues. Bug: angleproject:5124 Change-Id: If36a2dd72499e852ff41041a2495f1f47bd02213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469956 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Alan Cutter authored
This reverts commit 2dbccf3e. Reason for revert: Flaky crashes on bots. external/wpt/webxr/xrStationaryReferenceSpace_floorlevel_updates.https.html STDERR: #4 0x55ea51c21abc blink::XRSession::UpdatePresentationFrameState() Bug: 1138047 Original change's description: > WebXR: add recommendedViewportScale > > This uses an estimated GPU utilization ratio from ArCoreGl. The goal is > to reduce the recommended viewport scale if the web app is unable to hit > a target framerate due to excessive GPU work, but not do so if it's slow > due to excessive JS computations or similar where reducing the viewport > wouldn't help. This is opt-in, the scale only takes effect if the app > calls view.requestViewportScale(view.recommendedViewportScale) followed > by xrwebgllayer.getViewport(view). > > (Dynamic viewport scaling is only available if WebXRIncubations is > enabled.) > > Spec link for context: > https://immersive-web.github.io/webxr/#dom-xrview-recommendedviewportscale > > Change-Id: I0a8598d8bd03f27fd1d2cc6c542ff79812825d74 > Bug: 1133381 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213113 > Commit-Queue: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816813} TBR=sammc@chromium.org,klausw@chromium.org,bialpio@chromium.org,elalish@chromium.org Change-Id: Ic34275b3c147c9428d7d57c1a876a91b172bc586 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469640Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816854}
-
Weilun Shi authored
Add suffixes_to_varaints.py to support migrating all histogram_suffixes to new patterned histograms. The script currently only handles the simplest case, i.e. Suffixes with only one affected histogram to migrate to inline histograms. Bug: 758782 Change-Id: I32905df5df5d00310c3029674a95d2705dab2f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464207Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5458f6cbefc1753e8ef1ec884409d48d5cc1f1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469660Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a08dc37d19e5..095444c21262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I18465497dc89bdc231b01a9ba959a4714b7b59ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469402Reviewed-by:
-
Hiroki Sato authored
CL:2398438 changed the focus handling in ARC++ accessibility and when a user visits various windows in the same task, it intended to remember the last focused node for each window. However, there is a bug. ArcAccessiblityHelperService allocates chrome node id to each node and window, and that id is different if the root window id is different. As Android accessibility framework exposes only visible windows, even in the same task, the same chrome node id can be reused because visible root window can easily changes in a task. Thus, we should not have used chrome id to remember the last focused node, instead, we should use the android side window id. This change fixes the above issue. AX-Relnotes: n/a. Bug: b:169201305 (Initial focus issue in TextEditActivity) Test: tast arc.AccessiblityEvent (without CL:2467224) Test: unit_test AXTreeSourceArcTest Change-Id: If55058d9d66a636d54b73d3cd92a4bd2b5fea214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467738Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#816850}
-
Fergal Daly authored
Now, when the current frame is not live, creating a new frame for navigation also calls CommitPending to immediately commit the replacement. This happens when the current frame is - crashed - the very first main frame of the frame tree and navigation is requested before it becomes live, e.g. in a test that immediately navigates. This CL only addresses the crashed case. Support for this path has been causing various issues over time (most recently for RenderDocument, COOP/COEP, and bfcache), so removing it will make the navigation logic simpler and easier to reason about. The most complex part of this is handling the corner case of the commit failing. Things going on in this CL: - skip the early commit if requested - reset RenderViewHost's main frame back to the crashed frame if the navigation fails - reenable CrossOriginOpenerPolicyBrowserTest.CoopPageCrashIntoCoop - move ShouldCreateNewHostForCrashedFrame so that this feature can depend on it - handling the sad-tab We already have half of the desired behavior of not sitting around on a sad tab during slow navigations via SadTabHelper::RenderViewReady(), which clears the sad tab whenever we reinitialize the RenderView while showing the sad tab. Switching that to observe RenderFrameCreated should let us clear the sad tab on any new navigation, as well as edge cases where the renderer process might be reinitialized by a renderer debug URL. Cancelling the navigation also behaves sanely: it returns to a sad tab while updating the omnibox to show the previous URL. This is a port of https://crrev.com/c/2409886 that does not rely on the refactoring. Bug: 1072817 Change-Id: I3468c84f73354e4f0ad9bd747290feffe3349978 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426086Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Previously RasterContextProvider kept raw pointers to SharedImageInterface and ContextSupport interfaces. These pointers were also passed to OutputMailbox instances, which may outlive the decoder. There as nothing to guarantee that OutputMailbox doesn't outlive the SharedImageInterface implementation. Updated the decoder to use a ref-counted pointer to RasterContextProvider interface. This allows to ensure that SharedImageInterface is not destroyed before the OutputMailbox instances that depend on it. Bug: 1133325 Change-Id: I60b664d89207535d968cf998488457c789c800c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441935Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816848}
-
Jorge Lucangeli Obes authored
Per the original design doc, the fd passed to the remote end needs to be the *read* end of the pipe: https://docs.google.com/document/d/1m5NKwLRleJUoZppKva4QLpnHRYFBBCd280IFHhgqhVg/edit int pipe_fds[2]; int ret = pipe(pipe_fds); // Write end of the pipe. int lifeline_local = pipe[1]; // Read end of the pipe. This gets passed as |lifeline_fd|, // wrapped as a D-Bus fd type. int lifeline_remote = pipe[0]; Bug: 1135721 Change-Id: Ia7eed8a47b63662c235078fe9b470215e030ebf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466151 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816847}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc2dd313cf94..ad80b184a00d 2020-10-13 jmadill@chromium.org Test Runner: List tests explicitly without GTest. 2020-10-13 syoussefi@chromium.org Vulkan: Fix command reordering on release to external 2020-10-13 Kyle.Griffiths@imgtec.com Add PowerVR Vendor ID & Vulkan GL Line Emulation Exclusion 2020-10-13 bsheedy@chromium.org Update IsARM64 2020-10-13 jmadill@chromium.org Broaden Clear test failure to all OSX. 2020-10-13 jmadill@chromium.org Capture/Replay: Embed ANGLE version in replay. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132295,chromium:1135792,chromium:1136367 Tbr: ynovikov@google.com Change-Id: I372c655b6b085cfe47cf26db6cf14e5959d37d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469661Reviewed-by:
-
