GitLab

After we changed most of the oilpan bots to be named
"non-oilpan", we started getting an error because the
experimental linux_blink_oilpan_rel bot on
tryserver.chromium.linux did not get renamed on the
waterfall but did get renamed in mb_config.pyl .

Changing the bot name on the waterfall is somewhat annoying,
so for the moment we'll change the entry in MB instead.

TBR=haraken@chromium.org
BUG=587322
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_blink_oilpan_rel

Review URL: https://codereview.chromium.org/1701303003

Cr-Commit-Position: refs/heads/master@{#376059}

BUG=561584

Review URL: https://codereview.chromium.org/1703323002

Cr-Commit-Position: refs/heads/master@{#376058}

Set the target API for the class to 21 (lollipop) which is what is supported
by updatable webview. This prevents us individually suppress lint messages.

BUG=

Review URL: https://codereview.chromium.org/1704263002

Cr-Commit-Position: refs/heads/master@{#376057}

BUG= internal b/27226258

Review URL: https://codereview.chromium.org/1711563002

Cr-Commit-Position: refs/heads/master@{#376056}

BUG=384723
R=dmazzoni@chromium.org
TESTED=browser tests, using Jaws

Review URL: https://codereview.chromium.org/1695673004

Cr-Commit-Position: refs/heads/master@{#376055}

Calling IOSurfaceLock() followed by IOSurfaceUnlock() appears sufficient.

BUG=584760

Review URL: https://codereview.chromium.org/1709443002

Cr-Commit-Position: refs/heads/master@{#376054}

Use the non-linearized PDF code path if the server doesn't respond to range
requests with a partial response. Previously, Chrome entered a request loop if
the PDF was linearized and the server advertized byte range support but
responded with a 200 code instead of 206.

BUG=587502
R=thestig@chromium.org
TEST=Load https://www.usenix.org/legacy/publications/library/proceedings/sec96/full_papers/goldberg/goldberg.pdf

Review URL: https://codereview.chromium.org/1705353002

Cr-Commit-Position: refs/heads/master@{#376053}

Also, make sure that test objects inherit the versions from the parent.

BUG=578890

Review URL: https://codereview.chromium.org/1698043005

Cr-Commit-Position: refs/heads/master@{#376052}

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

A test was imported from csswg-test and was marked as failure. This
patch makes the test pass.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-parsing-001.html

Review URL: https://codereview.chromium.org/1696373003

Cr-Commit-Position: refs/heads/master@{#376051}

BUG=587669
TBR=dcheng@chromium.org, reillyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1705353003

Cr-Commit-Position: refs/heads/master@{#376050}

Certain drivers, particularly Mac drivers and ANGLE when running on the
D3D11 backend do not support timestamp queries despite implementing an
extension that has them in the specification (ARB_timer_query and
EXT_disjoint_timer_query). To indicate this, the driver returns 0 when
queried for the size of the timestamps they return using glGetQueryiv.
Additional logic was added to the GPUTimingImpl class to check for that
when using those extensions and to fall back to the time elapsed query
implementation of timestamps if the driver does not have native support.

BUG=587173
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1687353002

Cr-Commit-Position: refs/heads/master@{#376049}

When onStartCommand() is called, it is possible that the intent is null.
According to the SDK page, service must take care of the null check.

BUG=587399

Review URL: https://codereview.chromium.org/1708913002

Cr-Commit-Position: refs/heads/master@{#376048}

BUG=587664
TBR=tbansai@chromium.org, thestig@chromium.org, reillyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1708043002

Cr-Commit-Position: refs/heads/master@{#376047}

Previously, the panel caused some flakeyness in the interactive ui tests. Try re-enabling again.

Review URL: https://codereview.chromium.org/1711483003

Cr-Commit-Position: refs/heads/master@{#376046}

BUG=586056
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/1705243002

Cr-Commit-Position: refs/heads/master@{#376045}

The automation functions exponentialRampToValueAtTime,
setTargetAtTime, and setValueCurveAtTime were not correctly updating
the .value attribute of the AudioParam.  For the first two methods,
the computed value was one frame too far into the future.  For last
method, the return value was always the last curve element, which is
wrong.

BUG=574905
TEST=audioparam-update-value-attribute.html

Review URL: https://codereview.chromium.org/1695573002

Cr-Commit-Position: refs/heads/master@{#376044}

Reland of Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access. (patchset #1 id:1 of https://codereview.chromium.org/1694093002/ )

Reason for revert:
This revert was not the culprit CL. Reverting the revert.

Original issue's description:
> Revert of Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access. (patchset #2 id:20001 of https://codereview.chromium.org/1677363002/ )
>
> Reason for revert:
> Perf failures. Speculative revert to see if it fixes.
>
> BUG=586581,574802
>
> Original issue's description:
> > Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access.
> >
> > R=inferno@chromium.org, mbarbella@chromium.org, ochang@chromium.org, tkent@chromium.org
> > BUG=574802
> >
> > Committed: https://crrev.com/ad618c3357e189fb685ea88fe4b8b25ac34f2c75
> > Cr-Commit-Position: refs/heads/master@{#374424}
>
> TBR=mbarbella@chromium.org,ochang@chromium.org,tkent@chromium.org,mmoroz@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=574802
>
> Committed: https://crrev.com/64cb1f5327522142c658100746f34f8a012a45fa
> Cr-Commit-Position: refs/heads/master@{#375389}

TBR=mbarbella@chromium.org,ochang@chromium.org,tkent@chromium.org,mmoroz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=586581,574802

Review URL: https://codereview.chromium.org/1708703003

Cr-Commit-Position: refs/heads/master@{#376043}

BUG=

Review URL: https://codereview.chromium.org/1711503002

Cr-Commit-Position: refs/heads/master@{#376042}

tcmalloc was disabled in crrev.com/1668643002 - and from that point on,
the WebKit valgrind bot was continuously red. Reverting to see if that
ameliorates the issue.

Revert "Disable tcmalloc when building for valgrind"

This reverts commit 65aeea27.

BUG=582398
R=thakis@chromium.org
TBR=bratell@opera.com, thestig@chromium.org, reillyg@chromium.org, primiano@chromium.org

Review URL: https://codereview.chromium.org/1707983002

Cr-Commit-Position: refs/heads/master@{#376041}

BUG=488195

Review URL: https://codereview.chromium.org/1708683003

Cr-Commit-Position: refs/heads/master@{#376040}

New functions have been added so a sync token can represent
multiple resources at once. Adding a single sync token at
the end of generating a multitude of resources can be a win.

The most obvious use cases of this is the video layer which
generates a resource for each layer. A single sync token is
now generated at the end of the layer generation.

The layer tree UI resource also generates its own sync token.

BUG=584381
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1707143002

Cr-Commit-Position: refs/heads/master@{#376039}

deqp/functional/gles3/negativeshaderapi.html failing on Linux/Release as
well.

R=zmo@chromium.org,kbr@chromium.org
BUG=483282

Review URL: https://codereview.chromium.org/1707803003

Cr-Commit-Position: refs/heads/master@{#376038}

deqp_functional_gles3_buffercopy is flaky on the Win8 release nvidia bot.

R=zmo@chromium.org,kbr@chromium.org
BUG=587601

Review URL: https://codereview.chromium.org/1704163002

Cr-Commit-Position: refs/heads/master@{#376037}

Adds the new argument, stores the list of origins for which to intercept
requests, and adds origin checks to the interception code. Also updated the
various unit and layout tests.

This implements (parts of) the changes to the spec made in
https://github.com/mkruisselbrink/ServiceWorker/commit/88bbe9324fa8ac38d8af3e347564450d598757aa

BUG=540509

Review URL: https://codereview.chromium.org/1656933003

Cr-Commit-Position: refs/heads/master@{#376036}

BUG=None

Review URL: https://codereview.chromium.org/1641893003

Cr-Commit-Position: refs/heads/master@{#376035}

This CL adds support for always encoding all images within SkPicture to
WebP. On the decoding side it also assumes that the input will be WebP.

The pixels from Skia are premultiplied, but the import functions available
from WebP only supports un-premultiplied data, so the code unpremultiples
the values during the encoding step. Also, the quality and method
configuration is hard coded since any change in it would change the
hash of the data.

Also, the alpha-channel is always used, since the WebP encoder will
optimize the alpha-channel if all values are 255.

BUG=577262

Review URL: https://codereview.chromium.org/1680333004

Cr-Commit-Position: refs/heads/master@{#376034}

Prior to this change, when the last js reference to an IntersectionObserver went away, and there were no js references to the callback function, the callback would disable itself.  The observer and its callback should stay alive as long as there are still target Elements being observed.

BUG=586957,587299
R=adamk@chromium.org,haraken@chromium.org

Review URL: https://codereview.chromium.org/1707913002

Cr-Commit-Position: refs/heads/master@{#376033}

The main motivation is to stop network failure error spew in DevTools console.
This patch reinstates the "pause on download" functionality we once had.

BUG=541797

Review URL: https://codereview.chromium.org/1675613002

Cr-Commit-Position: refs/heads/master@{#376032}

This patch clips the source rect to the image rect. If the source rect
falls outside of the image rect, then we still allocate enough memory
for the original source rect, although we don't read the pixels into
it, which results in us eventually using uninitialized memory.

R=enne
BUG=585698
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee
Cr-Commit-Position: refs/heads/master@{#374963}

Review URL: https://codereview.chromium.org/1691623002

Cr-Commit-Position: refs/heads/master@{#376031}

Since we added udev to the sysroot /usr/lib/pkgconfig
now already exists (previously only /usr/lib/<arch>/pkgconfig
existed) so simply using 'mv' to rename the directory
is no longer enough.

BUG=561584

Review URL: https://codereview.chromium.org/1699353002

Cr-Commit-Position: refs/heads/master@{#376030}

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

This CL to start using this is https://codereview.chromium.org/1655083002/

BUG=533630

Review URL: https://codereview.chromium.org/1689043002

Cr-Commit-Position: refs/heads/master@{#376029}

Any test which runs on the main waterfall should run on debug and release. Otherwise a dcheck could be hit which wouldn't show up on the main waterfall, but would fail on the trybots which use release-with-asserts.

BUG=478244

Review URL: https://codereview.chromium.org/1705883002

Cr-Commit-Position: refs/heads/master@{#376028}

Only scan for wifi networks when the user is trying to pick a wifi
network.

BUG=587301

Review URL: https://codereview.chromium.org/1704803002

Cr-Commit-Position: refs/heads/master@{#376027}

In crrev.com/1434453008 we changed the internal format for images
from R8 to RED but we forgot to change glCopyTextureCHROMIUM internal
format validation.

This breaks video to WebGL on GL Core Profile since APPLE_ycbcr_422 is
not avaiable, we fall back to three R8 planes, and we then fail to validate
RED as internal format.

BUG=587158
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1703153002

Cr-Commit-Position: refs/heads/master@{#376026}

Mac currently has a separate path to enable/disable scroll animations in
Blink. Instead of using the existing Blink setting for scroll animations,
ScrollbarThemeMacCommon sets a flag scrollAnimationEnabledForSystem which
is then checked along side the Blink setting. A side-effect of this is
that --(disable|enable)-scroll-animator doesn't work on Mac and layout
tests default to scroll animations disabled with no way to turn them on.

This patch removes the scrollAnimationEnabledForSystem flag and instead
unifies this setting with how it's handled on other platforms. When Blink
settings are computed, the OSX setting is queried and set into the usual
enable_scroll_animator setting. Changes to the OSX setting cause the
browser process to recalculate and apply new Blink settings.

This allows layout tests to use internals.settings.setScrollAnimatorEnabled
to allow testing of scroll animation semantics on Mac.

BUG=

Review URL: https://codereview.chromium.org/1653003002

Cr-Commit-Position: refs/heads/master@{#376025}

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::AllowThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937

Review URL: https://codereview.chromium.org/1696233002

Cr-Commit-Position: refs/heads/master@{#376024}

This CL:
- adds support for [Sync] attribute;
- generates C++ sync method signatures;
- does the simplest thing to block and wait for results of sync calls. (Allows
  any messages of the same interface ptr to re-enter; disallows any messages of
  other message pipes to re-enter.)

The following will be in future CLs:
- Change the re-entrancy behavior.
- Support sync calls with associated interfaces.

BUG=577699

Review URL: https://codereview.chromium.org/1701423002

Cr-Commit-Position: refs/heads/master@{#376023}

Removing extraneous call to center(), which after latest Polymer roll (rev 374191)
started messing up the dialog position.

BUG=586599

Review URL: https://codereview.chromium.org/1705603002

Cr-Commit-Position: refs/heads/master@{#376022}

Revert of exo: Default pointer surface. (patchset #1 id:1 of https://codereview.chromium.org/1696533003/ )

Reason for revert:
This workaround is no longer needed.

Original issue's description:
> exo: Default pointer surface.
>
> BUG=
>
> Committed: https://crrev.com/85823af3165670d39e0a334e9b44d6dfa62f7ee6
> Cr-Commit-Position: refs/heads/master@{#375501}

TBR=elijahtaylor@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review URL: https://codereview.chromium.org/1705343002

Cr-Commit-Position: refs/heads/master@{#376021}

BUG=587282

Review URL: https://codereview.chromium.org/1708743002

Cr-Commit-Position: refs/heads/master@{#376020}