GitLab

Now that |low_entropy_provider| is used later in
VariationsFieldTrialCreator::SetupFieldTrials(),
VariationsFieldTrialCreator::CreateTrialsFromSeed() shouldn't
own |low_entropy_provider|.

Bug: 1138603
Change-Id: I53ba8d2b7160bd3c9f02e92af4bd53ca72c63f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525856
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826023}

This CL is fixing the DCHECK for GetSubstringBounds(...) which
was detected to fail sometime on albatros build.

1) Use IsBoundedBy(...) instead of Contains(...)
   The first problem was cause by the range [end,end) which is
   not considered to be part of the range (a.k.a Contains(....) will
   return false). IsBoundedBy accepts the empty ending range to be
   part of the range.

2) Some eliding behaviors may break the mapping between text indexes
   and display text indexes. The new check implementation is ensuring
   that eliding is not causing any invalid offsets.

We are expecting clusterfuzz to hit these DCHECKs until it's fixed.

R=gab@chromium.org, msw@chromium.org

Bug: 1146674, 1085014
Change-Id: I219ef476009fc85edb7b836d5143022f51ecb8e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521252Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826022}

Currently, when a H264 chunk cannot be converted to a DecodeBuffer, we
return a nullptr. This means that conversion errors are reported as
"null or empty" decoder buffer errors.

This CL fixes the issue by surfacing a media::Status along with the
nullptr.

Bug: 1139089
Change-Id: I018715b56f65b96e843e6af19c9b8300b73b1f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523750
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826021}

Framework has a bug which causes a exception in a race condition,
the exception make the app crash.

This patch catches this specific exception to prevent crash.

Adds a new set of tests for NotificationTask, its subclasses and
PlatformAPIWrapper to verify the capture exception working
correctly.

Bug: 1131430
Change-Id: Ia6ef93c47421700c0e52b1de267c6be00d0dd51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521224Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826020}

https://chromium-review.googlesource.com/c/chromium/src/+/2523674
introduced a Finch feature for showing Safety Tips on Safe Browsing
delayed warnings. In that CL, I neglected to update one spot where the
new feature should be checked: for computing the security level of a
page when a Safety Tip is showing. This CL fixes that bug and adds a
test.

Bug: 1146471
Change-Id: I69e794fb2a2c087855bce9c43694620efe490336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529949Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826019}

Adds support for provider selection for signed out
users by storing their selection in a pref.

Change-Id: I8f2016556542007e634ef450f1a9fb1f766af33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523560Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826018}

Some aar files (e.g. androidx) that chrome depends on contain a lint.jar
file and/or a annotations.zip file. The lint.jar file includes custom
android lint checks. The annotations.zip file contains @IntDef and other
annotations needed for lint checks that are usually available by source
but are not available in aars.

By using these files, we can make our existing lint checks more
comprehensive as well as benefit from lint checks by the aar library
authors.

See newly ignored checks in lint-baseline.xml which is updated in this
CL as an example. Actually fixing these errors is left for future CLs
in order to enable them quicker and avoid unnecessary relands.

Bug: 1078229
Change-Id: I3a8e67a9c41b8e8fbe339632f795b2aaab63456e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510793
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826017}

This change expands the Trust Tokens browser tests to cover additional
signing-related cases:

- issuance and redemption against one issuer, then signing against a
different issuer  -> should fail
- signing includes timestamp header if requested
- gamut of signRequestData parameter: `omit` should lead to no
signature, `headers-only` to signature over SRR, ...
- non-OK header in additionalSignedHeaders -> should error

Previous changes (crrev.com/c/2308860, crrev.com/c/2309007) added more
tests covering issuance and redemption.

Bug: 1071293
Change-Id: I702e0f3e3d17c703239e66781af2c64bc0cb0fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308866Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826016}

Needed because of the generated file
components/translate/content/common/translate.mojom.h,
which is included in a public dep here:
https://source.chromium.org/chromium/chromium/src/+/master:components/translate/content/browser/BUILD.gn;l=21

Bug: 1147383
Change-Id: I515742ab54905755c9f40ea30ad64fb1f61d78d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530203Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826015}

Roll Chrome Win64 PGO profile from chrome-win64-master-1604998756-dde3841da8adecb7243697161fbddafddb9cdeef.profdata to chrome-win64-master-1605020074-68960f639156f9ccbd07438455ce3664424ac683.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I7969ebffaa34d6de5744654c37cbc085f87280d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529198Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826014}

Disable virtual input tests for chrome_all_tast_tests

Bug:1147607

NOPRESUBMIT=true

NoTry: True
Tbr: shengjun@chromium.org
Change-Id: I53cb09bab71d0019037344f0a03c03715253f443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530652Reviewed-by: Yu Han <yuzhehan@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826013}

and <files-icon-button>

Bug: 1133186
Change-Id: Iadbe0630cf2398c41c2a1eb2a50851528543b6bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526893Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826012}

R=dmazzoni@chromium.org

Change-Id: Id32a26c536542f0aa80da6471cb1f801230554a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530745Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826011}

Lacros uses wayland server-side cursors, via the wayland protocol
extension zcr_cursor_shapes. That extension is ash/exo-only. As an
optimization, lacros skips loading cursor assets for cursors where
it knows it will use server-side cursors. See
https://chromium-review.googlesource.com/c/chromium/src/+/2516972

However, if you run an ozone/wayland/linux build against ash/exo as
the wayland server, the cursor factory will load the cursor asset,
but WaylandWindow will not use it. This trips a DCHECK.

This only affects developers. In production, ozone/wayland/linux
does not run against ash/exo. Likewise, lacros always runs against
ash/exo.

Avoid the DCHECK by explicitly limiting server-side cursor use to
lacros builds with ifdefs.

Bug: 1147529
Change-Id: Icf99271278e304fd357d6e69b7289cf66fe151a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530258Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826010}

StartWebEngineForTestsInternal() was previously including an empty
string from CommandLine's argv[0] in the component launch_info.
While WebEngine ignored this, it is technically incorrect and would
fail if copied for some other components.

Also update comments and other terminology related to switches and
arguments. Specifically, CommandLine's "args" does not include switches,
which means GetArgs() cannot be used for this.

Change-Id: Icb1944bfc92405664f973d126cab0c543b42ac4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511750Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826009}

Bug: 1146151
Change-Id: I11e43077984753aa8bbae25abd7841e2fa862500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530200Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826008}

This CL introduces MediaStreamTrackGenerator, a specialized
version of a MediaStreamTrack that exposes a writable stream
that allows applications to produce frames.
In terms of the model presented by the Media Capture and Streams
spec [1], this allows creating a track with a custom source.

[1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings

Bug: 1142955
Change-Id: I5f2a4426174aef50bdc6fe6a2bcec2268702932a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524321
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826007}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f1da47d0..2dbcdc10

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3d6e06defecd6a2af22c51eb6d2788c7f35160b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530255Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826006}

A previous CL added support for creating text attachments using query
parameters to chrome://nearby. This CL expands that support to allow
passing file paths to be shared, e.g.
chrome://nearby/share?file=/path/to/file1.png|/path/to/file2.jpg

Bug: 1145684
Change-Id: Ie8fb9aa6ec82404393045a7ee1d52597572f5f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530261Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Curt Clemens <cclem@google.com>
Cr-Commit-Position: refs/heads/master@{#826005}

R=mpearson@chromium.org

Bug: None
Change-Id: Ia99bd611c2ec48277be2dc1a6b8986319f0997fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462684
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826004}

This CL adds the implementation and tests for the Move function, which
rounds out the functions in the Tab Groups API.

Bug: 1106846
Change-Id: If943b628272aed06b700162dab85ccab4091b842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419754
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826003}

TBR=droger@chromium.org

Bug: 1145565
Change-Id: Ie2460e40a2ccafcee3116d667797a1ac8518d10e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529875
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826002}

Add several more unit tests to LorgnetteClientManager to cover the more
complex cases which haven't been covered yet. These mostly involve
successful end-to-end scans, as well as one failure for a scan which
started successfully but failed before completing.

Bug: b:169573779

Change-Id: Ib19c997250731aa097a2032b83e60d8fd2d49ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523435Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826001}

This change makes the QR scanning dialog on Android use an XML layout,
which is the more common and flexible method. It adds a checkbox for
whether to link the device, but that's not wired up yet.

BUG=1002262

Change-Id: I89b0e72f750900516266a896c6e32dc2b042b171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521832
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#826000}

When calling setInitialOverviewState(), it shouldn't check whether
Instant Start is enabled, but check whether the state has been set or
not.

Bug: 1137963
Change-Id: Ib1e099a1409291002eef962346dbb97d048f14e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514462
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825999}

This fixes the issue of too big scale for will-change:transform layers
by
- Partly reverting crrev.com/c/2447650 to apply the change on tiny
scales only. When the ideal scale is not tiny, use the original policy
to clamp minimum scale to the native scale.
- Increasing kMinScaleRatioForWillChangeTransform from 0.1 to 0.25 to
reduce memory and number of tiles when the scale is bigger than ideal,
from 100x to 16x in worst cases.

Bug: 1146393
Change-Id: Ida5720f5126648c2fad0b9921781714fa006d346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527733Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825998}

This test prematurely destroys the NavigationCoordinator, which flakily
leads to crashes when finishing the Activity after the test runes.

Bug: 1147553
Change-Id: I53adfc8c822b36b5124b31d366eed848fe5ffd71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530132Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825997}

These regression tests are for CL crrev.com/c/2517532.

Bug: 1143189
Change-Id: Ieee413a484e7acd89836a87609682ce84f53abb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519056Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Side Yilmaz <sideyilmaz@google.com>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825996}

This cl annotates the SceneChangeObserver interface as deprecated to
avoid new usage.

Bug: 110846
Change-Id: I5b562b9100c4b674f4f6cd9197f2a41322d47c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529697Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825995}

Adding support for dynamic generation of guids: when values are
specified as 'uuid5:name', midl.py will substitute the values with
generated dynamic guids using the uuid5 function. The uuid5 function
generates a guid based on the SHA-1 hash of a namespace identifier
(which is the guid that comes after 'PLACEHOLDER-GUID-') and a name
(which is a string, such as a version string "87.1.2.3").

For instance, when |dynamic_guid| is of the form:

"PLACEHOLDER-GUID-158428a4-6014-4978-83ba-9fad0dabe791=uuid5:88.0.4307.0
,"
"PLACEHOLDER-GUID-63B8FFB1-5314-48C9-9C57-93EC8BC6184B=uuid5:88.0.4307.0
"

"PLACEHOLDER-GUID-158428a4-6014-4978-83ba-9fad0dabe791" would be
substituted with uuid5("158428a4-6014-4978-83ba-9fad0dabe791",
"88.0.4307.0"), which is "64700170-AD80-5DE3-924E-2F39D862CFD5". And
"PLACEHOLDER-GUID-63B8FFB1-5314-48C9-9C57-93EC8BC6184B" would be
substituted with uuid5("63B8FFB1-5314-48C9-9C57-93EC8BC6184B",
"88.0.4307.0"), which is "7B6E7538-3C38-5565-BC92-42BCEE268D76".

TODO: The custom proxy/stub file ("_p.c") is not generated correctly for
dynamic IIDs (but correctly if there are only dynamic CLSIDs). The
proxy/stub lookup functions generated by MIDL.exe within "_p.c" rely on
a sorted set of vtable lists, which we are not currently regenerating.
At the moment, no project in Chromium that uses dynamic IIDs is relying
on the custom proxy/stub file.

So for now, midl.py will ignore the generated proxy/stub file from the
directory comparisons if |dynamic_guids| is prefixed with
"ignore_proxy_stub,".

Bug: 1109612
Change-Id: I179f67769a33644b06332bd5654a8ca8ebc385fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518098Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825994}

The gRPC client can be destroyed (and set nullptrby ::Destroy) while
the input method observer for focus events is still observing the page.

Bug: internal b/172272826
Test: manual on device
Change-Id: Ia2ddcf47ecd6b46a13d05a672f88a63a61b6ced5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529616Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825993}

Hide routine result list by default and expose "See/Hide Report" once test is in progress.

http://screen/BxhEBkxR2wGQbm9

Bug: 1125150
Test: browser_tests --gtest_Filter=DiagnosticsApp*
Change-Id: I1e1a57c22b629289a25f4f9af2d469c374d458c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527755
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825992}

Previously, if a safe browsing error triggered by an extension request
it would result in an invisible interstitial, and cause the extension
to hang. This removes the interstitial so the flagged request gets
cancelled, but the extension doesn't hang.

There was discussion in the bug about adding an API similar to the
one in WebView so the extension can react to the SB flagged request
and decide to bypass it or cancel it. This CL does not implement that,
just fixes the immediate bug.

Bug: 1036603
Change-Id: I0ae89bd9e8e09eb0956d3afab606d90738392c31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527534Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825991}

This avoids getting a newly created ContextImpl from every call to
Context.createContextForSplit().

Bug: 1126301
Change-Id: I080841b697e2f28000d2a4d11ff197a015a1dca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527852
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825990}

Bug: 1146552
Change-Id: I6b4ee181e0b62044892b2649033f426544f25c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526703
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825989}

- Remove restart the chrome while switching between dark and light mode.
- Preference will retain the value once it has been registered and set
  the value before. Go back to the |kDefaultDarkModeEnabled| if the flag
  is disabled.

Bug: 1146531, 1131543
Change-Id: Ie32da506f61fe78e31820456fe8ffc92d862ba8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530249Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825988}

A server change caused us to fail to compute the index
of the card when the action originates from the bottom sheet.
This change lets us continue to record metrics even if we
don't identify the card index, using MAX_INT as a special
value.

While this fix isn't ideal, it's better than missing out
on these metrics. We can improve this later.

Bug: 1111101
Change-Id: I063835a44ad4abb92f05e997fd27c535dc4dcb23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522574
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825987}

Tricium service will reject the config if the "platform" for the
definition and selection don't match -- but in fact the platform
field is not important anymore, since platform is actually determined
by the builder config. It doesn't make any difference whether we
specify UBUNTU or LINUX, so just unify it to one.

Bug: 1105239
Change-Id: I8822957fa34e9e5afaa06a687cdeed50614aa087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530749
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825986}

Change-Id: Ie1416346c5ba30775e005c96512c2de770c6b635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527630
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825985}

On ChromeOS the text does not appear in the output, so we should just
pass "" like other EXPECT_DEATH calls do.

  Result: died but not with expected error.
  Expected: contains regular expression "Check failed"
  Actual msg:
  [  DEATH   ]
  Stack trace:
  #0 0x5577cb1ef7ee ui::(anonymous namespace)::ClipboardTest_Bitmap_F16_Premul_Test<>::TestBody()

R=sky@chromium.org

Bug: 1144462
Change-Id: I8890b6fe3e5bfacf49c8bbb840a21543502ea537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530797Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825984}