- 07 Apr, 2017 40 commits
-
-
zpeng authored
This CL updates third_party/checkstyle to 7.6.1 so checkstyle would work with Java 8 lambda features. BUG=703238 Review-Url: https://codereview.chromium.org/2799303003 Cr-Commit-Position: refs/heads/master@{#462968}
-
lgarron authored
BUG=661799 Review-Url: https://codereview.chromium.org/2800563002 Cr-Commit-Position: refs/heads/master@{#462967}
-
kylixrd authored
Added EscapeString() to convert certain characters into XML escape (&xxx;) sequences BUG=708705 Review-Url: https://codereview.chromium.org/2803613003 Cr-Commit-Position: refs/heads/master@{#462966}
-
bpastene authored
TBR=jbudorick@chromium.org BUG= Review-Url: https://codereview.chromium.org/2800113002 Cr-Commit-Position: refs/heads/master@{#462965}
-
kbr authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/d0783b8..32cfddc BUG=685232, 701060, 709351 TEST=bots TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2798083005 Cr-Commit-Position: refs/heads/master@{#462964}
-
zpeng authored
This CL updates WebApkInstaller so that the murmur2 hash of the best badge icon would be calculated and passed to the WAM server in WebAPK proto along with the url of the best badge icon. BUG=649771 Review-Url: https://codereview.chromium.org/2676863002 Cr-Commit-Position: refs/heads/master@{#462963}
-
tedchoc authored
BUG=695306 Review-Url: https://codereview.chromium.org/2802303002 Cr-Commit-Position: refs/heads/master@{#462962}
-
minch authored
1. Sticky keys 2. Tap dragging Changes in this CL, 1. Add four functions in AccessibilityDelegate interface. This is used to show above two a11y features in system menu. BUG=632107 Review-Url: https://codereview.chromium.org/2802783002 Cr-Commit-Position: refs/heads/master@{#462961}
-
jbauman authored
This software isn't under our control, so suppress deadlock warnings we can't fix. BUG=691029 Review-Url: https://codereview.chromium.org/2807523002 Cr-Commit-Position: refs/heads/master@{#462960}
-
dgozman authored
This is a logical thing to do by itself, improves performance and makes it easier to reason about things. It may also help to prevent crashes if we somehow get into inconsistent state by not calling delegate methods at random times. Although not directly fixing the linked crash, I expect it to go away. BUG=704346 TBR=dtrainor@chromium.org Review-Url: https://codereview.chromium.org/2799783006 Cr-Commit-Position: refs/heads/master@{#462959}
-
hongchan authored
This CL is the second part of the conversion. It manually replaces: - RELEASE_ASSERT() with CHECK(). - ASSERT(...args) with one or more DCHECK_op(arg). With this CL the following script returns 0 result. ``` cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio grep -rnw . -e 'ASSERT(' ``` BUG=707655 Review-Url: https://codereview.chromium.org/2803073002 Cr-Original-Commit-Position: refs/heads/master@{#462904} Committed: https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5 Review-Url: https://codereview.chromium.org/2803073002 Cr-Commit-Position: refs/heads/master@{#462958}
-
wychen authored
BUG=693650 Review-Url: https://codereview.chromium.org/2803823004 Cr-Commit-Position: refs/heads/master@{#462957}
-
rtoy authored
The v8 bindings layer does the finite check for us so we don't have to check again. BUG=709061 TEST=covered by existing tests Review-Url: https://codereview.chromium.org/2804083004 Cr-Commit-Position: refs/heads/master@{#462956}
-
boliu authored
These are the only two (important) calls that do not have a return value, so can be made oneway. "oneway" is roughly equivalent to being asynchronous, since binder calls are synchronous by default. This is like an early test to make sure oneway doesn't cause issues. BUG=689758 Review-Url: https://codereview.chromium.org/2799683007 Cr-Commit-Position: refs/heads/master@{#462955}
-
skau authored
Flips the polarity of the --enable-native-cups flag to --disable-native-cups. BUG=583155 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2475813002 Cr-Commit-Position: refs/heads/master@{#462954}
-
dschuyler authored
This CL applies a pull request submitted to Polymer to add RTL support for paper-sliders. BUG=696437 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2801193002 Cr-Commit-Position: refs/heads/master@{#462953}
-
servolk authored
BUG=708808 Review-Url: https://codereview.chromium.org/2805533005 Cr-Commit-Position: refs/heads/master@{#462952}
-
macourteau authored
Screenshot: http://imgur.com/a/7WXgf BUG=602666 Review-Url: https://codereview.chromium.org/2807583003 Cr-Commit-Position: refs/heads/master@{#462951}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7d3d87233190..4e3abc1ad5f0 $ git log 7d3d87233..4e3abc1ad --date=short --no-merges --format='%ad %ae %s' 2017-04-07 reed cacherator upscales colortables to unify caching 2017-04-03 halcanary SkMultiPictureDocument : clean up MultiPictureDocumentReader interface 2017-04-07 robertphillips Make GrCopySurfaceOp friendlier to GrSurfaceProxy (take 2) 2017-04-07 scroggo Simplify subset computation in SkGifImageReader 2017-04-06 mtklein stop disabling threadsafe statics 2017-04-07 borenet Fix missing valgrind.supp in recipe-bundled tasks 2017-04-07 kjlubick Add ChromeOS Test/Perf jobs and recipe changes 2017-04-06 halcanary SkTypeface_win_dw: populate_glyph_to_unicode uses lowest unichar 2017-04-06 mtklein simplify SkRRect serialization 2017-04-06 mtklein Try disabling MSAN workarounds in SkJpegCodec 2017-04-07 borenet Reland: Use bundled recipes for all test/perf tasks 2017-04-06 mtklein jumper, gather_f16 Created with: roll-dep src/third_party/skia BUG=538133 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I31295c32b1fde854b28bc400f41c82c3c9bfe307 Reviewed-on: https://chromium-review.googlesource.com/471049Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#462950}
-
dgozman authored
We have a few users of it, which are better to use underlying models. We also have a log of SDKObject's like classes which do not inherit from SDKObject - that means this abstraction doesn't really work. As a bonus, we only inherit from Common.Object when necessary, reducing the overhead. BUG=none Review-Url: https://codereview.chromium.org/2801943003 Cr-Commit-Position: refs/heads/master@{#462949}
-
meacer authored
Content-initiated main-frame navigations to data URLs are being blocked in crbug.com/594215. After crrev.com/2702503002 lands, these test will stop working because they navigate to data URLs. The fix is to change the data URLs in these tests to HTTP urls, but doing that causes the tests to fail more often -- they start to fail on Windows. I investigated the failures and can't see a good way of fixing them (https://crbug.com/703727#c8) so I'm disabling them in the meanwhile. BUG=594215 Review-Url: https://codereview.chromium.org/2803813002 Cr-Commit-Position: refs/heads/master@{#462948}
-
rhalavati authored
Test Network traffic annotation tag is added to network requests of unittest in chrome/browser/*. BUG=656607 Review-Url: https://codereview.chromium.org/2804023003 Cr-Commit-Position: refs/heads/master@{#462947}
-
juncai authored
This is a follow-up CL for: https://codereview.chromium.org/2785383002/diff/80001/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc This CL added some test characteristic and descriptor UUIDs to bluetooth_test.h and updated device bluetooth unit tests to use them. BUG=None Review-Url: https://codereview.chromium.org/2798193002 Cr-Commit-Position: refs/heads/master@{#462946}
-
dougt authored
In Jan 20015, this test case on a ASAN run caused timeouts. An exception was added and life moved on. Re-running this tests locally does not appear to cause any timeout, and so we're going to re-enable the exception to see if there still exists a problem. BUG=446661 Review-Url: https://codereview.chromium.org/2799743007 Cr-Commit-Position: refs/heads/master@{#462945}
-
pkasting authored
This removes the forced Google URL re-check on a profile reset. The old behavior was added to correct cases where users said "no" to a server request to use a new TLD. Nowadays we don't prompt about this, so users can't be stuck on "the wrong" server. BUG=244291 TEST=none Review-Url: https://codereview.chromium.org/2799083003 Cr-Commit-Position: refs/heads/master@{#462944}
-
juliatuttle authored
Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This wraps the context in a service that keeps the implementation details of Reporting private while implementing and exposing the high-level operations that other components require from it. BUG=704259 Review-Url: https://codereview.chromium.org/2770443002 Cr-Commit-Position: refs/heads/master@{#462943}
-
zijiehe authored
After discussing in http://crbug.com/702251, we decide to enable browser shortcuts when the tab-strip / toolbar is visible on Mac OS. There is no comparable behavior on other platforms. This change adds a BrowserWindow::IsToolbarShowing() function to indicate whether the toolbar is showing up on the screen. BrowserWindowCocoa needs to override this function, which has not been done yet in this change. BUG=680809, 702251 Review-Url: https://codereview.chromium.org/2781633003 Cr-Commit-Position: refs/heads/master@{#462942}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c5350347..ef8c92ef Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2807573002 Cr-Commit-Position: refs/heads/master@{#462941}
-
hongchan authored
As a first step of ASSERT removal from modules/webaudio, this CL removes all DCHECK_IS_ON() condition check from isGraphOwner() and put the check inside of the method. The method is only used inside of DCHECK() so it must be no-op in the release build. That is why it returns false, so we can catch the anomaly when it happens. BUG=707643 Review-Url: https://codereview.chromium.org/2805823003 Cr-Commit-Position: refs/heads/master@{#462940}
-
schenney authored
The test is slower than slow. TBR=ellyjones@chromium.org BUG=709009 Review-Url: https://codereview.chromium.org/2806743002 Cr-Commit-Position: refs/heads/master@{#462939}
-
qyearsley authored
This change was made automatically with update-test-expectations. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media/autoplay-muted.html,http/tests/inspector/service-workers/service-worker-manager.html,fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html,http/tests/inspector/resource-tree/resource-tree-non-unique-url.html,http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/security/link-crossorigin-preload-no-cors.html,http/tests/inspector/tracing/timeline-script-parse.html,http/tests/media/media-source/mediasource-seek-beyond-duration.html,virtual/mojo-loading/http/tests/media/media-source/mediasource-seek-beyond-duration.html,external/wpt/fetch/api/redirect/redirect-location-worker.html,external/wpt/fetch/api/redirect/redirect-location.html,external/wpt/fetch/api/redirect/redirect-origin-worker.html,external/wpt/fetch/api/request/request-cache-default-conditional.html,external/wpt/service-workers/service-worker/registration-iframe.https.html BUG=691045,564403,651343,581468,666628,664839,678489,678490,705490,697087 Review-Url: https://codereview.chromium.org/2800123002 Cr-Commit-Position: refs/heads/master@{#462938}
-
jkrcal authored
This CL allows to set different intervals for soft fetches for wifi and fallback connections. This puts soft fetches on par to persistent fetches with respect to parameters. Previously we prioritized soft fetches triggered by NTP_OPENED. This feature is removed by this CL for the sake of simplicity (NTP_OPENED is the only trigger that we employ on M57 Stable). BUG=708146 Review-Url: https://codereview.chromium.org/2794313002 Cr-Commit-Position: refs/heads/master@{#462937}
-
lukasza authored
BUG=702300 TBR=lazyboy@chromium.org Review-Url: https://codereview.chromium.org/2805443005 Cr-Commit-Position: refs/heads/master@{#462936}
-
fsamuel authored
cc::Surface and SurfaceDependencyTracker used CompositorFrameMetadata's referenced_surfaces to determine dependencies of a CompositorFrame. This causes issues when referenced_surfaces contains surface IDs of hidden windows. Hidden windows do not generate CompositorFrames and so the parent CompositorFrame would block for four BeginFrames waiting for a child CompositorFrame that would never arrive. This effectively reduced the frame rate from 60fps to 15fps. This CL addresses this issue by introducing an embedded_surfaces set in CompositorFrameMetadata that only refers to surface IDs for which SurfaceDrawQuads were generated and thus will be visually present in the frame. In a subsequent CL, referenced_surfaces will be renamed to retained_surfaces and will only contain the set of surface IDs to which the parent wishes to retain the corresponding surfaces but does not embed them in SurfaceDrawQuads. Once generalized frame eviction is complete, we can drop the retained_surfaces field all together. BUG=672962 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2803913004 Cr-Commit-Position: refs/heads/master@{#462935}
-
bsheedy authored
Tests that the device capabilities reported by WebVR match expectations, although currently all tested devices have the same expectations. Automates one of our manual test cases. BUG=702700 Review-Url: https://codereview.chromium.org/2794383002 Cr-Commit-Position: refs/heads/master@{#462934}
-
mkwst authored
Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AqSrOMzwrlk/wUglQnTJCgAJ BUG=680970 Review-Url: https://codereview.chromium.org/2794303002 Cr-Commit-Position: refs/heads/master@{#462933}
-
liaoyuke authored
The original logic in |AddPendingItem| does nothing if the URL of the pending item is the same as the last committed item, except that the pending item is added due to form submission. However, this doesn't work with the new Request Desktop/Mobile Site because the new functionality requires adding a pending item with the same URL, but different UserAgentType. This CL re-factors |AddPendingItem| so that a pending item with the same URL can be added successfully as long as the UserAgentOverrideOption is not INHEIRT. This CL also adds corresponding unit tests to test the logic. BUG=678047 Review-Url: https://codereview.chromium.org/2794723002 Cr-Commit-Position: refs/heads/master@{#462932}
-
dfalcantara authored
* It's technically infeasible to assume that the search box can animate to the correct location all the time. Instead, just remove all of this code and keep it simple. * Since we're allowed to add resources now, move most initialization of the SearchActivity layout to XML. * Make the SearchActivity's LocationBarLayout inherit from the LocationBarPhone, instead. That's how it behaves anyway. * Makes the Omnibox full bleed like UX requested. BUG=708844 SCREENSHOTS=https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDdGF1NVo3ZWptTzQ Review-Url: https://codereview.chromium.org/2799783003 Cr-Commit-Position: refs/heads/master@{#462931}
-
tsergeant authored
This fixes an issue where the menu would appear blank in MD Downloads and Bookmarks. BUG=708892 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2804623005 Cr-Commit-Position: refs/heads/master@{#462930}
-
xhwang authored
Implement MediaDrmStorageImpl using PrefService. TBR=sdefresne@chromium.org BUG=493521 TEST=New unit tests added. Review-Url: https://codereview.chromium.org/2791903004 Cr-Commit-Position: refs/heads/master@{#462929}
-